In Combat System v2.0

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

23 Jan 2012
Bribe: This looks way, way better from the last time I reviewed your resource, and you added some good new features as well.

The main thing you need to change is the indexing. You use Paladon-esque indexing which only recycles indices after all the units leave combat, so over the course of a battle you will accumulate lots of indices making it dangerous.

I recommend you use the custom value of units provided by UnitIndexer, in combination with arrays, and then pick all units in the "in-combat" group in that "every 1 second" trigger.

You should also only fire the combat event if the damage is greater than 0, and you could also check the "starts ability effect" event and add units to the group if the spell target is an enemy.

Also, please don't advertise in large font.

 

[Magtheridon96]

please post triggers

 

[mckill2009]

so what's the purpose of this? floating text while you're in combat?...hmmm 1/5...

 

[NightElf125]

What are you talking about? This enables it so you can add your own actions after the system checks whether or not a unit is in combat, and if it is you could also disable some things. So it could be pretty useful imo. Good job.

 

[mckill2009]

What are you talking about? This enables it so you can add your own actions after the system checks whether or not a unit is in combat, and if it is you could also disable some things. So it could be pretty useful imo. Good job.

this system allows you to check if an unit is in combat or not

too simple...

 

[Gekigengar]

like dota blink dagger system.. could be usefull.

 

[Noobsmoke]

so what's the purpose of this? floating text while you're in combat?...hmmm 1/5...

you are right, i didn't gave you an exeple to understand what this system does .... with this system you can disable spells when the unit is in combat (like stealth from wow or dagger from dota) and enable them after the unit is leaving combat. Why do you think this is useless ?

 

[Noobsmoke]

please post triggers

i will, but i uploaded this system at 11:00 PM (for me) and i was too tired . Now it's 6:23 morning (for me) and i have to go on school. Ill put the triggers to both maps (buff system and in combat system) after i went from school.

 

[Cihparg]

Please combine your messages.
Also this system leaks and is not usefull for anything.

It uses way too many triggers to function and that lags the system by itself.

 

[Orcnet]

Can this be Implemented in a Duel-like state? like a 1v1 fight to players or just revealing a floating text?

 

[Maker]

Somehow the Enter Combat -trigger looks unnecessarily comlicated. Could you explain the logic?

Is taking/dealing damage the only thing that adds you to combat? What about targeting a unit with an ability? What happens if you're surrounded by enemies while in combat and the timer runs out?

The floating texts leak.

Remove the extra and:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • And - All (Conditions) are true
      • Conditions
        • (InCombat_Unit[InCombat_Index[1]] is in InCombat) Equal to True
        • InCombat_Time[InCombat_Index[1]] Greater than 0
        • (InCombat_Unit[InCombat_Index[1]] is alive) Equal to True

->

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (InCombat_Unit[InCombat_Index[1]] is in InCombat) Equal to True
    • InCombat_Time[InCombat_Index[1]] Greater than 0
    • (InCombat_Unit[InCombat_Index[1]] is alive) Equal to True

 

[Noobsmoke]

Please combine your messages.
Also this system leaks and is not usefull for anything.

It uses way too many triggers to function and that lags the system by itself.

leaks ? can you show me some ?

EDIT : nvm ...

 

[mckill2009]

asking what's the purpose of this doesnt mean that it's useless, I'm just asking coz...

1. No triggers posted
2. No concrete explanation on what's this for
example: "When a unit enters in combat it will leave after x secounds" <<< WHT is this?
3. No screenshots of 'spells disabled' while in combat (as you explained)

Lastly, stop giving examples of wow and dota coz not all people plays it...and, dont double post, use edit button...

 

[Noobsmoke]

asking what's the purpose of this doesnt mean that it's useless, I'm just asking coz...

1. No triggers posted
2. No concrete explanation on what's this for
example: "When a unit enters in combat it will leave after x secounds" <<< WHT is this?
3. No screenshots of 'spells disabled' while in combat (as you explained)

Lastly, stop giving examples of wow and dota coz not all people plays it...and, dont double post, use edit button...

i will work more at this system and i hope v1.0 will look good to everyone

 

[Zeatherann]

This could bee useful, despite it's simplicity this could prove invaluable for systems like Halo
s shield, as it only regenerates after 7 seconds of not being hit, or WoW's stealth/potions/hearths/food/ect can only be used out of combat, or only once per battle. OR even simply for a passive health regen while out of combat.

The fact that this is simple should only mean it will be leakless, and lagless to be used like any other boolean check. (such as IsUnitDead(), even though there are ways around that).

 

[Nestharus]

Just pointing out that this does the same thing but better http://www.hiveworkshop.com/forums/submissions-414/combat-state-186673/

And no, it's not approved yet even though it's more accurate than this one ;P. When it's approved, it should pretty much be 100% accurate and as fast as possible ;D.

 

[Zeatherann]

Ah, but this is not vJASS, so people like me can use it in their map and still hit the save button.

 

[Bribe]

This is going to get rejected until you post the triggers.

 

[Noobsmoke]

Version 1.0 is up and triggers are now in description

 

[Adiktuz]

Ah, but this is not vJASS, so people like me can use it in their map and still hit the save button.

is it that hard to download JNGP?

anyway, the idea looks fine though as Nestharus posted above, there is a better one... but I guess a GUI one, for those too lazy to download JNGP ,won't hurt...

one question, how do you make the units In combat? coz on the trigger I dont see an event (can't test the map for now...)...

 

[xorkatoss]

this is a pretty good system although i don't think it will be useful...
why would anybody want to disable skills while in battle?
especially the ones that are created for escaping...
anyway the is good and works fine gj 5.5
maybe the next thing you can do is to disable all combat abilities, and when you enter combat mode you can enable them ;p

 

[Adiktuz]

I think you can pretty much do it using this system... since what this does is that it enables you to determine wheter a unit is in combat or not... though not that flexible I think...

 

[Bribe]

Add Combat

Floating Text - Create floating text that reads Entering Combat at (Position of InCombat_Unit[InCombat_Index[2]])

- Leaks

Combat Check

Floating Text - Create floating text that reads Leaving Combat at (Position of InCombat_Unit[InCombat_Index[1]])

- Leaks

 

[Noobsmoke]

Add Combat

Floating Text - Create floating text that reads Entering Combat at (Position of InCombat_Unit[InCombat_Index[2]])

- Leaks

Combat Check

Floating Text - Create floating text that reads Leaving Combat at (Position of InCombat_Unit[InCombat_Index[1]])

- Leaks

thanks, fixed

 

[Nestharus]

Ok, here are some issues with accuracy-


When a unit initially attacks another unit from a long distance, the attacked unit is not in combat. An attacked unit is not in combat until it can perceive an attack, which is realistically when the given attack is within the acquisition range of the unit or (if not possible) when the attack actually damages the unit.

An attack is placed into combat as soon as it attacks, but the attacked is not placed into combat until the attack is close enough or the unit is damaged.

This was one of the problems that was being addressed with PurgeandFire111's CombatState script.


Another issue is that this can be a lot better if groups aren't used, but rather an indexer.

Given the attack times are constant, I would normally recommend something similar to a timer queue, but the timers are reset every time the unit is put back into a combat state.



As such, I don't recommend use of this resource or approval of it until the accuracy issue is fixed.

 

[Noobsmoke]

Ok, here are some issues with accuracy-


When a unit initially attacks another unit from a long distance, the attacked unit is not in combat. An attacked unit is not in combat until it can perceive an attack, which is realistically when the given attack is within the acquisition range of the unit or (if not possible) when the attack actually damages the unit.

An attack is placed into combat as soon as it attacks, but the attacked is not placed into combat until the attack is close enough or the unit is damaged.

This was one of the problems that was being addressed with PurgeandFire111's CombatState script.


Another issue is that this can be a lot better if groups aren't used, but rather an indexer.

Given the attack times are constant, I would normally recommend something similar to a timer queue, but the timers are reset every time the unit is put back into a combat state.



As such, I don't recommend use of this resource or approval of it until the accuracy issue is fixed.

the system is customisable ... just add this

• Attack Check
  • Events
    • Unit - A unit Is attacked
  • Conditions
  • Actions
    • Set InCombat_Index[2] = (InCombat_Index[2] + 1)
    • Set InCombat_Time[InCombat_Index[2]] = Combat_Option1
    • Set InCombat_Unit[InCombat_Index[2]] = (Attacked unit)
    • Trigger - Run Add Combat <gen> (ignoring conditions)
    • Set InCombat_Index[2] = (InCombat_Index[2] + 1)
    • Set InCombat_Time[InCombat_Index[2]] = Combat_Option1
    • Set InCombat_Unit[InCombat_Index[2]] = (Attacking unit)
    • Trigger - Run Add Combat <gen> (ignoring conditions)

 

[Bribe]

Something like that should be pre-built by yourself, rather than requiring users perform a lot of manual scripting to fix something which shouldn't have even been broken.

 

[Nestharus]

Sorry king_drift_alex, don't read GUI.

Really, a very simple way to put a unit into a combat state is to put a unit into a combat state whenever it is damaged and to put it into a combat state whenever it attacks.

 

[maddeem]

Looks very nice, I might use this in my rpg... +rep

*cough* I've seen this somewhere else earlier...

 

[Noobsmoke]

Version 2.0 released finally. Use it instead of other older versions.

 

[Magtheridon96]

I have a few suggestions.

Instead of defining units as "in combat" or "not in combat", you could tag units as:
- targeted for attack
- targeting for attack
- inflicting damage heavily
- inflicting damage lightly
- inflicted by heavy damage
- inflicted by light damage

And using that information, you can tell if the unit is in Combat or not

 

[Nestharus]

Actually, the big question is, should a unit be in combat when it is acquired as a target, or should it be in combat the moment it receives damage. Furthermore, should it leave comat when it is no longer acquired as a target?

 

[Fud]

Ok, here are some issues with accuracy-


When a unit initially attacks another unit from a long distance, the attacked unit is not in combat. An attacked unit is not in combat until it can perceive an attack, which is realistically when the given attack is within the acquisition range of the unit or (if not possible) when the attack actually damages the unit.

An attack is placed into combat as soon as it attacks, but the attacked is not placed into combat until the attack is close enough or the unit is damaged.

This was one of the problems that was being addressed with PurgeandFire111's CombatState script.


Another issue is that this can be a lot better if groups aren't used, but rather an indexer.

Given the attack times are constant, I would normally recommend something similar to a timer queue, but the timers are reset every time the unit is put back into a combat state.



As such, I don't recommend use of this resource or approval of it until the accuracy issue is fixed.

I disagree that this should be fixed. The unit is truly in combat until he is taking damage or attacking.
For instance, if a stealth spell can only be cast when out of combat. If a long ranged missile targets a unit the unit should be able to stealth before the missile hits him. whether he should take damage is up to you but damage isn't inflicted until the target is hit why should he enter combat? It is to the advantage of people like me who are trying to create a map with WOW-like gameplay.

 

[Palooo3]

If you ask me it's very usefull, I'm probably gonna use with "evade" system or give every hostile unit passive regeneration ability so when player run away from combat creeps will restore HP, anyway there are alot of useages for this, well done.