[JASS] I can't make a JASS version of this trigger

[meercat]

I'm just a noob with JASS, i'm trying my best to comprehend but it seems that the slow way is still the best.
I'm trying to make a JASS version of this skill but I seems to fail.. My syntax is always wrong...

Trigger Version:

• Triggers:
• Unit - A unit Is attacked
• Conditions
  • ((Attacking unit) has buff Kusanagi Chidori ) Equal to True
• Actions:
  • Set Lycast = (Position of (Triggering unit))
  • Unit - Create 1 Peasant for (Owner of (Attacking unit)) at Lycast facing (Facing of (Attacking unit)) degrees
  • Unit - Hide (Last created unit)
  • Unit - Order (Last created unit) to Human Mountain King - Storm Bolt (Attacked unit)
  • Unit - Add a 1.00 second Generic expiration timer to (Last created unit)
  • Custom script: call RemoveLocation(udg_Lycast)

The JASS that I always fail:

function Trig_Lyghtning_Conditions takes nothing returns boolean
    if ( not ( UnitHasBuffBJ(GetAttacker(), 'A005') == true ) ) then
       return false
    endif
    return true
    return GetSpellAbilityId() == 'A004'
endfunction

function Trig_Lyghtning_Actions takes nothing returns nothing
endfunction

//===========================================================================
function InitTrig_Lyghtningi takes nothing returns nothing 
    set gg_trg_Lyghtning = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Lyghtning, EVENT_PLAYER_UNIT_ATTACKED )
    call TriggerAddCondition( gg_trg_Lyghtning, Condition( function Trig_Lyghtning_Conditions ) )
    call TriggerAddAction( gg_trg_Lyghtning, function Trig_Lyghtning_Actions ) 
    local unit u = CreateUnitAtLoc(GetTriggerPlayer(), 'h002', GetSpellTargetLoc(), 0.00)
    call SetUnitPositionLoc(GetLastCreatedUnit(), GetUnitLoc(GetTriggerUnit()))
    set u = null
    set s = null

 

[GhostWolf]

• Conditions:
• Unit - A unit Is attacked

What the hell is that supposed to mean?

 

[meercat]

What the hell is that supposed to mean?

oh sorry just typo when copying the trigger

 

[The Reborn Devil]

You are missing an "endfunction" at the bottom of the JASS trigger, locals must be at the top of a function, there's an error in your "function Init_Trig...", GetTriggerPlayer() will not return the owner and it cannot be used in an InitTrig function and the local variable "s" isn't defined.

function InitTrig_Lyghtningi takes nothing returns nothing //Remove the "i" after "InitTrig_Lyghtning"
    set gg_trg_Lyghtning = CreateTrigger( )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Lyghtning, EVENT_PLAYER_UNIT_ATTACKED )
    call TriggerAddCondition( gg_trg_Lyghtning, Condition( function Trig_Lyghtning_Conditions ) )
    call TriggerAddAction( gg_trg_Lyghtning, function Trig_Lyghtning_Actions )
//==================
    local unit u = CreateUnitAtLoc(GetTriggerPlayer(), 'h002', GetSpellTargetLoc(), 0.00)
//==================
    call SetUnitPositionLoc(GetLastCreatedUnit(), GetUnitLoc(GetTriggerUnit()))
    set u = null
    set s = null //This isn't defined
endfunction //You forgot this

Your condition won't work correctly.

function Trig_Lyghtning_Conditions takes nothing returns boolean
    if ( not ( UnitHasBuffBJ(GetAttacker(), 'A005') == true ) ) then
       return false //The function will stop here
    endif
    return true //Or here
    return GetSpellAbilityId() == 'A004' //And this will never happen
endfunction

And your GUI trigger and your JASS trigger (if it had worked) will do something totally different.

Fixed and optimized version:

function Trig_Lyghtning_Conditions takes nothing returns boolean
    return GetUnitAbilityLevel(GetAttacker(), 'A005') > 0
endfunction

function Trig_Lyghtning_Actions takes nothing returns nothing
    local unit u = GetTriggerUnit()
    local player p = GetOwningPlayer(u)
    local real x = GetUnitX(u)
    local real y = GetUnitY(u)
    local unit u2 = CreateUnit(p, 'h002', x, y, 0.)
    call IssueTargetOrder(u2, "thunderbolt", u)
    call UnitApplyTimedLife(u2, 'BTLF', 1.)
    set u = null
    set p = null
    set u2 = null
endfunction

//===========================================================================
function InitTrig_Lyghtning takes nothing returns nothing
    set gg_trg_Lyghtning = CreateTrigger( )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Lyghtning, EVENT_PLAYER_UNIT_ATTACKED )
    call TriggerAddCondition( gg_trg_Lyghtning, Condition( function Trig_Lyghtning_Conditions ) )
    call TriggerAddAction( gg_trg_Lyghtning, function Trig_Lyghtning_Actions )
endfunction

 

[meercat]

You are missing an "endfunction" at the bottom of the JASS trigger, locals must be at the top of a function, there's an error in your "function Init_Trig...", GetTriggerPlayer() will not return the owner and it cannot be used in an InitTrig function and the local variable "s" isn't defined.

function InitTrig_Lyghtningi takes nothing returns nothing //Remove the "i" after "InitTrig_Lyghtning"
    set gg_trg_Lyghtning = CreateTrigger( )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Lyghtning, EVENT_PLAYER_UNIT_ATTACKED )
    call TriggerAddCondition( gg_trg_Lyghtning, Condition( function Trig_Lyghtning_Conditions ) )
    call TriggerAddAction( gg_trg_Lyghtning, function Trig_Lyghtning_Actions )
//==================
    local unit u = CreateUnitAtLoc(GetTriggerPlayer(), 'h002', GetSpellTargetLoc(), 0.00)
//==================
    call SetUnitPositionLoc(GetLastCreatedUnit(), GetUnitLoc(GetTriggerUnit()))
    set u = null
    set s = null //This isn't defined
endfunction //You forgot this

Your condition won't work correctly.

function Trig_Lyghtning_Conditions takes nothing returns boolean
    if ( not ( UnitHasBuffBJ(GetAttacker(), 'A005') == true ) ) then
       return false //The function will stop here
    endif
    return true //Or here
    return GetSpellAbilityId() == 'A004' //And this will never happen
endfunction

And your GUI trigger and your JASS trigger (if it had worked) will do something totally different.

Fixed and optimized version:

function Trig_Lyghtning_Conditions takes nothing returns boolean
    return GetUnitAbilityLevel(GetAttacker(), 'A005') > 0
endfunction

function Trig_Lyghtning_Actions takes nothing returns nothing
    local unit u = GetTriggerUnit()
    local player p = GetOwningPlayer(u)
    local real x = GetUnitX(u)
    local real y = GetUnitY(u)
    local unit u2 = CreateUnit(p, 'h002', x, y, 0.)
    call IssueTargetOrder(u2, "thunderbolt", u)
    call UnitApplyTimedLife(u2, 'BTLF', 1.)
    set u = null
    set p = null
    set u2 = null
endfunction

//===========================================================================
function InitTrig_Lyghtning takes nothing returns nothing
    set gg_trg_Lyghtning = CreateTrigger( )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Lyghtning, EVENT_PLAYER_UNIT_ATTACKED )
    call TriggerAddCondition( gg_trg_Lyghtning, Condition( function Trig_Lyghtning_Conditions ) )
    call TriggerAddAction( gg_trg_Lyghtning, function Trig_Lyghtning_Actions )
endfunction

thx!... I've learned much from you...

EDIT:
Oh, I forgot... The skill counts attack as executed even if the damage is not yet resolved, How I can solve this...

 

[Coolty44]

It may be wrong, but it is

EVENT_UNIT_DAMAGED

change that were it says

EVENT_PLAYER_UNIT_ATTACKED

and it should work

 

[Eleandor]

EVENT_UNIT_DAMAGED requires a specific unit, not a generic unit. So you'll basically need a damage detection system.

 

[meercat]

EVENT_UNIT_DAMAGED requires a specific unit, not a generic unit. So you'll basically need a damage detection system.

in the sound of it, it's advance....

 

[Eleandor]

The basic idea behind a damage detection system is simply adding the EVENT_UNIT_DAMAGED event to the trigger each time a unit enters the playable map. That way, each unit on the map will be registered. Pretty easy to implement that, but damage detection systems usually take care of some other things as well.

 

[WraithSeeker]

Check out Light Leakless Damage Detection System (LLDD) in wc3c.

 

[meercat]

Check out Light Leakless Damage Detection System (LLDD) in wc3c.

Thx, Eleandor and Wraith. I'll check it out.