Holy Vs. Darkness Spellpack V 0.5

[Moderator]

20:04, 30th Nov 2009
TriggerHappy:

Still can't approve without that last leak fix.

 

[kola]

Triggers in description plz

 

[X-OMG-X]

Triggers in description plz

Ditto.

 

[real138]

agh thats alot of triggers plz just dl and look?

Added int description.

 

[aaron]

agh thats alot of triggers plz just dl and look?

how bout no? i dont wanna download every spell i see in the spell section, also if you want people to use your spells POST THE CODE....

 

[kola]

6 spells = 6 to 12 copy/paste ... if this is long... how could u take the time to make 1 of the spells in the this pack?

 

[real138]

well im gonna do it just i cant right now. give me till 12 will be done then.
EDITmg... y does it do that 2 me... every time i post triggers it does that.
well i guess ill put it in first post

 

[axleion]

Every dead units takes damages depending on hero's intelligence.

ehm... a little wrong tooltip here?

 

[real138]

whoops i copied the person who had the ideas tooltips right in so i gotta check those better. can someone give feedback on the actual code.

 

[axleion]

1. change the words in loading screen: its written as Redscores
2. the maxlevel feature is different from the message in-game and the editor itself
3. you use same base ability for Last Stand and Holy Recovery which is bad.
4. the dark hero ability are only one level in-game, probably you forgot to change it to hero ability...
5. if you don't want to display the buff for the Dark Strike, you should base the ability on Critical Strike or what and use this as condition:

• (Level of Dark Strike for (Attacking unit)) Greater than 0

6. your way of checking for chance in Dark Strike is wrong...

• (Random integer number between 1 and 5) Not equal to 3

this is not 20% chance, its 80%. it should be equal to if you want to do it your way.
7. has location leaks, example in Dark Strike trigger:

Set DS_tmppoint = (Position of (Triggering unit))
Set DS_Group = (Units within (150.00 + ((Real((Level of Dark Strike for (Attacking unit)))) x 50.00)) of (Position of (Triggering unit)) matching ((((Matching unit) belongs to an enemy of (Owner of (Attacking unit))) Equal to True) and (((Matching unit) is alive) Equal to

you declare DS_tmppoint, but didn't use it on the group when it can. that makes the location in DS_Group leaks.

that's for now...

 

[real138]

ah ok right on it.
1. musta uploaded the bit older version where i hadnt changed the name and description yet. fixed
2. fixed
3. fixed
4. fixed
5. changed
6.fixed was using that for testing sorry
7. and fixed
Plz take a look at my other spells thanks guys

 

[Cihparg]

Spammadar.

 

[baassee]

holy tranq cast trigger leaks unit group

 

[real138]

usually when i destroy unit groups the spell stops working idk y. ill try and test it once i can.

 

[real138]

Updated.
fixed 2 of 3 leaks still have holy tranq group leak. cant seem to fix without breaking spell.

 

[Maker]

You could save

Temp_Integer_1 = Level of Dark Strike
and/or
Temp_Real_1=(Real(Level of Dark Strike))

and use the variables instead of doing those conversions/calculations several times. Although computers do those things really really quickly, reducing the performance cost is always good.

Same thing in Purification,

Set P_ManaBurn = ((Level of (Ability being cast) for (Triggering unit)) x 50)
^Do the real conversion there too, use real instead of integer.

Perhaps Dark Strike could use damage detection, Unit takes damage event rather than Unit is attacked.

HT time runs all the time, even though there are no units in HT_units. Turn the trigger off after you remove unit from the group, if the group is empty. Turn it on when the spell is cast.

You have unit group leak in HT_int.

• Set HT_point = (Position of (Load 1 of (Key (Picked unit)) in HT_hashtable))

Location leak, you don't remove it.

You could set that point after these checks:

• HT_time Greater than 0
• ((Picked unit) is alive) Equal to True

because you don't need it if those return false.

• Special Effect - Create a special effect at (Random point in (Region centered at HT_point with size (700.00, 700.00)))...

Location leak.

• Unit - Set life of (Picked unit) to ((Life of (Picked unit)) + ((Real((Level of Purification for (Load 1 of (Key (Picked unit)) in HT_hashtable)))) x 10.00))

You could do that calculation in the trigger that handles the casting of the spell, and save the value to hashtable.

You could save "Temp_Unit_1 = Load 1 of key (Picked Unit)..." and use that unit variable instead of loading the unit from hashtable several times.

Check the tooltip for Last Stand, it shows the level incorrectly.

Tooltip for haunt lacks some capital letters.

You use way too many variables, use shared global variables between spells. Like HT_point and LS_temppoint could both just use Temp_Point_1 for example.

This should fix the leak:

HT_Init

• HT Init Copy
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Holy Tranquility
  • Actions
    • Set HT_point = (Position of (Triggering unit))
    • Set HT_time = (((Level of (Ability being cast) for (Triggering unit)) x 5) + 5)
    • Set Temp_Group_1 = (Units within (500.00 + (100.00 x (Real((Level of (Ability being cast) for (Triggering unit)))))) of HT_point matching (((Matching unit) is alive) Equal to True))
    • Unit Group - Pick every unit in Temp_Group_1 and do (Actions)
      • Loop - Actions
        • Unit Group - Add (Picked unit) to HT_units
        • Hashtable - Save HT_time as 0 of (Key (Picked unit)) in HT_hashtable
        • Hashtable - Save Handle Of(Triggering unit) as 1 of (Key (Picked unit)) in HT_hashtable
    • Custom script: call RemoveLocation (udg_HT_point)
    • Custom script: call DestroyGroup(udg_Temp_Group_1)

 

[real138]

ok fixed all that stuff maker except one thing.
thanks for review helped alot.

 

[ELxCaigi]

how bout no? i dont wanna download every spell i see in the spell section, also if you want people to use your spells POST THE CODE....

LOL made me crack up xD "How about no"

 

[real138]

lol eh well i didnt finish my sentence so it sounded like i was lazy.

 

[Vulcano]

Fix your spell descriptions plz, i just read the first one:

Every unit in the targeted area loses every buff (friendly or not). Mana is burned for every unit. Every dead unit takes damage depending on hero's intelligence. Every unit killed by this spell can NOT revive, by any mean, they are totally destroyed.

Fat things were bad spelled, underlined things don't happen. Or you have forgotten to post some triggers.

 

[real138]

im sorry those were copied from peoples ideas. will be fixed tomrrow.