Holy Bomb v1.02

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

16:59, 31st Jan 2014
BPower:
Under no circumstances can a resource modify Unit User Data (Custom value) with the exception of Unit Indexing systems.

09:08, 5th Feb 2014
BPower:
http://www.hiveworkshop.com/forums/spells-569/holy-bomb-v1-02-a-247676/?prev=of%3Ddateline%26o%3DASC%26r%3D20%26status%3Dp%26imporder%3D1%26page%3D2#post2481120
Things that leak

 

[Malhorne]

What the use of this line

• (Percentage of life of HB_Target) is less than 100

oO !

 

[ILH]

Hmmmm.....it checks if the unit's life is less then 100%, so the dummy can holy light ^

 

[Malhorne]

Ah shit ^^
Sorry for this xD

 

[ILH]

Lol, no problem xD

EDIT: Ah! I think i forgot something....i think i forgot to change the dummy type to cant raise, cant decay :/ gonna fix it tommorow

 

[IcemanBo]

Do not use this: (leak)

• Unit Group - Pick every unit in (Units owned by (Owner of HB_Caster) of type Holy Bomb) and do (Actions)

Better never use this action if you can avoid it "Pick all units of type".

Instead, add those units manually per action into unit group:

• Unit Group - Add Unit to UnitGroup[PlayerNumber]

So maybe you need to create a Unit Group[array] variable, one group for each player, or you can find other solution.

 

[ILH]

Thx, will fix.
+rep

EDIT: Updated

 

[Daffa]

You leak point.

• Custom script: call RemoveLocation(udg_HB_Point2)

Must be placed when you loop the shockwave, you leak (amount of shockwave - 1) in the current code.

 

[ILH]

oh ok

+rep

 

[BPower]

- Don't use this one it does always leak (Check out Things that leak again)

• Set HB_Group = (Units owned by (Owner of HB_Caster) of type Holy Bomb)

- You don't have to use so many dummy casters. I recommend to use one per spell cast or even better one per game.
- In general I would like to see, that you code the holy light by yourself instead of using a dummy caster at all:

• Create a specialeffect at the position of the target.
• Deal a certain amount of damage to the target.
• Or heal it, by increasing its life value by the damage amount.

 

[ILH]

ok2 i'll fix it when i have time

 

[Kazeon]

- the dummy spell/unit is too much. you can manually heal/damage nearby units using trigger so that dummy spell can be optimized. you also can use only one dummy unit using that DUMMY.mdl. the bomb model, size, color, etc can be configurable in the init/cast trigger
- use one of missile system on this site for the shockwave, because shockwave damage amount need to be configurable
- damage/heal amount need to be configurable
- make your spell more customizable. as example: damage or number of shockwave for each level
- I think, point target is better for the main ability
- fix the follow through time
- the tooltip need to show the ability current level
- hide dummy unit from the map
- you don't need to create one dummy unit per target and per cast. just create one dummy for the whole game.
- store last created unit into a variable.
- store owner of HB_Dummy into a variable
- destroy HB_Point2 inside the loop, you leak it a lot
- move all dummy and the main ability to one category
- you have correctly remove the HB_Point2 leak above but not in the map. I think you forgot to update the map.

just that for now, I might be wrong here sorry for that

 

[ILH]

Wow wall of text ^^
Thank you for review, i'll take your suggestions if i have some time
+rep!

 

[pOke]

You should not use shockwave as it causes a permanent leak with its terrain deformation, instead use breath of fire, carrion swarm, crushing wave, etc.