[Trigger] Hero revival system

[Crystalknoct]

Here is my hero revival system used in my rpg I would like to make it so that it revives for more than 1 player and unit heres the trigger if anyone has any ideas on how to improve this I would like to make it as good as possible.

• Hero Revival
  • Events
    • Unit - A unit Dies
  • Conditions
    • (((Dying unit) is A Hero) Equal to True) and (((Owner of (Dying unit)) is an enemy of Neutral Hostile) Equal to True)
  • Actions
    • Set Hero_loc = (Center of Respawn <gen>)
    • Game - Display to (All players) for 15.00 seconds the text: ((|cffff0000 + (Name of (Owner of (Dying unit)))) + (|r + ( has been killed by a + (|cffff0000 + ((Name of (Killing unit)) + |r)))))
    • Countdown Timer - Start OURTIMER as a One-shot timer that will expire in 15.00 seconds
    • Countdown Timer - Create a timer window for (Last started timer) with title Hero Revival
    • Set Timer_window = (Last created timer window)
    • Countdown Timer - Show (Last created timer window) for (Owner of (Dying unit))
    • Wait 15.00 seconds
    • Countdown Timer - Destroy Timer_window
    • Hero - Instantly revive (Dying unit) at Hero_loc, Show revival graphics
    • Camera - Pan camera for (Owner of (Dying unit)) to Hero_loc over 0.00 seconds
    • Custom script: call RemoveLocation(udg_Hero_loc)

 

[Chaosy]

1. this way every single unit got the same respawn time. that should be able to config.
2. uses wait = bad

too simple to be approved in the current state

 

[Crystalknoct]

anyone have advice on how to make it work for many players/units I am kinda new to triggering so dont know alot

 

[Maker]

You can use a hashtable or arrays with dynamic indexing.

https://www.hiveworkshop.com/forums/trigger-gui-editor-tutorials-279/hashtables-mui-133407/
www.hiveworkshop.com/forums/spells-569/gui-dynamic-indexing-template-144325/

 

[ap0calypse]

First of all: never use "Dying Unit". Use "Triggering Unit" instead (especially if you're gonna use waits).
Another problem:

• Set Hero_loc = (Center of Respawn <gen>)
• Wait 15.00 seconds
• Custom script: call RemoveLocation(udg_Hero_loc)

You cannot put a wait between setting/removing a location! Because it still has the chance to leak and your effort will be in vain.

2. uses wait = bad

Doesn't have to be true.

This will work (I hope, quickly changed a few things here and there):

• Revive Hero
  • Events
    • Unit - A unit Dies
  • Conditions
    • ((Triggering unit) is A Hero) Equal to True
  • Actions
    • Custom script: local integer udg_PlayerNumber = GetPlayerId(GetTriggerPlayer())+1
    • Countdown Timer - Start DeathTimer[PlayerNumber] as a One-shot timer that will expire in 15.00 seconds
    • Countdown Timer - Create a timer window for DeathTimer[PlayerNumber] with title Revived in:
    • Set DeathTimerWindow[PlayerNumber] = (Last created timer window)
    • Countdown Timer - Hide (Last created timer window)
    • Countdown Timer - Show (Last created timer window) for (Triggering player)
    • Wait 14.70 seconds
    • Countdown Timer - Destroy DeathTimerWindow[PlayerNumber]
    • Set TempLoc1 = (Center of Respawn <gen>)
    • Hero - Instantly revive (Triggering unit) at TempLoc1, Show revival graphics
    • Camera - Pan camera for (Triggering player) to TempLoc1 over 0.00 seconds
    • Custom script: call RemoveLocation(udg_TempLoc1)
    • Custom script: set udg_TempLoc1 = null

Variables:

• "PlayerNumber": integer variable.
• "DeathTimer": timer variable, array.
• "DeathTimerWindow": timer window variable, array.
• "TempLoc1": location variable (because you only need 3 temporary location variables for the entire game, don't create more than that!)

Edit: this still doesn't have the flexibility that Chaosy wanted, but that can easily be fixed by using a hashtable as a look-up table to see the countdown/wait time for each unit type.
This may not be very clear to you, but if you don't need different revive times for different unit types, then there's no reason to explain this any further .

 

[Crystalknoct]

when I tested this it worked fine and even revived 2 units just didnt remove the second timer

 

[ap0calypse]

Oh wait, what? That trigger is meant for RPG's with 1 hero/player. It doesn't support any more than that (it wasn't meant to).
Best follow Maker's advice then, with the hashtables .

 

[Crystalknoct]

and my rpg is meant to only have 1 hero per player but I had 2 and killed them both at same time and they both revived fine

 

[-Kobas-]

Try something like this:

• SimpleHeroRevievSystem
  • Events
    • Unit - A unit Dies
  • Conditions
    • ((Triggering unit) is A Hero) Equal to True
    • ((Triggering unit) is an illusion) Equal to False
  • Actions
    • -------- Save Unit Into Variable --------
    • Set WriteInteger = (WriteInteger + 1)
    • Set HeroUnit[WriteInteger] = (Triggering unit)
    • Set RevievLocation[WriteInteger] = (Position of (Triggering unit))
    • -------- Wait --------
    • Wait 10.00 seconds
    • -------- Read Unit From Variable --------
    • Set ReadInteger = (ReadInteger + 1)
    • Hero - Instantly revive HeroUnit[ReadInteger] at RevievLocation[ReadInteger], Hide revival graphics
    • -------- Clean Leaks Below --------
    • Custom script: call RemoveLocation( udg_RevievLocation[udg_ReadInteger] )
    • -------- Try To Reset Counter --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • WriteInteger Equal to ReadInteger
      • Then - Actions
        • Set WriteInteger = 0
        • Set ReadInteger = 0
      • Else - Actions

 

[ap0calypse]

and my rpg is meant to only have 1 hero per player but I had 2 and killed them both at same time and they both revived fine

Oh okay.
Yeah, I know the hero will revive just fine, but since the timer/timer window uses an array based on the player number, the timers would bug. That's why it's only supposed to be used for 1 hero .
Anyways, since that seems to be the case, you could use it.

 

[Crystalknoct]

Oh okay.
Yeah, I know the hero will revive just fine, but since the timer/timer window uses an array based on the player number, the timers would bug. That's why it's only supposed to be used for 1 hero .
Anyways, since that seems to be the case, you could use it.

thanks for the help will make things better in the long run

 

[Maker]

https://www.hiveworkshop.com/threads/timers.230384/post-2292832

 

[-Kobas-]

Why are you ignoring my post >.>
I spend 2 min making that shit ^_^
It's the most simple way to make MUI stuff.

 

[Crystalknoct]

https://www.hiveworkshop.com/threads/timers.230384/post-2292832

shitty part is this counter acts with my creep revive would have to rework it ignore creeps unless you already have one with it I just didnt notice I dont understand custom scripts completly yet only some basics with them

Why are you ignoring my post >.>
I spend 2 min making that shit ^_^
It's the most simple way to make MUI stuff.

also didnt ignore it I have been busy trying to fix other problems that might not work with my other systems I apoligize if I offended you

 

[-Kobas-]

shitty part is this counter acts with my creep revive.



also didnt ignore it I have been busy trying to fix other problems that might not work with my other systems I apoligize if I offended you

Nah it's ok, I get used to it, just wanted to see did you get the idea how I made that. That example of mine will work for up to 8.191 units (if they all die at same time, or in that interval before first revive). And that's number you will never reach ^_^

You can using same analogy, create timer windows and everything else you need. It's simple as that.

 

[Crystalknoct]

Nah it's ok, I get used to it, just wanted to see did you get the idea how I made that. That example of mine will work for up to 8.191 units (if they all die at same time, or in that interval before first revive). And that's number you will never reach ^_^

You can using same analogy, create timer windows and everything else you need. It's simple as that.

I kinda understand how you did it I havnt worked alot with hashables just some minor stuff gotta learn more about them im slowly getting better at this but hey practice makes perfect and I actually like your method gunna give it a try see if it works with my other systems in a bit here btw nice job on your RPG going to have to try it when I am not working on mine.

 

[-Kobas-]

You can always upload map, it's much easier for us to point you in right direction
Not to mention terrain and other stuff we can check for you.

 

[Crystalknoct]

You can always upload map, it's much easier for us to point you in right direction
Not to mention terrain and other stuff we can check for you.

I can show you what I have atm for terrain n shit any input/ideas are appreaciated ill try to impliment this is my first major map im making so want it to be as good as it can be I didnt start with initial water level so I have to use the shitty cliffs for it unless somehow I can fix with newgen doubt it tho I reimported the whole map with it to try n fix earlier

 

[-Kobas-]

Attach map to post, or upload it into pastebin and then share link to it and we will see what can be done about it

 

[Crystalknoct]

Attach map to post, or upload it into pastebin and then share link to it and we will see what can be done about it

sent link via private message

 

[-Kobas-]

Ok will share info trough pm

 

[Crystalknoct]

Ok will share info trough pm

sounds good