GUI Rupture V1.6

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Rupture V1.6 | Reviewed by Maker | 1st November 2013 [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" Concept[/COLOR]] The spell can be used tactically as it makes the target take more damage if it moves It is directly from DotA as far as I know, copying the spells from there is not so original Triggers[/COLOR]] The spell is MUI and has a configuration trigger You have a leak when checking the travelled distance Use the ability level at the time of casting when dealing damage You need to remove the old position of target before updating it Add importing instructions Objects[/COLOR]] No critical issues The spell is given "spell, throw" animation, the caster does not have that animation You could remove the extra empty lines from the learn tooltip text Remove the dummy units if they are not used Effects[/COLOR]] A buff is applied There is a special effect to indicate that damage is dealt however you could consider creating a bit less effects The spell makes no sound Rating[/COLOR]] CONCEPT TRIGGERS OBJECTS EFFECTS RATING STATUS NEEDS FIX Links[/COLOR]] Destroy only trees Things that leak [COLOR="gray"

[/TD]

 

[deathismyfriend]

post triggers in description.
I think this is normal GUI not UMSWE.

Don't just use ITEs to make different lvls simply use a math equation.
This is MUI but it will loop through all unused indexes. Look at my tutorial things a guier should know the chapter how to index. It will show you how to properly index a spell.
This leaks locations very bad. Anything with position of / center of / player start location / offset will leak. Look at the tutorial things that leak on triggers and scripts page.
Never use 0.01 for a loop timer use 0.03
You need a config trigger. Please read spell submission rules before posting spells.
Don't use waits. not sure why you have a reset trigger...

 

[cotd333]

Thanks for the advice. I'll update it soon.

I made that reset trigger so you don't have to wait for the cooldown.

 

[deathismyfriend]

Thanks for the advice. I'll update it soon.

I made that reset trigger so you don't have to wait for the cooldown.

look at my tutorial things a guier should know it will help with a lot of stuff. Also there is a chapter on waits you should know about if using them.

 

[Rheiko]

where's the triggers?
post them here please

 

[FUJI]

Pls post the triggers there's a tutorial here made by MortAr

 

[deathismyfriend]

jakeZinc means this.
http://www.hiveworkshop.com/forums/miscellaneous-tutorials-456/how-easily-post-triggers-163285/

 

[FUJI]

^Exactly

 

[Rheiko]

• Set RupturePositionofTarget[OverallInt] = (Position of (Target unit of ability being cast))

should be

• Set RupturePositionofTarget[OverallInt] = (Position of RuptureTargetUnit[OverallInt])

so it's like this

• Set OverallInt = (OverallInt + 1)
• Set RuptureTriggerUnit[OverallInt] = (Triggering unit)
• Set RuptureTargetUnit[OverallInt] = (Target unit of ability being cast)
• Set RupturePositionofTarget[OverallInt] = (Position of RuptureTargetUnit[OverallInt])

also store the level of ability
and you should null a variable when it is no longer used
why this?

• Unit - Cause RuptureTriggerUnit[TempInt] to damage RuptureTargetUnit[TempInt], dealing (RuptureDamage[TempInt] x (Distance between (Position of RuptureTargetUnit[TempInt]) and RupturePositionofTarget[TempInt])) damage

it should be

• Unit - Cause RuptureTriggerUnit[TempInt] to damage RuptureTargetUnit[TempInt], dealing (RuptureDamage[TempInt] x (Distance between RupturePositionofTarget[TempInt] and RupturePositionofTarget[TempInt])) damage

so it's like this

• Set RupturePositionofTarget[TempInt] = (Position of RuptureTargetUnit[TempInt])
• Unit - Cause RuptureTriggerUnit[TempInt] to damage RuptureTargetUnit[TempInt], dealing (RuptureDamage[TempInt] x (Distance between RupturePositionofTarget[TempInt] and RupturePositionofTarget[TempInt])) damage

may i ask? is the rupture buff will stay forever?
and why the periodic timer is not turned off when you finish on using it?

 

[cotd333]

If I do this:

• Unit - Cause RuptureTriggerUnit[TempInt] to damage RuptureTargetUnit[TempInt], dealing (RuptureDamage[TempInt] x (Distance between RupturePositionofTarget[TempInt] and RupturePositionofTarget[TempInt])) damage

Then the damage would only be .20/.40/.60. The damage will be too small. As though the target unit doesn't even take damage.

Thanks for pointing this out:

• Set RupturePositionofTarget[OverallInt] = (Position of (Target unit of ability being cast))

No, the buff doesn't last forever. But once the unit loses the buff, the trigger no longer affects the unit. But the damage will stack if you cast the ability twice on the same unit (As long as it has the buff.).

 

[Rheiko]

wait, wait, wait..
my bad..
you should store that into a variable too, just like RupturePositionofTarget[TempInt]
but with new variable then use it

about the buff, i didn't notice you use buff back then.. lol

 

[FUJI]

Why nulling GLOBAL variables?? Is will gonna work??

 

[Maker]

Fix the leaks.

Untitled Trigger 001 If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Level of Rupture for RuptureTriggerUnit[OverallInt]) Equal to 1 Then - Actions Unit - Cause RuptureTriggerUnit[OverallInt] to damage RuptureTargetUnit[OverallInt], dealing 150.00 damage... Set RuptureDamage[OverallInt] = 0.20 Set RuptureDuration[OverallInt] = 7.00 Else - Actions If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Level of Rupture for RuptureTriggerUnit[OverallInt]) Equal to 2 Then - Actions Unit - Cause RuptureTriggerUnit[OverallInt] to damage RuptureTargetUnit[OverallInt], dealing 250.00 damage... Set RuptureDamage[OverallInt] = 0.40 Set RuptureDuration[OverallInt] = 8.00 Else - Actions If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Level of Rupture for RuptureTriggerUnit[OverallInt]) Equal to 3 Then - Actions Unit - Cause RuptureTriggerUnit[OverallInt] to damage RuptureTargetUnit[OverallInt], dealing 350.00 damage... Set RuptureDamage[OverallInt] = 0.60 Set RuptureDuration[OverallInt] = 9.00 Else - Actions

->

Unit - unit to damage unit, dealing (50.00 + (100.00 x (Real((Level of (Ability being cast) for (Triggering unit)))))) damage... Set RuptureDamage[OverallInt] = 0.20 x ability level Set RuptureDuration[OverallInt] = 6 + ability level

 

[Maker]

You still have location leaks.

 

[doomhammer99]

explain how they work inside the triggers using Comment .

 

[deathismyfriend]

explain how they work inside the triggers using Comment .

It helps if you say what you are referring to.

 

[Roland]

I Downloaded the spell and Tested it to my Map a While ago, (I was in school) Then, I was surprised that the Functions of the Spell looks great and outstanding. Well, 10 Over 10.

 

[deathismyfriend]

I Downloaded the spell and Tested it to my Map a While ago, (I was in school) Then, I was surprised that the Functions of the Spell looks great and outstanding. Well, 10 Over 10.

If you are going to give rating on triggers also please look at the triggers closer.
This still has a lot of leaks.

If just one instance is running this leaks 3 positions every .03 seconds. That is a lot of leaks when multiple units cast the spell and when the spell lasts for a long time. if spell lasts for 1 second and 100 units cast it it leaks 3,333 locations.

 

[deathismyfriend]

You keep updating but you're never fixing the leaks...

 

[T. D. W.]

Review

Suggestions

Rating

Set RuptureDuration[TempInt] = (RuptureDuration[TempInt] - 0.00)

there is no need for this ^"

Custom script: call RemoveLocation(udg_RupturePositionofTarget[udg_TempInt])

You need to move this after the Destroy effect, it doesn not clear leaks where you added it

Custom script: set udg_RupturePositionofTarget[udg_TempInt]=null

This ^ too

Special Effect - Create a special effect attached to the chest of RuptureTargetUnit[TempInt] using Objects\Spawnmodels\Human\HumanBlood\BloodElfSpellThiefBlood.mdl

attach it to the origin, not chest

Remove the Fx from the Buff, and add something like: if distance > 15 then create another Fx, like a double Fx

 

[Maker]

There's still a leak in the looping trigger, distance between...

 

[Malhorne]

• Custom script: set udg_RUPTURE_POSITION_OF_TARGET[udg_RUPTURE_CURRENT_INDEX]=null

It is pointless to null udg.

 

[Maker]

It is pointless to null udg.

It prevents a leak, but the leak is very very tiny.

 

[Malhorne]

Oh didn't knew that udg leak oO
Thanks Maker

 

[defskull]

It prevents a leak, but the leak is very very tiny.

In this case (uploading Spells in the Spells Section), this leak is negligible for trigger reviewing, right ?

 

[Malhorne]

I think yes since many spells don't null it.
But I don't really the matter since the var will be overriden whenever you cast again the spell.

 

[defskull]

Unless it's a local variable, then you should always null it.

 

[Malhorne]

For sure

 

[Maker]

In this case (uploading Spells in the Spells Section), this leak is negligible for trigger reviewing, right ?

It is ignored for GUI but not for vjass.

But I don't really the matter since the var will be overriden whenever you cast again the spell.

Irrelevant, removed objects will leak if not nulled.

 

[Malhorne]

Do you mean that we have to null globals ?

 

[Maker]

You don't have to, but it will leak if you don't.

 

[Malhorne]

So I have to ^^'
I'll fix it in my resources so ^^