[GUI] Divine Protection v1.2

Moderator · May 19, 2011

Bribe:

Looks REALLY good. I will test out this spell when I am home this evening.

No leaks, way more efficient than a GUI system needs to be, very nice work.

Unrelated to the spell, your "Dies" trigger could be simplified and also leaks a location. I advise changing it to this:

JASS:

local unit u = GetTriggerUnit()
local integer id = GetUnitTypeId(u)
local real f = GetUnitFacing(u)
local real x = GetUnitX(u)
local real y = GetUnitY(u)
call PolledWait(5.22)
call CreateUnit(Player(2), id, x, y, f)

Maker, v1.2. 14.07.2011
Approved.
You should put these if/then/elses inside each other:
DivDuration Equal to 8
DivDuration Equal to 5
DivDuration Equal to 2

Archangel678 · May 19, 2011

[rainbow]Please comment and rate.[/rainbow]

This spell makes units in the circle invulnerable, while dealing damage to hostile units that are in the circle. Basically, its Big Bad Voodoo combined with Death and Decay.

This spell does use Hashtables, and should be considerably efficient.

Magtheridon96 · May 19, 2011

For GUI, .. this spell is pretty efficient

Excellent Job!
No repeating functions, no leaks, MUI, good effects, configurable.
-> 5/5 ^^

Archangel678 · May 19, 2011

For GUI, .. this spell is pretty efficient
Excellent Job!
No repeating functions, no leaks, MUI, good effects, configurable.
-> 5/5 ^^

Thanks ^^. Any feedback on the effects on how they look? I actually reduced them by roughly 75% to reduce lagg...

<---200

Nightmare Moon · May 19, 2011

The effects are great! But i would like to see more DivEffectD effects around the circle. And you could slow down the lightning move a bit.
Well configured! I love when the spell are easy to configure!
Good work. i'd rate 5/5

You pick structures in groups, should they be picked?

Maker · May 19, 2011

The lightnings could originate from the center of the effect, not from the bottom of the effect.
Maybe attach some effect to the end point of the lightning.
Are you removing Strom Crow somewhere?
DivTRIGGER Equal to 0 should be done right after Set DivTRIGGER = (DivTRIGGER - 1), not during every loop.

Magtheridon96 · May 19, 2011

No leaks, way more efficient than a GUI system needs to be, very nice work.

I taught him everything he knows ^_^ (Did I?)

EDIT: To show you exactly how efficient this system is:

Look at the relatively low number of BJS:

JASS:

function Trig_DivineCast_Conditions takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == 'A000' ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineCast_Func012C takes nothing returns boolean
    if ( not ( IsUnitType(udg_DivDummyUNIT, UNIT_TYPE_FLYING) == false ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineCast_Func021001003001 takes nothing returns boolean
    return ( IsUnitAliveBJ(GetFilterUnit()) == true )
endfunction

function Trig_DivineCast_Func021001003002001 takes nothing returns boolean
    return ( IsUnitAlly(GetFilterUnit(), GetTriggerPlayer()) == true )
endfunction

function Trig_DivineCast_Func021001003002002 takes nothing returns boolean
    return ( GetOwningPlayer(GetFilterUnit()) == GetTriggerPlayer() )
endfunction

function Trig_DivineCast_Func021001003002 takes nothing returns boolean
    return GetBooleanOr( Trig_DivineCast_Func021001003002001(), Trig_DivineCast_Func021001003002002() )
endfunction

function Trig_DivineCast_Func021001003 takes nothing returns boolean
    return GetBooleanAnd( Trig_DivineCast_Func021001003001(), Trig_DivineCast_Func021001003002() )
endfunction

function Trig_DivineCast_Func021A takes nothing returns nothing
    set udg_DivPickedUnit = GetEnumUnit()
    call AddSpecialEffectTargetUnitBJ( "chest", udg_DivPickedUnit, udg_DivEffectA )
    call DestroyEffectBJ( GetLastCreatedEffectBJ() )
    call SetUnitInvulnerable( udg_DivPickedUnit, true )
    call GroupAddUnitSimple( udg_DivPickedUnit, udg_DivGroup2 )
    set udg_Handle_Div2 = GetHandleId(udg_DivPickedUnit)
    call SaveUnitHandleBJ( udg_DivDummyUNIT, 6, udg_Handle_Div2, udg_Hash_Divine )
endfunction

function Trig_DivineCast_Actions takes nothing returns nothing
    set udg_DivCast = GetTriggerUnit()
    set udg_DP = GetSpellTargetLoc()
    // ========================
    set udg_DivLevel = GetUnitAbilityLevelSwapped('A000', udg_DivCast)
    set udg_DivAoE = ( udg_DivAoEB + ( udg_DivAoEI * I2R(udg_DivLevel) ) )
    set udg_DivDuration = ( udg_DivDurationB + ( udg_DivDurationI * udg_DivLevel ) )
    set udg_DivDPS = ( udg_DivDPSB + ( udg_DivDPSI * I2R(udg_DivLevel) ) )
    // Dummy "Shield" Create & Growth
    set udg_DivAngle = GetUnitFacing(udg_DivCast)
    call CreateNUnitsAtLoc( 1, udg_DivDummy, GetTriggerPlayer(), udg_DP, udg_DivAngle )
    set udg_DivDummyUNIT = GetLastCreatedUnit()
    if ( Trig_DivineCast_Func012C() ) then
        call UnitAddAbilityBJ( 'Amrf', udg_DivDummyUNIT )
    else
    endif
    set udg_Handle_Div = GetHandleId(udg_DivDummyUNIT)
    // ========================
    // Lightning
    set udg_DivLoop = 1
    loop
        exitwhen udg_DivLoop > 4
        set udg_DivAngle = ( udg_DivAngle + udg_DivAngleUp )
        set udg_DP2 = PolarProjectionBJ(udg_DP, udg_DivAoE, udg_DivAngle)
        set udg_DL = AddLightningEx(udg_DL1, true , GetLocationX(udg_DP), GetLocationY(udg_DP), (udg_DPH2), GetLocationX(udg_DP2), GetLocationY(udg_DP2), GetLocationZ(udg_DP2) + (udg_DPH1) )
        call SaveLightningHandleBJ( udg_DL, ( udg_DivLoop + 6 ), udg_Handle_Div, udg_Hash_Divine )
        call RemoveLocation(udg_DP2)
        set udg_DivLoop = udg_DivLoop + 1
    endloop
    call SetUnitFlyHeight( udg_DivDummyUNIT, (udg_DPH2) - (udg_DivHeightNull), 0.00 )
    // ========================
    // ========================
    set bj_wantDestroyGroup = true
    call ForGroupBJ( GetUnitsInRangeOfLocMatching(udg_DivAoE, udg_DP, Condition(function Trig_DivineCast_Func021001003)), function Trig_DivineCast_Func021A )
    // ========================
    // Save Hashtables
    // ========================
    call SaveUnitHandleBJ( udg_DivCast, 1, udg_Handle_Div, udg_Hash_Divine )
    call SaveRealBJ( udg_DivAoE, 2, udg_Handle_Div, udg_Hash_Divine )
    call SaveIntegerBJ( udg_DivDuration, 3, udg_Handle_Div, udg_Hash_Divine )
    call SaveRealBJ( udg_DivDPS, 4, udg_Handle_Div, udg_Hash_Divine )
    call SaveGroupHandleBJ( udg_DivGroup2, 5, udg_Handle_Div, udg_Hash_Divine )
    call SaveRealBJ( udg_DivAngle, 11, udg_Handle_Div, udg_Hash_Divine )
    call SaveIntegerBJ( udg_DivIntegerSFX, 15, udg_Handle_Div, udg_Hash_Divine )
    call GroupAddUnitSimple( udg_DivDummyUNIT, udg_DivGroup )
    // ========================
    // Clean up/Turn on
    // ========================
    set udg_DivTRIGGER = ( udg_DivTRIGGER + 1 )
    call EnableTrigger( gg_trg_DivineLoop )
    call RemoveLocation(udg_DP)
endfunction

//===========================================================================
function InitTrig_DivineCast takes nothing returns nothing
    set gg_trg_DivineCast = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_DivineCast, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_DivineCast, Condition( function Trig_DivineCast_Conditions ) )
    call TriggerAddAction( gg_trg_DivineCast, function Trig_DivineCast_Actions )
endfunction

JASS:

function Trig_DivineLoop_Func002C takes nothing returns boolean
    if ( not ( udg_DivCount >= udg_DivCountMAX ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004Func011Func007001003001 takes nothing returns boolean
    return ( IsUnitAlly(GetFilterUnit(), GetOwningPlayer(udg_DivDummyUNIT)) == false )
endfunction

function Trig_DivineLoop_Func004Func011Func007001003002001 takes nothing returns boolean
    return ( GetOwningPlayer(GetFilterUnit()) != GetOwningPlayer(udg_DivDummyUNIT) )
endfunction

function Trig_DivineLoop_Func004Func011Func007001003002002001 takes nothing returns boolean
    return ( IsUnitAliveBJ(GetFilterUnit()) == true )
endfunction

function Trig_DivineLoop_Func004Func011Func007001003002002002001 takes nothing returns boolean
    return ( IsUnitType(GetFilterUnit(), UNIT_TYPE_MAGIC_IMMUNE) == false )
endfunction

function Trig_DivineLoop_Func004Func011Func007001003002002002002001 takes nothing returns boolean
    return ( IsUnitHiddenBJ(GetFilterUnit()) == false )
endfunction

function Trig_DivineLoop_Func004Func011Func007001003002002002002002 takes nothing returns boolean
    return ( IsUnitIllusionBJ(GetFilterUnit()) == false )
endfunction

function Trig_DivineLoop_Func004Func011Func007001003002002002002 takes nothing returns boolean
    return GetBooleanAnd( Trig_DivineLoop_Func004Func011Func007001003002002002002001(), Trig_DivineLoop_Func004Func011Func007001003002002002002002() )
endfunction

function Trig_DivineLoop_Func004Func011Func007001003002002002 takes nothing returns boolean
    return GetBooleanAnd( Trig_DivineLoop_Func004Func011Func007001003002002002001(), Trig_DivineLoop_Func004Func011Func007001003002002002002() )
endfunction

function Trig_DivineLoop_Func004Func011Func007001003002002 takes nothing returns boolean
    return GetBooleanAnd( Trig_DivineLoop_Func004Func011Func007001003002002001(), Trig_DivineLoop_Func004Func011Func007001003002002002() )
endfunction

function Trig_DivineLoop_Func004Func011Func007001003002 takes nothing returns boolean
    return GetBooleanAnd( Trig_DivineLoop_Func004Func011Func007001003002001(), Trig_DivineLoop_Func004Func011Func007001003002002() )
endfunction

function Trig_DivineLoop_Func004Func011Func007001003 takes nothing returns boolean
    return GetBooleanAnd( Trig_DivineLoop_Func004Func011Func007001003001(), Trig_DivineLoop_Func004Func011Func007001003002() )
endfunction

function Trig_DivineLoop_Func004Func011Func007A takes nothing returns nothing
    set udg_DivPickedUnit = GetEnumUnit()
    call UnitDamageTargetBJ( udg_DivCast, udg_DivPickedUnit, udg_DivDPS, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_DIVINE )
    call AddSpecialEffectTargetUnitBJ( "chest", udg_DivPickedUnit, "Abilities\\Weapons\\WingedSerpentMissile\\WingedSerpentMissile.mdl" )
    call DestroyEffectBJ( GetLastCreatedEffectBJ() )
endfunction

function Trig_DivineLoop_Func004Func011Func010001003001001 takes nothing returns boolean
    return ( IsUnitInGroup(GetFilterUnit(), udg_DivGroup2) == false )
endfunction

function Trig_DivineLoop_Func004Func011Func010001003001002 takes nothing returns boolean
    return ( IsUnitInGroup(GetFilterUnit(), udg_DivGroup3) == false )
endfunction

function Trig_DivineLoop_Func004Func011Func010001003001 takes nothing returns boolean
    return GetBooleanAnd( Trig_DivineLoop_Func004Func011Func010001003001001(), Trig_DivineLoop_Func004Func011Func010001003001002() )
endfunction

function Trig_DivineLoop_Func004Func011Func010001003002001 takes nothing returns boolean
    return ( IsUnitAliveBJ(GetFilterUnit()) == true )
endfunction

function Trig_DivineLoop_Func004Func011Func010001003002002001 takes nothing returns boolean
    return ( IsUnitAlly(GetFilterUnit(), GetOwningPlayer(udg_DivDummyUNIT)) == true )
endfunction

function Trig_DivineLoop_Func004Func011Func010001003002002002 takes nothing returns boolean
    return ( GetOwningPlayer(GetFilterUnit()) == GetOwningPlayer(udg_DivDummyUNIT) )
endfunction

function Trig_DivineLoop_Func004Func011Func010001003002002 takes nothing returns boolean
    return GetBooleanOr( Trig_DivineLoop_Func004Func011Func010001003002002001(), Trig_DivineLoop_Func004Func011Func010001003002002002() )
endfunction

function Trig_DivineLoop_Func004Func011Func010001003002 takes nothing returns boolean
    return GetBooleanAnd( Trig_DivineLoop_Func004Func011Func010001003002001(), Trig_DivineLoop_Func004Func011Func010001003002002() )
endfunction

function Trig_DivineLoop_Func004Func011Func010001003 takes nothing returns boolean
    return GetBooleanAnd( Trig_DivineLoop_Func004Func011Func010001003001(), Trig_DivineLoop_Func004Func011Func010001003002() )
endfunction

function Trig_DivineLoop_Func004Func011Func010A takes nothing returns nothing
    set udg_DivPickedUnit = GetEnumUnit()
    call AddSpecialEffectTargetUnitBJ( "origin", udg_DivPickedUnit, udg_DivEffectB )
    call DestroyEffectBJ( GetLastCreatedEffectBJ() )
    call SetUnitInvulnerable( udg_DivPickedUnit, true )
    call GroupAddUnitSimple( udg_DivPickedUnit, udg_DivGroup2 )
    set udg_Handle_Div2 = GetHandleId(udg_DivPickedUnit)
    call SaveUnitHandleBJ( udg_DivDummyUNIT, 6, udg_Handle_Div2, udg_Hash_Divine )
endfunction

function Trig_DivineLoop_Func004Func011Func013Func005Func001C takes nothing returns boolean
    if ( ( IsUnitAliveBJ(udg_DivDummyUNIT) == false ) ) then
        return true
    endif
    if ( ( IsUnitHiddenBJ(udg_DivPickedUnit) == true ) ) then
        return true
    endif
    if ( ( udg_DivTar == null ) ) then
        return true
    endif
    if ( ( udg_DivTar == udg_DivDummyUNIT ) ) then
        return true
    endif
    return false
endfunction

function Trig_DivineLoop_Func004Func011Func013Func005C takes nothing returns boolean
    if ( not Trig_DivineLoop_Func004Func011Func013Func005Func001C() ) then
        return false
    endif
    if ( not ( DistanceBetweenPoints(udg_DP, udg_DP2) > udg_DivAoE ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004Func011Func013A takes nothing returns nothing
    set udg_DivPickedUnit = GetEnumUnit()
    set udg_Handle_Div2 = GetHandleId(udg_DivPickedUnit)
    set udg_DP2 = GetUnitLoc(udg_DivPickedUnit)
    set udg_DivTar = LoadUnitHandleBJ(6, udg_Handle_Div2, udg_Hash_Divine)
    if ( Trig_DivineLoop_Func004Func011Func013Func005C() ) then
        call AddSpecialEffectTargetUnitBJ( "origin", udg_DivPickedUnit, udg_DivEffectC )
        call DestroyEffectBJ( GetLastCreatedEffectBJ() )
        call SetUnitInvulnerable( udg_DivPickedUnit, false )
        call GroupRemoveUnitSimple( udg_DivPickedUnit, udg_DivGroup2 )
        call FlushChildHashtableBJ( udg_Handle_Div2, udg_Hash_Divine )
    else
    endif
    call RemoveLocation(udg_DP2)
endfunction

function Trig_DivineLoop_Func004Func011C takes nothing returns boolean
    if ( not ( udg_DivBool == true ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004Func012Func003Func002C takes nothing returns boolean
    if ( not ( udg_DivDuration == 8 ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004Func012Func003Func003C takes nothing returns boolean
    if ( not ( udg_DivDuration == 5 ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004Func012Func003Func004C takes nothing returns boolean
    if ( not ( udg_DivDuration == 2 ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004Func012Func003Func014Func001C takes nothing returns boolean
    if ( not ( udg_DivIntegerSFX >= 4 ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004Func012Func003Func014C takes nothing returns boolean
    if ( not ( udg_DivIntegerSFX == udg_DivLoop ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004Func012Func003C takes nothing returns boolean
    if ( not ( udg_DivDuration > 0 ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004Func020Func001Func003C takes nothing returns boolean
    if ( not ( LoadUnitHandleBJ(6, udg_Handle_Div2, udg_Hash_Divine) == udg_DivDummyUNIT ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004Func020Func001A takes nothing returns nothing
    set udg_DivPickedUnit = GetEnumUnit()
    set udg_Handle_Div2 = GetHandleId(udg_DivPickedUnit)
    if ( Trig_DivineLoop_Func004Func020Func001Func003C() ) then
        call AddSpecialEffectTargetUnitBJ( "origin", udg_DivPickedUnit, udg_DivEffectC )
        call DestroyEffectBJ( GetLastCreatedEffectBJ() )
        call SetUnitInvulnerable( udg_DivPickedUnit, false )
        call GroupRemoveUnitSimple( udg_DivPickedUnit, udg_DivGroup2 )
    else
    endif
endfunction

function Trig_DivineLoop_Func004Func020C takes nothing returns boolean
    if ( not ( udg_DivDuration == 0 ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004A takes nothing returns nothing
    set udg_DivDummyUNIT = GetEnumUnit()
    set udg_DP = GetUnitLoc(udg_DivDummyUNIT)
    set udg_Handle_Div = GetHandleId(udg_DivDummyUNIT)
    // =============================
    set udg_DivAoE = LoadRealBJ(2, udg_Handle_Div, udg_Hash_Divine)
    set udg_DivAngle = LoadRealBJ(11, udg_Handle_Div, udg_Hash_Divine)
    set udg_DivAngleTemp = udg_DivAngle
    set udg_DivDuration = LoadIntegerBJ(3, udg_Handle_Div, udg_Hash_Divine)
    set udg_DivIntegerSFX = LoadIntegerBJ(15, udg_Handle_Div, udg_Hash_Divine)
    // =============================
    if ( Trig_DivineLoop_Func004Func011C() ) then
        set udg_DivCast = LoadUnitHandleBJ(1, udg_Handle_Div, udg_Hash_Divine)
        set udg_DivDPS = LoadRealBJ(4, udg_Handle_Div, udg_Hash_Divine)
        set udg_DivGroup2 = LoadGroupHandleBJ(5, udg_Handle_Div, udg_Hash_Divine)
        // ==============================
        set bj_wantDestroyGroup = true
        call ForGroupBJ( GetUnitsInRangeOfLocMatching(udg_DivAoE, udg_DP, Condition(function Trig_DivineLoop_Func004Func011Func007001003)), function Trig_DivineLoop_Func004Func011Func007A )
        // ==============================
        set bj_wantDestroyGroup = true
        call ForGroupBJ( GetUnitsInRangeOfLocMatching(udg_DivAoE, udg_DP, Condition(function Trig_DivineLoop_Func004Func011Func010001003)), function Trig_DivineLoop_Func004Func011Func010A )
        // ==============================
        // ==============================
        call ForGroupBJ( udg_DivGroup2, function Trig_DivineLoop_Func004Func011Func013A )
        // ==============================
        set udg_DivDuration = ( udg_DivDuration - 1 )
        call SaveGroupHandleBJ( udg_DivGroup2, 5, udg_Handle_Div, udg_Hash_Divine )
        call SaveIntegerBJ( udg_DivDuration, 3, udg_Handle_Div, udg_Hash_Divine )
    else
    endif
    set udg_DivLoop = 1
    loop
        exitwhen udg_DivLoop > 4
        set udg_DL = LoadLightningHandleBJ(( udg_DivLoop + 6 ), udg_Handle_Div, udg_Hash_Divine)
        // =============================
        if ( Trig_DivineLoop_Func004Func012Func003C() ) then
            if ( Trig_DivineLoop_Func004Func012Func003Func002C() ) then
                // // Remove a few BJs doing this method.
                call SetLightningColor( udg_DL, 0.80, 0.80, 0.80, 1 )
            else
            endif
            if ( Trig_DivineLoop_Func004Func012Func003Func003C() ) then
                call SetLightningColor( udg_DL, 0.60, 0.60, 0.60, 1 )
            else
            endif
            if ( Trig_DivineLoop_Func004Func012Func003Func004C() ) then
                call SetLightningColor( udg_DL, 0.40, 0.40, 0.40, 1 )
            else
            endif
            // =============================
            // =============================
            set udg_DivAngleTemp = ( udg_DivAngleTemp + ( udg_DivAngleUp * ( I2R(udg_DivLoop) - 1 ) ) )
            set udg_DP2 = PolarProjectionBJ(udg_DP, udg_DivAoE, udg_DivAngleTemp)
            // =============================
            // =============================
            call MoveLightningEx(udg_DL , true , GetLocationX(udg_DP), GetLocationY(udg_DP), GetLocationZ(udg_DP) + (udg_DPH2) , GetLocationX(udg_DP2), GetLocationY(udg_DP2), GetLocationZ(udg_DP2) + (udg_DPH1) )
            // =============================
            if ( Trig_DivineLoop_Func004Func012Func003Func014C() ) then
                if ( Trig_DivineLoop_Func004Func012Func003Func014Func001C() ) then
                    set udg_DivIntegerSFX = 0
                else
                endif
                call AddSpecialEffectLocBJ( udg_DP2, udg_DivEffectD )
                call DestroyEffectBJ( GetLastCreatedEffectBJ() )
            else
            endif
            call RemoveLocation(udg_DP2)
        else
            call DestroyLightning( udg_DL )
        endif
        set udg_DivLoop = udg_DivLoop + 1
    endloop
    // =============================
    set udg_DivIntegerSFX = ( udg_DivIntegerSFX + 1 )
    set udg_DivAngle = ( udg_DivAngle + udg_DivAngleConstantUp )
    // =============================
    call SaveIntegerBJ( udg_DivIntegerSFX, 15, udg_Handle_Div, udg_Hash_Divine )
    call SaveRealBJ( udg_DivAngle, 11, udg_Handle_Div, udg_Hash_Divine )
    // =============================
    if ( Trig_DivineLoop_Func004Func020C() ) then
        call ForGroupBJ( udg_DivGroup2, function Trig_DivineLoop_Func004Func020Func001A )
        call GroupRemoveUnitSimple( udg_DivDummyUNIT, udg_DivGroup )
        call UnitApplyTimedLifeBJ( 0.01, 'BTLF', udg_DivDummyUNIT )
        call SetUnitExplodedBJ( udg_DivDummyUNIT, true )
        set udg_DivTRIGGER = ( udg_DivTRIGGER - 1 )
        call FlushChildHashtableBJ( udg_Handle_Div, udg_Hash_Divine )
    else
    endif
    // =============================
    call RemoveLocation(udg_DP)
endfunction

function Trig_DivineLoop_Func005Func002Func006Func009C takes nothing returns boolean
    if ( ( udg_DivTar == null ) ) then
        return true
    endif
    if ( ( IsUnitDeadBJ(udg_DivTar) == true ) ) then
        return true
    endif
    return false
endfunction

function Trig_DivineLoop_Func005Func002Func006C takes nothing returns boolean
    if ( not Trig_DivineLoop_Func005Func002Func006Func009C() ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func005Func002A takes nothing returns nothing
    set udg_DivPickedUnit = GetEnumUnit()
    // =============================
    set udg_Handle_Div2 = GetHandleId(udg_DivPickedUnit)
    set udg_DivTar = LoadUnitHandleBJ(6, udg_Handle_Div2, udg_Hash_Divine)
    // =============================
    if ( Trig_DivineLoop_Func005Func002Func006C() ) then
        // =============================
        call AddSpecialEffectTargetUnitBJ( "origin", udg_DivPickedUnit, udg_DivEffectC )
        call DestroyEffectBJ( GetLastCreatedEffectBJ() )
        // =============================
        call SetUnitInvulnerable( udg_DivPickedUnit, false )
        call GroupRemoveUnitSimple( udg_DivPickedUnit, udg_DivGroup2 )
        // =============================
        call FlushChildHashtableBJ( udg_Handle_Div2, udg_Hash_Divine )
    else
    endif
endfunction

function Trig_DivineLoop_Func005C takes nothing returns boolean
    if ( not ( udg_DivTRIGGER == 0 ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Actions takes nothing returns nothing
    // This makes a "1 second" delay...
    if ( Trig_DivineLoop_Func002C() ) then
        set udg_DivBool = true
        set udg_DivCount = 0
    else
        set udg_DivBool = false
        set udg_DivCount = ( udg_DivCount + 1 )
    endif
    // =============================
    call ForGroupBJ( udg_DivGroup, function Trig_DivineLoop_Func004A )
    if ( Trig_DivineLoop_Func005C() ) then
        // =============================
        call ForGroupBJ( udg_DivGroup2, function Trig_DivineLoop_Func005Func002A )
        // =============================
        call DisableTrigger( GetTriggeringTrigger() )
    else
    endif
endfunction

//===========================================================================
function InitTrig_DivineLoop takes nothing returns nothing
    set gg_trg_DivineLoop = CreateTrigger(  )
    call DisableTrigger( gg_trg_DivineLoop )
    call TriggerRegisterTimerEventPeriodic( gg_trg_DivineLoop, 0.03 )
    call TriggerAddAction( gg_trg_DivineLoop, function Trig_DivineLoop_Actions )
endfunction

That's pretty low compared to other spells

Good Job ^^

Stape · May 19, 2011

It looks really epic!5/5

illegalpie · May 19, 2011

Magtheridon96 said:

I taught him everything he knows ^_^ (Did I?)

EDIT: To show you exactly how efficient this system is:

Look at the relatively low number of BJS:

JASS:

function Trig_DivineCast_Conditions takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == 'A000' ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineCast_Func012C takes nothing returns boolean
    if ( not ( IsUnitType(udg_DivDummyUNIT, UNIT_TYPE_FLYING) == false ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineCast_Func021001003001 takes nothing returns boolean
    return ( IsUnitAliveBJ(GetFilterUnit()) == true )
endfunction

function Trig_DivineCast_Func021001003002001 takes nothing returns boolean
    return ( IsUnitAlly(GetFilterUnit(), GetTriggerPlayer()) == true )
endfunction

function Trig_DivineCast_Func021001003002002 takes nothing returns boolean
    return ( GetOwningPlayer(GetFilterUnit()) == GetTriggerPlayer() )
endfunction

function Trig_DivineCast_Func021001003002 takes nothing returns boolean
    return GetBooleanOr( Trig_DivineCast_Func021001003002001(), Trig_DivineCast_Func021001003002002() )
endfunction

function Trig_DivineCast_Func021001003 takes nothing returns boolean
    return GetBooleanAnd( Trig_DivineCast_Func021001003001(), Trig_DivineCast_Func021001003002() )
endfunction

function Trig_DivineCast_Func021A takes nothing returns nothing
    set udg_DivPickedUnit = GetEnumUnit()
    call AddSpecialEffectTargetUnitBJ( "chest", udg_DivPickedUnit, udg_DivEffectA )
    call DestroyEffectBJ( GetLastCreatedEffectBJ() )
    call SetUnitInvulnerable( udg_DivPickedUnit, true )
    call GroupAddUnitSimple( udg_DivPickedUnit, udg_DivGroup2 )
    set udg_Handle_Div2 = GetHandleId(udg_DivPickedUnit)
    call SaveUnitHandleBJ( udg_DivDummyUNIT, 6, udg_Handle_Div2, udg_Hash_Divine )
endfunction

function Trig_DivineCast_Actions takes nothing returns nothing
    set udg_DivCast = GetTriggerUnit()
    set udg_DP = GetSpellTargetLoc()
    // ========================
    set udg_DivLevel = GetUnitAbilityLevelSwapped('A000', udg_DivCast)
    set udg_DivAoE = ( udg_DivAoEB + ( udg_DivAoEI * I2R(udg_DivLevel) ) )
    set udg_DivDuration = ( udg_DivDurationB + ( udg_DivDurationI * udg_DivLevel ) )
    set udg_DivDPS = ( udg_DivDPSB + ( udg_DivDPSI * I2R(udg_DivLevel) ) )
    // Dummy "Shield" Create & Growth
    set udg_DivAngle = GetUnitFacing(udg_DivCast)
    call CreateNUnitsAtLoc( 1, udg_DivDummy, GetTriggerPlayer(), udg_DP, udg_DivAngle )
    set udg_DivDummyUNIT = GetLastCreatedUnit()
    if ( Trig_DivineCast_Func012C() ) then
        call UnitAddAbilityBJ( 'Amrf', udg_DivDummyUNIT )
    else
    endif
    set udg_Handle_Div = GetHandleId(udg_DivDummyUNIT)
    // ========================
    // Lightning
    set udg_DivLoop = 1
    loop
        exitwhen udg_DivLoop > 4
        set udg_DivAngle = ( udg_DivAngle + udg_DivAngleUp )
        set udg_DP2 = PolarProjectionBJ(udg_DP, udg_DivAoE, udg_DivAngle)
        set udg_DL = AddLightningEx(udg_DL1, true , GetLocationX(udg_DP), GetLocationY(udg_DP), (udg_DPH2), GetLocationX(udg_DP2), GetLocationY(udg_DP2), GetLocationZ(udg_DP2) + (udg_DPH1) )
        call SaveLightningHandleBJ( udg_DL, ( udg_DivLoop + 6 ), udg_Handle_Div, udg_Hash_Divine )
        call RemoveLocation(udg_DP2)
        set udg_DivLoop = udg_DivLoop + 1
    endloop
    call SetUnitFlyHeight( udg_DivDummyUNIT, (udg_DPH2) - (udg_DivHeightNull), 0.00 )
    // ========================
    // ========================
    set bj_wantDestroyGroup = true
    call ForGroupBJ( GetUnitsInRangeOfLocMatching(udg_DivAoE, udg_DP, Condition(function Trig_DivineCast_Func021001003)), function Trig_DivineCast_Func021A )
    // ========================
    // Save Hashtables
    // ========================
    call SaveUnitHandleBJ( udg_DivCast, 1, udg_Handle_Div, udg_Hash_Divine )
    call SaveRealBJ( udg_DivAoE, 2, udg_Handle_Div, udg_Hash_Divine )
    call SaveIntegerBJ( udg_DivDuration, 3, udg_Handle_Div, udg_Hash_Divine )
    call SaveRealBJ( udg_DivDPS, 4, udg_Handle_Div, udg_Hash_Divine )
    call SaveGroupHandleBJ( udg_DivGroup2, 5, udg_Handle_Div, udg_Hash_Divine )
    call SaveRealBJ( udg_DivAngle, 11, udg_Handle_Div, udg_Hash_Divine )
    call SaveIntegerBJ( udg_DivIntegerSFX, 15, udg_Handle_Div, udg_Hash_Divine )
    call GroupAddUnitSimple( udg_DivDummyUNIT, udg_DivGroup )
    // ========================
    // Clean up/Turn on
    // ========================
    set udg_DivTRIGGER = ( udg_DivTRIGGER + 1 )
    call EnableTrigger( gg_trg_DivineLoop )
    call RemoveLocation(udg_DP)
endfunction

//===========================================================================
function InitTrig_DivineCast takes nothing returns nothing
    set gg_trg_DivineCast = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_DivineCast, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_DivineCast, Condition( function Trig_DivineCast_Conditions ) )
    call TriggerAddAction( gg_trg_DivineCast, function Trig_DivineCast_Actions )
endfunction

JASS:

function Trig_DivineLoop_Func002C takes nothing returns boolean
    if ( not ( udg_DivCount >= udg_DivCountMAX ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004Func011Func007001003001 takes nothing returns boolean
    return ( IsUnitAlly(GetFilterUnit(), GetOwningPlayer(udg_DivDummyUNIT)) == false )
endfunction

function Trig_DivineLoop_Func004Func011Func007001003002001 takes nothing returns boolean
    return ( GetOwningPlayer(GetFilterUnit()) != GetOwningPlayer(udg_DivDummyUNIT) )
endfunction

function Trig_DivineLoop_Func004Func011Func007001003002002001 takes nothing returns boolean
    return ( IsUnitAliveBJ(GetFilterUnit()) == true )
endfunction

function Trig_DivineLoop_Func004Func011Func007001003002002002001 takes nothing returns boolean
    return ( IsUnitType(GetFilterUnit(), UNIT_TYPE_MAGIC_IMMUNE) == false )
endfunction

function Trig_DivineLoop_Func004Func011Func007001003002002002002001 takes nothing returns boolean
    return ( IsUnitHiddenBJ(GetFilterUnit()) == false )
endfunction

function Trig_DivineLoop_Func004Func011Func007001003002002002002002 takes nothing returns boolean
    return ( IsUnitIllusionBJ(GetFilterUnit()) == false )
endfunction

function Trig_DivineLoop_Func004Func011Func007001003002002002002 takes nothing returns boolean
    return GetBooleanAnd( Trig_DivineLoop_Func004Func011Func007001003002002002002001(), Trig_DivineLoop_Func004Func011Func007001003002002002002002() )
endfunction

function Trig_DivineLoop_Func004Func011Func007001003002002002 takes nothing returns boolean
    return GetBooleanAnd( Trig_DivineLoop_Func004Func011Func007001003002002002001(), Trig_DivineLoop_Func004Func011Func007001003002002002002() )
endfunction

function Trig_DivineLoop_Func004Func011Func007001003002002 takes nothing returns boolean
    return GetBooleanAnd( Trig_DivineLoop_Func004Func011Func007001003002002001(), Trig_DivineLoop_Func004Func011Func007001003002002002() )
endfunction

function Trig_DivineLoop_Func004Func011Func007001003002 takes nothing returns boolean
    return GetBooleanAnd( Trig_DivineLoop_Func004Func011Func007001003002001(), Trig_DivineLoop_Func004Func011Func007001003002002() )
endfunction

function Trig_DivineLoop_Func004Func011Func007001003 takes nothing returns boolean
    return GetBooleanAnd( Trig_DivineLoop_Func004Func011Func007001003001(), Trig_DivineLoop_Func004Func011Func007001003002() )
endfunction

function Trig_DivineLoop_Func004Func011Func007A takes nothing returns nothing
    set udg_DivPickedUnit = GetEnumUnit()
    call UnitDamageTargetBJ( udg_DivCast, udg_DivPickedUnit, udg_DivDPS, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_DIVINE )
    call AddSpecialEffectTargetUnitBJ( "chest", udg_DivPickedUnit, "Abilities\\Weapons\\WingedSerpentMissile\\WingedSerpentMissile.mdl" )
    call DestroyEffectBJ( GetLastCreatedEffectBJ() )
endfunction

function Trig_DivineLoop_Func004Func011Func010001003001001 takes nothing returns boolean
    return ( IsUnitInGroup(GetFilterUnit(), udg_DivGroup2) == false )
endfunction

function Trig_DivineLoop_Func004Func011Func010001003001002 takes nothing returns boolean
    return ( IsUnitInGroup(GetFilterUnit(), udg_DivGroup3) == false )
endfunction

function Trig_DivineLoop_Func004Func011Func010001003001 takes nothing returns boolean
    return GetBooleanAnd( Trig_DivineLoop_Func004Func011Func010001003001001(), Trig_DivineLoop_Func004Func011Func010001003001002() )
endfunction

function Trig_DivineLoop_Func004Func011Func010001003002001 takes nothing returns boolean
    return ( IsUnitAliveBJ(GetFilterUnit()) == true )
endfunction

function Trig_DivineLoop_Func004Func011Func010001003002002001 takes nothing returns boolean
    return ( IsUnitAlly(GetFilterUnit(), GetOwningPlayer(udg_DivDummyUNIT)) == true )
endfunction

function Trig_DivineLoop_Func004Func011Func010001003002002002 takes nothing returns boolean
    return ( GetOwningPlayer(GetFilterUnit()) == GetOwningPlayer(udg_DivDummyUNIT) )
endfunction

function Trig_DivineLoop_Func004Func011Func010001003002002 takes nothing returns boolean
    return GetBooleanOr( Trig_DivineLoop_Func004Func011Func010001003002002001(), Trig_DivineLoop_Func004Func011Func010001003002002002() )
endfunction

function Trig_DivineLoop_Func004Func011Func010001003002 takes nothing returns boolean
    return GetBooleanAnd( Trig_DivineLoop_Func004Func011Func010001003002001(), Trig_DivineLoop_Func004Func011Func010001003002002() )
endfunction

function Trig_DivineLoop_Func004Func011Func010001003 takes nothing returns boolean
    return GetBooleanAnd( Trig_DivineLoop_Func004Func011Func010001003001(), Trig_DivineLoop_Func004Func011Func010001003002() )
endfunction

function Trig_DivineLoop_Func004Func011Func010A takes nothing returns nothing
    set udg_DivPickedUnit = GetEnumUnit()
    call AddSpecialEffectTargetUnitBJ( "origin", udg_DivPickedUnit, udg_DivEffectB )
    call DestroyEffectBJ( GetLastCreatedEffectBJ() )
    call SetUnitInvulnerable( udg_DivPickedUnit, true )
    call GroupAddUnitSimple( udg_DivPickedUnit, udg_DivGroup2 )
    set udg_Handle_Div2 = GetHandleId(udg_DivPickedUnit)
    call SaveUnitHandleBJ( udg_DivDummyUNIT, 6, udg_Handle_Div2, udg_Hash_Divine )
endfunction

function Trig_DivineLoop_Func004Func011Func013Func005Func001C takes nothing returns boolean
    if ( ( IsUnitAliveBJ(udg_DivDummyUNIT) == false ) ) then
        return true
    endif
    if ( ( IsUnitHiddenBJ(udg_DivPickedUnit) == true ) ) then
        return true
    endif
    if ( ( udg_DivTar == null ) ) then
        return true
    endif
    if ( ( udg_DivTar == udg_DivDummyUNIT ) ) then
        return true
    endif
    return false
endfunction

function Trig_DivineLoop_Func004Func011Func013Func005C takes nothing returns boolean
    if ( not Trig_DivineLoop_Func004Func011Func013Func005Func001C() ) then
        return false
    endif
    if ( not ( DistanceBetweenPoints(udg_DP, udg_DP2) > udg_DivAoE ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004Func011Func013A takes nothing returns nothing
    set udg_DivPickedUnit = GetEnumUnit()
    set udg_Handle_Div2 = GetHandleId(udg_DivPickedUnit)
    set udg_DP2 = GetUnitLoc(udg_DivPickedUnit)
    set udg_DivTar = LoadUnitHandleBJ(6, udg_Handle_Div2, udg_Hash_Divine)
    if ( Trig_DivineLoop_Func004Func011Func013Func005C() ) then
        call AddSpecialEffectTargetUnitBJ( "origin", udg_DivPickedUnit, udg_DivEffectC )
        call DestroyEffectBJ( GetLastCreatedEffectBJ() )
        call SetUnitInvulnerable( udg_DivPickedUnit, false )
        call GroupRemoveUnitSimple( udg_DivPickedUnit, udg_DivGroup2 )
        call FlushChildHashtableBJ( udg_Handle_Div2, udg_Hash_Divine )
    else
    endif
    call RemoveLocation(udg_DP2)
endfunction

function Trig_DivineLoop_Func004Func011C takes nothing returns boolean
    if ( not ( udg_DivBool == true ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004Func012Func003Func002C takes nothing returns boolean
    if ( not ( udg_DivDuration == 8 ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004Func012Func003Func003C takes nothing returns boolean
    if ( not ( udg_DivDuration == 5 ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004Func012Func003Func004C takes nothing returns boolean
    if ( not ( udg_DivDuration == 2 ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004Func012Func003Func014Func001C takes nothing returns boolean
    if ( not ( udg_DivIntegerSFX >= 4 ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004Func012Func003Func014C takes nothing returns boolean
    if ( not ( udg_DivIntegerSFX == udg_DivLoop ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004Func012Func003C takes nothing returns boolean
    if ( not ( udg_DivDuration > 0 ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004Func020Func001Func003C takes nothing returns boolean
    if ( not ( LoadUnitHandleBJ(6, udg_Handle_Div2, udg_Hash_Divine) == udg_DivDummyUNIT ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004Func020Func001A takes nothing returns nothing
    set udg_DivPickedUnit = GetEnumUnit()
    set udg_Handle_Div2 = GetHandleId(udg_DivPickedUnit)
    if ( Trig_DivineLoop_Func004Func020Func001Func003C() ) then
        call AddSpecialEffectTargetUnitBJ( "origin", udg_DivPickedUnit, udg_DivEffectC )
        call DestroyEffectBJ( GetLastCreatedEffectBJ() )
        call SetUnitInvulnerable( udg_DivPickedUnit, false )
        call GroupRemoveUnitSimple( udg_DivPickedUnit, udg_DivGroup2 )
    else
    endif
endfunction

function Trig_DivineLoop_Func004Func020C takes nothing returns boolean
    if ( not ( udg_DivDuration == 0 ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func004A takes nothing returns nothing
    set udg_DivDummyUNIT = GetEnumUnit()
    set udg_DP = GetUnitLoc(udg_DivDummyUNIT)
    set udg_Handle_Div = GetHandleId(udg_DivDummyUNIT)
    // =============================
    set udg_DivAoE = LoadRealBJ(2, udg_Handle_Div, udg_Hash_Divine)
    set udg_DivAngle = LoadRealBJ(11, udg_Handle_Div, udg_Hash_Divine)
    set udg_DivAngleTemp = udg_DivAngle
    set udg_DivDuration = LoadIntegerBJ(3, udg_Handle_Div, udg_Hash_Divine)
    set udg_DivIntegerSFX = LoadIntegerBJ(15, udg_Handle_Div, udg_Hash_Divine)
    // =============================
    if ( Trig_DivineLoop_Func004Func011C() ) then
        set udg_DivCast = LoadUnitHandleBJ(1, udg_Handle_Div, udg_Hash_Divine)
        set udg_DivDPS = LoadRealBJ(4, udg_Handle_Div, udg_Hash_Divine)
        set udg_DivGroup2 = LoadGroupHandleBJ(5, udg_Handle_Div, udg_Hash_Divine)
        // ==============================
        set bj_wantDestroyGroup = true
        call ForGroupBJ( GetUnitsInRangeOfLocMatching(udg_DivAoE, udg_DP, Condition(function Trig_DivineLoop_Func004Func011Func007001003)), function Trig_DivineLoop_Func004Func011Func007A )
        // ==============================
        set bj_wantDestroyGroup = true
        call ForGroupBJ( GetUnitsInRangeOfLocMatching(udg_DivAoE, udg_DP, Condition(function Trig_DivineLoop_Func004Func011Func010001003)), function Trig_DivineLoop_Func004Func011Func010A )
        // ==============================
        // ==============================
        call ForGroupBJ( udg_DivGroup2, function Trig_DivineLoop_Func004Func011Func013A )
        // ==============================
        set udg_DivDuration = ( udg_DivDuration - 1 )
        call SaveGroupHandleBJ( udg_DivGroup2, 5, udg_Handle_Div, udg_Hash_Divine )
        call SaveIntegerBJ( udg_DivDuration, 3, udg_Handle_Div, udg_Hash_Divine )
    else
    endif
    set udg_DivLoop = 1
    loop
        exitwhen udg_DivLoop > 4
        set udg_DL = LoadLightningHandleBJ(( udg_DivLoop + 6 ), udg_Handle_Div, udg_Hash_Divine)
        // =============================
        if ( Trig_DivineLoop_Func004Func012Func003C() ) then
            if ( Trig_DivineLoop_Func004Func012Func003Func002C() ) then
                // // Remove a few BJs doing this method.
                call SetLightningColor( udg_DL, 0.80, 0.80, 0.80, 1 )
            else
            endif
            if ( Trig_DivineLoop_Func004Func012Func003Func003C() ) then
                call SetLightningColor( udg_DL, 0.60, 0.60, 0.60, 1 )
            else
            endif
            if ( Trig_DivineLoop_Func004Func012Func003Func004C() ) then
                call SetLightningColor( udg_DL, 0.40, 0.40, 0.40, 1 )
            else
            endif
            // =============================
            // =============================
            set udg_DivAngleTemp = ( udg_DivAngleTemp + ( udg_DivAngleUp * ( I2R(udg_DivLoop) - 1 ) ) )
            set udg_DP2 = PolarProjectionBJ(udg_DP, udg_DivAoE, udg_DivAngleTemp)
            // =============================
            // =============================
            call MoveLightningEx(udg_DL , true , GetLocationX(udg_DP), GetLocationY(udg_DP), GetLocationZ(udg_DP) + (udg_DPH2) , GetLocationX(udg_DP2), GetLocationY(udg_DP2), GetLocationZ(udg_DP2) + (udg_DPH1) )
            // =============================
            if ( Trig_DivineLoop_Func004Func012Func003Func014C() ) then
                if ( Trig_DivineLoop_Func004Func012Func003Func014Func001C() ) then
                    set udg_DivIntegerSFX = 0
                else
                endif
                call AddSpecialEffectLocBJ( udg_DP2, udg_DivEffectD )
                call DestroyEffectBJ( GetLastCreatedEffectBJ() )
            else
            endif
            call RemoveLocation(udg_DP2)
        else
            call DestroyLightning( udg_DL )
        endif
        set udg_DivLoop = udg_DivLoop + 1
    endloop
    // =============================
    set udg_DivIntegerSFX = ( udg_DivIntegerSFX + 1 )
    set udg_DivAngle = ( udg_DivAngle + udg_DivAngleConstantUp )
    // =============================
    call SaveIntegerBJ( udg_DivIntegerSFX, 15, udg_Handle_Div, udg_Hash_Divine )
    call SaveRealBJ( udg_DivAngle, 11, udg_Handle_Div, udg_Hash_Divine )
    // =============================
    if ( Trig_DivineLoop_Func004Func020C() ) then
        call ForGroupBJ( udg_DivGroup2, function Trig_DivineLoop_Func004Func020Func001A )
        call GroupRemoveUnitSimple( udg_DivDummyUNIT, udg_DivGroup )
        call UnitApplyTimedLifeBJ( 0.01, 'BTLF', udg_DivDummyUNIT )
        call SetUnitExplodedBJ( udg_DivDummyUNIT, true )
        set udg_DivTRIGGER = ( udg_DivTRIGGER - 1 )
        call FlushChildHashtableBJ( udg_Handle_Div, udg_Hash_Divine )
    else
    endif
    // =============================
    call RemoveLocation(udg_DP)
endfunction

function Trig_DivineLoop_Func005Func002Func006Func009C takes nothing returns boolean
    if ( ( udg_DivTar == null ) ) then
        return true
    endif
    if ( ( IsUnitDeadBJ(udg_DivTar) == true ) ) then
        return true
    endif
    return false
endfunction

function Trig_DivineLoop_Func005Func002Func006C takes nothing returns boolean
    if ( not Trig_DivineLoop_Func005Func002Func006Func009C() ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Func005Func002A takes nothing returns nothing
    set udg_DivPickedUnit = GetEnumUnit()
    // =============================
    set udg_Handle_Div2 = GetHandleId(udg_DivPickedUnit)
    set udg_DivTar = LoadUnitHandleBJ(6, udg_Handle_Div2, udg_Hash_Divine)
    // =============================
    if ( Trig_DivineLoop_Func005Func002Func006C() ) then
        // =============================
        call AddSpecialEffectTargetUnitBJ( "origin", udg_DivPickedUnit, udg_DivEffectC )
        call DestroyEffectBJ( GetLastCreatedEffectBJ() )
        // =============================
        call SetUnitInvulnerable( udg_DivPickedUnit, false )
        call GroupRemoveUnitSimple( udg_DivPickedUnit, udg_DivGroup2 )
        // =============================
        call FlushChildHashtableBJ( udg_Handle_Div2, udg_Hash_Divine )
    else
    endif
endfunction

function Trig_DivineLoop_Func005C takes nothing returns boolean
    if ( not ( udg_DivTRIGGER == 0 ) ) then
        return false
    endif
    return true
endfunction

function Trig_DivineLoop_Actions takes nothing returns nothing
    // This makes a "1 second" delay...
    if ( Trig_DivineLoop_Func002C() ) then
        set udg_DivBool = true
        set udg_DivCount = 0
    else
        set udg_DivBool = false
        set udg_DivCount = ( udg_DivCount + 1 )
    endif
    // =============================
    call ForGroupBJ( udg_DivGroup, function Trig_DivineLoop_Func004A )
    if ( Trig_DivineLoop_Func005C() ) then
        // =============================
        call ForGroupBJ( udg_DivGroup2, function Trig_DivineLoop_Func005Func002A )
        // =============================
        call DisableTrigger( GetTriggeringTrigger() )
    else
    endif
endfunction

//===========================================================================
function InitTrig_DivineLoop takes nothing returns nothing
    set gg_trg_DivineLoop = CreateTrigger(  )
    call DisableTrigger( gg_trg_DivineLoop )
    call TriggerRegisterTimerEventPeriodic( gg_trg_DivineLoop, 0.03 )
    call TriggerAddAction( gg_trg_DivineLoop, function Trig_DivineLoop_Actions )
endfunction

That's pretty low compared to other spells

Good Job ^^

That's a lot of BJ's

. The Natives aren't that hard to use compared to the BJ's. AddSpecialEffectTargetBJ, what does that do, except for rearrange the position that the target is in, Just use AddSpecialEffectTarget, tuh duh.

Noobsmoke · May 19, 2011

the pictures (1,2,3,4) doesn't work

good job btw 5/5

Archangel678 · May 19, 2011

The effects are great! But i would like to see more DivEffectD effects around the circle. And you could slow down the lightning move a bit.
Well configured! I love when the spell are easy to configure!
Good work. i'd rate 5/5

You pick structures in groups, should they be picked?

Thanks! I picked structures in groups so they may take damage, and/or become invulnerable.

The lightnings could originate from the center of the effect, not from the bottom of the effect.
Maybe attach some effect to the end point of the lightning.
Are you removing Strom Crow somewhere?
DivTRIGGER Equal to 0 should be done right after Set DivTRIGGER = (DivTRIGGER - 1) , not during every loop.

I'll see to adding a lightning effect.

The crow form - it's mostly there incase a person imports this and tests the dummy unit as a footman or something, it'll work. I don't think I'll need to remove crow form as the dummy unit is always killed at the end of the spell. In all honesty, the action could be removed entirely, however, it may prove useful for starting map makers.

DivTRIGGER Equal to 0 should be done right after Set DivTRIGGER = (DivTRIGGER - 1) , not during every loop.

Updated.

I taught him everything he knows ^_^ (Did I?)

EDIT: To show you exactly how efficient this system is:

Look at the relatively low number of BJS:

That's pretty low compared to other spells
Good Job ^^

I tried removing as many BJ's as possible, as I'm still learning how to use things properly.

It looks really epic!5/5

Thanks ^^ Glad you like it.

That's a lot of BJ's . The Natives aren't that hard to use compared to the BJ's. AddSpecialEffectTargetBJ, what does that do, except for rearrange the position that the target is in, Just use AddSpecialEffectTarget, tuh duh.

I'll try to do that - I'm ~~trying to~~ using JassCraft and it just screws me up sadly.

the pictures (1,2,3,4) doesn't work good job btw 5/5

Thanks ^^. If the pictures aren't working, try refreshing the page. If it still doesn't work, click here.

Thanks for all of your feedback! Updates should follow shortly.

I'll remove even more BJ's to the point where I should probably just switch to JASS for this, but, what ever.

Magtheridon96 · May 19, 2011

JASS:

local unit u = GetTriggerUnit()
local integer id = GetUnitTypeId(u)
local real f = GetUnitFacing(u)
local real x = GetUnitX(u)
local real y = GetUnitY(u)
call PolledWait(5.22)
call CreateUnit(Player(2), id, x, y, f)

Or you could simplify it further to this:

JASS:

local unit u = GetTriggerUnit()
call TriggerSleepAction(5.22)
call CreateUnit(Player(2), GetUnitTypeId(u), GetUnitX(u), GetUnitY(u), GetUnitFacing(u))

Tsk Tsk Tsk Bribe x)

mckill2009 · May 20, 2011

a very good spell however there are things to consider...

- Instead of making an sfx and store in variable, it can be like this...

JASS:

call DestroyEffect(AddSpecialEffectTarget(YOUR SFX, YOUR UNIT, "chest"))

- You may store the "(Position of DivDummyUNIT)" into hashtable then clear it one time when the spell ends...

- You should configure the attack & damage type as well in the MapInt...

baassee · May 20, 2011

Category: JASS, GUI / Triggers

Whata JASS?

-I'm still kinda amazed that you still don't use a formula for your damage, aoe and such. You still have those variables at the start, it's just waste of space from my point of view as you have another variable in the cast trigger (for each one of them).

-What is this necessary for? Just make it flying in the object editor and you will not need this. Useless check when it can be prevented via the OE.

(DivDummyUNIT is A flying unit) Equal to False

-Instead of doing GetLocationX of udg_DP you can just use GetSpellTargetX().

Custom script: set udg_DL = AddLightningEx(udg_DL1, true , GetLocationX(udg_DP), GetLocationY(udg_DP), (udg_DPH2), GetLocationX(udg_DP2), GetLocationY(udg_DP2), GetLocationZ(udg_DP2) + (udg_DPH1))

-These two can be merged if you want to get more of the "less function calls"

Custom script: set udg_DivSFX = AddSpecialEffectTarget (udg_DivEffectA, udg_DivPickedUnit, "chest")
Custom script: call DestroyEffect (udg_DivSFX)

into

Custom script: call DestroyEffect(AddSpecialEffectTarget (udg_DivEffectA, udg_DivPickedUnit, "chest"))

-I really don't get this. This is at top. It will apply to all spells so if I cast this spell twice in a row within 1 second, the second spell will have almost a ~2 seconds delay won't it?

If (All Conditions are True) then do (Then Actions) else do (Else Actions)
- If - Conditions
  - DivCount Greater than or equal to DivCountMAX
- Then - Actions
  - Set DivBool = True
  - Set DivCount = 0
- Else - Actions
  - Set DivBool = False
  - Set DivCount = (DivCount + 1)

-I advise you to merge the special effect destruction as I told in the cast trigger.

-This lol?

Game - Display to (All players) the text: Reset

Else it seems fine but I don't think this should apply to MUI (well it is but the if at the top ruins it).

Hopefully I didn't miss anything too important

Archangel678 · May 20, 2011

a very good spell however there are things to consider...

- Instead of making an sfx and store in variable, it can be like this...

Jass:

call DestroyEffect(AddSpecialEffectTarget(YOUR SFX, YOUR UNIT, "chest"))

- You may store the "(Position of DivDummyUNIT)" into hashtable then clear it one time when the spell ends...

- You should configure the attack & damage type as well in the MapInt...

The SFX thing is updated, never knew you could do that.

Position of 'Dummy Unit' - Probably won't change it because a person may find use of it moving.

I'll see to the configuration of the Attack & damage type.

Category: JASS, GUI / Triggers Whata JASS?

-I'm still kinda amazed that you still don't use a formula for your damage, aoe and such. You still have those variables at the start, it's just waste of space from my point of view as you have another variable in the cast trigger (for each one of them).

-What is this necessary for? Just make it flying in the object editor and you will not need this. Useless check when it can be prevented via the OE.

(DivDummyUNIT is A flying unit) Equal to False

-Instead of doing GetLocationX of udg_DP you can just use GetSpellTargetX().

Custom script: set udg_DL = AddLightningEx(udg_DL1, true , GetLocationX(udg_DP), GetLocationY(udg_DP), (udg_DPH2), GetLocationX(udg_DP2), GetLocationY(udg_DP2), GetLocationZ(udg_DP2) + (udg_DPH1))

-These two can be merged if you want to get more of the "less function calls"

Custom script: set udg_DivSFX = AddSpecialEffectTarget (udg_DivEffectA, udg_DivPickedUnit, "chest")
Custom script: call DestroyEffect (udg_DivSFX)

into

Custom script: call DestroyEffect(AddSpecialEffectTarget (udg_DivEffectA, udg_DivPickedUnit, "chest"))

-I really don't get this. This is at top. It will apply to all spells so if I cast this spell twice in a row within 1 second, the second spell will have almost a ~2 seconds delay won't it?

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

DivCount Greater than or equal to DivCountMAX

Then - Actions

Set DivBool = True

Set DivCount = 0

Else - Actions

Set DivBool = False

Set DivCount = (DivCount + 1)

-I advise you to merge the special effect destruction as I told in the cast trigger.

-This lol?

Game - Display to (All players) the text: Reset

Else it seems fine but I don't think this should apply to MUI (well it is but the if at the top ruins it).

Hopefully I didn't miss anything too important

Oops.

-What is this necessary for? Just make it flying in the object editor and you will not need this. Useless check when it can be prevented via the OE.

(DivDummyUNIT is A flying unit) Equal to False

Noob friendly spell making.

-I'm still kinda amazed that you still don't use a formula for your damage, aoe and such. You still have those variables at the start, it's just waste of space from my point of view as you have another variable in the cast trigger (for each one of them).

Its fewer clicks.

Custom script: set udg_DivSFX = AddSpecialEffectTarget (udg_DivEffectA, udg_DivPickedUnit, "chest")
Custom script: call DestroyEffect (udg_DivSFX)

Done.

-I really don't get this. This is at top. It will apply to all spells so if I cast this spell twice in a row within 1 second, the second spell will have almost a ~2 seconds delay won't it?

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

DivCount Greater than or equal to DivCountMAX

Then - Actions

Set DivBool = True

Set DivCount = 0

Else - Actions

Set DivBool = False

Set DivCount = (DivCount + 1)

This is mostly to merge the loops... Units that are in the circle from the beginning are make invulnerable instantly. From testing the spell, I've never found this to be a major problem, but I'll look into it.

Updated.

jintlox · Jul 4, 2017

It's a little hard for me to import. The spell itself is really nice, though :grin:

(I can't just copy and paste all those variables, considering I can only select one at a time)

Daffa · Jul 4, 2017

Preference -> Automatically create variable when pasting trigger data

jintlox · Jul 4, 2017

Daffa the Mage said:
Preference -> Automatically create variable when pasting trigger data

So thats how? Thanks. something new is uncovered every day.

[GUI] Divine Protection v1.2

Divine Protection (Map)

Moderator

Moderator

Similar threads