[GUI]Destroy trees system v1.2

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

July 21st 2012
Magtheridon96:

Well, now you're using a much better algorithm, so this might actually be useful.

One problem though, you have an extra line in there:
Custom script: call IssuePointOrderLoc(udg_TempUnit, udg_DTS_String_Order, udg_DTS_Point_TargetPoint)

This shouldn't be in there because TempUnit is specific to the testmap.

edit
maddeem suggested a much better algorithm.
Using it would get the rating up to "Useful" since no other "Tree Destroying" systems use an algorithm as efficient as this.

Old Review

Moderator: Pharaoh_ Date: 11:30, 18th May 2012 I am afraid there is a much more efficient solution to destroying trees. You don't need 100 levels for an ability, you can loop through AoE/128 (this is the pathing of a common tree) and order the dummy to cast it x Loop times. Nice presentation by the way (next time, consider posting the triggers as well). Lacking

 

[Tank-Commander]

Triggers

• Destroy Trees System
  • Events
    • Map initialization
  • Conditions
  • Actions
    • -------- |||||||||||||||||||||||||||||||||||||||||||||||||||||||XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX||||||||||||||||||||||||||||||||||||||||||||||||||||||| --------
    • -------- CONFIGURE THE SPELL --------
    • -------- |||||||||||||||||||||||||||||||||||||||||||||||||||||||XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX||||||||||||||||||||||||||||||||||||||||||||||||||||||| --------
    • -------- THE UNIT-TYPE OF THE DUMMY --------
    • Set DTS_UnitType_Dummy = Dummy
    • -------- THE ABILITY THAT DESTROY THE TREES --------
    • Set DTS_Ability_DestroyTrees = Destroy trees
    • -------- THE STRING ORDER OF THE ABILITY --------
    • Set DTS_String_Order = forceofnature
    • -------- |||||||||||||||||||||||||||||||||||||||||||||||||||||||XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX||||||||||||||||||||||||||||||||||||||||||||||||||||||| --------
    • -------- CONFIGURE THE SPELL --------
    • -------- |||||||||||||||||||||||||||||||||||||||||||||||||||||||XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX||||||||||||||||||||||||||||||||||||||||||||||||||||||| --------
    • Set DTS_Point_TargetPoint = (Center of (Playable map area))
    • Unit - Create 1 DTS_UnitType_Dummy for Player 1 (Red) at DTS_Point_TargetPoint facing 0.00 degrees
    • Set TempUnit = (Last created unit)
    • Unit - Add DTS_Ability_DestroyTrees to TempUnit
    • Unit - Remove TempUnit from the game
    • Custom script: call RemoveLocation(udg_DTS_Point_TargetPoint)
    • Custom script: endfunction
    • Custom script: function DTS_Run takes nothing returns nothing
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • DTS_Real_AreaOfEffect Greater than 2000.00
      • Then - Actions
        • Game - Display to (All players) the text: The maximum radius ...
        • Set TempInteger = 2000
      • Else - Actions
    • Set TempInteger = (Integer((DTS_Real_AreaOfEffect / 20.00)))
    • Unit - Create 1 DTS_UnitType_Dummy for Neutral Hostile at DTS_Point_TargetPoint facing 0.00 degrees
    • Set TempUnit = (Last created unit)
    • Unit - Add DTS_Ability_DestroyTrees to TempUnit
    • Unit - Set level of DTS_Ability_DestroyTrees for TempUnit to TempInteger
    • Custom script: call IssuePointOrderLoc(udg_TempUnit, udg_DTS_String_Order, udg_DTS_Point_TargetPoint)
    • Unit - Add a 0.50 second Generic expiration timer to TempUnit
    • Custom script: call RemoveLocation(udg_DTS_Point_TargetPoint)

Example

• Example
  • Events
    • Player - Player 1 (Red) skips a cinematic sequence
  • Conditions
  • Actions
    • Set TempUnit = Paladin 0001 <gen>
    • Set DTS_Real_AreaOfEffect = ActualRadius
    • Set DTS_Point_TargetPoint = (Position of TempUnit)
    • Custom script: call ExecuteFunc("DTS_Run")

Comments:

Well, what I first noticed was that you're controlling it using force of nature, which does work I suppose, but isn't the traditional method for destroying trees, because it doesn't actually detect that a tree is there, just gets rid of it if there is. Also this setup isn't the most useful (even if it is 4 functions to control it) Becuase your radius of the actual ability, is determined by object data levels for such an ability.

The traditional method:

Using a peasant to detect trees by matching commands and then doing as you want with the tree you've found Is mroe useful generally speaking, and already exists in the help sections when people don't know how to do it, and requires even less triggering than this does. For example:

Say you have a spell which needs to destroy trees in a given area:

You pick all the destructibles within (radius) of (Point)
- Set TempDestuct = (Picked destructible)
- Run (Trigger)

Other Trigger:

Order (Tree Checker) to (right click) (TempDestuct)
If then else
- Conditions
- - Current order of (Tree Checker) = "harvest"
- Actions
- - Kill (TempDestruct)

That should give you the basic gist of what I mean, in eithercase, it's longer than it needs to be, since all you actually need is to use this traditional order detection to do it. However setting the system to this would cause it to become too simple. Obviously (Tree Checker) has been created in another trigger which runs at map init, and is a peasant. (Which is invulnerable, hidden, etc.)

Edit: For the record, it could also be a function which is called, and have the peasant creation/setup in the same trigger as where the function is.

 

[eubz]

Hey,I have found a good example of destroy only trees. http://www.hiveworkshop.com/forums/1910913-post4.html

 

[Adiktuz]

the GUI trigger on eubz's link pawns this one in an epic way...

 

[Tank-Commander]

Yeah that's exactly what I was describing XD

 

[maddeem]

How is this even a system? This is like making a destroy unit system..
The best way to go about a system like this is to save the integer ID of all trees, then load it of destructables you want to check.
It takes more work to initialize but in the end it beats all other methods in efficiency.

 

[Magtheridon96]

That's actually a nice method, and I would totally use it for my maps, but it would require the user to re-register destructables he creates during the game (you know, trees respawning for example )

 

[maddeem]

That's actually a nice method, and I would totally use it for my maps, but it would require the user to re-register destructables he creates during the game (you know, trees respawning for example )

Actually if you were referring to my post I meant the coder would do save all tree types into a hashtable like this:

call SaveInteger(hashtable,'tree',0,1)

Then you load based off the destructible ID to check whether its a tree or not

if LoadInteger(hashtable,ID,0)=1 then

 

[Magtheridon96]

Oh, types, yeah, that sounds much better.
Brilliant, really.

Though currently, this algorithm is acceptable for the Spells section because we /can/ accept the second-best.

I would still recommend using it.

@KhaosMachine: Take notes ;D