[GUI] Custom Bunker System 0.08

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

00:45, 24th November 2012
Magtheridon96:

- Instead of expecting users to fill out arrays of data, you can encapsulate the whole process of 'adding' a unit by expecting users to set some temporary system variables to whatever values they want and running a trigger called "Register Bunker Type" or something
- You could store (Triggering unit) into a variable so you don't have to repeat it multiple times in a loop. (You can apply this to most things that are inside parentheses)
-

Code

• Custom script: set bj_wantDestroyGroup = true
• Unit Group - Pick every unit in (Units within cbsVAR_BunkerRadius[tempId] of tempLoc matching ((Matching unit) Equal to cbs_BunkerUnit[tempId])) and do (Actions)
  • Loop - Actions
    • Set tempBool = True

This method is pretty slow. Instead of picking all the units in the group, you can store the group as a variable, and do this:
set udg_tempBool = (FirstOfGroup(udg_groupVariable) != null)

 

[Tank-Commander]

Well it's nice I guess, though seems a little redundant, since we can just create bunker abilities to units which is actually quite a lot less hassle. Eitherway: Don't use IntegerA use your own, it's good practice and there are some issues with integerA though I don't think any of them apply here, and if you use them all, don't call them IntegerA to avoid confusion. Can't see any immediate problems, though my code-reading isn't that good this time of night

Other than that, seems pretty unique, if a bit bulky for one system, but yeah quite fond of it.

 

[rulerofiron99]

Thanks! A light search made me none the wiser as to the problems with Integer A, any chance you could link me to some reading material?

 

[baassee]

Integer A fucks up loops if there is example a wait in the loop. Yet even without waits this issue has happened.

 

[defskull]

Thanks! A light search made me none the wiser as to the problems with Integer A, any chance you could link me to some reading material?

Replace the function with using Variable Integer instead;

• For each (Integer YourIntegerVariable) from 1 to cbs_BunkerId, do (Actions)
  • Loop - Actions

The YourIntegerVariable does not need to be set its value, it's just for the looping action.

 

[maddeem]

integer a problems are a myth, any variable will fuck up with waits.

 

[CoLd Bon3]

The system is reeeealy nice. I like how the units inside attack with their own attack type. However, i have some suggestions. What happens when a melee units enters the bunker - nothing. You should make it like the old bunkers, make 'em shoot arrows when melee units are inside. It would also be good if you somehow display how much units in the bunker are there, or at least their unit-type (this can be done really easily with a floating text). It might be confusing in a map if the user has 15 bunkers with different unit-types in them.

Otherwise, it's REEEALY nice! I like it very much!

 

[rulerofiron99]

I'll add the option for a special attack type, and a floating text indicator. (a "progress bar" showing capacity while unselected, an a list of all units when selected)

I suppose I should also add the LoadUnload sound.

 

[CoLd Bon3]

I'll add the option for a special attack type, and a floating text indicator. (a "progress bar" showing capacity while unselected, an a list of all units when selected)

After you do this, your system will be bangarang!

 

[defskull]

integer a problems are a myth, any variable will fuck up with waits.

Tell this to Magtheridon, and you'll be lectured by him for 3 hours straight saying Integer A/B bugs when used globally simultaneously by more than 1 trigger at a time.

 

[CoLd Bon3]

Tell this to Magtheridon, and you'll be lectured by him for 3 hours straight saying Integer A/B bugs when used globally simultaneously by more than 1 trigger at a time.

Um, in my map, i have at least 6 triggers using Integer A. Can you tell me what is the problem (desync, leak, etc.)? I am worried.

However, i haven't seen problems so far... but all the triggers don't run at once. I mean, first goes one of the triggers, then another, then another...

 

[rulerofiron99]

Um, in my map, i have at least 6 triggers using Integer A. Can you tell me what is the problem (desync, leak, etc.)? I am worried.

However, i haven't seen problems so far...

If, for example, you have a trigger that does an Int A for loop, and runs another trigger that also does an Int A for loop.

... isn't there like a way to force integer A into a local variable?
e.g.

• Custom script: local integer ForLoopIndexA

 

[CoLd Bon3]

If, for example, you have a trigger that does an Int A for loop, and runs another trigger that also does an Int A for loop.

So... what? Arn't those integers get replaced with no problem?

 

[rulerofiron99]

If a trigger is run by another trigger, you can think of it as being "in" the other trigger.

So the parent trigger will increment
inta = 1
inta = 2
inta = 3
run other trigger
... which will the star inta at 1 or whatever you set
so now the main loop will continue with inta = the last value set by the child trigger, and miss a whole bunch of actions, potentially.

EDIT: New version up. Oh dear, what a lot of triggers :S (it isn't bloat, I promise!)

 

[CoLd Bon3]

No, no, i didn't want to say that they are a chain of triggers. They are simply no goin' together. Well, there are some cases where there are two chained triggers, both with integer a, but i have seen no problems so far. Everything is executed perfectly.

 

[defskull]

Well if you have the chance to use a better method, why evade ?
You're just gonna need it one variable that can be used by all triggers.

 

[CoLd Bon3]

So i need a different variable for each time i have to loop, or one variable for everything, or one variable with different array for each usage?

 

[defskull]

One variable for all triggers.
I just name my looping integer variable LoopingInteger, I used it in all my triggers and it works fine.

 

[rulerofiron99]

One variable for all triggers.
I just name my looping integer variable LoopingInteger, I used it in all my triggers and it works fine.

Until you use nested loops ;p

 

[defskull]

I never mentioned about nested loops - I think if you create a nested loop(s), that is your problem to solve it.

This would be for single loop only.

 

[CoLd Bon3]

I never mentioned about nested loops - I think if you create a nested loop(s), that is your problem to solve it.

This would be for single loop only.

The the hell is a nested loop?

 

[rulerofiron99]

The the hell is a nested loop?

If you have a for loop inside another for loop.

For example if you want to fill a region with units in a square/grid formation, you'd use a for loop to get the x value, and a for loop inside there to get the y value.

 

[ndh]

I love the new changes : )

 

[defskull]

Suggestions:
- You did not clean the Floating Text when you select the Bunker (if you spam click on the Bunker filled with units, you will notice that the Floating Text font grows "thicker", right ? This is because you did not clean the last Floating Text and create a new one, fix this, you can make it stay there forever - in other words, it leaks)
- When we click on the bunker (somehow the bunker must have an attack order, why ?) Because, if I want to focus all my units to attack specific individual unit, I would just click on the Bunker and order attack to that unit, all units in that Bunker will be forced to change its attack target.
- When Bunker dies, you should remove all data attached to it (Floating Text, mostly). Currently, when Bunker dies, Floating Text remains there

 

[SonicFlare101]

hey thanx for completing my request.
its really good. 5/5

 

[rulerofiron99]

Fixes coming soon.

Also, it looks like my system is still relevant - I didn't realise that cargo hold was hardcoded to maximum 10 units!

I'll be changing this system to more generally be a Cargo Hold Extension system, along with multiple options.

 

[FRENGERS]

Woow nice idea and also cool!! @.@ Like this!! 5/5 Always!!
Can this do on unit?? ( E.g.: On Bus )

 

[rulerofiron99]

Not just yet; I'll upload a version that allows that soon.

 

[Wrda]

So... what? Arn't those integers get replaced with no problem?

Integers A or B won't get replaced, because they run instantly, this means that they will increment instantly, no problem with that, it only screws up if you are using a wait action inside the loop.

 

[Jimbo123]

Not sure if this is necro post territory; I noticed in your map that units stop attacking from the bunker after three attacks.