[GUI] Boulder Smash Remake - "Billiards"

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

16:10, 2nd Jan 2015
Maker: Check the replies in this thread.

 

[Bannar]

I could not see any major flaws, or meaby I'm just too tired after football match
Anyway, some portions could be simplified - or meaby not, since this is GUI. I'm talking about deallocation part.

In BS Cast trigger:

• Actions
  • Set TempLoc00 = (Position of (Triggering unit))
  • Set TempLoc01 = (Position of (Target unit of ability being cast))
  • Set BS_MUI_Index = (BS_MUI_Index + 1)
  • Set BS_Caster[BS_MUI_Index] = (Triggering unit)
  • Set BS_Level[BS_MUI_Index] = (Level of C_BS_Boulder_Smash_Ability for BS_Caster[BS_MUI_Index])
  • Set BS_Remnant[BS_MUI_Index] = (Target unit of ability being cast)

should be:

• Actions
  • Set BS_MUI_Index = (BS_MUI_Index + 1)
  • Set BS_Caster[BS_MUI_Index] = (Triggering unit)
  • Set BS_Level[BS_MUI_Index] = (Level of C_BS_Boulder_Smash_Ability for BS_Caster[BS_MUI_Index])
  • Set BS_Remnant[BS_MUI_Index] = (Target unit of ability being cast)
  • Set TempLoc00 = (Position of BS_Caster[BS_MUI_Index])
  • Set TempLoc01 = (Position of BS_Remnant[BS_MUI_Index])

Just check the triggers for things similar to this case. Good job anyway.

 

[Tal'Rarity]

Pretty cool spell, 4/5 for the idea itself and nicely done.

Only thing I saw when I looked over the triggers was what Bannar said.

However since you already add the timer to the trigger as the event you may as well switch to 0.31250000 or what you already said you dislike, it allows for one more frame or two which is more accurate and smoother. Since it is a periodic event maybe you should switch it to a timer because periodic events continually run even after the trigger is off, I found out when like 3 people told me. Though it is a GUI spell so it doesn't matter as much, only matters if you want it to be a top spell with best possible efficiency.

 

[Wrda]

• Cast Cancel
• Events
• Unit - A unit Begins casting an ability
• Conditions
• And - All (Conditions) are true
• Conditions
• (Ability being cast) Equal to C_BS_Boulder_Smash_Ability
• ((Target unit of ability being cast) is in BS_In_Effect) Equal to True
• Actions
• Unit - Order (Triggering unit) to Stop

You should NEVER EVER use "a unit begins casting"... Because it can bug, just use "a unit starts an effect..."
On BS loop the special effects should be configurable.
Looks like a nice spell. 4/5

 

[The6thMessenger]

• Cast Cancel
• Events
• Unit - A unit Begins casting an ability
• Conditions
• And - All (Conditions) are true
• Conditions
• (Ability being cast) Equal to C_BS_Boulder_Smash_Ability
• ((Target unit of ability being cast) is in BS_In_Effect) Equal to True
• Actions
• Unit - Order (Triggering unit) to Stop

You should NEVER EVER use "a unit begins casting"... Because it can bug, just use "a unit starts an effect..."
On BS loop the special effects should be configurable.
Looks like a nice spell. 4/5

Because, you weren't supposed to cast the ability on a moving target. This cancels the spell immediately.

 

[Tal'Rarity]

There is one thing you did do wrong actually, just take the and - all out. It already counts that without the and - all.

 

[GywGod133]

Trigger - Turn on BS Loop <gen>

you must put it in ITE

if
BS_MUI_Index = 0
then
Trigger - Turn on BS Loop <gen>
else

 

[The6thMessenger]

Trigger - Turn on BS Loop <gen>

you must put it in ITE

if
BS_MUI_Index = 0
then
Trigger - Turn on BS Loop <gen>
else

Oh... you... again...

 

[Deadly Nightshade]

Looks cute. Can I use this for a golem skill?

 

[IcemanBo]

Really no need to ask if you may use uploaded resources.

 

[Deadly Nightshade]

haha okay ^_^

 

[The6thMessenger]

Yes and no.

This is technically a Dota Skill... so it's not up to me. But then again yes because it's not yet implemented.

 

[GywGod133]

in constant trigger

remove it
Trigger - Turn off (This trigger) this is useless

or change it into this
call DestroyTrigger( GetTriggeringTrigger())

 

[Vinz]

Oh... you... again...

It is bad practice to turn on loop triggers already running.

 

[The6thMessenger]

in constant trigger

remove it
Trigger - Turn off (This trigger) this is useless

or change it into this
call DestroyTrigger( GetTriggeringTrigger())

So far, it works and it's fine.

 

[Vinz]

He didn't say it would't work, so I think he is talking about code optimization.
Also, the loop trigger's index should be a temp var, not a prefixed one.

 

[GywGod133]

In your Trigger Loop

You forgot this
Unit Group - Add (Picked unit) to BS_Already_Hit[BS_Integer_A]

The Red Part, change it into Temp_Unit

 

[IcemanBo]

• In many cases you should store "Last created unit" into a TmpVariable to avoid multiple calls of same function and to gain performance.
• I don't think pausing the dummy is really needed. Avoid it if possible, probably just adding locust to the unit in object editor is enough?
• As Dat-C3 has mentioned "And - All (Conditions) are true" is not needed in your Cast Cancel trigger.
  I also see this in loop trigger of yours. If you just add condtions they are automatically linked with "and" in between... so all must be true.
  The only case you might need it is if you work with "Or - Condtions" block.
• In BS Cast trigger:
  

  (Unit-type of BS_Remnant[BS_MUI_Index]) Equal to Stone Remnant

  -->
  

  (Unit-type of BS_Remnant[BS_MUI_Index]) Equal to C_BS_Remnant_Type

  Also as mentioned by Mythic, only make following action if index equals 1:
  

  Trigger - Turn on BS Loop <gen>

• In loop:
  

  If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions BS_MUI_Index Less than or equal to 0 Then - Actions Trigger - Turn off (This trigger) Else - Actions

  ^This should be moved into deindex part. (And could be changed just to Equals 0, but that doesn't really matter.)
  In your Unit Group enumeration you still use "Picked Unit". Use your variable Temp_Unit instead.
• You can deindex if "BS_Count[BS_Integer_A] Less than or equal to 1" instead of when it gets 0. Then you might move following operation into Ellse - Actions, where you decrement the counter:
  

  Set BS_Count[BS_Integer_A] = (BS_Count[BS_Integer_A] - 1)

• DamageType and AttackType should be configurable.
• Hidden

  • Set TempGroup = (Units within C_BS_Search_AOE of TempLoc00 matching (((Unit-type of (Matching unit)) Equal to C_BS_Remnant_Type) and (((((Matching unit) is alive) Equal to True) and (((Matching unit) is in BS_In_Effect) Equal to False)) and ((((Matching unit) is in BS_Last_M
  • Set Temp_Unit = No unit
  • Unit Group - Pick every unit in TempGroup and do (Actions)
  ^In this unit group enumeration you can directly destroy the group after you found a matching unit with:
  

  Custom script: call DestroyGroup (udg_TempGroup)

• Special effects should be configurable.
• You might consider of making it useable with multiple levels, not only one.
• Names of variables are too long and unreadable in some cases, i.e:
  - You don't need the word "MUI" in any variable name. (even if your spell is MUI)
  - "Integer_A". You create custom integers, so no need to tend to given default loop integer names of the GUI. Something like "Int" would suffice.
• Useful comments for configuration and a guide through your system code would be helpful.
  
  That's it for now. The idea is cool I think. From the video I saw that the unit was moved out of map border. You might want to change this.
  If you make the changes I might find some new points to mention, have a nice day!

 

[Maker]

You pause the unit but try to use expiration timer. The expiration timer will not start. You need to fix that.

Try to use only one dummy to damage stun every unit. Setting movement speed, cast bacswing and cast point to 0 will help there.

 

[The6thMessenger]

You pause the unit but try to use expiration timer. The expiration timer will not start. You need to fix that.

Try to use only one dummy to damage every unit. Setting movement speed, cast backswing and cast point to 0 will help there.

Right... um yeah, so i have to make a dummy unit every time i were supposed to damage a unit? Why?

 

[Maker]

Right... um yeah, so i have to make a dummy unit every time i were supposed to damage a unit? Why?

I meant stun