[GUI] BloodSoul's Spells - 0.3

[Moderator]

14:56, 30rd Sep 2009
The_Reborn_Devil:

The issues are fixed now and I couldn't find any other problems.
Coding looks good too.
Approved.
I give these spells the rating Useful.

 

[Septimus]

This is my first time uploading a spell here.

lies...

http://www.hiveworkshop.com/forums/spells-569/guided-arrow-spell-127392/

 

[BloodSoul]

I deleted that spell.

 

[Dark_Dragon]

hmm first spell... i dont know and i dont care. well spell seems to be fine, for some reason i like it and found it quite usefull even if its basic but its quite good. bad things are that indexing system needs to be better, like paladons system. however 1.24 was released so plz use hashtables... with hashtables u need only one global non-array variable of type hashtable. it will make it more readable and easy to install... as well that missile does not change height when i cast it on air unit. i think u should fix that.

seems to me that u are beginner and i can see ur quite good for beginner so keep it up. 3/5 for now. u need to fix this by using hashtables and then index system can be simple as well.

ohh btw u dont need to store group in variable when using bj_wantDestroyGroup! if u use variable it will just leak group's at map startup since its an array it will as well slow map startup.

Greets!
~Dark Dragon

 

[BloodSoul]

hmm first spell... i dont know and i dont care. well spell seems to be fine, for some reason i like it and found it quite usefull even if its basic but its quite good. bad things are that indexing system needs to be better, like paladons system. however 1.24 was released so plz use hashtables... with hashtables u need only one global non-array variable of type hashtable. it will make it more readable and easy to install... as well that missile does not change height when i cast it on air unit. i think u should fix that.

seems to me that u are beginner and i can see ur quite good for beginner so keep it up. 3/5 for now. u need to fix this by using hashtables and then index system can be simple as well.

ohh btw u dont need to store group in variable when using bj_wantDestroyGroup! if u use variable it will just leak group's at map startup since its an array it will as well slow map startup.

Greets!
~Dark Dragon

Thanks Dark Dragon.
I will change to Hashtables and fix the bug about missile. +rep. xD
--
Edit:
I don't change the Index System to hashtables, yet...
I change the old Index System to Paladon's Index System.

 

[Deuterium]

Deuterium's Brief Review:

[GUI] BloodSoul's Spells - 0.2

1. Destroy the B_Damaged group, because since it's indexed it doesn't get fully recycled:

• Unit Group - Remove all units from B_Damaged[Index[3]]

2. Why create floating text over at a point instead of creating it over the unit directly?

• Floating Text - Create floating text that reads (String((Integer(B_MaxDamage[Index[3]])))) at B_Point with Z offset 0.00, using font size 9.75, color (33.00%, 33.00%, 99.00%), and 0.00% transparency

Also add a user adjustable global which allows the unit to pick if he wants the floating text or not.



Actually impressive and clean GUI coding there. However, I don't find anything original in the spells, but it could be useful for those searching for such spells. Just make sure to fix the first problem, and you're good to go! The second point is just a minor issue. 3/5

 

[Dark_Dragon]

i changed rating to 4/5 only because its your first spell and you did your best to fix all what u could. as well you could fix this things Deuterium mentioned...

Greets!
~DD

 

[BloodSoul]

i changed rating to 4/5 only because its your first spell and you did your best to fix all what u could. as well you could fix this things Deuterium mentioned...

Greets!
~DD

Thanks, DD!

 

[Deuterium]

Glad to know you worked on fixing those

 

[BloodSoul]

Thanks to all those who helped me!

 

[ToPsYoNe]

Nice spells ^^ +rep