Moderator
M
Moderator
19:01, 20th Sep 2009
Deuterium:
1. No "Learn Tooltip" and badly writting Normal Tooltip.
2. A point-targetable ability doesn't fit this spell; either make it Target Type: Instant (No Target), which I actually prefer, or check the option Targeting Image.
3. Don't use Casting unit, use Triggering unit instead:
4. You leak a point by setting it twice:
5. In my opinion, you should use some reviving dummy ability to "actually" revive the unit, rather then replacing the unit.
6. Instead of the current debugging message function, use SimError by Vexorian since it perfectly imitates Warcraft's debug message. Otherwise, you must include the present function in a separate trigger and adjust the color of the message.
7. Some trigger comments would be nice. Specially in order to define where the adjustable globals are and what each does.
8. Also, make the trigger more adjustable. Make the radius for picking and damaging modifiable for instance.
9. You've got tons of English-related mistakes here and there. Fix them up.
10. And the most important point: I see no documentation on how to import!
The idea is definetly nice and original. However, although coding is decent for a GUI spell, it could be improved. And most importantly, you need to include documentation on how to import. Work on the just mentioned issues, and you're good to go.
Hanky:
Fix the points Deuterium said and improve the indexing of your spell.
Deuterium:
1. No "Learn Tooltip" and badly writting Normal Tooltip.
2. A point-targetable ability doesn't fit this spell; either make it Target Type: Instant (No Target), which I actually prefer, or check the option Targeting Image.
3. Don't use Casting unit, use Triggering unit instead:
-
Set GR_Speed[GR_LoopIndex[2]] = (2.00 x (Real((Level of (Ability being cast) for (Casting unit)))))
4. You leak a point by setting it twice:
-
Set GR_LeakPoint[1] = (Target point of ability being cast)
5. In my opinion, you should use some reviving dummy ability to "actually" revive the unit, rather then replacing the unit.
6. Instead of the current debugging message function, use SimError by Vexorian since it perfectly imitates Warcraft's debug message. Otherwise, you must include the present function in a separate trigger and adjust the color of the message.
7. Some trigger comments would be nice. Specially in order to define where the adjustable globals are and what each does.
8. Also, make the trigger more adjustable. Make the radius for picking and damaging modifiable for instance.
9. You've got tons of English-related mistakes here and there. Fix them up.
10. And the most important point: I see no documentation on how to import!
The idea is definetly nice and original. However, although coding is decent for a GUI spell, it could be improved. And most importantly, you need to include documentation on how to import. Work on the just mentioned issues, and you're good to go.
Hanky:
Fix the points Deuterium said and improve the indexing of your spell.