Frozen Orb v2.1

[Moderator]

Frozen Orb v1.0.3 | Reviewed by Maker | 5th November 2013 [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" Concept[/COLOR]] The core of the spell is a forward moving projectile which is not that special by itself. The smalled projectiles that spawn and scatter around really make it more impressive, and making the spell have a chance to not leave corpses is a nice touch Triggers[/COLOR]] Good importing instructions The spell performs well and causes no FPS drop even with multiple simultaneous casts You can declare locals inside a static if Use TriggerRegisterAnyUnitEventBJ instead of writing it yourself Null the destroyed current.model immediately. The destroy method could check if the effect is not null and then destroy and null it Objects[/COLOR]] Good tooltip Overall well done configuration Effects[/COLOR]] The visual effects fit the theme And so do the sounds Rating[/COLOR]] CONCEPT TRIGGERS OBJECTS EFFECTS RATING STATUS APPROVED

 

[FUJI]

Reviewing..

EDIT: Review

Frozen Orb v1.0.0
This spell had been reviewed by jakeZinc.

The triggering looks good, neat and clean. I don't find some wrong or harm code nor leaks in the code and I understand it correctly in the help of documenting the codes.

The documentation is well fine and it gives directly to the point but the configuration is lacking in documentation .

The configuration is well good but you can try to add constant configuration in the global blocks than enumerating the currently value in the function

It is nice spell that it really fits the lich's spell. I don't notice anything lags and it is MUI Spell.

None.

The importing instruction is a bit simple maybe adding more documentation to it.

The special effects is good and it really fits the concept of the spell.

Useful in the damage line and clusters of the units in the line.

Adding a special effect or a blast effect to the mini shard of frost when exploding will really gonna be nice that removing like seems nothing or boring. You can set the movement type of the dummy to fly than hover. You don't need invulnerable ability to the dummy because Locust ability already does it. The test unit is too bit frustating because it is already reviving the footman units in 0.00 seconds that looks like odd xD but anyway there's no problem with that."Abilities\\Spells\\Undead\\FrostNova\\FrostNovaTarget.mdl"//Displayed of the target explodes maybe try it to explain why it does need a aposthropy and double slash because some users don't know about that. It is really good spell there's nothing to say.

The tooltip description supports the level of the spell but a little bit too unexplain.

Rejected: 1-10
Unacceptable : 11-30
Lacking : 31-49
Useful : 50-69
Recommended : 70-90
Highly Recommended : 91-100
Director Cut : 101-105

1) Triggering - 18/20
2) Documentation - 9/10
3) Importing Instruction - 6/10
4) Special Effects - 10/15
5) Usefulness - 17/20
6) Tooltip - 7/10
7) Configuration - 7/10

Total Score - 74/105
jakeZinc Rating - 4/5
Status - Recommended and Expected vote for Approval
Award - +Rep

 

[BPower]

Adding a special effect or a blast effect to the mini shard of frost when exploding will really gonna be nice that removing like seems nothing or boring.

Actually the Lich missile has an explosion effect. The problem you mentioned is connected to the way Dummy works. I already have two solutions in mind .

EDIT: Added an explosion effect, by creating an extra effect. It's a dirty way and better solutions are very welcome.
EDIT: Found a better solution

You can set the movement type of the dummy to fly than hover. You don't need invulnerable ability to the dummy because Locust ability already does it.

It's the default setting of Particle provided by the Dummy testmap. I'm not changing it.

The test unit is too bit frustating ...

Its a demo map not a game itself and therefore totally fine .

Thank you for the extensive review.

 

[FUJI]

"It's the default setting of Particle provided by the Dummy testmap. I'm not changing it. "
It is from the ORB Dummy .

 

[BPower]

Updated: Changed the code based on the Maker's suggestions, since they make sense.

Changes

• You can declare locals inside a static if
• Use TriggerRegisterAnyUnitEventBJ instead of writing it yourself
• Null the destroyed current.model immediately. The destroy method could check if the effect is not null and then destroy and null it

 

[BPower]

Update: Minor changes made. I didn't intend to bump this resource.

Changes:

• Now slighly faster than before
• Alloc is now optional
• functions are now constant functions
• Moved none configurable constant variables into the struct
• Improved the code
• Updated the documentation to my standart format

 

[BPower]

Updated to v1.0.5, if you are using v1.0.4 you don't have to update it in your map.

DummyCaster is no longer required, but optional.
Fixed a very minor issue, as the spell was using bj_lastCreatedGroup for the group enumeration.
Also updated the links posted in the spell description.

 

[Vinz]

Omg dat Bpower. Epic spell! <3

 

[BPower]

Update:

The spell is now based on my Missile library. The code of the previous version can still be found in the demo map and in the thread description.

If you compare the previous and new version, you will see that the amount of code has shrunk, as
projectile movement and collision checks are now takes over by Missile.

For very little overhead Missile provides you incredible useful projectile features. Check out the full API in the link I posted or
read Missile's API in the library, which is included in the demo map
Also UnitIndexer and requirements are no longer part of Frozen Orb.
DummyCaster has been removed, if you use a dummy spell casting system feel free to integrate it to Frozen Orb.

I highly recommend to import some of Missiles optional requirements ( MissileRecycler, WorldBounds, GroupUtils, ... )

 

[Kazeon]

Meet your brother

 

[BPower]

I'm aware of Echo's Frozen Orb, I was also when I wrote my version.
However this version is cleaner and performs better.

Now with the Missile implementation the projectile behaviour is on a whole new level.

 

[BPower]

Changelog:

- Re-structured the code. Ice bolts and the main orb are now seperated into two structs.
- Improved customization options.
- Outsourced the frostnova buff into na extra struct.