[General] Fixing the leaks in my Map

[Mgeterno11]

When I play my map it starts lagging after a few minutes later. I do not know why. Maybe because of the doodads or the imported models, or the spells are maybe leaky. Unfortunately, I do not know how to fix it.
I attach my map below. I would be grateful if you could help me how to fix leaks with triggers. If you want, you can do it in my map then send it to me when it is fixed. Thanks.

 

[Chaosy]

I know that people dont like downloading maps to check for stuff. I would suggest debugging and showing suspicious triggers.

I suggest disabling loop triggers and see if it still starts too lag. Loop triggers seems to be the problem since the map lags after a while.

 

[IcemanBo]

hey Mgeterno11, there is a cool tutorial here, I'm sure it might help you to fix memory leaks - http://www.hiveworkshop.com/forums/triggers-scripts-269/things-leak-35124/

 

[Mgeterno11]

Thanks but I do not know how to do it. I don't know how to do the tutorial either. And the problem is that currently I am a bit busy to make that. I just want you to look at my map and look for problematic triggers.

 

[IcemanBo]

Ok, you can ask like this of course.. but next time it might be better you post in Request section.

 

[Chaosy]

the tri arrow trigger leaks. Other than that I found no big flaw. I only made a fast check tho

 

[pOke]

Too many Unit groups

• Mighty Hammer casting
  • Events
    • Time - Every 0.01 seconds of game time
  • Conditions
  • Actions
    • Set MightyHammer_Countdown = (MightyHammer_Countdown - 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • MightyHammer_Countdown Less than or equal to 0
      • Then - Actions
        • Trigger - Turn off (This trigger)
        • Unit Group - Remove all units from MightyHammer_DamageGroup
        • Unit - Kill MightyHammer_Hammer
        • Custom script: call DestroyGroup(udg_MightyHammer_DamageGroup)
      • Else - Actions
        • Set MightyHammer_Point = (Position of MightyHammer_Hammer)
        • Set MightyHammer_Point2 = (MightyHammer_Point offset by 6.00 towards MightyHammer_Angle degrees)
        • Unit - Move MightyHammer_Hammer instantly to MightyHammer_Point2
        • Set MightyHammer_UnitGroup = (Units within 250.00 of MightyHammer_Point2 matching ((((Owner of (Matching unit)) is an enemy of (Owner of MightyHammer_Hero)) Equal to True) and ((((Matching unit) is in MightyHammer_DamageGroup) Equal to False) and (((Matching unit) is alive) Equal to True
        • Unit Group - Pick every unit in MightyHammer_UnitGroup and do (Actions)
          • Loop - Actions
            • Special Effect - Create a special effect attached to the overhead of (Picked unit) using Abilities\Spells\Human\StormBolt\StormBoltMissile.mdl
            • Special Effect - Destroy (Last created special effect)
            • Unit Group - Add (Picked unit) to MightyHammer_DamageGroup
            • Unit - Cause MightyHammer_Hero to damage (Picked unit), dealing ((100.00 x (Real((Level of Mighty Hammer (Orc Warchief) for MightyHammer_Hero)))) x (Real(Weaponcraft[(Player number of (Owner of MightyHammer_Hero))]))) damage of attack type Spells and damage type Normal
        • Custom script: call RemoveLocation(udg_MightyHammer_Point)
        • Custom script: call RemoveLocation(udg_MightyHammer_Point2)
        • Custom script: call DestroyGroup(udg_MightyHammer_UnitGroup)

Point Leaks

• [TRIGGER]Tri Arrow
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Tri-Arrow
  • Actions
    • Unit Group - Pick every unit in (Units within 1000.00 of (Position of (Triggering unit))) and do (Actions)
      • Loop - Actions
        • Unit Group - Add (Picked unit) to TriUnitsArrow
        • Set TriArrowLimit = (Number of units in TriUnitsArrow)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • TriArrowLimit Less than or equal to 3
          • Then - Actions
            • Unit Group - Pick every unit in TriUnitsArrow and do (Actions)
              • Loop - Actions
                • Unit - Create 1 Dummy (Tri-Arrow) for (Owner of (Triggering unit)) at (Position of (Triggering unit)) facing Default building facing degrees
                • Unit - Order (Last created unit) to Night Elf Warden - Shadow Strike (Picked unit)
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • ((Picked unit) has buff Shadow Strike) Equal to True
                  • Then - Actions
                    • Unit - Kill (Last created unit)
                    • Unit Group - Remove all units of TriUnitsArrow from TriUnitsArrow
                  • Else - Actions
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • TriArrowLimit Greater than 3
              • Then - Actions
                • Unit Group - Remove (Random unit from (Random (TriArrowLimit - 4) units from TriUnitsArrow)) from TriUnitsArrow **Unit Group Leak here too
                • Unit Group - Pick every unit in TriUnitsArrow and do (Actions)
                  • Loop - Actions
                    • Unit - Create 1 Dummy (Tri-Arrow) for (Owner of (Triggering unit)) at (Position of (Triggering unit)) facing Default building facing degrees
                    • Unit - Order (Last created unit) to Night Elf Warden - Shadow Strike (Picked unit)
                    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                      • If - Conditions
                        • ((Picked unit) has buff Shadow Strike) Equal to True
                      • Then - Actions
                        • Unit - Kill (Last created unit)
                        • Unit Group - Remove all units of TriUnitsArrow from TriUnitsArrow
                      • Else - Actions
              • Else - Actions

Player Group Leak//You're trying to convert it to index but you put player 1 for all of them, but when you fix it will leak a player group

• CH 1 per type
  • Events
    • Time - Elapsed game time is 1.00 seconds
  • Conditions
  • Actions
    • For each (Integer A) from 1 to 10, do (Actions)
      • Loop - Actions
        • Player - Limit training of Acentis to 1 for (Random player from (Player group(Player 1 (Red))))
        • Player - Limit training of Zul'usx Magician to 1 for (Random player from (Player group(Player 1 (Red))))
        • Player - Limit training of Dwarven Rider to 1 for (Random player from (Player group(Player 1 (Red))))
        • Player - Limit training of Kul'Tiras Mage to 1 for (Random player from (Player group(Player 1 (Red))))
        • Player - Limit training of Frozen Spirit to 1 for (Random player from (Player group(Player 1 (Red))))
        • Player - Limit training of Wild Wizard to 1 for (Random player from (Player group(Player 1 (Red))))
        • Player - Limit training of Ogrim Doomhammer to 1 for (Random player from (Player group(Player 1 (Red))))
        • Player - Limit training of Obsidian Overlord to 1 for (Random player from (Player group(Player 1 (Red))))
        • Player - Limit training of Janer Skymercina to 1 for (Random player from (Player group(Player 1 (Red))))
        • Player - Limit training of Archer Mistress to 1 for (Random player from (Player group(Player 1 (Red))))
        • Player - Limit training of Sorceress to 1 for (Random player from (Player group(Player 1 (Red))))

Too many Unit groups

• Elemental Aura 2
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked unit) has buff Elemental Aura ) Equal to True
          • Then - Actions
            • Unit - Add Spellbook (Elemental Aura 2) to (Picked unit)
          • Else - Actions
            • Unit - Remove Spellbook (Elemental Aura 2) from (Picked unit)

Your map has a lot of function calls and could use some TLC to make it nice and polished.

 

[Mgeterno11]

Thanks, all 3 of you. How do I fix the unit gropus and make the one-hero limit without lacking, Thanks if you tell me how to fix these triggers.

 

[Binsu]

http://world-editor-tutorials.thehelper.net/cat_usersubmit.php?view=27219

And I do think it's just fine to have many unit groups as long that you destroy it if it will not be used anymore. See the link here that is all about memory leaks. Might help you on fixing the leaks that pOke listed here.

 

[Mgeterno11]

Thanks, Hell_Master, I will look at it and mabye I can fix.

 

[Nichilus]

And I do think it's just fine to have many unit groups as long that you destroy it if it will not be used anymore.

The problem may not be in leaks when using group, but that he picks every unit in map and sorts trough them every 0,03 seconds.
If he has too many units in map, it may lag the game, not to mention if he has more triggers like that running at the same time.

 

[Mgeterno11]

Thanks for sorting this out. What should I do to fix it? Thanks if you tell me.