[Trigger] Facing Angles

[TheDestroyer]

So I need a trigger that works where you type -angle [X]
and the unit that is selected faces that angle
I know how to do part of this,
but can someone help me with the rest?

Here is what I have so far:

For the red part i need:
[unit that triggering player has selected]
and for the blue part:
[selected unit is owned by triggering player]

There is probably some other stuff that needs to be added too

 

[Choggers]

ok try this out I dont know if you wanted to make all units the player has selected face the angle but thats what ive gone on, and i dont know if you wanted all the players to have this ability but if not just remove them from the event.

• Angle facing
  • Events
    • Player - Player 1 (Red) types a chat message containing -angle as A substring
    • Player - Player 2 (Blue) types a chat message containing -angle as A substring
    • Player - Player 3 (Teal) types a chat message containing -angle as A substring
    • Player - Player 4 (Purple) types a chat message containing -angle as A substring
    • Player - Player 5 (Yellow) types a chat message containing -angle as A substring
    • Player - Player 6 (Orange) types a chat message containing -angle as A substring
  • Conditions
  • Actions
    • Set Angle_Units = (Units currently selected by (Triggering player))
    • Unit Group - Pick every unit in Angle_Units and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Owner of (Picked unit)) Equal to (Triggering player)
          • Then - Actions
            • Unit - Make (Picked unit) face (Real((Substring((Entered chat string), 8, (Length of (Entered chat string)))))) over 0.01 seconds
          • Else - Actions

 

[TheDestroyer]

Thanks a lot. Gave you some rep

 

[TheDestroyer]

Although 1 thing, where is 'real' from (real((Substring((entered chat string)...

EDIT: of course I found it right after I post...

 

[Bannar]

Your trigger leaks group, and btw you do not need to set group here:

• Actions
  • Custom script: set bj_wantDestroyGroup = true
  • Unit Group - Pick every unit in (Units currently selected by (Triggering player)) and do (Actions)
    • Loop - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Owner of (Picked unit)) Equal to (Triggering player)
        • Then - Actions
          • Unit - Make (Picked unit) face (Real((Substring((Entered chat string), 8, (Length of (Entered chat string)))))) over 0.01 seconds
        • Else - Actions

 

[Magtheridon96]

It would be more efficient in Jass though in case you're interested
You don't need JNGP for this:

function Trig_SetFacingAngles_Enum takes nothing returns boolean
    local unit u = GetFilterUnit()
    local string s = GetEventPlayerChatString()
    if IsUnitAlly(u,GetTriggerPlayer()) and GetWidgetLife(u)>0.405 then
        call SetUnitFacing(u,S2R(SubString(s,7,StringLength(s))))
    endif
    set u = null
    return false
endfunction

function Trig_SetFacingAngles_Actions takes nothing returns boolean
    local group g = CreateGroup()
    call GroupEnumUnitsSelected(g,GetTriggerPlayer(),Filter(function Trig_SetFacingAngles_Enum))
    call DestroyGroup(g)
    set g = null
    return false
endfunction

function InitTrig_SetFacingAngles takes nothing returns nothing
    local trigger t=CreateTrigger()
    local integer i=0
    loop
        exitwhen i>11
        call TriggerRegisterPlayerChatEvent(t,Player(i),"-angle",false)
        set i=i+1
    endloop
    call TriggerAddCondition(t,Condition(function Trig_SetFacingAngles_Actions))
    set t = null
endfunction

 

[Maker]

Magtheridon96, remember to return false in the actions function, and you should use 7 instead of 8 in the substring. And how about nulling that s.

 

[Magtheridon96]

@Maker:
Fixed it
For the 8 -> 7 thing, it was a common GUI -> vJass mistake
For the string nulling, yeah, I'll start doing that from now on
For the return false thing, yeah.. I wrote the script here , so I didn't check for syntax errors >.<

 

[mckill2009]

is it really a MUST to null local variables?...btw Mags, your group needs to be nulled as well...

 

[Maker]

Yeah, local handle variables should be nulled. That excludes reals, integers and strings. So that string does not need to be nulled

 

[baassee]

And booleans.

 

[D4RK_G4ND4LF]

@Maker:
Fixed it
For the 8 -> 7 thing, it was a common GUI -> vJass mistake
For the string nulling, yeah, I'll start doing that from now on
For the return false thing, yeah.. I wrote the script here , so I didn't check for syntax errors >.<

that would not have happened with GUI

 

[TheDestroyer]

ok so I tested the trigger, and at first it worked but then I realised two problems...
1) all the units you had selected before rotate with it
2) it doesn't work on buildings which is an important part to it

@magtheridon does that work for buildings?

 

[Bannar]

Problems with mine or magy one?

 

[TheDestroyer]

Problems with mine or magy one?

chogger's one

 

[Bannar]

Because his trigger leaks group, did you saw my solution? -.- maggy did also good job in jass.

Buildings cant be selected by player while he is selecting units, so either buidling or units can be rotated.
However, you can change the condition about group eg. to just pick units in given area and your problem is solved.

 

[Magtheridon96]

I made it so that it doesn't rotate buildings
I'll fix it
Usually I only concentrate on details like nulling when I'm writing code for myself

Fixed mine
It works on buildings and I remembered to null those variables

 

[D4RK_G4ND4LF]

I made it so that it doesn't rotate buildings
I'll fix it
Usually I only concentrate on details like nulling when I'm writing code for myself

since when is it possible to rotate buildings? (except towers with ancients root ability when attacking and custom models with special bones)

 

[Bannar]

It is, by moving buildings - look here for my mini-system.

EDIT: Improved map a bit from previous uploaded version, so if you used the link you got outdated one.

 

[Magtheridon96]

since when is it possible to rotate buildings? (except towers with ancients root ability when attacking and custom models with special bones)

I don't know D:<
Stop confusing me >.<
If he gets a fatal error, he'll come back here : P
Nothing to worry about xD

 

[D4RK_G4ND4LF]

It is, look here for my mini-system here, click first map.
It can be improved a bit, but I was in hurry so efficency ins't perfect.

stop abusing bugs
anyway it won't work with SetUnitFacing and your system is useless since adding a single ability has the same effect without affecting attacks
though this will probably work for what TheDestroyer is looking for

 

[Bannar]

Man its made for being an alternative, and it works fine (for sure it is not useless). Updated it to properly turn off when group is empty, and nulled units to free memory. I know it has issue with attacks, but there is no other way.

Abusing bugs? Its just simple moving.
By the way, don't be so ignorant next time.

 

[D4RK_G4ND4LF]

there is no other way

http://www.hiveworkshop.com/forums/general-mapping-tutorials-278/tower-turning-tutorial-33448/
Your post
???

 

[TheDestroyer]

maggy your JASS thingy didnt work
I'm gonna try Spinnaker's trigger now

 

[Bannar]

D4RK_G4NDALF you must have serious problems with reading. Linking me post for what sake? You didn't understood what've said there?
I just clarified that I had no idea that you can face towers via root, because I've never needed to do such things, and thats why I experimented and created small trigger which do what he has to do. It is good alternative after all.

Make up your midn and what I've said I repeat: don't be so ignorant, there are other words to discribe that something is not perfect.

 

[TheDestroyer]

ok I got it
thanks to everyone