Energy Field 1.02

[Moderator]

Energy Field 1.02 | Reviewed by Maker | 21st Aug 2013

APPROVED

Leakless and MUI spell Use a variable for the dummy and dummy ability You could improve the learn tooltip and pay attention to the learned icon position in command card Rather than storing the level of the ability, store the damage value

[tr]

 

[FRENGERS]

Woow cool
Hope you can vJASS.... vJASS is more neater

 

[mckill2009]

Fix your indexing coz its bad atm...use dynamic indexing by hanky

 

[deathismyfriend]

this will leak and bug up.

• Set EF_TargetPoint[TempIndex] = EF_TargetPoint[EF_Integer]
• Set EF_TargetPoint[EF_Integer] = TempPoint
• Custom script: call RemoveLocation(udg_TempPoint)
• Custom script: call RemoveLocation(udg_EF_TargetPoint[udg_EF_Integer])

u should remove the location of the location that u is at tempIndex. then u set target point tempindex = target point maxIndex.
then set the one at maxIndex to null.

@ mckill2009
the indexing he uses is fine to use. it is dynamic indexing
check out my tutorial for gui he uses the same indexing in that one.

 

[Almia]

For the unit size,please make all those 100 to 0.
I suggest you using Dummy.mdx to make the effect of the unit model configurable(dummy.mdx outdoes it)
Ask Maker to how to optimize the unit's data.

@deathismyfriend
It is not a dynamic indexing,it is called an Indexed Array.

@mckill
dimf is right,it is efficient.

 

[deathismyfriend]

It is not a dynamic indexing,it is called an Indexed Array.

oooo ok thanks for the correction. i thought there was a difference just thought it was another type. lol

 

[mckill2009]

the indexing he uses is fine to use. it is dynamic indexing
check out my tutorial for gui he uses the same indexing in that one.

I tested his spell, the trigger doesnt turn off...

EDIT:
5 units casted same time...

 

[Almia]

Ah it was because he was checking first if the indexes are 0 or not at the start.
It must be:

OnCast:

set index = index + 1
if index == 1 then
    call EnableTrigger(someTrigger)
endif

OnEnd:

set indexedData[tempIndex] = indexedData[index]
set index = index - 1
if index == 0 then
    call DisableTrigger(someTrigger)
endif

 

[deathismyfriend]

could also be the location bug i said. also he should check if the maxIndex is 0 only in the de-index portion. this will stop it from unnecessarily running.

not sure y u do this after u reduce the index.

• Set TempReal = EF_Time[TempIndex]
• Set EF_Time[TempIndex] = EF_Time[EF_Integer]
• Set EF_Time[EF_Integer] = TempReal

also u should reduce the looping integer after u reduce the maxIndex integer.
if u dont ur spell looping will skip an index whenever something gets de-indexed.

 

[Almia]

could also be the location bug i said. also he should check if the maxIndex is 0 only in the de-index portion. this will stop it from unnecessarily running.

not sure y u do this after u reduce the index.

• Set TempReal = EF_Time[TempIndex]
• Set EF_Time[TempIndex] = EF_Time[EF_Integer]
• Set EF_Time[EF_Integer] = TempReal

also u should reduce the looping integer after u reduce the maxIndex integer.
if u dont ur spell looping will skip an index whenever something gets de-indexed.

He was using an index recycler,though what he was doing is recyling it infinitely

set index[1] = index[2]
set index[2] = index[1]

 

[deathismyfriend]

i understand that im just not sure y he does it lol. it doesnt seem to be needed.

 

[Almia]

Correct.

 

[Vinz]

For the unit size,please make all those 100 to 0.
I suggest you using Dummy.mdx to make the effect of the unit model configurable(dummy.mdx outdoes it)
Ask Maker to how to optimize the unit's data.

What? Didn't I use dummy.mdx? Ok I'll set it to 0.

u should remove the location of the location that u is at tempIndex. then u set target point tempindex = target point maxIndex.
then set the one at maxIndex to null.

Thanks for that, my logic seems messed up.

Gonna update after a little testing.

 

[Almia]

If you really used dummy.mdx,you can attach special effects to the dummy. You are not.
Download it here and credit Vexorian : https://www.hiveworkshop.com/forums/pastebin.php?id=sqh27s

 

[Vinz]

lolwut?

Trigger

• Unit - Create 1 Dummy for EF_Player[TempIndex] at TempPoint facing Default building facing degrees
  • Set TempUnit = (Last created unit)
  • Special Effect - Create a special effect attached to the chest of TempUnit using EF_EffectModel
  • Special Effect - Destroy (Last created special effect)
  • Special Effect - Create a special effect attached to the chest of TempUnit using EF_ReleaseEffect
  • Special Effect - Destroy (Last created special effect)
  • Animation - Change TempUnit's size to (EF_Size%, 0.00%, 0.00%) of its original size
  • Animation - Change TempUnit's vertex coloring to (EF_Color[1]%, EF_Color[2]%, EF_Color[3]%) with EF_Color[4]% transparency
  • Unit - Add Energy Field (Dummy) to TempUnit

Image

 

[Almia]

Oh sorry didnt' saw that.

 

[msongyboi]

Your spell is a little bit glitchy, it has issues sometimes when there are multiple instances running

 

[Almia]

Your spell is a little bit glitchy, it has issues sometimes when there are multiple instances running

That is because his spell was not fully MUI

 

[deathismyfriend]

this might be the problem. this isnt coded right.

• Set EF_Caster[EF_Integer] = EF_Caster[TempIndex]
• Set EF_Caster[TempIndex] = TempCaster

it should be this

• Set EF_Caster[TempIndex] = Set EF_Caster[EF_Integer]

also u set this twice in ur de-index part.

• Set EF_Level[TempIndex] = EF_Level[EF_Integer]
• Set EF_Level[EF_Integer] = TempInteger

 

[Maker]

The deindexing should look like this

-------- Nulling and recycling of variables -------- Set EF_Caster[TempIndex] = EF_Caster[EF_Integer] Set EF_Level[TempIndex] = EF_Level[EF_Integer] Custom script: call RemoveLocation(udg_EF_TargetPoint[udg_TempIndex]) Set EF_TargetPoint[TempIndex] = EF_TargetPoint[EF_Integer] Set EF_Time[TempIndex] = EF_Time[EF_Integer] Set TempIndex = (TempIndex - 1) Set EF_Integer = (EF_Integer - 1)

This is not needed

EF_Energies[TempIndex] Less than or equal to 0.00

Resource set to Needs Fix

 

[Maker]

You remove the location you reindex, thus it will screw up the instance.

 

[Vinz]

Okay done. ^

 

[Malhorne]

I like this one more than the arcane watch, the effects are cooler and more fluent.

 

[Vinz]

Yeah, the other one was pretty dull.

 

[Malhorne]

Ahah quite true.
The idea of the other is good but the effect aren't fluent. And this spell is easier to understand tho

 

[Vinz]

Yes lol that was very complicated.

 

[Malhorne]

What do you mean x°) ?

 

[Vinz]

I mean for you to be able to kill someone and prematurely end that; you would have to calculate your base damage, charge multiplier and guess how many stacks you have.

 

[Malhorne]

Yes the other was more complicated, and less understandable ^^
Hope you will get it approved soon anyway

 

[neo_sluf]

nice! job wrathion! +REP for the good job!

 

[Xerxes]

You know what I could learn a thing or two from this spell

 

[Vinz]

It is old, it has lots of silly stuff. And nowadays everything non JASS that I touch gets infected for no reason so I can't update