Energy Ball v1.0

[Moderator]

Moderator: Pharaoh_ Date: 02:00, 8th Jun 2012 Suggestions: You should use prefix of the spell's name in the variables, not suffix, so that they become more distinct. Instead of creating and destroy a group per cast, you could set a generic array variable with the current index being its value. Then check if the looping trigger runs the saved index, if it is, damage the unit, otherwise don't. AoE should be configurable per cast, not a globally fixed value. SupportMultiLevel, although nice idea, it doesn't really save performance, it actually burdens it with that check. Just directly set the values, as if it's always multilevel. Other than that, Useful.

 

[MortAr]

I don't get why do you need to move the dummy with X/Y?

• Unit Group - Pick every unit in (Units within aoeEB of DummyLocEB) and do (Actions)
• Loop - Actions
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• ((Picked unit) is alive) Equal to True
• ((Picked unit) is in UnitGroupDamagedEB[ArrayEB]) Equal to False
• ((Picked unit) belongs to an enemy of (Owner of DummyEB[ArrayEB])) Equal to True

Why not simply use a group instead of these huge ITE calls?

Spell is pretty simple and it doesn't create any unique effect so I give it a 2/5.

 

[defskull]

I don't get why do you need to move the dummy with X/Y?

Because apparently, SetUnitPositionLoc (a.k.a Unit - Move Unit (Instantly)) is much slower than SetUnitX/Y, which is much slower compared to coordinates, I'll use coordinates later on.

Why not simply use a group instead of these huge ITE calls?

If I use a Unit Group, would it make a difference ?
I still have to asses those conditions ?

 

[Iconer]

u sould mk a bal tat ataking near unit! then wen it done, it wil impaking!

 

[defskull]

Is that your mother tongue ?
Dude, seriously -,-

Adding a knockback to the explosion ?
Might think about it

 

[MortAr]

Using the group removes the entire ITE call, which will give more space and less calls further on.
If not, you could use a local group with the custom scripts.

 

[defskull]

Show me, then.

How can group remove the ITE calls

Oh, and the local group

 

[Almia]

why did you put two variables like this:
[trigger=] Set DummyDistanceEB = 1200.00
Set DummySpeedEB = 500.00
Set DummyDistanceEB = 1200.00[/trigger]

 

[defskull]

That, is a silly mistake, my bad
Will fix it

 

[mckill2009]

- I suggest you put the AttackType and DamageType to configurables.
- Put the 2nd condition in your loop in the first condition else part.
- Put the 3rd condition below the "Set LoopingIntegerEB = (LoopingIntegerEB - 1)"
- BUT, since you have an expiration timer for the dummy, you dont need these;

• ((Playable map area) contains DummyMoveEB) Equal to True
• Unit - Kill DummyEB[ArrayEB]
• (DummyEB[ArrayEB] is dead) Equal to True

instead, in your first condition use;

• (DummyEB[ArrayEB] is alive) Equal to True

in all the trigger and spell is good, rating it 4/5 until optimized fully...

 

[defskull]

- BUT, since you have an expiration timer for the dummy, you dont need these;

Dude ?
That is to kill the unit when it goes out of map bound, when we use SetUnitX/Y function, you know, it will force the unit to go over the map bound and if not killed, it will crash the map, instantly.

 

[mckill2009]

I removed it but didnt crash the map, it maybe coz the unit died already before going out the map bounds...

 

[wolfikun]

spell is simple and yet I think why haven't I thought of this