Easy Item Stack 'n Split v2.7.4 [Unmaintained]

[xorkatoss]

i like the idea of being able to purchase items from shops regardless of a full inventory.
a bag system could be useful too...even though there are lots of bag systems in the hive...

 

[fvtb]

Thanks for this system. It's easy to use.

+rep!

 

[xorkatoss]

hey dude, it's been a while...
as you already know, this is the best stacking system available BUT it takes more space than it's supposed to be...(IMO)
a normal stacking system takes about 5-6kb and yours is about 25kb...
i know that 20kb is not that much BUT im making a roc map for b.net with tft data...
so as you can see even 1kb lower is good 4 me since i want players to download my map fast...

what im trying to say:
could you please add a bonus stacking system that can:
1)stack items
2)split into half
3)unlimited stacks
4)pick up regardless of full inventory
5)no parameters and comments(to reduce size)
6)call it Item Stack and Split Lite?
7)make it in GUI if possible...(i don't like vJass sry)
8)use as less actions as possible (ofc )

thnx for wasting your time to read this!
and a bigger thnx plus rep if you do my request!!^^

EDIT:
oh well i guess you are not interested in my idea *_*

 

[Dangerb0y]

Hey man. Sorry for the extremely late reply. To be honest I'm not really supporting this system anymore. I just don't have time for it these days. So i'm gonna have to turn down your request unfortunately.

If you wanna get your map size down, you could just use Wc3mapoptimizer by Vexorian. It'll automatically remove comments and anything else it can to reduce the size of your map as much as possible. I completely understand your concern, but I really don't think 5-25kB makes much of a difference anyway.

Cheers dude, and good luck with your map. If you send me a link I'll be happy to add it under "Maps Using This System."

 

[Smiddle]

Alright, let's necropost.

In the test map, when I pick up a tome with a full inventory, it plays the error sound. (using the GUI trigger)

Though it seems like an easy fix, just by throwing an item check condition before playing the sound.

 

[RatonLynk]

Guys, How to install

 

[Smiddle]

Guys, How to install

Activate "automatically create unknown variables when pasting trigger data" (or whatever it is) in preferences and simply paste one of the triggers in your map. Doesn't it work?

 

[Barade]

Does this work with shops if the inventory is full? Can you buy items which will stack even if the inventory is full?

 

[BiroN]

This is awesome!

 

[pred1980]

Does this work with shops if the inventory is full? Can you buy items which will stack even if the inventory is full?

No, but i implemented it by using tomes

 

[mr po]

other player can hear the error sound

 

[Sverkerman]

Kind of a late reply, but perhaps I'll find an answer to my question.

This system makes the event "Unit Generic - Unit Acquires an item" run twice instead of once when picking up an item.
Anyone with a fix?

EDIT: Found a good workaround, added a boolean variable and set it to true when the item stack system is giving items/removing items and to false when it is not to track if the Acquire Item/Lose Item event is player based or system based.

 

[Alethos]

@Sverkerman Hey, can you explain what your workaround is more completely? I'm unfamiliar with boolean variables but the way I would have done it is turning off/on triggers relating to 'unit acquires (or loses) an item' when appropriate... but it seems like your solution may be more simple.

EDIT: Err... nvm, I think I figured it out- Turning off/on other triggers can be problematic (?) but if I set boolean to true and false before and after the system uses 'give- item' then put a condition: 'is variable false?' than it should work. Thanks

 

[Sverkerman]

@Alethos Exactly You've got it!

 

[RiotZ]

Alright, something which is peeving me is, when you try to pick up power ups with a full inventory it says "Inventory is full." even though I removed this message from gameplay interface and it orders the unit to stop. How do I fix this.

 

[IcemanBo]

Did you Put in a space symbol? IT should contain some character.

 

[RiotZ]

Did you Put in a space symbol? IT should contain some character.

I did.

I found the part in his script that is forcing you to stop and removed it when your inventory is full. Simple enough.

 

[Cake is a Lie]

But how to put an error message when inventory is really full?

 

[Cake is a Lie]

Can I ask how to disable stacking on a specific item?

 

[Alethos]

But how to put an error message when inventory is really full?

You can't both have your cake and eat it

Can I ask how to disable stacking on a specific item?

This only affects charged items but if you set the system to 'useitemlevel' as the cap you can set the item level to one for just one charge. Otherwise you can edit the code directly and put conditions for your specific item(s)

---
Question: Jass checker says this trigger leaks a point. Is it a false positive? Is it the jass condition where it checks to see if pointtargetcommand = null (can't remember actual wording) or something else?

 

[Cake is a Lie]

You can't both have your cake and eat it


This only affects charged items but if you set the system to 'useitemlevel' as the cap you can set the item level to one for just one charge. Otherwise you can edit the code directly and put conditions for your specific item(s)

---
Question: Jass checker says this trigger leaks a point. Is it a false positive? Is it the jass condition where it checks to see if pointtargetcommand = null (can't remember actual wording) or something else?

Ok,good idea...Thanks!

 

[Kadakash]

You can't both have your cake and eat it


This only affects charged items but if you set the system to 'useitemlevel' as the cap you can set the item level to one for just one charge. Otherwise you can edit the code directly and put conditions for your specific item(s)

Im using GUI, where do i have to put that condition?

 

[LifeguardLeroy]

SO Useful, a must in any RPG/hero map

 

[Ricola3D]

I think there is an error here:

• Actions
• [...]
• Then - Actions
  • Set EasyItem_string[0] = EasyItem__ERRORSOUND
  • Custom script: if GetLocalPlayer() != GetOwningPlayer(udg_EasyItem_unit) then
  • Set EasyItem_string[0] = <Empty String>
  • Custom script: endif
  • Custom script: set udg_EasyItem_sound = CreateSound( EasyItem__ERRORSOUND, false, false, false, 12700, 12700, "" )
  • Sound - Set volume of EasyItem_sound to 100.00%
  • Sound - Play EasyItem_sound
  • Sound - Destroy EasyItem_sound
  • Set EasyItem_sound = No sound

In CreateSound, you should use the udg_EasyItem_string[0] variable you just set, not the EasyItem__ERRORSOUND variable no ?

 

[Ricola3D]

Very good system. Just 2 suggestion for developers who implement it:

1/ Carefull, because of this system when a unit acquires an item, the event is triggered 2x
2/ The system triggers the error sound when inventory full without a "inventory is full" message
3/ The system triggers the error sound even if the picked item is a power-up or activates automatically on acquisition.

To fix 2/ and 3/ I modified a bit a part of the trigger (requires Warcraft 1.31):

• Set EasyItem__ERRORMESSAGE = Inventory is full.
• [...]
• Else - Actions
  • Unit - Order EasyItem_unit to Stop
  • -------- PLAY THE FULL INVENTORY ERROR SOUND FOR TRIGGER PLAYER --------
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • < 2 new conditions added here >
      • (Item-class of EasyItem_item) Not equal to Powerup
      • (Item: EasyItem_item's Boolean Field: Use Automatically When Acquired ('ipow')) Equal to False
      • < -------------------------------->
      • EasyItem__ERRORSOUND Not equal to <Empty String>
    • Then - Actions
      • Set EasyItem_string[0] = EasyItem__ERRORSOUND
      • Custom script: if GetLocalPlayer() != GetOwningPlayer(udg_EasyItem_unit) then
      • Set EasyItem_string[0] = <Empty String>
      • Custom script: endif
      • Custom script: set udg_EasyItem_sound = CreateSound( udg_EasyItem_string[0], false, false, false, 12700, 12700, "" )
      • Sound - Set volume of EasyItem_sound to 100.00%
      • Sound - Play EasyItem_sound
      • Sound - Destroy EasyItem_sound
      • Set EasyItem_sound = No sound
      • < 2 new lines>
      • Custom script: call ClearTextMessages()
      • Custom script: call DisplayTimedTextToPlayer(GetOwningPlayer(udg_EasyItem_unit),0.50,-1.00,2.00,"|cffffcc00"+udg_EasyItem__ERRORMESSAGE+"|r")
      • < ------------>
    • Else - Actions

 

[Kakerate]

Is there compatibility for preventing, say, any items of a Type from splitting? I have 'charged' items that are not meant to split in my map, and that functionality would be amazing.

 

[catlover47]

When my heroes pick up items it creates a Holy Light special effect, but I cant find anywhere in the trigger to disable this.

 

[Ricola3D]

For info, I'm currently asking to Dangerb0y, who retired, if I can take over the development of this system, in order for it to still be functional with Warcraft patch 1.32+.

Copy of the PM I sent to him:

Spoiler

Hello !

First of all thanks for your hardwork development W3 systems in the past !

I'm currently using your Easy Item Stack 'n Split v2.7.4 system in my map, Xnd Hero Siege. I did some fix for myself since W3 patch changed a few things and made the system not work properly anymore.

I saw that you've retired, so I would like to ask to you : can I take on the development of this system ? With respect of your work & credits of course, like I did with Sogat for X Hero Siege.

Sincerely,

Ricola3D

 

[Barade]

Does this work with the native Warcraft stacking system? Every item type in Warcraft has a stack limit. Otherwise, items do not stack. Does this system check those values or does it use its own limits/flags if an item can be stacked or not? I was thinking about writing my own unstack code because Warcraft now has this native stack system but no unstacking support.

 

[Dáñté Jáçkşóñ]

It's incredible but, when Im with 5 permanent items and i want to buy 5 potions from a goblin merchant i can buy only 1. Can you make the GUI to stack items when they are bought as well?

 

[Ricola3D]

Using a modified version of it in my map "Xnd Hero Siege", I absolutely love it !