Earthbomb v 1.2

[Moderator]

Reviewed by Maker, Earthbomb v 1.2, 30th Dec 2011

Approved. The initial effect with the sound it makes are well chosen. However I think the War Stomp effect could be changed to something else. You could experiment with offsetting the initial effect a bit, give it some height since now it get clipped with terrain on uneven ground. Improvement suggestions: Use a variable for Real(level of abil) Use dynamic indexing where expired instances are removed/overwritten

Old reviews

Reviewed by Maker, Earthbomb v 1.1, 29th Dec 2011

Required changes Separate disable fog/black mask from the effect paths. The trigger where you set the paths should be in the spell folder Indexing doesn't recycle max index, also you could remove instances when they end. You could use Hanky's dynamic indexing Use the method Pharaoh_ suggested for adding/removin Crow Form Optional changes: Use a variable for Real(level of abil)

14:59, 22nd Dec 2011
Pharaoh_:

1.0

• Set ETargetPoint[EIndex] = (Target point of ability being cast)

I'd suggest using

• Custom script: set udg_ETargetX[udg_EIndex] = GetSpellTargetX()
• Custom script: set udg_ETargetY[udg_EIndex] = GetSpellTargetY()

to prevent the delayed memory restoration.

• Set TempInt = (Player number of (Triggering player))

Is this actually used in the first trigger?

• ETimer[EInteger] Greater than 0.00

You perform this check twice.

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • ETimer[EInteger] Greater than 0.00
  • Then - Actions
  • Else - Actions
    • Set EGroup[EInteger] = (Units within 300.00 of ETargetPoint[EInteger] matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is Magic Immune) Equal to False) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Ow
    • Unit Group - Pick every unit in EGroup[EInteger] and do (Actions)
      • Loop - Actions
        • Unit - Cause ECaster[EInteger] to damage (Picked unit), dealing EDamage[EInteger] damage of attack type Chaos and damage type Normal
        • Unit - Turn collision for (Picked unit) Off
    • Special Effect - Create a special effect at ETargetPoint[EInteger] using Abilities\Weapons\SteamTank\SteamTankImpact.mdl
    • Special Effect - Destroy (Last created special effect)
    • Special Effect - Destroy EMarker[EInteger]

->

• Set EGroup[EInteger] = (Units within 300.00 of ETargetPoint[EInteger] matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is Magic Immune) Equal to False) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Ow
  • Unit Group - Pick every unit in EGroup[EInteger] and do (Actions)
    • Loop - Actions
      • Unit - Cause ECaster[EInteger] to damage (Picked unit), dealing EDamage[EInteger] damage of attack type Chaos and damage type Normal
      • Unit - Turn collision for (Picked unit) Off
  • Special Effect - Create a special effect at ETargetPoint[EInteger] using Abilities\Weapons\SteamTank\SteamTankImpact.mdl
  • Special Effect - Destroy (Last created special effect)
  • Special Effect - Destroy EMarker[EInteger]

I suggest you used this (http://www.hiveworkshop.com/forums/trigger-gui-editor-tutorials-279/how-give-unit-ability-fly-201936/) tutorial for flying height modification.

• Special Effect - Create a special effect at TempLoc2 using Abilities\Spells\Orc\WarStomp\WarStompCaster.mdl

• Special Effect - Create a special effect attached to the origin of (Picked unit) using Abilities\Spells\Orc\Devour\DevourEffectArt.mdl

• Special Effect - Create a special effect at ETargetPoint[EInteger] using Abilities\Weapons\SteamTank\SteamTankImpact.mdl

• Special Effect - Create a special effect at ETargetPoint[EIndex] using Abilities\Spells\Orc\AncestralSpirit\AncestralSpiritCaster.mdl

Make the effects' path configurable.

• Set EGroup[EInteger] = (Units within 300.00 of ETargetPoint[EInteger] matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is Magic Immune) Equal to False) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Ow

Make Area of Effect configurable as well.

 

[RakEnRoL]

Hello there. I would like to rate this spell of yours. The spell is simple but it is really nice. I like it. There are still errors with your codes.

Rating: 4/5
The spell is simple and cool
The knockback effects is great
The effects could be better

 

[maddeem]

Hello there. I would like to rate this spell of yours. The spell is simple but it is really nice. I like it. There are still errors with your codes.

Rating: 4/5
The spell is simple and cool
The knockback effects is great
The effects could be better

I love how people say a rating and don't actually rate it. :sarcasm:
That's just rude.

On topic: This is a weird way of indexing lol, I would suggest using a system. Oh and...

• For each (Integer A) from 0 to EInteger, do (Set ERecycledList[(Integer A)] = 0)
  • Set EMax = 0
  • Set ELastRecycled = 0

Couldn't you just null these at the start of each cast?
Meh, doesn't really matter though.

 

[Marsal]

I love how people say a rating and don't actually rate it. :sarcasm:
That's just rude.

On topic: This is a weird way of indexing lol, I would suggest using a system. Oh and...

• For each (Integer A) from 0 to EInteger, do (Set ERecycledList[(Integer A)] = 0)
  • Set EMax = 0
  • Set ELastRecycled = 0

Couldn't you just null these at the start of each cast?
Meh, doesn't really matter though.

Well.... actually it's a system made by me ~.~
Erm. Nope? If you null them at the start it would completely ruin the whole trigger.
edit:
or I can do it if i make another if but that would be less optimal.

 

[maddeem]

Well.... actually it's a system made by me ~.~
Erm. Nope? If you null them at the start it would completely ruin the whole trigger.
edit:
or I can do it if i make another if but that would be less optimal.

So this person is claiming credit for your work? :s
Or?

 

[Marsal]

So this person is claiming credit for your work? :s
Or?

Erm... I don´t really understand what do you mean. What person? I´m the only one who use this system and I´m the author of the system.

 

[maddeem]

Erm... I don´t really understand what do you mean. What person? I´m the only one who use this system and I´m the author of the system.

Gosh I was tired when I posted that. Please disregard it

Does this or does this not look like a nazi symbol... Lol
Just a tip, to make the spell a bit more realistic, you should change the unit's fly height dependent upon terrain height.
Anyway nice and simple spell. Deserves 5/5.

 

[Marsal]

Gosh I was tired when I posted that. Please disregard it
View attachment 109599
Does this or does this not look like a nazi symbol... Lol
Just a tip, to make the spell a bit more realistic, you should change the unit's fly height dependent upon terrain height.
Anyway nice and simple spell. Deserves 5/5.

Nope!Chuck Testa. It´s a basic war3 effect. Also, originally that sign meant peace or what. Also it´s a japanise letter.
Well I´ll try to make it and thanks.

 

[Kam]

This does not account for doodads or destructibles. Units will end up in trees.

 

[Mediumunwell]

@Kam
That's not always a bad thing >.<
but, yes, having it configurable to check for pathability would be nice.
I say let them fall off cliffs and into the ocean and even land on higher ground if they get launched high enough. Good luck with triggering that, though.