Dimension Blaster v 1.2

[Moderator]

04:14, 18th Jun 2011
Maker:
Approved.

 

[Maker]

I think the visuals are ok and there's some originality to be found here.

Trigger comments

First you set the variable to false, then loop through all indexes and check whether the variable is false.

• Dimension Blaster
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Dimension Blaster
  • Actions
    • Set DBGet = False
    • For each (Integer A) from 1 to DBMax, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • DBGet Equal to False

At 0 is instant.

• Animation - Change DBOrb[DBInteger] flying height to DBHeight[DBInteger] at 99999.00

Are the projectiles supposed to give vision? They could be created for neutral passive.

Move this

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • DBCount Equal to 0
  • Then - Actions
    • Trigger - Turn off (This trigger)
  • Else - Actions

to right after this
Set DBCount = (DBCount - 1)
So many less function calls that way.

Do the init triggers settings belong to the spell or not? Without them the spell won't work. Or is that recycling thing in the beginning of the trigger bugged?

The spell is not easily configurable, and all spells should be according to spell rules. Make a configuration trigger or something.

You don't destroy the DBTempGroup.

It seems that DBMax is never subtracted from. So if there once has been 3 instances of the spell running, the loop will always loop from 1 to 3, even if there's only one instance running.

 

[baassee]

• (Owner of DBCaster[DBIndex])

Should be Triggering Player. In the cast trigger.

Why are the temporary point variables arrayed? And why are they prefixed? Use something common like TempPoint or TempLoc and make as many as you need. No need for the variable to be arrayed.

TempReal variables? That was something new. Same as above.

I think the attacktype and damagetype should be configurable too.

 

[Marsal]

I think the visuals are ok and there's some originality to be found here.

Trigger comments

First you set the variable to false, then loop through all indexes and check whether the variable is false.

• Dimension Blaster
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Dimension Blaster
  • Actions
    • Set DBGet = False
    • For each (Integer A) from 1 to DBMax, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • DBGet Equal to False

At 0 is instant.

• Animation - Change DBOrb[DBInteger] flying height to DBHeight[DBInteger] at 99999.00

Are the projectiles supposed to give vision? They could be created for neutral passive.

Move this

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • DBCount Equal to 0
  • Then - Actions
    • Trigger - Turn off (This trigger)
  • Else - Actions

to right after this
Set DBCount = (DBCount - 1)
So many less function calls that way.

Do the init triggers settings belong to the spell or not? Without them the spell won't work. Or is that recycling thing in the beginning of the trigger bugged?

The spell is not easily configurable, and all spells should be according to spell rules. Make a configuration trigger or something.

You don't destroy the DBTempGroup.

It seems that DBMax is never subtracted from. So if there once has been 3 instances of the spell running, the loop will always loop from 1 to 3, even if there's only one instance running.

well glad to hear this

At the loop trigger this part sets it true if it found a free index slot so it won't use the last free slot

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • DBGet Equal to False
  • Then - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • DBRecycle[(Integer A)] Equal to True
      • Then - Actions
        • Set DBIndex = (Integer A)
        • Set DBGet = True
      • Else - Actions

the projectiles are to show the current AoE but the vision isn't necesseary

well it's not important because at the variables you can change the boolean's default value to True and the Integers are default 0 and you can insert the custom script next to the index recycling at the spell trigger ~.~

what do you mean about "The spell is not easily configurable, and all spells should be according to spell rules." ? you just have to modify the values given

heh i forgot to clear that leak ~.~

i know that my index recycling system isn't the best but it's mine and unique ~.~ don't worry, i'll improve my sys. soon

• (Owner of DBCaster[DBIndex])

Should be Triggering Player. In the cast trigger.

Why are the temporary point variables arrayed? And why are they prefixed? Use something common like TempPoint or TempLoc and make as many as you need. No need for the variable to be arrayed.

TempReal variables? That was something new. Same as above.

I think the attacktype and damagetype should be configurable too.

what's the problem with arrays? ~.~

they are prefixed because some people use the spells in their map and sometimes the same named variables can cause problems
example: if i use the point variable just as TempPoint with an array and the map already have this variable but without array it can cause errors

i just wanted to use as less variable as possible

 

[baassee]

Because arrays takes more space than a few more non-arrayed variables.

Then if you don't array them then you're good to go?

 

[Marsal]

well i didn't knew that ~.~

the arrays are just for me, everyone has it's own taste, that's mine, for me the work is a bit faster on this way

 

[Magtheridon96]

they are prefixed because some people use the spells in their map and sometimes the same named variables can cause problems
example: if i use the point variable just as TempPoint with an array and the map already have this variable but without array it can cause errors

You're like one of the few people who actually get me

I agree. I always prefix my variables because i don't wanna cause problems with other variables in maps that might have the same name.

All you other hivers except him are unable to perceive that.

You've made my day man! Your spell is MUI and leakless (i think ;p), so...

5/5

 

[baassee]

I agree. I always prefix my variables because i don't wanna cause problems with other variables in maps that might have the same name.

All you other hivers except him are unable to perceive that.

They won't as WC3 is one threaded and as long as you destroy the location within the current function (and not passes it on the next interval or waits) it will not bug. And we all do get it. It's not that we're stupid, we're just making the maps your using with these spells perform better. If that's bad, please report this post.

 

[Marsal]

I often see that the TempPoint variable is already there but sometimes it's arrayed and sometimes not. So yes I just don't want to cause any problem if someone use tha spell.

 

[baassee]

The one who arrayed it should be damned...

 

[Marsal]

Well yes but don't worry I'll change these temp variables but not now, now I making my entry for the current terraining contest ~.~.

 

[Maker]

Yeah, it's actually better to share "temp" variables among spells, so that not every spell has it's own variables.

 

[Marsal]

Also added better flying arc* ~.~

 

[Marcos DAB]

I bit confuse.

 

[Marsal]

confuse what?

 

[Adiktuz]

looks cool... and the idea is really nice... just do what Maker said...

the tooltip on the description is a bit long... maybe combine the similar things and just enumerate what changes every level, just like how they do it on the default wc3 abilities?

 

[Magtheridon96]

• -------- Configurables on each level --------
• -------- Level 1 --------
• Set AoE[1] = 300.00
• Set DamageType[1] = Chaos
• Set Damage_and_Heal[1] = 75.00
• Set TravelTime[1] = 0.75
• -------- Level 2 --------
• Set AoE[2] = 350.00
• Set DamageType[2] = Chaos
• Set Damage_and_Heal[2] = 100.00
• Set TravelTime[2] = 1.00
• -------- Level 3 --------
• Set AoE[3] = 400.00
• Set DamageType[3] = Chaos
• Set Damage_and_Heal[3] = 125.00
• Set TravelTime[3] = 1.25

It may be good to make the spell configurable on each level,
but I think it would be better if you use formulas to calculate
damage and AoE

For Damage: 50.00 + (Level * 25.00)
For AoE: 250.00 + (Level * 50.00)

For Damage type, don't use an array since damage type
rarely changes per level

For Travel time: 0.50 + (Level * 0.25)

 

[Adiktuz]

just use Base Damage and damage per level... coz the normal things that people use... I don't think its good to sacrifice performance (talking about getting rid of those arrays) for this matter...

 

[Magtheridon96]

just use Base Damage and damage per level... coz the normal things that people use... I don't think its good to sacrifice performance (talking about getting rid of those arrays) for this matter...

LOL
That sums up what i just said
Listen to Adiktuz 3)

 

[Marsal]

I added these variables because someone said it's so hard to configure the spell, even it was so easy ~.~.