Boulder Strike v. 1.2

[Moderator]

11:55, 2nd Aug 2013
PurgeandFire: Changes made. Approved!

 

[DivineLight]

nice spell, but i don't know, is it only me or..
when the boulder fall down from the sky and hit the ground.. it's laggy..
well, nevermind.. my laptop half broken anyway..
good job..
cool spell

 

[T. D. W.]

yeah, it may lag a bit for slow computers
anw thx

 

[DivineLight]

np..
i just like it

 

[deathismyfriend]

U should store anything u use twice or more into a variable and use the variable. Example picked unit

 

[Wrda]

• Set loc = (Point(0.00, 0.00))

you don't really need to do this the default location of points or locations are 0 (center of the map), even when they are nulled.
Must be a great spell, didn't test yet

 

[DivineLight]

• Set loc = (Point(0.00, 0.00))

you don't really need to do this the default location of points or locations are 0 (center of the map), even when they are nulled.
Must be a great spell, didn't test yet

yes, you don't really need to do this..
hmm, can't review this very well when i'm sleepy

 

[T. D. W.]

• Set loc = (Point(0.00, 0.00))

you don't really need to do this the default location of points or locations are 0 (center of the map), even when they are nulled.
Must be a great spell, didn't test yet

I think calling a nulled variable is not very good, and when u do what u say, the location (0, 0) yes, but i think it will leak or cause something bad because the variable is null

 

[DivineLight]

you use this

• Set loc = (Point(0.00, 0.00))

for this

• Unit - Create 1 Peasant for Neutral Passive at loc facing Default building facing degrees

then remove leaks

• Custom script: call RemoveLocation(udg_loc)

so nothing wrong right?

 

[Ofel]

You can also use :

• Custom script: set udg_HarvestDummy = CreateUnit(Player(15), 'hpea', 0, 0, 0)

to create unit without location...

 

[DivineLight]

i'm not good with scripts

 

[deathismyfriend]

its simple. although do it like this to make it easier.

• Set tempX = get x of point
• Set tempY = get y of point
• Set tempR = unit facing
• Set tempUnitType = Peasant
• Custom script: set udg_HarvestDummy = CreateUnit( Player(15), udg_tempUnitType, udg_tempX, udg_tempY, udg_tempR)

the player(15) in custom script is in jass so that is actually for player 16. player 1 red would be Player( 0) player 2 blue is Player( 1) and so on

 

[T. D. W.]

@Ofel the Editor & Deathismyfriend
Yh this script line would be good
@Divine
I know there is school, but you should try a little bit the custom scripts, they can be really useful sometimes

 

[deathismyfriend]

this script line does not create any location leaks. using a 0 x and 0 y value will in no way be harmful.

 

[T. D. W.]

Mmm, is that so for other values like (100,250) for example

 

[deathismyfriend]

im not sure what u mean.
wc3's map is made by coordinates. x,y values.
so it uses these values for everything.
a location is actually a set of coordinates. one x and one y coordinate.
in this custom script im using only the x and y coordinates.

 

[T. D. W.]

I mean, if the coordinates (0,0) do no leak, is it the same for (100,250) for example?

 

[DivineLight]

i think he mean is it harmful if the values is filled with (100,250)?

 

[deathismyfriend]

this custom script will never leak. it doesnt create a location therefore it doesnt leak.

 

[T. D. W.]

Ok, question answered

 

[Wrda]

Mmm, is that so for other values like (100,250) for example

That's coordinates, like altitude and longitude.

 

[deathismyfriend]

Yup lol np.

 

[T. D. W.]

Update
*Fixed some lines in the triggers
*You now can change the knockback distance and switch between End of the AoE or Custom Value

 

[PurgeandFire]

Review:

• You shouldn't check if the group is empty every 0.03 seconds. It is inefficient internally. You should use your own counter to determine if the group is empty. For example, you would set the integer variable to:
  
  • Set TempInt = TempInt + 1
  In the "Cast" trigger. When you remove the unit from the group, simply decrement it:
  
  • Set TempInt = TempInt - 1
  Then instead of checking if the group is empty, you just see if "TempInt Equal to 0", then "Turn off (This trigger)".
• Next time, you shouldn't use variable names like "x" or "loc" or "y/y2". It isn't a big issue for me, but it can become annoying for map makers when they see random variables and they don't know what it belongs to. I recommend that you prefix them with "BS_" like you did for the other ones--or make it "TempX" or "TempLoc".
• Merge:
  
  • Set y = (Load 1 of Key from BS_HA)
    • Set y = (y - 0.03)
  To:
  
  • Set y = (Load 1 of Key from BS_HA) - 0.03
  (Do the same for y and y2 later on in the trigger as well)
• Note that the default pathability checks that Warcraft III does only apply to preplaced pathing. As such, they will not take into account pathing blockers/buildings or any dynamic pathing. This may cause issues in playable maps if they use your spell. I highly recommend using the item pathing-check technique instead of your current pathing check.

Other than that, I think it is a very pretty spell. Good work.

 

[T. D. W.]

@PnF
Thanks for the moderation.. I was getting tired of waiting..
Any way, i will fix all of what you said

Other than that, I think it is a very pretty spell. Good work.

Thanks

 

[T. D. W.]

Timed Update, but it's here, the 1.2 version fixes all the wanted changes from PnF

 

[Geshishouhu]

Great work. Love this one and your Freezing Bow spell. +Rep

Edit: but I do not think these spells can be used in one map without changing the names of the globals variables. Not a bit deal though.

 

[T. D. W.]

Great work. Love this one and your Freezing Bow spell. +Rep

Edit: but I do not think these spells can be used in one map without changing the names of the globals variables. Not a bit deal though.

Thanks, and i can't do anything for the variables, if you encounter another spell that have BS as initials, i am sorry for you bu you will have to change the variable names

 

[FUJI]

Nice spell made from you . 5/5

 

[T. D. W.]

Nice spell made from you . 5/5

Hh, thanks

 

[Geshishouhu]

Thanks, and i can't do anything for the variables, if you encounter another spell that have BS as initials, i am sorry for you bu you will have to change the variable names

Actually I was talking about the two spells created by you, they share same globals, such as udg_Unit, etc. But as I said its not a big deal, Just a little suggestion, can you use more specific globals next time when you create a new spell? Coz I really like them and want to use them all. LOL
Good works! +Rep

 

[T. D. W.]

Oh, it's not a prob since they are temp variables so not a problem, and my next spell is JASS so there is temp variables = only globals for options
Any way thanks

 

[nhocklanhox6]

Cool spell, Nice Work
+REP

 

[T. D. W.]

Cool spell, Nice Work
+REP

Thanks

 

[FUJI]

I mean, if the coordinates (0,0) do no leak, is it the same for (100,250) for example?

Of course it will not leak as coordinates in real variables, they're not location nor points .

 

[T. D. W.]

Lol, i now code jass so i know that xD you took a lot time to answer this xD

 

[FUJI]

^ Lol I'd just saw your resources and I find this question in this page yesterday XD.

 

[fostaa]

The spell is incredible but has an unpleasant bug:
1. Does not make enemies attacking you if you hit them with this.
2.(Suggestion) - Make the terrain change last for a few seconds after the multiple boulders disappear. Same goes for a crater in the middle.

Except those things, it's 5/5, so I voted 4.

 

[T. D. W.]

Oh yeah ^^' the dummy deals thr damage
And what terrain change Oo

Any way thanks for the rate

 

[FUJI]

@fostaa

Lol that is not terrain, it is from the demolisher missile fx that Jad used.

 

[The Lich KIng.]

Hi.Im using this ability for one of my boss fights but since its channel,I dont know how to make my boss fight use it with "Order unit to "Ability" on a region"
I cant find channel ability in the list so i want to know is there any way to use this spell in this way?

 

[Pyrogasm]

Channel can have its base order string changed, so edit that field (not order string use/turn on) in the ability to some point-targeted order (flamestrike, blizzard, summon stasis ward, etc.) and then order the unit to use that spell.

 

[The Lich KIng.]

Channel can have its base order string changed, so edit that field (not order string use/turn on) in the ability to some point-targeted order (flamestrike, blizzard, summon stasis ward, etc.) and then order the unit to use that spell.

thank you it worked