Sand Strike 1.2

[Moderator]

12:50, 6th Jan 2010
TriggerHappy:

I may have messed up my review, I will review once again soon.

The_Reborn_Devil:
I get the feeling you haven't fixed anything I've pointed out other than fixing that bug the others talked about.
Since I'm feeling really nice I'm going to approve it since there isn't anything really wrong other than the effects (as in what happens with those you hit etc) being a bit lacking.

Status: Approved
Rating: Lacking/Useful

 

[Tank-Commander]

Right, I'm gonna be testing this one, Give me a while and I'll edit this post on what i think.

Edit: the coding seems fine, It does appear to be mui/mpi, but to be certain I suggest in the test map you add a second scorpion

As simple as spells like these are (there are quite alot of these I've seen) I did manage to find on problem

Bug

Should be an easy problem to fix, I suggest you make it so when it comes into contact with walls and trees etc. that you stop the scorpion otherwise the affect could be quite bad.

A decent spell, But sadly It isn't soemthing I havn't seen b4.

 

[jms]

ok thank !

 

[DevilDuke1995]

Add a description.

 

[jms]

read the hidden stuff !! :S

 

[DevilDuke1995]

read the hidden stuff !! :S

Description shouldnt be hidden...

 

[D4RK_G4ND4LF]

Add a description.

agree

and you should also add something to prevent that units can move out of bounds
this spell also isn't MUI (place another caster on your map and cast it towards different directions)
and it will hit structures, flying units and magic immune units
copying dota spells again and again does not make them better either
(this spell is slightly better then others like that but not original anyway)

edit: add a description to the CODE (which variable stands for what etc...)

 

[calex3]

Bugged....still possible to fix....just make caster to go back when it is going to unwalkable terrain......
Something like knockback....you need to check next point is it walkable and then move caster back by one instance you shoulded move him foward...
And about making it MUI you need to add condition to Loop trigger....condition: If SS[SSinteger[2]] Not Equal to 0

 

[jms]

Bugged....still possible to fix....just make caster to go back when it is going to unwalkable terrain......

i will fix it.. but is it going to be approved ?

@D4RK G4ND4LF
this is nothing like dota's spell !! :S
and i will add some description...

Edit: @ calex3 i will fix this too

 

[DevilDuke1995]

As D4RK_G4NDALF said this is not mpi/mui (that means its not likely to be approved). Also dont use DISBTN as research button and set its path to ReplaceableTextures\Commandbuttonsdisabled\DISBTNSandStorm.blp. I hate that green thing, dont u?

EDIT: Add a hashtable to make it MUI.

 

[calex3]

If you maybe don't understand here is fixed one...

EDIT: Add a hashtable to make it MUI.

No need for them...they are for advanced triggering problems...this is just another simple spell ..

The important thing is to understand what is indexing systems and every spell you make will be MUI if you know what you are doing..

 

[DevilDuke1995]

No need for them...they are for advanced triggering problems...this is just another simple spell ..

And use arrays?

EDIT: oh this works with pause? mine was buggy... Anyway jms upload calex3's version and give him gredits

 

[calex3]

This is recycling system so when no spells are active, when integer(0) is equal to 0 integer(1) will be set to 0 too so everything is set back to 0 and there is no such thing as bad indexing system which goes to 8000 with index..

 

[jms]

so right now it isn't MUI/MPI ??
is it going to be approved??

 

[DevilDuke1995]

so right now it isn't MUI/MPI ??
is it going to be approved??

No now it IS MUI and that depends on if mods will think this is approvable

 

[calex3]

yes only thing remove that pause and animation in first trigger....walk animation will not appear anyways....so it is useless......
it will be approved... moderators will give you at least 2/5 trust me...
Nahh maybe it won't because you used imported files...but I think that TriggerHappy will bypass that minor thing..

 

[MortAr]

- Lacks a properly documentation
- SFX causes intense lag

 

[jms]

@calex3
Ok thank you ;D
@~Mortar
I will change the sfx model
@both of you
I never ment to upload this spell.I was making a "Desert Scorpion spell pack" but then I got bored and uploaded this single spell instead...

 

[Kingz]

Doesn't use recycling indexes.

FOR THE LAST TIME:

If it resets the index when there are no running spells it ISN'T recycling!

If it recycles indexes while other spells are running that IS recycling.

Sorry to use caps but people are proclaiming a lot of systems recycling these days >.>

 

[X-OMG-X]

First of all, remove the imports.

 

[calex3]

Doesn't use recycling indexes.

FOR THE LAST TIME:

If it resets the index when there are no running spells it ISN'T recycling!

If it recycles indexes while other spells are running that IS recycling.

Sorry to use caps but people are proclaiming a lot of systems recycling these days >.>

I remember you told me that lame indexes won't be allowed.....and that this one is allowed???

 

[hell gate]

Right, I'm gonna be testing this one, Give me a while and I'll edit this post on what i think.

Edit: the coding seems fine, It does appear to be mui/mpi, but to be certain I suggest in the test map you add a second scorpion

As simple as spells like these are (there are quite alot of these I've seen) I did manage to find on problem

Bug

Should be an easy problem to fix, I suggest you make it so when it comes into contact with walls and trees etc. that you stop the scorpion otherwise the affect could be quite bad.

A decent spell, But sadly It isn't soemthing I havn't seen b4.

you can fix this if you add an if befor moving the unit.
if then else
conditions
Playable map arena contains "new move point" equal to true
then
move unit to "new move point"
endif

 

[calex3]

you can fix this if you add an if befor moving the unit.
if then else
conditions
Playable map arena contains "new move point" equal to true
then
move unit to "new move point"
endif

did I allready fixed this???
http://www.hiveworkshop.com/forums/spells-569/sand-strike-155112/#post1432156

 

[baassee]

Doesn't use recycling indexes.

FOR THE LAST TIME:

If it resets the index when there are no running spells it ISN'T recycling!

If it recycles indexes while other spells are running that IS recycling.

Sorry to use caps but people are proclaiming a lot of systems recycling these days >.>

I do not get your point, what do you call the first one then? Dynamic index system?

Well kingz is right about that one cause the word recycling is about the spell recycles when the spell ends "like hankys template"

dunno what you should call dynamic indexing/paladons indexing system for

 

[jms]

i dnt understand what you guys are saying about recycling!!

 

[hell gate]

did I allready fixed this???
http://www.hiveworkshop.com/forums/spells-569/sand-strike-155112/#post1432156

yes you fixed it but now the scorpion can't move over cliffs but if jms like this more then hmm...

 

[Kingz]

This isn't a recycling index system.

To quote DSG:

This system does not recycle indexes, it only just restricts their range to a seemingly random number.

So this is a system with restricted index range, it isn't a system with dynamic indexes and recycling.

 

[jms]

@Kingz
but it does work !

 

[hell gate]

This isn't a recycling index system.

To quote DSG:


So this is a system with restricted index range, it isn't a system with dynamic indexes and recycling.

i don't understand...

• Set SSinteger[0] = (SSinteger[0] - 1)
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• SSinteger[0] Equal to 0
• Then - Actions
  • Set SSinteger[1] = 0
  • Trigger - Turn off (This trigger)

does this not recycling?

 

[Kingz]

No, it doesn't.

 

[hell gate]

why not?
if the current spell is finished it set the counter to counter - 1 and if the counter is 0 it resett the total spell index. can you exactly say me what he has done wrong? may i have missed a thing

 

[Kingz]

Example of his indexing.

Indexing explanations

6 spells are running

1 2 3 4 5 6

Next spell cast:

1 2 3 4 5 6 7

A spell finishes:

1 2 3 4 5 6 7

A new spell is cast:

1 2 3 4 5 6 7 8

All spell finishes:

0

Dynamic indexing example:

1 2 3 4 5 6

A new spell:

1 2 3 4 5 6 7

A spell number 2 finishes:

1 X 3 4 5 6 7

A spell number 5 finishes:

1 X 3 4 X 6 7

A new spell is cast:

1 2 3 4 X 6 7

Spell number 7 finishes:

1 2 3 4 X 6

And so on...

 

[hell gate]

ahh now i know what you mean.. yes it's nit dynamic (i solved this problem with hashtables ) this uses the simplest index recycling... but i think it's ok (i said ok not super!! ^^)

 

[calex3]

Is this even possible to be done...??

you can fix this if you add an if befor moving the unit.
if then else
conditions
Playable map arena contains "new move point" equal to true
then
move unit to "new move point"
endif

there is no such thing as playable map area contains point.....as I know...
there is playable map area contains unit...you can create dummy at next point and check is it inside map....
anyways if you use this then you can stuck at hill.....and it think if you have no mana you will need to wait for a while...

 

[Kingz]

If PointX > PlayableAreaMaxX or PointX < PlayableAreaMinX or PointY > PlayableAreaMaxY or PointY < PlayableAreaMinY.

The condition should look like that.
Also this is explained in words, in trigger editor it looks difrent ofcourse.

 

[calex3]

Yeah that's probably the best way

 

[hell gate]

i'm sure that this condition exists, because i use it in my missile sys

 

[Kingz]

It is (All units in PlayableMap Contains) *Unit*.

Checking for a point makes no sense....

 

[hell gate]

yes you are right :/

• (MS_PlayableMapArena contains Unit) equal to False

 

[jms]

Still not approved..!

 

[Rmx]

The Spell causes intense lag and like KingZ said, that isn't a proper recycling of indexes, you should recycle when a spell is finished and not when all instances are finished.

 

[calex3]

Rmx you are right but your spells don't recycle too.....and mine also...
and still gets approved...

 

[Rmx]

Well yes, but even thought we should always hope for the best and
not encourage them for doing our mistakes

 

[calex3]

can he at least add condition I told him before and his spell will be approved....[condition which makes it MUI(SS[SSinteger[2] not equal to 0]) under the for each integer line in Loop trigger]
I think he only wants that...
I wanted my first spell to be approved so badly...

 

[The Reborn Devil]

Lol, I messed up my review a bit too, just like TriggerHappy. Should be fixed now though
Please tell me if I failed even more in that review ^^

 

[calex3]

Triggering is fine but still he forgot to put condition I told before.......
SS[SSinteger[2] not equal to 0 under first line in Loop trigger...Now it isn't MUI and it has bugs....told before too.....
omg can't he just do this little thing to get it approved???

 

[jms]

Sry but I am very busy so I can't do this now, will do it asap..