Sand Dive v1.0

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Moderator: Pharaoh_ Date: 05:41, 8th Apr 2012 Instead of enumerating nearby units, until you find the main target, you could check distance between your caster and the target. morph alternate string is an animation specifically used for this model. You may want to add a comment above that action. The array for 4 instances of a location variable is not needed; simply use four different variables. Set CasterSD = No unit This is not needed. Store the impaling dummy in a variable, before repeatedly referencing to it. Selection - Select CasterSD for (Owner of CasterSD) Prefer Add CasterSD to (Owner of CasterSD) selection; this will allow the player to retain the selection of every unit, before he commands their hero to cast this skill. There are certain cases, where hidden units can still acquire targets and normally attack them. Add Cargo Hold (Burrow) when you hide the caster and remove it on impact -make sure you don't null the caster, as you currently do, otherwise it won't work-. RangeSD Less than or equal to 0.00 This is not needed, the "Else" branch should automatically realize that it should switch the actions from the "Then" branch. Retain the Unit is alive condition and in the "Then" branch check the range; if it's higher than 0, subtract X, else, stun the caster.

 

[defskull]

The array for 4 instances of a location variable is not needed; simply use four different variables.

Is this heavily demanded for the spell to be approved ?
I mean, won't it be mass use of variable compared to index ?
Creating 4 variables, seems... inefficient

Set CasterSD = No unit
This is not needed.

If I remove this line, even if my Caster reaches the target and proceed with the stun, my Caster will be stunned
How do I prevent that ?

RangeSD Less than or equal to 0.00
This is not needed, the "Else" branch should automatically realize that it should switch the actions from the "Then" branch. Retain the Unit is alive condition and in the "Then" branch check the range; if it's higher than 0, subtract X, else, stun the caster.

This is to check if the Target is dead, then it stops the Caster and submerging it without stunning it
If I remove those condition in the Else action, even if the Target is dead (the spell is stopped abruptly because the Target simply died), the Caster will still be stunned
I want the Caster to not be stunned if the spell ended while the Target dies
If I remove this condition of part of the spell, then you are are correct, I should not add more conditions to it
But it seems I want the it the Caster will not be stunned if the Target is dead, then the condition branch should stay the same don't you think ?

NOTE: You can test this by using the triggers in that map in the Initialization folder

To all other matter, I will fix it, thanks for the review

 

[Adiktuz]

Arrays are always created with 8100++ indexes, the number you set at the variable editor is just the indexes that will be given the value or initialized (like for a unit group array, it is the indexes that will be given a default group using CreateGroup()), and all other indexes from there up to 8190 I think is the max, will be either null, 0, false or whatever,

now tell me if making 4 variables is more efficient than initializing thousands of indexes...

As for the spell itself, well I thought it was some kinda burrow strike... but no, it works really different... I would like to say I like the idea of this spell...

 

[defskull]

Arrays are always created with 8100++ indexes, the number you set at the variable editor is just the indexes that will be given the value or initialized (like for a unit group array, it is the indexes that will be given a default group using CreateGroup()), and all other indexes from there up to 8190 I think is the max, will be either null, 0, false or whatever,

now tell me if making 4 variables is more efficient than initializing thousands of indexes...

Thanks for enlightening me

As for the spell itself, well I thought it was some kinda burrow strike... but no, it works really different... I would like to say I like the idea of this spell...

Err perhaps I should change the screenshot wouldn't it ? Haha

 

[Adiktuz]

Maybe you could add more enemies and then use this on the middle enemy, but it would look like tidehunter's ravage then... The screenshot is pretty fitting as it is since that is exactly what the spell does...

just fix/improve the other parts and this will be good to go... and I hope to see more like this from you...

 

[KnnO]

Nice spell
I think it is better to use four point vars such as loc loc2 loc3 loc 4 rather than array Point