Awesome dude,, looking good and useful,, but I have suggestion,, in trigger ordering,, I think it is a mess mentioning units inside of a native many times,, so I recommend to set them in a variable to reduce the memory usage

and put some description and configuration for us to edit the amounts and happenings,, for example the amount of heal,, where can we edit the amount? :|

 

I am using variables for all units (caster and target), I don't know what you mean with this.

They are in the "Dive Attack start" trigger. It's explained in the map as well, and there is a comment showing which variables can be edited. Duration, speed, and cooldown have to be there because they are indexed. I could move damage, heal and speed multiplier to map init, but then the changable variables would be in 2 different locations, which I didn't want.

• Dive Attack start
  • Events
    • Unit - A unit Is attacked
  • Conditions
    • And - All (Conditions) are true
      • Conditions
        • (Level of Dive Attack for (Attacking unit)) Greater than 0
        • ((Attacking unit) is Snared) Equal to False
  • Actions
    • -------- Fixed variables, do not change these. --------
    • Set DiveAttackIndex = (DiveAttackIndex + 1)
    • Set DiveAttackCaster[DiveAttackIndex] = (Attacking unit)
    • Set DiveAttackTarget[DiveAttackIndex] = (Attacked unit)
    • Set DiveAttackHeight[DiveAttackIndex] = (Default flying height of DiveAttackCaster[DiveAttackIndex])
    • Set DiveAttackCanceled[DiveAttackIndex] = False
    • Set DiveAttackState[DiveAttackIndex] = 1
    • -------- Other variabes, change values as you will. --------
    • Set DiveAttackDamage = 10.00 // damage
    • Set DiveAttackHeal = 10.00 // heal
    • Set DiveAttackMaxDur[DiveAttackIndex] = 3.00 // max chase duration before the bird gives up
    • Set DiveAttackCooldownTimer[DiveAttackIndex] = (Random real number between 0.80 and 1.20) // attack cooldown
    • Set DiveAttackSpeed[DiveAttackIndex] = (Current movement speed of DiveAttackCaster[DiveAttackIndex]) // dive speed (set to a fixed value if you want)
    • Set DiveAttackSpeedMultiplier = 1.50// dive speed multiplier (if you use a fixed speed for the above value, set this to 1)

 

Speed, damages, heals and durations must be in a separate trigger "Configuration"

• Configs
  • Events
    • Map Initialization
  • Conditions
  • Actions
    • Set DiveAttackDur = 3.00

• Set DiveAttackMaxDur[DiveAttackIndex] = DiveAttackDur

EDIT: Also cool idea 5/5!!

 

What I mean is the "Dive Attack order checks"

 

Speed: With my current implementation, it must be set upon cast, and not pre-set on init, because it's set to the unit's current movement speed. MS slows do affect the speed of it

As for the others, I planned to make them randomized as well, similar to how attack damage of units is usually "randomized" between a min and a max.

I still could throw them all into the init, though.

I see. yes, I can use variables there.

----

Updating tomorrow.

 

the speed multiplier

 

I'll see if I can get them all in the init trigger.

 

At this point, it would be ideal for you to implement this in JASS, based on how the trigger actions are arranged and categorized.

Spell Mechanics: Notes: ​ In trigger Dive Attack order checks, it would be best to save (Ordered unit) into a variable, so that you save some execution time (calling a function is slower than reading a variable). A proper config trigger could be set up outside of the trigger Dive Attack Start. This is to save some write-ups, which comes down to optimization. Suggestions: ​ To resolve the horizontal lift bug where the albatross doesn't go anywhere, make the albatross go to a projected location with the same trajectory as the first location of the albatross before the attack. Project the movement of the albatross upon ascending as an arc. (This is only a challenge-based suggestion). Status: ​ Awaiting Update

 

Updated.

Added unit variables to the order check trigger

Moved dmg, heal, speed, cd and duration to config

Slightly Changed how dmg, heal and speed work
* Added min/max damage
* The heal is now a % of damage dealt
* The movement speed now defaults to current movement speed when the speed value in the config is set to 0. The multiplier is only used when set to 0.

 

I have basically no experience with jass, so I don't think I could.

As for the 1st suggestion, I already figured out why that happens. I had some unnecessary conditions there which sometimes made the bird skip the move order.

As for suggestion 2, I wanted to keep that part as simple as possible. The ascending is just

• Animation - Change DiveAttackCaster[DiveAttackLoop] flying height to (Default flying height of DiveAttackCaster[DiveAttackLoop]) at (Default flying height of DiveAttackCaster[DiveAttackLoop])
• Unit - Order DiveAttackCaster[DiveAttackLoop] to Move To DiveAttackLocCasterNew

I think it's fine. I might consider adding an arc to it though. I'm currently trying to figure out why long-ranged killing dives break it completely.


Edit:

Update 3

I was able to fix the bug by changing the order of events. For some reason, the target dying before changing the loop's state broke it, so now I made it damage after setting the state. I still have no idea why the order would matter here, and why it only happened when it was a long-ranged dive.

 

It makes me happy to see people make good spells that are actually useable for normal WC3 and not overtly flashy shit like 90% of the spell section.
Not to mention the creative take on this spell, the concept is just so cool.
I tried using it with Crypt Lord's Locust with great results.

 

A minor thing, you can actually remove the wait in the Config Trigger and preload them directly, as far as how I've tested the map.
There is/are a (few) variable/s whose purpose/s are quite ambiguous, and I'll list it below (and the questions that may arise), but I suppose these can be tested out.

udg_DiveAttackMoveSpeed

- Does this take movement speed or does this act as some sort of forced movement speed multiplier upon diving?

There are also a couple of things that don't need to be redefined in map initialization, such as the following variables (located in the Config trigger):

udg_DiveAttackGroup

udg_DiveAttackGroupAutocast

Other than that, the spell is ready for approval.

Status:

• Approved

 

The sound preloading didn't work for me without the wait, that's why I added it.

----

DiveAttackMoveSpeed is the variable that decides the dive speed. If you set it to 0, it defaults to the caster's current movement speed. If you set it to any positive value, it uses that value instead.

If you set it to 0, you then can use the DiveAttackSpeedMultiplier variable to increase the speed by a percentage.

The variables are explained in the trigger comment.

----

The 2 groups need to be created only once, that's why they are in the config. Where else could I put them?

 

When a unit group variable is created in the variable editor, it will always hold an empty group. From that, the lines that assign that variable to a group will overwrite the previously stored group handle (which is unnecessary), thus leading to my suggestion of removing that.

About the comments, I did not notice the presence of it within the trigger comment section when giving my review, so my apologies.

 

LOL how did i miss this. looks hilarious.