Druid Spellpack (GUI)

[Wrda]

You should separate the configurable parts of a spell from the spell's actions itself. For Example, Decomposing trigger having a new trigger like this:

Spoiler: Decompose Initialization

• Decompose Initialization
  • Events
  • Conditions
  • Actions
    • -------- =================================== --------
    • -------- =================================== --------
    • -------- =================================== --------
    • -------- ALL OF THESE VARIABLES CAN BE EDITED TO CHANGE THE STATS OF THE SPELL --------
    • Set Decompose_Ability = Decompose
    • Set Decompose_AbilityRegen = Decompose (Regen)
    • Set Decompose_AoE_Range = 500.00
    • -------- regeneration - abilitylevel*thisfactor --------
    • Set Decompose_HealFactor1 = 30.00
    • Set Decompose_ManaFactor1 = 30.00
    • -------- regeneration - strength*abilitylevel/thisfactor --------
    • Set Decompose_HealFactor2 = 15.00
    • Set Decompose_ManaFactor2 = 15.00
    • -------- fancy effect model --------
    • Set Decompose_SFX = Abilities\Spells\Undead\DeathCoil\DeathCoilSpecialArt.mdl

Now you replace the values of the other trigger with these variables, wherever they're used. In most cases, the user shouldn't have to go to the core of the spell to modify the configurable parts. When importing spells, specially if someone already has a moderate amount, it will take the process longer.
This logic should be applied to all other spells.

Looking at the Decompose trigger, you only need 1 dummy unit for all instant spells. Add the ability to the dummy before issuing to cast and then remove it. Changing abilities fields sometimes won't work for all abilities you'll be using, it's safer to increase the level of the ability and then decrease it (increasing the level of the ability works even if the ability has only 1 level).


Barkskin: Deserves to have a configurable trigger on its own. The base cooldown can very from level 1 to level 2 and so on, better to store the amount in an array. I don't understand the need for Barkskin Trigger. If the unit doesn't have the buff, then Check Barkskin DmgRed trigger won't fire.

Nature's Incarnation: Also needs a configurable trigger, like the rest of the abilities. In NaturesInc Cast:

Spoiler: Redundant check

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • And - All (Conditions) are true
          • Conditions
            • (Ability being cast) Equal to Shapeshift: Bear
            • (Unit-type of (Triggering unit)) Equal to Druid
        • And - All (Conditions) are true
          • Conditions
            • (Ability being cast) Equal to Shapeshift: Wolf
            • (Unit-type of (Triggering unit)) Equal to Druid
        • And - All (Conditions) are true
          • Conditions
            • (Ability being cast) Equal to Shapeshift: Moonkin
            • (Unit-type of (Triggering unit)) Equal to Druid
        • And - All (Conditions) are true
          • Conditions
            • (Ability being cast) Equal to Shapeshift: Spider
            • (Unit-type of (Triggering unit)) Equal to Druid
  • Then - Actions

You only need 1 of "(Unit-type of (Triggering unit)) Equal to Druid" check, move it to the main condition. NaturesInc_CD should be array to reflect the different ability's levels cooldowns.
The line call UnitMakeAbilityPermanent(GetTriggerUnit(), true, 'A00J') requires that 'A00J' to be a variable, part of the configurable trigger. "NaturesInc_MaxDuration[NaturesInc_Index] = 16.00" the 16.00 should be on the configurable part and not "NaturesInc_MaxDuration[NaturesInc_Index]" itself.
In NaturesInc LoopDuration trigger, NaturesInc_CounterDuration[NaturesInc_LoopInteger] isn't being de-indexed, nor being set to 0.00 as default on cast, it bugs the spell after the first time use. The cooldown only ability seems to have different icon X Y positions than the actual passive ability.

Woodland Spirits: Spirit Summon: WSpirit_Duration should also be an array, to reflect separate ability levels. "call RemoveLocation(udg_WSpirit_Loc)" should be done at the end of all actions since if all conditions fail it will leak. There are a lot of things that should be configurable easier here, such as the base chance, the chance increment per level, the special effect's model. Even all the formulas could be configurable on a trigger apart, but perhaps it is quite straight forward to change and understand for the common user.
The special effect in Spirits DeathAnimation should also be configurable.

Wildfire: While setting damage in "Wildfire_Damage[(Custom value of (Triggering unit))]", what does division by 5 and ability level multiplied by 7 mean? They look arbitrary numbers. That's another example of a configurable part, along with the next lines. Only required 1 dummy unit as described earlier, with the safe method to ensure ability modified fields work. You don't actually need to destroy Wildfire_UnitGroup[3], since it never leaks. This spell is stuck in an endless loop since the counter keeps reseting each enemy's neighbour to 0.

Lunar Fall: A seperate configurable part. The damage is acting earlier than the effect shows colliding with the unit, which can be weird, different effects will have different times colliding (a lot are instant though).

Lightning Rod: A seperate configurable part. Needs the safe method of ability field modifications. Only needs 1 dummy unit (which can be initialized somewhere on initialization).

Cyclone Cast trigger: A seperate configurable part. Perhaps also is incomplete (?).
Cyclone Loop: No need "Do Nothing". Cyclone_Ramp[Cyclone_Index] is never set to 0 on cast, so after first cast it is always 30. There's lot of things that should be in the configurable part.

Moonkin Shapeshift: A seperate configurable part.
Moonkin Loop trigger:

• Unit - For Unit MoonkinSS_Caster[MoonkinSS_LoopInteger], start cooldown of ability Shapeshift: Moonkin over (10.00 - MoonkinSS_Counter[MoonkinSS_LoopInteger]) seconds.

If 10 is the duration of the morph, then it must be configurable too.
Moonkin MSteal CDR trigger: A unit is attacked isn't a good event, better use "damaged".

Bear Shapeshift: BearSS Cast trigger: A seperate configurable part, specially with all the abilities being added and removed.
Bear Loop trigger:

• Unit - For Unit BearSS_Caster[BearSS_LoopInteger], start cooldown of ability Shapeshift: Bear over (10.00 - BearSS_Counter[BearSS_LoopInteger]) seconds.

If 10 is the duration of the morph, then it must be configurable too. This also happens on Spider Loop and Wolf Loop triggers.
Bear Bash trigger: only 1 dummy unit required.

Spider Shapeshift: A seperate configurable part.
SpiderShapeshift Cast trigger:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • And - All (Conditions) are true
      • Conditions
        • (Ability being cast) Equal to Shapeshift: Spider
        • Or - Any (Conditions) are true
          • Conditions
            • (Unit-type of (Triggering unit)) Equal to DruidMoonkin
            • (Unit-type of (Triggering unit)) Equal to DruidBear
            • (Unit-type of (Triggering unit)) Equal to DruidWolf

You don't need the "And - All (Conditions) are true" part, it is "and" by default.
Spider Web: A unit is attacked isn't a good event.
The following leaks a unit group:

• Set Spider_Web_AoE_Targets[(Custom value of (Attacking unit))] = (Random Spider_Web_AoE_TargetCap[(Custom value of (Attacking unit))] units from (Units within Spider_Web_AoE_Range[(Custom value of (Attacking unit))] of SpiderSS_Caster_LocationOffset matching ((((Matching unit) belongs to an enemy of (Owner of (Attacking un

"(Units within Spider_Web_AoE_Range[(Custom value of (Attacking unit))]" part. Only 1 dummy unit required, safe method to change ability level fields. Web didn't look it worked properly.

Wolf Shapeshift: A seperate configurable part.
WolfSS Cast trigger:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • And - All (Conditions) are true
      • Conditions
        • (Ability being cast) Equal to Shapeshift: Wolf
        • Or - Any (Conditions) are true
          • Conditions
            • (Unit-type of (Triggering unit)) Equal to DruidMoonkin
            • (Unit-type of (Triggering unit)) Equal to DruidSpider
            • (Unit-type of (Triggering unit)) Equal to DruidBear

Similar to before, And - All (Conditions) not needed.
Wolf Ferocity trigger: Safe method to change unit ability level fields, described earlier.

Morphing from spider to bear and cycling around them and orders seem to remove the spider morph ability somehow.
Jump System by Paladon shouldn't be mixed within the spell pack, but rather a requirement that is clear to the user.
This is an interesting thematic spell pack overall.

 

[Illbean]

You should separate the configurable parts of a spell from the spell's actions itself. For Example, Decomposing trigger having a new trigger like this:

Spoiler: Decompose Initialization

• Decompose Initialization
  • Events
  • Conditions
  • Actions
    • -------- =================================== --------
    • -------- =================================== --------
    • -------- =================================== --------
    • -------- ALL OF THESE VARIABLES CAN BE EDITED TO CHANGE THE STATS OF THE SPELL --------
    • Set Decompose_Ability = Decompose
    • Set Decompose_AbilityRegen = Decompose (Regen)
    • Set Decompose_AoE_Range = 500.00
    • -------- regeneration - abilitylevel*thisfactor --------
    • Set Decompose_HealFactor1 = 30.00
    • Set Decompose_ManaFactor1 = 30.00
    • -------- regeneration - strength*abilitylevel/thisfactor --------
    • Set Decompose_HealFactor2 = 15.00
    • Set Decompose_ManaFactor2 = 15.00
    • -------- fancy effect model --------
    • Set Decompose_SFX = Abilities\Spells\Undead\DeathCoil\DeathCoilSpecialArt.mdl

Now you replace the values of the other trigger with these variables, wherever they're used. In most cases, the user shouldn't have to go to the core of the spell to modify the configurable parts. When importing spells, specially if someone already has a moderate amount, it will take the process longer.
This logic should be applied to all other spells.

Looking at the Decompose trigger, you only need 1 dummy unit for all instant spells. Add the ability to the dummy before issuing to cast and then remove it. Changing abilities fields sometimes won't work for all abilities you'll be using, it's safer to increase the level of the ability and then decrease it (increasing the level of the ability works even if the ability has only 1 level).


Barkskin: Deserves to have a configurable trigger on its own. The base cooldown can very from level 1 to level 2 and so on, better to store the amount in an array. I don't understand the need for Barkskin Trigger. If the unit doesn't have the buff, then Check Barkskin DmgRed trigger won't fire.

Nature's Incarnation: Also needs a configurable trigger, like the rest of the abilities. In NaturesInc Cast:

Spoiler: Redundant check

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • And - All (Conditions) are true
          • Conditions
            • (Ability being cast) Equal to Shapeshift: Bear
            • (Unit-type of (Triggering unit)) Equal to Druid
        • And - All (Conditions) are true
          • Conditions
            • (Ability being cast) Equal to Shapeshift: Wolf
            • (Unit-type of (Triggering unit)) Equal to Druid
        • And - All (Conditions) are true
          • Conditions
            • (Ability being cast) Equal to Shapeshift: Moonkin
            • (Unit-type of (Triggering unit)) Equal to Druid
        • And - All (Conditions) are true
          • Conditions
            • (Ability being cast) Equal to Shapeshift: Spider
            • (Unit-type of (Triggering unit)) Equal to Druid
  • Then - Actions

You only need 1 of "(Unit-type of (Triggering unit)) Equal to Druid" check, move it to the main condition. NaturesInc_CD should be array to reflect the different ability's levels cooldowns.
The line call UnitMakeAbilityPermanent(GetTriggerUnit(), true, 'A00J') requires that 'A00J' to be a variable, part of the configurable trigger. "NaturesInc_MaxDuration[NaturesInc_Index] = 16.00" the 16.00 should be on the configurable part and not "NaturesInc_MaxDuration[NaturesInc_Index]" itself.
In NaturesInc LoopDuration trigger, NaturesInc_CounterDuration[NaturesInc_LoopInteger] isn't being de-indexed, nor being set to 0.00 as default on cast, it bugs the spell after the first time use. The cooldown only ability seems to have different icon X Y positions than the actual passive ability.

Woodland Spirits: Spirit Summon: WSpirit_Duration should also be an array, to reflect separate ability levels. "call RemoveLocation(udg_WSpirit_Loc)" should be done at the end of all actions since if all conditions fail it will leak. There are a lot of things that should be configurable easier here, such as the base chance, the chance increment per level, the special effect's model. Even all the formulas could be configurable on a trigger apart, but perhaps it is quite straight forward to change and understand for the common user.
The special effect in Spirits DeathAnimation should also be configurable.

Wildfire: While setting damage in "Wildfire_Damage[(Custom value of (Triggering unit))]", what does division by 5 and ability level multiplied by 7 mean? They look arbitrary numbers. That's another example of a configurable part, along with the next lines. Only required 1 dummy unit as described earlier, with the safe method to ensure ability modified fields work. You don't actually need to destroy Wildfire_UnitGroup[3], since it never leaks. This spell is stuck in an endless loop since the counter keeps reseting each enemy's neighbour to 0.

Lunar Fall: A seperate configurable part. The damage is acting earlier than the effect shows colliding with the unit, which can be weird, different effects will have different times colliding (a lot are instant though).

Lightning Rod: A seperate configurable part. Needs the safe method of ability field modifications. Only needs 1 dummy unit (which can be initialized somewhere on initialization).

Cyclone Cast trigger: A seperate configurable part. Perhaps also is incomplete (?).
Cyclone Loop: No need "Do Nothing". Cyclone_Ramp[Cyclone_Index] is never set to 0 on cast, so after first cast it is always 30. There's lot of things that should be in the configurable part.

Moonkin Shapeshift: A seperate configurable part.
Moonkin Loop trigger:

• Unit - For Unit MoonkinSS_Caster[MoonkinSS_LoopInteger], start cooldown of ability Shapeshift: Moonkin over (10.00 - MoonkinSS_Counter[MoonkinSS_LoopInteger]) seconds.

If 10 is the duration of the morph, then it must be configurable too.
Moonkin MSteal CDR trigger: A unit is attacked isn't a good event, better use "damaged".

Bear Shapeshift: BearSS Cast trigger: A seperate configurable part, specially with all the abilities being added and removed.
Bear Loop trigger:

• Unit - For Unit BearSS_Caster[BearSS_LoopInteger], start cooldown of ability Shapeshift: Bear over (10.00 - BearSS_Counter[BearSS_LoopInteger]) seconds.

If 10 is the duration of the morph, then it must be configurable too. This also happens on Spider Loop and Wolf Loop triggers.
Bear Bash trigger: only 1 dummy unit required.

Spider Shapeshift: A seperate configurable part.
SpiderShapeshift Cast trigger:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • And - All (Conditions) are true
      • Conditions
        • (Ability being cast) Equal to Shapeshift: Spider
        • Or - Any (Conditions) are true
          • Conditions
            • (Unit-type of (Triggering unit)) Equal to DruidMoonkin
            • (Unit-type of (Triggering unit)) Equal to DruidBear
            • (Unit-type of (Triggering unit)) Equal to DruidWolf

You don't need the "And - All (Conditions) are true" part, it is "and" by default.
Spider Web: A unit is attacked isn't a good event.
The following leaks a unit group:

• Set Spider_Web_AoE_Targets[(Custom value of (Attacking unit))] = (Random Spider_Web_AoE_TargetCap[(Custom value of (Attacking unit))] units from (Units within Spider_Web_AoE_Range[(Custom value of (Attacking unit))] of SpiderSS_Caster_LocationOffset matching ((((Matching unit) belongs to an enemy of (Owner of (Attacking un

"(Units within Spider_Web_AoE_Range[(Custom value of (Attacking unit))]" part. Only 1 dummy unit required, safe method to change ability level fields. Web didn't look it worked properly.

Wolf Shapeshift: A seperate configurable part.
WolfSS Cast trigger:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • And - All (Conditions) are true
      • Conditions
        • (Ability being cast) Equal to Shapeshift: Wolf
        • Or - Any (Conditions) are true
          • Conditions
            • (Unit-type of (Triggering unit)) Equal to DruidMoonkin
            • (Unit-type of (Triggering unit)) Equal to DruidSpider
            • (Unit-type of (Triggering unit)) Equal to DruidBear

Similar to before, And - All (Conditions) not needed.
Wolf Ferocity trigger: Safe method to change unit ability level fields, described earlier.

Morphing from spider to bear and cycling around them and orders seem to remove the spider morph ability somehow.
Jump System by Paladon shouldn't be mixed within the spell pack, but rather a requirement that is clear to the user.
This is an interesting thematic spell pack overall.

This was an incredibly long and detailed reply.
I am forever grateful for it!

An update is already in the works overhauling how the abilities are being fired and making them easier to import and use, but I will take as much as possible of this to heart and modify further per your instructions.

I thank you again for the detailed review <3

 

[Illbean]

The next update, which is the one incoperating all the changes and fixes outlined by Wrda is due in a matter of days.
There's a big triggering overhaul and a MASSIVELY upgraded useability with changing the values of the spells. It's simply not compareable to the old version.

At the same time with the proper version upload, i'll also include as many instructions and information as possible here in this post to guide users.


EDIT:
The updated version is now available! ENJOY!

 

[Wrda]

• Actions
  • -------- =================================== --------
  • Set VariableSet Decompose_Loc[0] = (Position of (Triggering unit))
  • Set VariableSet Decompose_Loc[1] = (Position of (Target unit of ability being cast))
  • Set VariableSet Decompose_UnitGroup = (Units within Decompose_AoE_Range of Decompose_Loc[0] matching ((((Matching unit) has buff Decompose (Healing Buff)) Equal to False) and ((((Matching unit) belongs to an ally of (Triggering player).) Equal to True) and (((Matching unit) is alive) Equal to Tru
  • Trigger - Run Decompose Config <gen> (checking conditions)
  • Unit - Create 1 DUMMY for Neutral Passive at Decompose_Loc[0] facing Default building facing degrees
  • Unit - Add a 0.50 second Generic expiration timer to (Last created unit)
  • -------- Fetch every eligable target for the regeneration effect and then apply it to them all. --------
  • Unit Group - Pick every unit in Decompose_UnitGroup and do (Actions)
    • Loop - Actions
      • Unit - Add Decompose_DummySpell to (Last created unit)
      • Ability - Set Ability: (Unit: (Last created unit)'s Ability with Ability Code: Decompose_DummySpell)'s Real Level Field: Hit Points Gained ('Rej1') of Level: 0 to Decompose_Heal
      • Ability - Set Ability: (Unit: (Last created unit)'s Ability with Ability Code: Decompose_DummySpell)'s Real Level Field: Mana Points Gained ('Rej2') of Level: 0 to Decompose_Mana
      • Ability - Set Ability: (Unit: (Last created unit)'s Ability with Ability Code: Decompose_DummySpell)'s Real Level Field: Duration - Normal ('adur') of Level: 0 to Decompose_Duration
      • Ability - Set Ability: (Unit: (Last created unit)'s Ability with Ability Code: Decompose_DummySpell)'s Real Level Field: Duration - Hero ('ahdu') of Level: 0 to Decompose_Duration
      • Unit - Increase level of Decompose_DummySpell for (Last created unit)
      • Unit - Decrease level of Decompose_DummySpell for (Last created unit)
      • Unit - Order (Last created unit) to Night Elf Druid Of The Claw - Rejuvenation (Picked unit)
      • Unit - Remove Decompose_DummySpell from (Last created unit)
  • -------- Fancy effect and then clear leaks --------
  • Special Effect - Create a special effect at Decompose_Loc[1] using Decompose_SpecialEffect
  • Special Effect - Destroy (Last created special effect)
  • Custom script: call RemoveLocation (udg_Decompose_Loc[0])
  • Custom script: call RemoveLocation (udg_Decompose_Loc[1])
  • Custom script: call DestroyGroup(udg_Decompose_UnitGroup)

You don't need to add, set ability fields, increase and decrease level and remove the ability within the unit group action. you can do all that before it (the removing of ability should be done after the whole group action block, of course). This is true for most of teh other spells. This can also be further improved by making a dummy for all instant cast spells.
I don't see the necessity of NaturesInc_Group being an array. You're creating groups on NaturesInc_ShieldedUnitUni for all the indeces on the array, which is too much, you can insert this instead:

• Actions
  • Custom script: if udg_NaturesInc_ShieldedUnitUni[GetUnitUserData(GetTriggerUnit())] == null then
  • Custom script: set udg_NaturesInc_ShieldedUnitUni[GetUnitUserData(GetTriggerUnit())] = CreateGroup()
  • Custom script: endif

Into here (NaturesInc Cast trigger):

Spoiler: implementation

• For each (Integer A) from 0 to (Ability: (Unit: (Triggering unit)'s Ability with Ability Code: Nature's Incarnation )'s Integer Field: Levels ('alev')), do (Actions)
  • Loop - Actions
    • Set VariableSet NaturesInc_CD[(Integer A)] = NaturesInc_CDValue
• -------- Grab every unit in shield range and apply their shield buff. --------
• Set VariableSet NaturesInc_Group[0] = (Units within NaturesInc_AoE_Range of NaturesInc_Loc matching (((((Matching unit) has buff Nature's Incarnation (Shield Buff) ) Equal to False) and (((Matching unit) is alive) Equal to True)) and (((Matching unit) belongs to an ally of (Owner of (Triggering u
• Unit - Create 1 DUMMY for Neutral Passive at NaturesInc_Loc facing Default building facing degrees
• Unit - Add a 0.50 second Generic expiration timer to (Last created unit)
• --------------------------->HERE<------------------------------------------------------------------
  • Custom script: if udg_NaturesInc_ShieldedUnitUni[GetUnitUserData(GetTriggerUnit())] == null then
  • Custom script: set udg_NaturesInc_ShieldedUnitUni[GetUnitUserData(GetTriggerUnit())] = CreateGroup()
  • Custom script: endif
• --------------------------->HERE<------------------------------------------------------------------
  • Unit Group - Pick every unit in NaturesInc_Group[0] and do (Actions)
    • Loop - Actions
      • Set VariableSet NaturesInc_Caster[(Custom value of (Picked unit))] = (Triggering unit)
      • Unit Group - Add (Picked unit) to NaturesInc_ShieldedUnitUni[(Custom value of (Triggering unit))]
      • Unit - Add NaturesInc_DummySpell to (Last created unit)
      • Ability - Set Ability: (Unit: (Last created unit)'s Ability with Ability Code: NaturesInc_DummySpell)'s Real Level Field: Duration - Normal ('adur') of Level: 0 to NaturesInc_MaxDuration
      • Ability - Set Ability: (Unit: (Last created unit)'s Ability with Ability Code: NaturesInc_DummySpell)'s Real Level Field: Duration - Hero ('ahdu') of Level: 0 to NaturesInc_MaxDuration
      • Unit - Increase level of NaturesInc_DummySpell for (Last created unit)
      • Unit - Decrease level of NaturesInc_DummySpell for (Last created unit)
      • Unit - Order (Last created unit) to Human Priest - Inner Fire (Picked unit)
      • Unit - Remove NaturesInc_DummySpell from (Last created unit)
  • Custom script: call RemoveLocation(udg_NaturesInc_Loc)
  • Custom script: call DestroyGroup(udg_NaturesInc_Group[0])
  • Unit - For Unit (Triggering unit), start cooldown of ability NaturesInc_ThisSpell " over "NaturesInc_CD[(NaturesInc_AbilityLv[(Custom value of (Triggering unit))] - 1)] seconds.

NaturesInc Cast doesn't seem to be working well, the trigger doesn't fire at all, unless I remove the order comparison related to "unimmolate", which doesn't exist, perhaps you meant "unimmolation".
NaturesInc LoopDuration: You're using custom value of Damage Target in a periodic event, it won't work.

Spirit Summon: special effects leaking. Can solve with the overshadowing global variable method.

Wildfire Loop:
You don't need this there:

• Set VariableSet Wildfire_Caster[(Custom value of Wildfire_Victim[Wildfire_LoopInteger])] = Wildfire_Caster[(Custom value of Wildfire_Victim[Wildfire_Index])]

"Set VariableSet Wildfire_IndexCurrent = Wildfire_Index" is pointless, so just use Wildfire_Index on the loop:

• Actions
  • For each (Integer Wildfire_LoopInteger) from 1 to Wildfire_Index, do (Actions)

Also, remove "Set VariableSet Wildfire_IndexCurrent = Wildfire_Index" on the deindexing part.
This solves the the endless recursion of firing spreading on targets.

Overall looks a lot better.