Admiral Spellpack v1 [GUI/MUI]

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

22:49, 12th Jan 2014
BPower:
Normally I don't intervene so quickly, but rather give the thread time to progess.

First and foremost use a different way of indexing, look into this thread it is very easy to understand Dynamic Indexing

Heay Slash

• Store picked unit into a variable
• The same unit can be hit multiple times, hence the damage is often a multiple of the original damage.

Heavy Stomp

• The animation speed should be configurable
• The variable names should be HS_ and not S_
• Use TriggeringUnit and not CastingUnit
• You have a location leak
• Don't use an array for caster and damage if you don't need it inside the loop

The spell concepts are very simple, hence I expect the code to be very good and clear, otherwise I won't approve it.

 

[Rheiko]

It's been awhile since my last time reviewing spells

| Rheiko | 12/01/14

Needs Fix

Rheiko's Review: -Heavy Slash- =============== Set HS_Caster[HS_LoopIndex[2]] = (Casting unit) -> use triggering unit instead of casting unit Set HS_MaxDistance[HS_LoopIndex[2]] = HS_MaxDistance_Config[(Level of HS_Ability for HS_Caster[HS_LoopIndex[2]])] Store "(Level of HS_Ability for HS_Caster[HS_LoopIndex[2]])" into a variable Unit - Cause HS_Caster[HS_LoopIndex[3]] to damage (Picked unit), dealing HS_Damage1[HS_LoopIndex[3]] damage of attack type Spells and damage type Normal Store picked unit into a variable (i.e TempUnit) store everything you use twice or more into a variable Set HS_LeakPoint[4] = (Position of (Picked unit)) Special Effect - Create a special effect at (Position of (Picked unit)) using HS_Effect[3] you store a location but you don't use it? so what was that for? Use that stored location Set HS_LeakPoint[1] = (Position of HS_Caster[HS_LoopIndex[2]]) Set HS_LeakPoint[2] = ((Position of HS_Caster[HS_LoopIndex[2]]) offset by HS_CurDistance[HS_LoopIndex[2]] towards HS_Angle[HS_LoopIndex[2]] degrees) use that HS_LeakPoint[1] Custom script: call RemoveLocation(udg_HS_LeakPoint[3]) You destroy LeakPoint[3] when there is no LeakPoint[3] ever be stored you should destroy LeakPoint[4] instead -Heart Stomp- =============== Set S_Damage[S_LoopIndex[2]] = S_Damage_Config[(Level of (Ability being cast) for S_Caster[S_LoopIndex[2]])] Level of S_Ability

[TD][/TD]

 

[KaelKorther]

It's been awhile since my last time reviewing spells

| Rheiko | 12/01/14

Needs Fix

Rheiko's Review: -Heavy Slash- =============== Set HS_Caster[HS_LoopIndex[2]] = (Casting unit) -> use triggering unit instead of casting unit Set HS_MaxDistance[HS_LoopIndex[2]] = HS_MaxDistance_Config[(Level of HS_Ability for HS_Caster[HS_LoopIndex[2]])] Store "(Level of HS_Ability for HS_Caster[HS_LoopIndex[2]])" into a variable Unit - Cause HS_Caster[HS_LoopIndex[3]] to damage (Picked unit), dealing HS_Damage1[HS_LoopIndex[3]] damage of attack type Spells and damage type Normal Store picked unit into a variable (i.e TempUnit) Set HS_LeakPoint[4] = (Position of (Picked unit)) Special Effect - Create a special effect at (Position of (Picked unit)) using HS_Effect[3] you store a location but you don't use it? so what was that for? Use that stored location Set HS_LeakPoint[1] = (Position of HS_Caster[HS_LoopIndex[2]]) Set HS_LeakPoint[2] = ((Position of HS_Caster[HS_LoopIndex[2]]) offset by HS_CurDistance[HS_LoopIndex[2]] towards HS_Angle[HS_LoopIndex[2]] degrees) use that HS_LeakPoint[1] Custom script: call RemoveLocation(udg_HS_LeakPoint[3]) You destroy LeakPoint[3] when there is no LeakPoint[3] ever be stored you should destroy LeakPoint[4] instead -Heart Stomp- =============== Set S_Damage[S_LoopIndex[2]] = S_Damage_Config[(Level of (Ability being cast) for S_Caster[S_LoopIndex[2]])] Level of S_Ability

[TD][/TD]

thanks for telling me...im hurry while making the spells...

 

[Rheiko]

thanks for telling me...im hurry while making the spells...

ahaha, i can see that

 

[KaelKorther]

can someone give me suggestion for this spellpack update...
i need 3 more spell to complete this spellpack

 

[Malhorne]

I suggest you not to ask suggestions in the spell forum which is a place where we submit.
If you want ideas go there : http://www.hiveworkshop.com/forums/idea-factory-462/

EDIT : Did you upload the same spell 'Heavy Slash' oO ?

 

[deathismyfriend]

You need to update this as i said about your other spells. This uses an old inefficient and break prone indexing method that is slower than the newer style shown in my tutorial things a guier should know in the chapter how to index.