MUI Spell Traps v1

[Moderator]

12th Dec 2015
IcemanBo: Too long time as NeedsFix. Rejected.

15:38, 6th Feb 2010
The_Reborn_Devil:

This leaks. (Position of Intrappola_Caster) leaks, as well as all the others.

Status: Rejected until updated
Rating: N/A

PM me or another mod once you've fixed this to get the spell reviewed again. Have a nice day!

 

[Arnadath]

seems nice but post triggers/ jass script please

 

[Crazed_seal2]

Hmmm the triggers look ok....
I'll post them:

Triggers

• Spell Cast
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Holy Light
  • Actions
    • Set A = (A + 1)
    • Set Intrappola_Caster[A] = (Triggering unit)
    • Set Intrappola_Target[A] = (Target unit of ability being cast)
    • Set Intrappola_BOOL[A] = True
    • -------- --------
    • Special Effect - Create a special effect attached to the origin of Intrappola_Target[A] using Abilities\Spells\Human\AerialShackles\AerialShacklesTarget.mdl
    • Set Intrappola_Effect1[A] = (Last created special effect)
    • Lightning - Create a Magic Leash lightning effect from source (Position of Intrappola_Caster[A]) to target (Position of Intrappola_Target[A])
    • Set Intrappola_Light[A] = (Last created lightning effect)

• Loop
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • For each (Integer i) from 1 to A, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Intrappola_BOOL[i] Equal to True
          • Then - Actions
            • -------- Muovo il target e l'effetto fulmine --------
            • Unit - Turn collision for Intrappola_Target[i] Off
            • Unit - Pause Intrappola_Target[i]
            • Set Intrappola_Count[i] = (Intrappola_Count[i] + 1)
            • Set Intrappola_Distance[i] = (Distance between (Position of Intrappola_Caster[i]) and (Position of Intrappola_Target[i]))
            • -------- La velocitÃ* di spostamento del target è proporzionale a quella del Caster --------
            • Unit - Move Intrappola_Target[i] instantly to ((Position of Intrappola_Target[i]) offset by ((Current movement speed of Intrappola_Caster[i]) x (0.03 x ((Intrappola_Distance[i] / 400.00) - (0.45 + 0.00)))) towards (Angle from (Position of Intrappola_Target[i]) to (Position of Intrappola_Caster[i])) degre
            • Lightning - Move Intrappola_Light[i] to source (Position of Intrappola_Caster[i]) and target (Position of Intrappola_Target[i])
            • -------- Per ora è disattivato, permette di danneggiare le unitÃ* vicine al target --------
            • Unit Group - Pick every unit in (Units within 50.00 of (Position of Intrappola_Target[i])) and do (Actions)
              • Loop - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • Intrappola_Target[i] Not equal to (Picked unit)
                  • Then - Actions
                    • Unit - Cause Intrappola_Target[i] to damage (Picked unit), dealing 2.00 damage of attack type Spells and damage type Spirit Link
                  • Else - Actions
            • -------- Questo serve solo per distruggere i distruttibili --------
            • Destructible - Pick every destructible in (Region centered at (Position of Intrappola_Target[i]) with size (150.00, 150.00)) and do (Actions)
              • Loop - Actions
                • Destructible - Kill (Picked destructible)
            • -------- Quando si verifica una delle seguenti condizioni INTERROMPO il ciclo --------
            • -------- Timer scaduto --------
            • -------- Caster Morto --------
            • -------- Target Morto --------
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • Or - Any (Conditions) are true
                  • Conditions
                    • Intrappola_Count[i] Greater than or equal to 200
                    • (Intrappola_Caster[i] is dead) Equal to True
                    • (Intrappola_Target[i] is dead) Equal to True
              • Then - Actions
                • -------- Faccio tornare tutto normale --------
                • Set Intrappola_BOOL[i] = False
                • Special Effect - Destroy Intrappola_Effect1[i]
                • Unit - Turn collision for Intrappola_Target[i] On
                • Unit - Unpause Intrappola_Target[i]
                • Lightning - Destroy Intrappola_Light[i]
              • Else - Actions
          • Else - Actions

 

[Kingz]

Add recycling index method and periodic trigger turn off to this spell.
Spells using non-recycling methods won't be aproved due to the spell section rules.

Also casting the spell on yourself makes it bug.

 

[Arnadath]

The code leaks locations please fix them (triggers with pollar ofset, should have a variable location which will be removed.) fix and ill check again

 

[The Trigger]

How can I stop the cycle when the spell for that 'i' ending? @resolved..
mmh help me,
Custom script: call RemoveLocation(udg_Variable_name) << wrong
How i do? thx (I never used custom scripts)

 

[D4RK_G4ND4LF]

How can I stop the cycle when the spell for that 'i' ending? @resolved..
mmh help me,
Custom script: call RemoveLocation(udg_Variable_name) << wrong
How i do? thx (I never used custom scripts)

use udg_i instead
i would be a local variable
udg_ is for globals
all variables you create are called "udg_"something

I just tested your spell and let it run while eating (for like 20 minutes) and after that I wasn't able to close wc3 cause of leaks (it leaked 200 mbyte!!!!!)

 

[The Trigger]

Custom script: call RemoveLocation(udg_Intrappola_Caster[udg_i])
because it is still wrong?
(I reloaded the map, now the maximum size of array is 30)

 

[Slaydon]

first make an integer called i :>

 

[The Trigger]

i = integer
I'm a programmer is normal use I for integer

@update

Hum
Custom script: call DestroyLightning(udg_Intrappola_Light[udg_i]) << cause a crash..
mmh try now

 

[Crazed_seal2]

Umm, you don't need custom script to destroy lightning there is already a present action that can destroy lightning

• Example
• Events
• Conditions
• Actions
  • Lightning - Destroy (Your Lightning)

 

[The Trigger]

Umm, you don't need custom script to destroy lightning there is already a present action that can destroy lightning

• Example
• Events
• Conditions
• Actions
  • Lightning - Destroy (Your Lightning)

well, it is enough to limit the array index to 30 (and auto-reload it)
..now the spell should no longer be heavy on ram!

it should work

 

[Ironside]

So the spell is MUI but it leaks ?

 

[Kingz]

Using array limitations is just wrong.

Either use hashtables or indexing, since anything below those methods shouldn't get aproved in the first place.

 

[Mainywc3sear]

descripition so bad

 

[xintell]

are there any fix version of this skill??