Trap Lightning v1.2

[Moderator]

Trap Lightning v1.2 | Reviewed by Maker | 11th Oct 2013

APPROVED

Approved There could be only one timer The spell is slightly laggy in its default configuration So many unnecessary repetated calculations here set x = GetWidgetX(dummyleft) + TRAP_SORT * Cos(.01747*TRAP_ANGLE) set y = GetWidgetY(dummyleft) + TRAP_SORT * Sin(.01747*TRAP_ANGLE) Improve the tooltip description When you create the falling orb, immediately give it flying height The height of the lightnings do not match the flying height of the two dummy orbs

[tr]

 

[Rheiko]

S C Y T H E D E A T H?
anyway, cool spell nee-san 5/5

 

[Daffa]

Nice, this is another amazing work. I hope more wonderful spells will come.

Rewards :
+3 Rep
5/5 Score

 

[Rheiko]

what's happen to jakeZinc's post?
my posts turn into triple posts, lol

 

[mckill2009]

- null your player local
- CTL or T32 is better to use for 0.03125 than TU
- Table is used in a weird way, use Dummy by Nesthaurus instead
- Use WorldBounds

 

[nhocklanhox6]

- null your player local
- CTL or T32 is better to use for 0.03125 than TU
- Table is used in a weird way, use Dummy by Nesthaurus instead
- Use WorldBounds

Oh, thanks .

 

[Geshishouhu]

I am really waiting for this spell (and also the other new ones) to get approved. I really wanna use them. LOL

 

[bowser499]

Trap Lightning v1.1 Review

The lightning is a dangerous element. For example, it can form a trap like in this spell by nhocklanhox6.

Originality: 4/5. This spell has its charm, but it's still not unique to get 5/5. Here are some examples of similar spells to this one:

• http://www.hiveworkshop.com/forums/spells-569/lightning-spells-roflcoptor-v1-3d-135990/
• http://www.hiveworkshop.com/forums/spells-569/lightning-storm-new-143785/
• http://www.hiveworkshop.com/forums/spells-569/gui-arcane-circle-227098/

Looks like this spell is just the combined phases of those ones.

Execution: 3.5/5. This code is...well, it can be a lot better. I can give some things I've pointed out here.

• Bad variable naming. Qt Coding Style is really good example on how to name the variables right. So, according to one of the postulates of Qt, you must name variables depending on for what they are created. unit u is a bad example because we can't deduct what this variable does. unit abilityCaster or unit caster are some good examples of correct variable naming. Please note that, to avoid messing up, local variables must be named from a lowercase letter and global variables must be named from the uppercase letter. For example, unit Caster is a perfect name for a global variable and unit caster is a perfect name for a local variable. But still, you can use local integer i for loops since this abbreviation is very popular.
• Unsafe 'Amrf' adding and removal. Different people are using different methods to operate dummies and it always needs to be foreseen by the maker of the spell. So, instead of doing:

  call UnitAddAbility(d,'Amrf')
              call UnitRemoveAbility(d,'Amrf')

  do:

  if UnitAddAbility(d,'Amrf') then
              call UnitRemoveAbility(d,'Amrf')
          endif

  Also make 'Amrf' as configurable constant. It's not the only ability that allows to modify flying height.
• Preloading abilities missing. This one needs some analyzis. For example, imagine that the user wants to make 100 levels of the spell (which means 100 levels of the Stun ability). It might lag during the first cast of the spell then. However, it is preventable. Add this ability to the dummy at the Object Editor, not when the spell is being cast. Then place this dummy owned by Neutral Passive somewhere on the map and remove him when the game will start. Advice the users to use such a method too in documentation if they experience lag during the first cast of the spell. This can make the spell more handy and will also show you as the competent one in such questions. So, remove this code from your spell: call UnitAddAbility(d,SPELL_STUN).
• GetWidgetX/Y is faster than GetUnitX/Y. It was benchmarked by me multiple times. The key is here:

  type unit extends widget
  type widget extends agent
  type agent extends handle

  The widget type is one level higher than unit so it will execute faster.
• Unsafe lightning operations. Sometimes destroying a lightning can result a fatal error. To prevent that, use Lightning Utils. It will make code safer. And these lightnings here aren't instantly destroyed anyways.
• Creating a dummy for Player(15) that can't allow a player to have a vision in the area is plain stupid. Create the dummy for the owner of the ability caster instead.
• To make the orb's flying more smooth there is a trick allowing to do so, just figure out on how to use rates. This parameter isn't that useless as it seems: it allows to use a lot more intensive timer without much lag. Just experiment with it based on the link I gave you.
• Pre-init struct variables. All these variables:

          lightning ll
          lightning lr
          //unit
          unit c
          unit d
          unit dl
          unit dr
          //real
          real xx
          real yy
          real h
          real r
          real al
          real ar
          real in
          real maxdis
          real dam
          //xedamage installing
          xedamage xed

  can easily be pre-inited. For example, real r = 0.. It will free you from the need to reinit them all again and again.

Effects: 3.5/5. Not that extraordinary eyecandy but it's pretty fitting in my opinion. I'd added some inner circles and made AOE decrease over time to reach one single point in the end and then *BOOM* here we see the lightning that strikes in the area where the lightnings were focused. It will make sense.

Overall: ((4+3.5+3.5)/3) = 3.7 = 4/5. This spell is a nice one but it needs many improvements in order to become a good coded spell.

4/5: Recommended

 

[Rheiko]

bowser get really active at spell section now, eh

 

[nhocklanhox6]

Review

The lightning is a dangerous element. For example, it can form a trap like in this spell by nhocklanhox6.

Originality: 4/5. This spell has its charm, but it's still not unique to get 5/5. Here are some examples of similar spells to this one:

• http://www.hiveworkshop.com/forums/spells-569/lightning-spells-roflcoptor-v1-3d-135990/
• http://www.hiveworkshop.com/forums/spells-569/lightning-storm-new-143785/
• http://www.hiveworkshop.com/forums/spells-569/gui-arcane-circle-227098/

Looks like this spell is just the combined phases of those ones.

Execution: 3.5/5. This code is...well, it can be a lot better. I can give some things I've pointed out here.

• Bad variable naming. Qt Coding Style is really good example on how to name the variables right. So, according to one of the postulates of Qt, you must name variables depending on for what they are created. unit u is a bad example because we can't deduct what this variable does. unit abilityCaster or unit caster are some good examples of correct variable naming. Please note that, to avoid messing up, local variables must be named from a lowercase letter and global variables must be named from the uppercase letter. For example, unit Caster is a perfect name for a global variable and unit caster is a perfect name for a local variable. But still, you can use local integer i for loops since this abbreviation is very popular.
• Unsafe 'Amrf' adding and removal. Different people are using different methods to operate dummies and it always needs to be foreseen by the maker of the spell. So, instead of doing:

  call UnitAddAbility(d,'Amrf')
              call UnitRemoveAbility(d,'Amrf')

  do:

  if UnitAddAbility(d,'Amrf') then
              call UnitRemoveAbility(d,'Amrf')
          endif

  Also make 'Amrf' as configurable constant. It's not the only ability that allows to modify flying height.
• Preloading abilities missing. This one needs some analyzis. For example, imagine that the user wants to make 100 levels of the spell (which means 100 levels of the Stun ability). It might lag during the first cast of the spell then. However, it is preventable. Add this ability to the dummy at the Object Editor, not when the spell is being cast. Then place this dummy owned by Neutral Passive somewhere on the map and remove him when the game will start. Advice the users to use such a method too in documentation if they experience lag during the first cast of the spell. This can make the spell more handy and will also show you as the competent one in such questions. So, remove this code from your spell: call UnitAddAbility(d,SPELL_STUN).
• GetWidgetX/Y is faster than GetUnitX/Y. It was benchmarked by me multiple times. The key is here:

  type unit extends widget
  type widget extends agent
  type agent extends handle

  The widget type is one level higher than unit so it will execute faster.
• Unsafe lightning operations. Sometimes destroying a lightning can result a fatal error. To prevent that, use Lightning Utils. It will make code safer. And these lightnings here aren't instantly destroyed anyways.
• Creating a dummy for Player(15) that can't allow a player to have a vision in the area is plain stupid. Create the dummy for the owner of the ability caster instead.
• To make the orb's flying more smooth there is a trick allowing to do so, just figure out on how to use rates. This parameter isn't that useless as it seems: it allows to use a lot more intensive timer without much lag. Just experiment with it based on the link I gave you.
• Pre-init struct variables. All these variables:

          lightning ll
          lightning lr
          //unit
          unit c
          unit d
          unit dl
          unit dr
          //real
          real xx
          real yy
          real h
          real r
          real al
          real ar
          real in
          real maxdis
          real dam
          //xedamage installing
          xedamage xed

  can easily be pre-inited. For example, real r = 0.. It will free you from the need to reinit them all again and again.

Effects: 3.5/5. Not that extraordinary eyecandy but it's pretty fitting in my opinion. I'd added some inner circles and made AOE decrease over time to reach one single point in the end and then *BOOM* here we see the lightning that strikes in the area where the lightnings were focused. It will make sense.

Overall: ((4+3.5+3.5)/3) = 3.7 = 4/5. This spell is a nice one but it needs many improvements in order to become a good coded spell.

4/5: Recommended

Thanks a lot .

Spell updated