Lightning Rain v1.2 [GUI]

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

In importing instructions, you don't mention about configuring the ability in the cast condition.
I recommend you change 0.04 interval to 0.03. In my opinion 0.04 looked choppy and I knew it was due to too low update time even before looking at the triggers.
I prefer creating dummies for neutral passive.
Instead of

• Set LR_Level = (Real((Level of Lightning Rain for LR_Caster)))

you should store the damage, including LR_Damage multiplication when the spell is cast.

Old review

05:06, 13th Sep 2011
Pharaoh_:
• Use one dummy, instead of 3, with the dummy.mdx model and add the special effects you want on it, since it is invisible, but has attachment points for this purpose. This model can be found here: http://www.wc3c.net/showthread.php?p=1007469&fromattachment=1007469#1007469
• Remove the buffs and set set Targets allowed to None.
• Use documentation as to what the following line does:

• Hashtable - Save 0 as 1 of LR_Handle in LR_Hash

•

• (Load 1 of LR_Handle from LR_Hash)

• (Load 3 of LR_Handle in LR_Hash)

Set them in a variable to improve readability and efficiency.
•

• Set LR_Caster = (Picked unit)

You don't have to declare it again in the "Else" branch.
• Turn Lightning Rain Lightning loop when you create the dummy, not in the main trigger, you will save some calls.
• In the Rain Lightning loop trigger, move the following action out of the if/then/else stament: Custom script: call RemoveLocation(udg_LR_Point1)
• Make sure you delete unused variables from the Variable Editor (Ctrl + B).
• The triggers deal extra damage to mechanicals, however, this seemingly tiny detail should be displayed in the tooltip.
• Abilities\Weapons\Bolt\BoltImpact.mdl: This should be configurable as well as:

• (Random real number between 0.00 and 10.00)

•

• Unit - Move LR_LightningUnit instantly to LR_Point2, facing (Facing of LR_LightningUnit) degrees

For the special effect of the orb, where the facing is not nearly distinctive, you could just use 0 degrees, since it's not needed to perform cosntant GetUnitFacing() calls.

 

[Jazztastic]

Please comment and rate. I feel I did a pretty good job on this. The screenshot doesn't do it justice, you have to really watch it.

 

[Magtheridon96]

I am so proud of you for not using TriggerSleepAction :3

 

[Bribe]

When picking all units every 0.04 seconds even though we are destroying the unit
group it is still leaking handle IDs. I tried this with my own spell and the handle IDs
were just climbing into the hundreds and hundreds of thousands on top of what it
should be, and during this whole time the RAM is increasing a little bit. The current
solution I have is to do a custom script enum and then do a gui pick all units - this
avoids the need to destroy the group and of course is then better for keeping the
RAM low.

 

[mckill2009]

hmm let's see...
- LR_Level should be during cast, not during the loop
- Turn on Lightning Rain Lightning Loop <gen> should be in the cast as well
- I really dont know what's the purpose of this >>> Set LR_X = 0.00
in the 0.1 loop trigger
- Make attacktype and damagetype configurables as well
- The 0.04 should be off just like the 0.1 loop
- It's better to add a condition if the caster is alive or not

 

[Jazztastic]

@Mag, Shaddup

@Bribe, Could you link an example of doing it the correct way please? I kindof get what you're saying, but I learn faster when I can see examples

@Mckill, the level is saved to the dummy units, otherwise we can't recall the data correctly. The second loop is off. And the reason why LR_X is set back to 0 everytime is because it is the X-axis in my parabola function.

• Set LR_X = ((Load 6 of LR_Handle from LR_Hash) + 1.00)
• Animation - Change LR_LightningUnit flying height to ((((LR_X x LR_X) x -1.00) + (Load 4 of LR_Handle from LR_Hash)) + (58.00 x LR_X)) at 0.00
• Hashtable - Save LR_X as 6 of LR_Handle in LR_Hash

You're right about the other stuff though. I should move the trigger turn on, should make damage configurable, and should check to see if caster is dead or not.

 

[xorkatoss]

awesome spell dude!! 5/5
would it be too much to ask for a point-target ability?

 

[Jazztastic]

It wouldn't be too hard to make point target, but I need to fix some errors with my spell first after I get some feedback (Especially leaking handles >_>)

 

[-Derp-]

I really liked this spell, its easily vJASS worthy. You've come a long way from your first spell pack. ^^


First off, I suggest using this dummy unit model as you're using 3 dummy units at the moment. To apply effects, simply add a special effect to its attachment points, and destroy it when done.



This can be simplified:

• Set LR_Angle = (Random angle)
• Unit - Create 1 LR_LightningType[LightningPicker] for (Owner of LR_Caster) at LR_Point1 facing LR_Angle degrees
• ->
• Unit - Create 1 LR_LightningType[LightningPicker] for (Owner of LR_Caster) at LR_Point1 facing (Random angle) degrees

I still believe Explode Unit is better than Kill Unit, though I have no true evidence to support my claim.

I do not see where you're turning off the .04 loop.

From what I understand, Handle Ids are unique integers given to anything that extend handles. Unit groups, units, timers, triggers, etc., extend handles. This allows us to use hashtables and what not with them. The more X created, the larger the handle id will become, and the larger the number, the longer it takes for the machine to process the command.

This occurs with just about any spell, I do not understand what Bribe's motives are or if my information is wrong.

 

[Jazztastic]

I think I might have uploaded the version of the map before I put in the part to turn off the trigger. I'll also add some trigger comments so people can follow what I'm doing. And yes, I am using three dummies, but I'd rather not force a user to get an import, even if 75% of them already have the dummy model. Simplifying the angle thing is right, I don't know why I left it in there. Originally the lightning balls were going to be created at every 30 degrees (two full circles). I'll change that.

Thanks for the feedback

EDIT: Whoa

You've come a long way from your first spell pack. ^^

How'd you know about that? That was uber deleted, like, four months ago. Lol, I always end up deleting 4/5 resources I upload here, because I either don't like them or don't feel like fixing them.

 

[Jazztastic]

~Updated to v1.1~

Derp

It's my thread, I'll double post whenever I want, so don't even start that arguement

 

[mckill2009]

the level is saved to the dummy units, otherwise we can't recall the data correctly.

if I cast level 1 'during the cast', then I changed my level to level 2 'during the loop',
then the level 1 lightnings will automatically level 2?...not good...

the reason why I see no purpose of Set LR_X = 0.00 is that it's not saved in the 0.1 loop
so how can it can be loaded if not saved?, unless I'm blind and did not see the saved LX_X???...

btw, I removed the LX_X = 0 and still works...

 

[Jazztastic]

You're right about LR_X, it wasn't ever saved into a hash. I loaded the value for each specific unit, and it returned 0 because tehre wasn't any data placed in it, which works fine. Thanks for catching that.

 

[xorkatoss]

im not an expert on hastables...in fact i pretty much suck but shouldn't you clear child hashtables?

 

[xorkatoss]

• //
• St00f
• Hashtable - Clear all child hashtables of child LR_Handle in LR_Hash
• More St00f

guess i missed it sry *_*

 

[mckill2009]

im not an expert on hastables...in fact i pretty much suck but shouldn't you clear child hashtables?

sometimes you can use or change the value it for some other usage, so you dont have to clear 'always'...

 

[xorkatoss]

im just passing by to ask:
when is point-target version of spell coming?
because im still waiting for it *_*

 

[Jazztastic]

Right now, all my time and energy is going towards mapping madness #2, which will be over in a few hours (gotta finish it). Afterwards, I'm going to take a week hiatus to adjust back into school/take a break from wc3 modding. Next weekend, I can definitely make one for you. I'd recommend that you make it yourself though I'm always for people learning how to create things, but if you REALLY need me, I can make it next week. Expect a PM

 

[xorkatoss]

Next weekend, I can definitely make one for you. I'd recommend that you make it yourself though

well for some reason it's hard to understand spells i didn't make...
i guess that's because i know step by step what each trigger does (in my spells)
plus im also kinda busy editing my rpg...i really need some terraining lessons *_*
and thnx in advance if you are making the point-target spell for me!!

 

[Jazztastic]

After receiving moderator feedback, I shall promptly fix this spell. I was almost done with the point target one too >_>

Sorry xorkatoss, don't mean to keep you waiting so long, but I'll probably release the point target on the first post as an attachment as soon as I finish fixing my problems.

 

[xorkatoss]

After receiving moderator feedback, I shall promptly fix this spell. I was almost done with the point target one too >_>

Sorry xorkatoss, don't mean to keep you waiting so long, but I'll probably release the point target on the first post as an attachment as soon as I finish fixing my problems.

nop tyt(take your time), after all with school i barely have free time...
and thnx for making it!!

Suggestion:
You could put the point-target spell in the map too and just disable it...
so if we want to try it we just enable/disable triggers instead of downloading the attached map...

 

[maddeem]

Honestly should have been done in two triggers. Besides that this does NOT support levels. And if it does, well I can't any place to edit it. But since you're new... Ehh.
Also, you should have just one generic dummy, vex's dummy.
Most of your trigger comments are totally useless.

 

[Orcnet]

useful and I might use it someday

 

[Jazztastic]

Updated to v1.2

Fixed like half of the stuff Pharoah_ mentioned. I either didn't consider it necessary or didn't agree with the other stuff he said. I decided to limit the SFX due to graphical lag I was experiencing with the spell (Having 4 internets and WE might have influenced it, but w/e). I'd recommend redownloading if you had 1.0 or 1.1