[GUI] Amethyster Spellpack v1.2

[Moderator]

11:06, 17th Jul 2012
Magtheridon96: Approved.

Job well done. The presentation is also excellent.
4.3/5.

Comments

• It would be nice if you would use multiple unit variables instead of that (2*index - 1) trick.
• It would also be cool if you were to cache the triggering unit in your "Bewitched Drizzles" spell.

 

[dangles20]

Don't use

Hidden

instead use

test

This is a test[/hidden*] - The word inbetween these marks " " is the name of the hidden tip, you may change this name and it won't affect it just make sure you keep in these marks " "

remove the star at the end of /hidden] when you do it and it will give this result

test

This is a test

 

[KnnO]

Thanks, Actually I was working it out right now, I guess it is fixed

 

[Shadowleaves]

Nice page
And nice spells

 

[TheFrozen]

Check this link:
http://www.youtube.com/watch?v=vjuvmVMLDbs
There is someone can make this spell....??
If someone can make this spell please make this spell...!!

 

[KhaosMachine]

Post some screenshots

 

[KnnO]

I added them thanks

 

[zv27]

excellent

 

[Magtheridon96]

The presentation here is excellent.
Just for that, I'll give you a 5/5. (The triggers seem fine at a glance as well.)

 

[Kingz]

Power is a really intensive function for the processor.

I think writing X*X instead of Power(X,2) is actually much better (i think i read it somewhere).

Also parabola equations can be made in a number of ways with simple math understanding... i think users are past the point of not being able to make one themselves anyway.

Also... your usage of coordinates is wrong.
You use Point with offset then use GetLocationX/Y instead of writing the following (jass example):

X = GetUnitX(...) + distance * Cos(radian)

Simple fix with gui would be to convert angle to radians and use what i mentioned above or use:

call SetUnitX(GetUnitX(...) + udg_Drz_X * Cos(udg_Drz_Angle * bj_DEGTORAD)

Point being, the current use of coordinates is sloppy because you are again using locations to get them.

The spell is written well but i have no time to test it, these are just the things i noticed from looking at it.

If you really want to be efficent (which i think you did aim for because you use SetUnitX/Y custom scripts), remove use of locations ^^

Edit:

Dynamic index recycling would be an improvement also, since atm there is no recycling.
On the side note, i recommend you to start learning JASS ^^

 

[KnnO]

Power is a really intensive function for the processor.

I think...

Thank you for your reply!
I will change the power to X*X

Woah! I am using locations and setting unit xy? lol sorry I didn't notice that because the spell is old and I just continued developing it, so ok I will remove locations usage.

I am learning Jass, actually right now I am making a map with vjass using jngp, this is just a gui spell because I feel that there are people/newbies wanting spells in gui.

I am not sure about "recycling", I searched for it but I don't know what it'll benefit me.
When an instance spell finishes, it takes the last instance (var_count) variables to its variables, then it reduces the var_count and var_index by 1. isn't it the same thing or an additional actions?

 

[Kingz]

Well the triggering is almost as good as it gets so i wouldn't worry much about dynamic recycling ^^

And gl in learning JASS ^^

+rep for nice presentation and clean code as far as i see.

 

[KnnO]

Thanks for rep
I remember that power function is a keen process and I read it somewhere too but I didn't know that it is for vJass, I think read it in another programming language(s).

 

[deathdoorway]

Has nice eye candy and layout is good. Ill give you 5/5

 

[KnnO]

Thank you! and thanks to everyone who rated this

 

[defskull]

So I herd u liek kreating spellz ?
Ratud 5/5

 

[KnnO]

Thanks !
(late reply is late)

 

[Bluegreen891]

Nice spells. I used your spells in my map and I liked it. Added credits list and 5/5 rating, Thank you very much for your spells.

 

[KnnO]

Thanks ! I'll play your map too!