Does last created unit group leaks

[HammerFist132]

I am really confused with leaks. So do I need to create variable for last created unit gorup and then clean it. Or i can just use it with no variables and with not leaks.(same questions for unit)

 

[ap0calypse]

For unit groups, you don't need a variable.

Before using the unit group, you can add the line

• Custom script: set bj_wantDestroyGroup = true

Then do the unit group actions.

Units don't leak, locations (points) do though.


Further reading.
(The rest of the thread can also be useful if you'd like to know more about leaks ).

Edit: the JASS lines you see there can easily be used in GUI with the "Custom script"-action.

 

[claptomanic]

i could be wrong but i remeber that i read that the GUI 'last created unit' creates a group in background so that would leak.

could be wrong but i think i read it. maybe a jasser could say whether im right^^

 

[HammerFist132]

so for excample: attacking unit do not leak, but position of attacking unit do leak

 

[ap0calypse]

The GUI-version "Unit - Create Unit" stores the created unit(s) inside bj_lastCreatedGroup, but it does not leak: it re-uses the unit group variable (it does not create one).
"Last created unit" is a unit variable, so that doesn't leak.

Edit: that is correct, HammerFist.

 

[defskull]

So this script does not leak eh apo ?

• Actions
  • Set TempLoc = (Position of (Triggering unit))
  • Unit - Create 10 Footman for Player 1 (Red) at TempLoc facing Default building facing degrees
  • Custom script: set bj_wantDestroyGroup = true
  • Unit Group - Pick every unit in (Last created unit group) and do (Actions)
    • Loop - Actions
      • Unit - Kill (Picked unit)
  • Custom script: call RemoveLocation(udg_TempLoc)

Let's focus on the "Pick every unit..." action.
Just by adding set bj_wantDestroyGroup = true destroys the leak ?

 

[PurgeandFire]

@defskull: Yes. "Pick every unit..." translates to ForGroupBJ(). ForGroupBJ() checks if bj_wantDestroyGroup after it calls the ForGroup() function and will destroy the group if you want it to.

function ForGroupBJ takes group whichGroup, code callback returns nothing
    // If the user wants the group destroyed, remember that fact and clear
    // the flag, in case it is used again in the callback.
    local boolean wantDestroy = bj_wantDestroyGroup
    set bj_wantDestroyGroup = false

    call ForGroup(whichGroup, callback)

    // If the user wants the group destroyed, do so now.
    if (wantDestroy) then
        call DestroyGroup(whichGroup)
    endif
endfunction

 

[defskull]

Since we're related to the topic, might as well ask a question;
Does this leak ?

• Unit - Kill (Random unit from (Random 1 units from TempGroup))

Don't focus on the TempGroup, just focus on the function Random unit from...

 

[HammerFist132]

Dudes thx for taking participation here, also if others have some question simular to my, be free to ask here.

 

[ap0calypse]

Since we're related to the topic, might as well ask a question;
Does this leak ?

• Unit - Kill (Random unit from (Random 1 units from TempGroup))

Don't focus on the TempGroup, just focus on the function Random unit from...

Yes, this leaks.
You're actually using 2 unit groups: Random units from (group) and (group) itself.
Even though you're only picking 1 unit, Warcraft will always put it in a newly created unit group.

You should destroy both groups (this also means that "set bj_wantDestroyGroup" doesn't work for both of them: you should store at least 1 group in a variable, like you did).