Disarmament v1.1

[Elprede]

How many more systems are you planning to update? Which ones?

 

[IcemanBo]

Back then when I cleaned the Spell Section I rejected like 800 resources or so because of author inactivity.
I also took some time to check them for useful concepts, so we might take initiative to re-create them one day.

System Reinventing

 

[Deleted member 219079]

All these gameplay tweaking snippets are nice additions to hive's collection!

In your onInit you create timer which you forgot to call ReleaseTimer() on afterwards: call TimerStart(NewTimer(), 0, false, function thistype.init).

 

[IcemanBo]

Nice catch, thanks. I will update it next days.

 

[AGD]

I think you forgot to make the struct entend an array

 

[IcemanBo]

Yes, indeed. Thank you.

 

[IcemanBo]

Updated:

• Made above mentioned changes.
• Added static method isUnitDisarmed takes unit u returns boolean, and a GUI equivalent
• Added some safety check to prevent disarming units which already have the cargo ability.

 

[Aniki]

Have you thought about silencing the 'Aatk' ability in order to disable a unit's attack (you can see how this can be done from this amazing silence guide by leandrotp)? The 'Abun' (orc-cargo) ability seems to hide the attack button as well, which is fine I guess, but not as "cool" as actually seeing the attack ability getting silenced, also you can disable the attack for any unit which has the 'Aatk' ability.

PS: leandrotp's method also allows one to disable the 'Amov' ability (and almost any other ability?) ;P

 

[IcemanBo]

Hm, yes I should consider looking into it, I totaly forgot.

 

[KILLCIDE]

Very useful system. It would be great if you can add the feature Aniki was talking about though! I also really like the GUI-friendly feature you added with it.

Needs Fixed

• Nothing

Suggestions

• if not (duration != 0) then
      // do stuff
  else
      if not UnitAddAbility(u, DISARM_ID) and not IsUnitInGroup(u, GROUP) then
          // debug message
          return false
      endif
  endif
  
  // >>
  
  if not (duration !=) then
      // do stuff
  elseif not UnitAddAbility(u_DISARM_ID) and not IsUnitInGroup(u, GROUP) then
      // debug message
      return false
  endif

Status

Approved​

 

[IcemanBo]

I finaly found time to read the silence tutorial, it's pure awesomeness.
Simply adding/removing in comparison though is, more straight forward.

I don't think it's worth for me to rewrite it now and use the silence method, specialisized for 'Aatk'.
It would be probably good though if, when leandrotp has continued his work, him or soemone else writes a full useable system with also mentionening exceptions and everything related.

 

[ukn0wnD3str0y3r]

Thanks man! for making a better verison of it

 

[IcemanBo]

Since patch 1.29 it will be better to use the new native:

native BlzUnitDisableAbilitytakes unit whichUnit, integer abilId, boolean flag, boolean hideUI returns nothing

.. because with it, the attack ability ('Aatk') can be correcly enabled again. The cargo approach is now outdated.

 

[Chaosy]

.. I should have scrolled down earlier, would have saved me an hour of implementing the silence approach.

 

[IcemanBo]

Hm, yeh. Added note at very top.

 

[Daffa]

I assume it should be

native BlzUnitDisableAbility takes unit whichUnit, integer abilId, boolean flag, boolean hideUI returns nothing

with a space between Ability and takes

 

[FlorianGeyerGiebelstadt]

I want to add common special effect on the disarmed unit while this function is working on. (like Yellow Question ! Mark) How can I modify this?

 

[Daffa]

I want to add common special effect on the disarmed unit while this function is working on. (like Yellow Question ! Mark) How can I modify this?

Over a year late, but if you use 1.29+, you should use the new native approach instead