[General] detect when damage is taken

[Chaosy]

As I understand it a DDS detect the damage before it is actually dealt.
However it would be useful for me to detect when the damage actually is taken

 

[Maker]

For what purpose? The existing damage detection systems do a pretty good job.

It is not possible to detect the exact moment, either you do stuff after or before the damage is applied.

 

[Chaosy]

Would have been a shortcut for my absorb system. I tried to work with the max hp ability but I cant get it to work. First I thought that I simply could add the ability and then edit the current health and then remove the ability. But then I noticed it changed the % hp so that screwed my idea

edit: I also noticed that no matter what I do with the ability I need to remove it. And if I remove it in the current trigger the unit will be back at 100% hp with nothing done

 

[Maker]

Use the physical damage detection for GUI. It does everything you need. It can block all damage very easily, it does the max hp increase for you.

 

[Chaosy]

ok, I think I got a clue on how to do that, which variable he use for the damage? I cant find it in the API?

 

[Maker]

amount

 

[Chaosy]

ok, I tried to import it but I get a critical/fatal error after configuring the ID of the damage reduction and hp spell.

so I could not test if it works...

• AS absorb Copy
  • Events
    • Game - damageEventTrigger becomes Equal to 1.00
  • Conditions
  • Actions
    • Custom script: call SetUnitLife(GetTriggerUnit(),GetUnitState(GetTriggerUnit(), UNIT_STATE_LIFE) + udg_amount)

 

[looking_for_help]

Hi,

ok, I tried to import it but I get a critical/fatal error after configuring the ID of the damage reduction and hp spell.

Which error? Did you spell the ID correct?

so I could not test if it works...

• AS absorb Copy
  • Events
    • Game - damageEventTrigger becomes Equal to 1.00
  • Conditions
  • Actions
    • Custom script: call SetUnitLife(GetTriggerUnit(),GetUnitState(GetTriggerUnit(), UNIT_STATE_LIFE) + udg_amount)

You shouldn't do that, just set the amount variable to the desired value. You just set the unit life here but the system needs to know that you actually want to modify the damage - therefore set the amount. The rest works automatic.

 

[Chaosy]

1. yes.

error msg

Error message:
FATAL ERRROR
Program: path here
exception 0xC0000005 (ACCESS_VIOLATION) at 0023:6FCC504

The instruction at '0023:6FCC504' referenced memory at '0x00000020'-
the memory could not be read

img

function InitGlobalVariables takes nothing returns nothing
    // Put here the correct ability IDs
    set udg_DAMAGE_TYPE_DETECTOR = 'A002'
    set udg_SET_MAX_LIFE = 'A001'
    
    // Here you can configure some stuff, read the documentation for further info
    set udg_SPELL_DAMAGE_REDUCTION_ITEM = 'brac'
    set udg_SPELL_RESISTANCE_AUTO_DETECT = false
    set udg_ETHEREAL_DAMAGE_FACTOR = 1.66
    set udg_BRACERS_SPELL_DAMAGE_REDUCTION = 0.33
    set udg_TRIGGER_CLEANUP_PERIOD = 60.0
endfunction

2. what you mean? I am pretty sure I need a damage variable to do that.

 

[Maker]

If you want to null damage, just set amount to 0.

 

[looking_for_help]

1. yes.

Hm ok, did you create all required variables? And what do you mean with critical error, what does the error message say?

2. what you mean? I am pretty sure I need a damage variable to do that.

Only the amount variable. Just set it for example to zero, to block all damage:

• OnDamage
  • Ereignisse
    • Game - damageEventTrigger becomes Equal to 1.00
  • Bedingungen
    • damageType Equal to 0
  • Aktionen
    • Set amount = 0.00

EDIT:

Ok, after taking a look at your map I found the problem. It has nothing to do with the DDS as the map still crashes when you delete it

But you use some custom game interface (maybe the one from the import manager?). If I disable this interface the map works without any problems
(with the DDS active of course).

 

[Chaosy]

I dont know what you mean by interface. So far I know I dont got any

 

[looking_for_help]

Yes you do, check under "Advanced->Game-Interface...".

There the box "Use own game interface" is checked. If I uncheck it, the map works. Also check your import manager, you have there a 0 kb file.

 

[Chaosy]

that is very weird I have not changed that

 

[looking_for_help]

Maybe you forgot it or used a map where it was already implemented. Can happen

By the way, I saw you use version 1.0.0.1 of the DDS. This is not the latest one, you should use version 1.0.0.2.

Greetings,
lfh

 

[Chaosy]

Great, mind if I try to copy your absorb damage method? thats the part I want not the actual dds.

 

[looking_for_help]

Uhm, how do you want to do that? You need a DDS because otherwise the damage blocking can't work.

But you can try of course, I won't mind

 

[Chaosy]

Lets just say that you got tons of stuff in your system I dont need all of it
for example the damage type detection

 

[looking_for_help]

So you don't want damage type support?

Then the only remaining system for GUI users that allows this is Bribes DDS. Its good but unfortunatly bugged with damage events that share the same instance.

If you didn't refer on damage type detection: the rest of the system is absolutly neccessary to work flawless in all situations.

 

[PurgeandFire]

Just to explain, the process goes like this:

Unit takes damage event fires.
Add the ability that increases life.
Set life to current life + absorb amount
set absorb amount = absorb amount - incoming damage
Start a countdown timer (one-shot) that lasts 0.00 seconds (this will allow the damage to be taken)
Remove ability

Or something along those lines iirc.

 

[Chaosy]

Purge wow so stupid of me
thats what I needed
did not think of adding a timer

 

[looking_for_help]

Or something along those lines iirc.

Thats will just work for the regular case.

To cover all situations you have to identify which case is actually happening, as explained here. Timer informations have to get updated or considered beforehand corresponding to the case you are in. Otherwise the system will bug.

 

[PurgeandFire]

Thats will just work for the regular case.

To cover all situations you have to identify which case is actually happening, as explained here. Timer informations have to get updated or considered beforehand corresponding to the case you are in. Otherwise the system will bug.

Thanks, I didn't mention that. You can simply put it in a stack and then loop through them.

size = size + 1
units[size] = unit

Then in the loop:

loop
exitwhen size == 0
// handle units[size]
set size = size - 1
endloop

It should take care of instances happening at the same time. Not sure what the other instance you mentioned is referring to.

 

[Chaosy]

So I got to index the unit and the timer?
Hashtable would work fine I hope.

 

[PurgeandFire]

You can just use a unit array and an integer.

Although, if you are using lfh's system, can't you just use his damage modification features? Unless you are still using Weep's.

 

[Maker]

I also recommend using lfh's system.

Little by little you improve your system and notice new bugs, then fix them. When all is said and done, you notice you have coded a similar damage detection system that lfs has done.

No need to reinvent the wheel.

 

[Chaosy]

You got a point maker, however I will update it so it works atleast.
I got 3 reasons.
1. It is my intention to replace my jass hashtable with gui which will make it useful for gui users since lfhs system is vjass. Same with damage engine its more jass than gui
2. I want it to be a absorb system and nothing else I will make it support any dds by configing which variable the system use for damage etc.
3. A personal thing really but I fully want to understand the systems I use and understand what they are able to do. Therefore I prefer my own system.

 

[looking_for_help]

Not sure what the other instance you mentioned is referring to.

Oh, you are right, the third instance is only relevant for damage type detection (stacking spell damage has to be treated a bit different than stacking physical),
so if you don't care about damage type detection you can forget the last case.