Dark Matter

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

11:10, 3rd Jun 2011
Maker:
This could be approved, but do some of the improvements I suggested in post #3 of this thread. Turning off DM finish Channeling and the unit group empty check are the most important ones. You also leak IV_group2 in the finish cnanneling trigger.

 

[Marcos DAB]

I'll check.

Seems fine, but whenever caster are unable to issue an order does't work perfectly ?

Also need more documentation.

 

[Maker]

Comments

The learn icon should be active, it's passive now.
Instead of using DM finish Channrling trigger, you could just test the current order of the caster inside the loop. If you still decie to use that trigger, then turn it on/off when needed, don't have it on all the time.
These checks should only be done after a unit is removed from the group:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (IV_group4 is empty) Equal to True
  • Then - Actions
    • Trigger - Turn off (This trigger)
  • Else - Actions

Owner of triggering unit -> triggering player. That works faster and produces the same result.
Store the Key(Triggering unit) into an integer variable, and use the variable when you save stuff into hashtable. Same for Key(Picked unit) in the loop when you save/load data.
Instead of storing the unit group into a variable, you could do this:

• Custom script: set bj_wantDestroyGroup = true
• Unit Group - Pick every unit in (Units within 500 of...)

The boolean will ensure that the group is destroyed after it is used. This works faster than setting the group into a variable.
Remove unnecessary variables, like point4 and point5. You could use point1 and point2 instead of those for example.
The knockback speed could decrease during every loop, now the units just stop abruptly.

 

[G00dG4m3]

I expected it to be something like Veigar's Dark Matter in League of Legends, but after reading comments I saw knockback and stuff

 

[x3GlikE]

Seems ok.. to me.
Also make it so that it only effects alive units cause it drags dead units to,