damage source is the unit being attacked?

[ownlyme]

Hey guys,
I have this trigger to give lumber on attack.
But it also gives lumber when the "damage source" is being attacked.

• onhit vamps
  • Events
  • Conditions
  • Actions
    • Set aantileak_unit = (Damage source)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • aantileak_unit Equal to Heiress 0015 <gen>
      • Then - Actions
        • Player - Add (Integer((150.00 + ((Damage taken) / 50.00)))) to valwinner Current lumber
        • Hero - Add (Integer((25.00 + ((Damage taken) / 34.00)))) experience to Heiress 0015 <gen>, Show level-up graphics
      • Else - Actions
    • Custom script: set udg_aantileak_unit = null

how i added the "unit takes damage" event, 100% no bugs here

• init enemies
  • Events
    • Unit - A unit enters (Playable map area)
  • Conditions
  • Actions
    • Set aantileak_unittype = (Unit-type of (Entering unit))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • aantileak_unittype Equal to Gold supplier
      • Then - Actions
        • Set gsupp = (Entering unit)
        • Trigger - Add to onhit goldsupplier <gen> the event (Unit - (Entering unit) Takes damage)
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Or - Any (Conditions) are true
          • Conditions
            • aantileak_unittype Equal to Vampire
            • aantileak_unittype Equal to Vampire Minion
      • Then - Actions
        • Trigger - Add to onhit vamps <gen> the event (Unit - (Entering unit) Takes damage)
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • aantileak_unittype Equal to Vampiric Stun Tower
      • Then - Actions
        • Trigger - Add to onhit vamptowers <gen> the event (Unit - (Entering unit) Takes damage)
      • Else - Actions

How to do it properly?
Thanks.

 

[Flux]

First of all, making a DDS that way is bad because it leaks a Trigger Event meaning after the unit dies/removed, the event is still there. Second, units initially on the map are not added if they have a 'Vampire' unit type. This won't matter if your map has no units initially.
Now to fix your DDS, you need to periodically (i.e
every 60 sec) 'refresh' the onhitvamps. By 'refresh' I meant destroying and re-creating the onhitvamps trigger to remove all its Events. When re-creating, pick all units in the map and if the condition is true, add them to the Event via
'Trigger - Add to onhit ... the event a (Picked Unit) takes damage'

Now for your problem, you didn't set the valwinner variable.

 

[Chaosy]

Weep did the best DDS in my opinion. Not in terms of functionality, where it's clearly inferior to the newer ones. But for the sole purpose of detecting damage it's a simple yet effective way. You might want to check it out, however it's in jass.

 

[Bribe]

Weep's is the most simple DDS, and would work just fine here since the damage amount isn't being modified nor matter if it is spell or physical.

 

[ownlyme]

i did set the valwinner variable in another trigger.
guess i will use weep's then.
thanks guys

 

[ownlyme]

i found the bug.
i think it was the spiked carpadace which i had set to 0 damage, but it still triggered a damage taken event