Damage Engine 5.A.0.0

[Map Designer]

Can this force unit to roll some number from its damage dice?
e.g. it force max damage roll (bless) or min damage roll (min).
can it also remove of dice (do basic dmg only)

Edit: also, is it possibile to make spirit link damage pure and not magical? Units that have magic resistance will reduce spirit link damage.
Edit: I think I got it. Best way to fully remove magic resistance abilties (including hero armor resistance), and replace it with conditional trigger which will reduce spell damage ONLY IF its above certain threshold. Normally, spirit link damage redistribution is ver low (between 5-75)
And spells usually do a lot of damage. Min spell damage is warden SS (Except blizzard and flamestrike).

This is buggy fix but simple. If you know your map, you will understand which conditions to use to work around this spirit link.


Though is there straight forward fix?

 

[Bribe]

Can this force unit to roll some number from its damage dice?
e.g. it force max damage roll (bless) or min damage roll (min).
can it also remove of dice (do basic dmg only)

Not a perfect solution for this. No DDS works with damage prior to the dice/critical strike/searing arrows flat damage increasers because Blizzard's API doesn't allow it.

However, if you detect "IsDamageAttack" and don't use Critical Strike in your map (if you do, you'd have to trigger it) you can reset the damage dice. Blizzard made new natives to detect those figures so you can recalculate it and set DamageEventAmount to the new figure.

Edit: also, is it possibile to make spirit link damage pure and not magical? Units that have magic resistance will reduce spirit link damage.
Edit: I think I got it. Best way to fully remove magic resistance abilties (including hero armor resistance), and replace it with conditional trigger which will reduce spell damage ONLY IF its above certain threshold. Normally, spirit link damage redistribution is ver low (between 5-75)
And spells usually do a lot of damage. Min spell damage is warden SS (Except blizzard and flamestrike).

This is buggy fix but simple. If you know your map, you will understand which conditions to use to work around this spirit link.


Though is there straight forward fix?

Very easy fix here. From a DamageModifierEvent 1.00, check if DamageEventDamageT is Equal to DAMAGE_TYPE_SPIRIT_LINK. If so, change DamageEventAttackT to something else like ATTACK_TYPE_CHAOS. This won't work with ethereal units but will work with the rest.

 

[Map Designer]

Very easy fix here. From a DamageModifierEvent 1.00, check if DamageEventDamageT is Equal to DAMAGE_TYPE_SPIRIT_LINK. If so, change DamageEventAttackT to something else like ATTACK_TYPE_CHAOS. This won't work with ethereal units but will work with the rest.

we can make it with magic attacks then. problem will be that original spirit link by passed armor reductions, but iirc even your damage engine gives us this option so that should be fine.

 

[fatherofchill]

I'm confused as to why this isn't working but I'm still relatively new to this engine:

• trusty block
  • Events
    • Game - DamageEvent becomes Equal to 1.00
  • Conditions
    • (DamageEventTarget has buff Trusty Block ) Equal to True
    • DamageEventAmount Less than or equal to 300.00
  • Actions
    • Custom script: set DamageEngine_inception = true
    • Set VariableSet DamageEventAmount = 0.00
    • Special Effect - Create a special effect attached to the overhead of DamageEventTarget using Abilities\Spells\Human\Defend\DefendCaster.mdl
    • Special Effect - Destroy (Last created special effect)

The purpose is to block any damage below 300 while the buff is on.

 

[Bribe]

You don't need "set DamageEngine_inception = true" and I'm not sure why you're using it.

Additionally, setting the DamageEventAmount to 0.00 needs to be done from DamageModifierEvent - 1.00.

When you fully nullify the amount, however, you'll want to set DamageEventOverride to True.

 

[Map Designer]

Whats with the damage_inception? Why is it in custom script and why would you want to use it? Its says its only for advanced users so I would not use it.

 

[Bribe]

Whats with the damage_inception? Why is it in custom script and why would you want to use it? Its says its only for advanced users so I would not use it.

I only made it for @SpasMaster as his project has a lot of overlapping damage which uses controlled recursive events.

 

[fatherofchill]

You don't need "set DamageEngine_inception = true" and I'm not sure why you're using it.

Additionally, setting the DamageEventAmount to 0.00 needs to be done from DamageModifierEvent - 1.00.

When you fully nullify the amount, however, you'll want to set DamageEventOverride to True.

Thank you! I appreciate it.

 

[PlaidThief]

I hope someone can help me. Everything works fine, but i cant get the "healing event" to work. The DamageEvent dont fires with a negative Damage. I have a fresh (actual 5.5.0) copy from the Engine(Map). I need only a few green Numbers on my map .

Damage Tag
Events
Game - DamageEvent becomes Equal to 1.00
Conditions
Actions
Game - Display to (All players) the text: (damage: + (String(DamageEventAmount)))

Works with Damage but you dont get negative numbers on healing.

 

[Bribe]

I hope someone can help me. Everything works fine, but i cant get the "healing event" to work. The DamageEvent dont fires with a negative Damage. I have a fresh (actual 5.5.0) copy from the Engine(Map). I need only a few green Numbers on my map .

Damage Tag
Events
Game - DamageEvent becomes Equal to 1.00
Conditions
Actions
Game - Display to (All players) the text: (damage: + (String(DamageEventAmount)))

Works with Damage but you dont get negative numbers on healing.

DamageEvent does not detect healing. In fact, nothing properly does. Heal Event KIND OF detects healing, but it lacks source tracking unless you trigger it.

 

[PlaidThief]

Thanks for your reply. Then i have to make it

The presentation, Screens and Forum answers above, have suggested that this is possible with this DamageEngine 5.5.

Nevertheless its a good "round" work. Thanks for that.

 

[Bribe]

Thanks for your reply. Then i have to make it

The presentation, Screens and Forum answers above, have suggested that this is possible with this DamageEngine 5.5.

Nevertheless its a good "round" work. Thanks for that.

Damage Engine just supports converting a damage value into one that heals, but Heal Event (in my signature) allows you to detect when a unit's life jumps from something like a Priest's heal or even detects rapid regeneration like Rejuvenation.

 

[Bribe]

Update to 5.6.0.0:

Rewrote a significant amount of the internal code so that struct and GUI syntax both work - and are synchronized with each other. vJass-exclusive users can disable the GUI synchronization if they don't use any GUI damage events in their maps.

Four new variables must be added to your variable editor:

• boolean NextDamageIsAttack
• boolean NextDamageIsMelee
• boolean NextDamageIsRanged
• integer NextDamageWeaponT

Struct syntax should not need too much introduction - Damage.index is the triggering event ID, and the syntax is Damage.index.amount/source/target/etc. To initialize a JASS damage event, use:

function RegisterDamageEvent takes code c, string eventName, real value returns nothing

The string is simplified: "Modifier", "" (for simple DamageEvent), "After", "Lethal", "AOE"

Finally, a neat QOL improvement is that I have assigned weight to each of the events.

Here are the highlights:

DamageModifierEvent 2 and 3 are not important anymore (but still work exactly as they did before). However, you can now control MUCH more detail in terms of order. You can even do DamageModifierEvent becomes Equal to 0.50 or 1.50 for an event that runs before, and after (respectively) than the standard 1.00 event. It can be fine tuned to 1.01, 1.02, etc. if you really want to be specific.

DamageModiferEvents at 4.00 and higher will run after armor and Warcraft 3 shields are calculated. This marks no change to the way existing maps employ the event, but allows far greater control over the post-armor process and now you can use crazy numbers like 420.69 (nice) for marking very low priority events.

DamageEvent becomes Equal to 0.00 now registers the 0 damage event, but I've kept 2.00 around for backwards compatibility (because I absolutely appreciate backwards compatibility when possible). Anything not equal to 2.00 or 0.00 will register as a DamageEvent with a user-specified priority (so yes, even 420.69 works here too).

Speaking of, any event previously limited to 1.00 will now allow ANY value ro be registered. So LethalDamageEvent set at 0.00 would have a significantly higher priority than 420.69.

Nice, right?

 

[GaLaxY_256]

Hello sir Bribe, which one should I use for 1.31 patch (I can't update patch since I use limited data). I mean 3.8 is good but I also want to use 5.0+ features too

 

[Bribe]

Hello sir Bribe, which one should I use for 1.31 patch (I can't update patch since I use limited data). I mean 3.8 is good but I also want to use 5.0+ features too

I think this should work on 1.31, so it's worth a shot.

 

[MichaelSieger]

Hi
first of all, great script, allowed me to do a couple things which seemed either way too complicated to make sure they wouldnt be abusable or outright impossible.

but as always, if a user makes an account just to post; there must be a problem and it seems to be one i couldnt find the solution to after browsing this thread -admittedly not all 60+ pages of it-

im trying to apply extra spell damage on hit while the unit is affected by a specific buff, which is (or seemed at least) easy enough on its own and works most of the time... other than when another unit is dealing damage with immolation (ability based on immolation but same deal, so its just immolation) at the same time; to specify, it doesnt work at all if immolation from another unit is going, they do not have to be dealing damage to the same target.

im sure im just missing some sort of variable i should be keeping track of

(oh, and im working in gui)

5/5 work on the script though, Bribe, really thanks for it!

 

[SpasMaster]

im trying to apply extra spell damage on hit

What do you refer to as "on-hit"? Auto-attack? Dealing damage from any source? Dealing damage with a specific spell?
Do you want the original damage instance to be modified or to have it cause a separate damage instance?

other than when another unit is dealing damage with immolation (ability based on immolation but same deal, so its just immolation) at the same time

So if I understand correctly, you want a unit to deal extra damage to units, while that same unit is affected by a buff other than immolation?

I am willing to help you out and give you some direction, but you must be a bit more clear and specific with what you want to do exactly.

 

[MichaelSieger]

What do you refer to as "on-hit"? Auto-attack? Dealing damage from any source? Dealing damage with a specific spell?
Do you want the original damage instance to be modified or to have it cause a separate damage instance?

Hello
ill clarify, and apologies if it wasnt clear at first. then ill also include some findings because i managed to actually overcome the issue a bit earlier today, but in an unconventional way

• EleMasteryOnhit
  • Events
    • Game - DamageEvent becomes Equal to 1.00
  • Conditions
    • DamageEventSource Equal to uSham
    • (uSham has buff Elemental Force ) Equal to True
    • IsDamageMelee Equal to True
  • Actions
    • If ((Level of Elemental Mastery for uSham) Equal to 1) then do (Unit - Cause uSham to damage DamageEventTarget, dealing 70.00 damage of attack type Spells and damage type Lightning) else do (Unit - Cause uSham to damage DamageEventTarget, dealing 140.00 damage of attack type Spells and damage type Lightning)

its a plain trigger i know, as im not well versed in damage engine yet, however it works.
the further clarification then, based on the trigger shown: buff on unit from skill -> unit damages something with a regular right-click -> should do 70 or 140 extra spell damage based on level of ability that provides the buff

the ability is there, buff is there, all those conditions are fine.

anyway, as i said the issue has been overcome by reverting my damage engine back to 5.5.0.0 as this worked there, and despite not touching the trigger at all, if i upgrade to 5.6.0.1, weird things start happening

on to those weird things i noticed:

• the first hit from the unit never fires the trigger, i noticed this while trying to debug. if the unit satisfies all conditions, and attacks, nothing happens. however, starting from the second hit, the trigger fires every single time as it is supposed to, and the bonus damage is applied... until...
• theres anything else at all doing damage; at first i thought it was only immolate being used somewhere was what was causing the problem, but this proved to be false. i put another 4 completely standard units on the map to attack something to test (2 knights, 2 huntresses), then right-clicked different enemies on all of them. the trigger becomes inconsistent, and sometimes the bonus spell damage is applied when the main unit's attacks connect, sometimes it isnt
• if immolate is in effect (tested it with stock immolate, only increased the aoe so it can hit more), it fully stops the bonus damage from getting applied

all this weirdness only occurs if im on 5.6.0.1, downgrading to 5.5.0.0 immediately fixes every issue, and everything works perfectly as it should

if theres any insight on how i should change the trigger if i wish to upgrade to 5.6.0.1 because im missing something, some change in functionality, im open to it; otherwise i can just stay on 5.5.0.0, but i wanted to report my findings nonetheless

thank you again

 

[AGD]

Finally, a neat QOL improvement is that I have assigned weight to each of the events.

Here are the highlights:

DamageModifierEvent 2 and 3 are not important anymore (but still work exactly as they did before). However, you can now control MUCH more detail in terms of order. You can even do DamageModifierEvent becomes Equal to 0.50 or 1.50 for an event that runs before, and after (respectively) than the standard 1.00 event. It can be fine tuned to 1.01, 1.02, etc. if you really want to be specific.

DamageModiferEvents at 4.00 and higher will run after armor and Warcraft 3 shields are calculated. This marks no change to the way existing maps employ the event, but allows far greater control over the post-armor process and now you can use crazy numbers like 420.69 (nice) for marking very low priority events.

DamageEvent becomes Equal to 0.00 now registers the 0 damage event, but I've kept 2.00 around for backwards compatibility (because I absolutely appreciate backwards compatibility when possible). Anything not equal to 2.00 or 0.00 will register as a DamageEvent with a user-specified priority (so yes, even 420.69 works here too).

Speaking of, any event previously limited to 1.00 will now allow ANY value ro be registered. So LethalDamageEvent set at 0.00 would have a significantly higher priority than 420.69.

Nice, right?

Cool idea

 

[Bribe]

Hello
ill clarify, and apologies if it wasnt clear at first. then ill also include some findings because i managed to actually overcome the issue a bit earlier today, but in an unconventional way

• EleMasteryOnhit
  • Events
    • Game - DamageEvent becomes Equal to 1.00
  • Conditions
    • DamageEventSource Equal to uSham
    • (uSham has buff Elemental Force ) Equal to True
    • IsDamageMelee Equal to True
  • Actions
    • If ((Level of Elemental Mastery for uSham) Equal to 1) then do (Unit - Cause uSham to damage DamageEventTarget, dealing 70.00 damage of attack type Spells and damage type Lightning) else do (Unit - Cause uSham to damage DamageEventTarget, dealing 140.00 damage of attack type Spells and damage type Lightning)

its a plain trigger i know, as im not well versed in damage engine yet, however it works.
the further clarification then, based on the trigger shown: buff on unit from skill -> unit damages something with a regular right-click -> should do 70 or 140 extra spell damage based on level of ability that provides the buff

the ability is there, buff is there, all those conditions are fine.

anyway, as i said the issue has been overcome by reverting my damage engine back to 5.5.0.0 as this worked there, and despite not touching the trigger at all, if i upgrade to 5.6.0.1, weird things start happening

on to those weird things i noticed:

• the first hit from the unit never fires the trigger, i noticed this while trying to debug. if the unit satisfies all conditions, and attacks, nothing happens. however, starting from the second hit, the trigger fires every single time as it is supposed to, and the bonus damage is applied... until...
• theres anything else at all doing damage; at first i thought it was only immolate being used somewhere was what was causing the problem, but this proved to be false. i put another 4 completely standard units on the map to attack something to test (2 knights, 2 huntresses), then right-clicked different enemies on all of them. the trigger becomes inconsistent, and sometimes the bonus spell damage is applied when the main unit's attacks connect, sometimes it isnt
• if immolate is in effect (tested it with stock immolate, only increased the aoe so it can hit more), it fully stops the bonus damage from getting applied

all this weirdness only occurs if im on 5.6.0.1, downgrading to 5.5.0.0 immediately fixes every issue, and everything works perfectly as it should

if theres any insight on how i should change the trigger if i wish to upgrade to 5.6.0.1 because im missing something, some change in functionality, im open to it; otherwise i can just stay on 5.5.0.0, but i wanted to report my findings nonetheless

thank you again

The new patch has much more aggressive gatekeeping for detecting damage from code, so it's likely that your map has at least one runaway instance that sets NextDamageType without actually damaging anything afterward.

I could do some ugly tooling to loosely patch up user errors like this with a periodic timer, but my recommendation instead would be to use the Object Manager (press F11) to find all uses of that integer variable and make sure it's not being used incorrectly somewhere.

 

[MichaelSieger]

The new patch has much more aggressive gatekeeping for detecting damage from code, so it's likely that your map has at least one runaway instance that sets NextDamageType without actually damaging anything afterward.

I could do some ugly tooling to loosely patch up user errors like this with a periodic timer, but my recommendation instead would be to use the Object Manager (press F11) to find all uses of that integer variable and make sure it's not being used incorrectly somewhere.

Sorry, but i have no idea what you just said to me
either you misunderstood me, or i just dont understand what the post is supposed to mean; and i think its likely the second option, so what integer exactly are you referecing?

 

[Bribe]

Sorry, but i have no idea what you just said to me
either you misunderstood me, or i just dont understand what the post is supposed to mean; and i think its likely the second option, so what integer exactly are you referecing?

The integer "NextDamageType". Check if you use it anywhere in your code. Or if you PM me your map I can check your code for you.

 

[MichaelSieger]

The integer "NextDamageType". Check if you use it anywhere in your code. Or if you PM me your map I can check your code for you.

No, i do not use that variable anywhere

anyway, i threw together a test map because it took 10 minutes to do to show off what i mean, and i think at this point you could treat this is a legitimate bug report even and not really an issue with my map, unless the trigger i already posted before is somehow faulty.

about this test map, all the modifications i did:

• in the object editor:
  • changed immolation to 400 aoe
  • created custom grunt unit with 9000 health, fleeing off, attacks off, 0 hp regen
• in the trigger editor:
  • added dds 5.6.0.1
  • created one global variable named hero
  • created two triggers which are the following

• init
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Set VariableSet hero = Mountain King 0000 <gen>
    • Player - Make Player 1 (Red) treat Player 2 (Blue) as an Enemy
    • Player - Make Player 2 (Blue) treat Player 1 (Red) as an Ally
    • Player - Set the current research level of Priest Adept Training to 2 for Player 1 (Red)

• dmg
  • Events
    • Game - DamageEvent becomes Equal to 1.00
  • Conditions
    • IsDamageMelee Equal to True
    • DamageEventSource Equal to hero
    • (hero has buff Inner Fire) Equal to True
  • Actions
    • Unit - Cause hero to damage DamageEventTarget, dealing 1500.00 damage of attack type Spells and damage type Magic

there's nothing else that has been done other than what you see in the following video to showcase the issue i've been trying to relentlessly communicate:

ddstest - Streamable

 

[Bribe]

Update to 5.6.1.0 -

Patchworkon Melee/Ranged detection, recursion tracking. Also added the ability to modify damage from a DamageEvent to both make it easier on beginners as well as open up variety for those who may want to branch out with their damage flow options.


@MichaelSieger this fixes the issue you brought to my attention as I was able to reproduce it, then I was able to find out why and resolve why it was happening.

Due to this being primarily a bug fix, this is recommended for all users on 5.6 and later.

 

[MichaelSieger]

Update to 5.6.1.0 -

Patchworkon Melee/Ranged detection, recursion tracking. Also added the ability to modify damage from a DamageEvent to both make it easier on beginners as well as open up variety for those who may want to branch out with their damage flow options.


@MichaelSieger this fixes the issue you brought to my attention as I was able to reproduce it, then I was able to find out why and resolve why it was happening.

Due to this being primarily a bug fix, this is recommended for all users on 5.6 and later.

Did some testing again with a bit more than just a very simple trigger, and it seems to be working flawlessly now, thank you

 

[Ugabunda]

Hi Bribe,

I'm trying to use your Engine because sometimes I want to set the damage to 0 before it reaches my hero (I understand that your engine can do that, unlike GUI Friendly Damage Detection which "just" recognizes the damage after it is done). Unfortunately I'm getting many conflicts with other libraries / JASS spells which I imported and I don't know how to solve this.

Is this something you can maybe help with?

If yes, attached the map (sorry it's quite big due to reforged and 256x256 icons I imported). Cheers!

 

[Bribe]

Hi Bribe,

I'm trying to use your Engine because sometimes I want to set the damage to 0 before it reaches my hero (I understand that your engine can do that, unlike GUI Friendly Damage Detection which "just" recognizes the damage after it is done). Unfortunately I'm getting many conflicts with other libraries / JASS spells which I imported and I don't know how to solve this.

Is this something you can maybe help with?

If yes, attached the map (sorry it's quite big due to reforged and 256x256 icons I imported). Cheers!

Hi Ugabunda,

This will depend on whether those others are doing damage processing of their own. If so, you'll need to let me know what systems they are (ie. If they use a different Damage Engine).

I'm unable to use the Test Map feature currently as it keeps defaulting to this weird menu when Warcraft 3 starts and it's rather daunting for me to try to figure out why.

 

[Ugabunda]

Hi Ugabunda,

This will depend on whether those others are doing damage processing of their own. If so, you'll need to let me know what systems they are (ie. If they use a different Damage Engine).

I'm unable to use the Test Map feature currently as it keeps defaulting to this weird menu when Warcraft 3 starts and it's rather daunting for me to try to figure out why.

I think this happens precisely because Damage Engine currently conflicts with the others (my previously attached Map also defaults to the menu in WC3 Reforged when I have code errors). I attached a map which opens with the newest Reforged Client (meaning I deleted Damage Engine there). Does this work?

And not sure if this will help, but the current libraries I have in the map are:
- xebasic
- xedamage
- T32
- SimError
- TimerUtils
- Group Utils
- Illusion
- DamageEvent (by Flux)
- DamageModify (by Flux)
- GUI Friendly Damage Detection

The error is:
1. Identifier redeclared : "Damage"
2. ---- (previously declared here)

(I'm sure once you solve these other errors will pop up...)


Let me please know if you are able to open this map - If not I will attach the code from the above libraries individually.

 

[Bribe]

The two systems by Flux cannot coexist with Damage Engine. If you link me those two systems I can write up some compatibility scripts to make it plug in directly into Damage Engine.

 

[Ugabunda]

That would be superb. See here the original thread:
[vJASS] - DamagePackage

Or attached as text file for the latest version 1.44 (in case you can't open his map)

Thank you in advance!

 

[Bribe]

5.6.2.0 - Fixed a bug with Damage modification and laid groundwork for a bunch of optional vJass compatibility addons.

recommended for all users.

@Ugabunda I have just posted in Flux's thread a compatibility script. You can delete both of those libraries and replace them with my short plugin script.

 

[SinisterLuffy]

@Bribe Do you still have the latest version of damage engine that is compatible with non-Reforged patch?
The link in the description goes no where, even though it is highlighted.

 

[Av3n]

So... I've encountered a strange bug with 5.6.2.0 (as well as 5.6.1.0). There are instances where using a dummy unit to cast a spell on a target in a "udg_DamageEvent" block completely prevents the damage instance. I don't think I've encountered this issue with Damage Engine 5.4.2.3 based on player reports...

I have attached an MWE with the latest version of Damage Engine + an on-hit slow effect cast by a dummy unit. Notice after a few auto-attacks of applying the on-hit slow effect, damage stops registering on the Peasants.

 

[Bribe]

So... I've encountered a strange bug with 5.6.2.0 (as well as 5.6.1.0). There are instances where using a dummy unit to cast a spell on a target in a "udg_DamageEvent" block completely prevents the damage instance. I don't think I've encountered this issue with Damage Engine 5.4.2.3 based on player reports...

I have attached an MWE with the latest version of Damage Engine + an on-hit slow effect cast by a dummy unit. Notice after a few auto-attacks of applying the on-hit slow effect, damage stops registering on the Peasants.

Can you please try it from a DamageModifierEvent or AfterDamageEvent and let me know if you get along better with one of those?

@Bribe Do you still have the latest version of damage engine that is compatible with non-Reforged patch?
The link in the description goes no where, even though it is highlighted.

I just fixed that thanks. But I think all you need to do to make it work with 1.31 is add this to the top of the DamageEngine library:

function BlzGetEventIsAttack takes nothing returns boolean
   return BlzGetEventDamageType() == DAMAGE_TYPE_NORMAL
endfunction

@Ugabunda make sure Weep's library is replaced with the DamageEngine compatibility version as well.

 

[Ugabunda]

@Ugabunda I have just posted in Flux's thread a compatibility script. You can delete both of those libraries and replace them with my short plugin script.

@Ugabunda make sure Weep's library is replaced with the DamageEngine compatibility version as well.

Thank you! I did the following:

1) C&P Damage Engine to my map
2) Delete DamageEvent (from Flux)
3) Delete DamageModify (from Flux)
4) Delete GUI Friendly Damage Detection
4) Add a trigger function with the compatibility patch for Flux's Damage System
5) Add a trigger function with the compatibility patch for Weep's GDD

Unfortuntely still getting an error, this time it's the "ilusion" library, I just checked it and it's also by Flux:
[vJASS] - [System] Illusion

Error:
Line 3349: Missing requirement: DamageEvent (libraries cannot require scopes)

Probably also needs a compatibility patch, sorry for this...

 

[FUJI]

Hey Bribe,

I'm hesitating to use this on my next upcoming resources that would surely involve damage detection,
It seems like Damage Engine 3.8 is my only option. However, is the 3.8's API safe to use and would not
cause compatibility issues to reforged users that have Damage Engine 5+ in their maps?

Or there are things that I should consider?

 

[Av3n]

Can you please try it from a DamageModifierEvent or AfterDamageEvent and let me know if you get along better with one of those?

I can confirm in the MWE that only AfterDamageEvent doesn't prevent damage from registering. When I apply the adjustment to the map I'm working on, the FPS drops significantly after a few auto-attacks.

I'll look into figuring out what causes this. Then, I'll incorporate in the MWE.

 

[Bribe]

Hey Bribe,

I'm hesitating to use this on my next upcoming resources that would surely involve damage detection,
It seems like Damage Engine 3.8 is my only option. However, is the 3.8's API safe to use and would not
cause compatibility issues to reforged users that have Damage Engine 5+ in their maps?

Or there are things that I should consider?

If you're just using basic things no, but you'd be missing out on the plethora of useful features which have been released since then.

Thank you! I did the following:

1) C&P Damage Engine to my map
2) Delete DamageEvent (from Flux)
3) Delete DamageModify (from Flux)
4) Delete GUI Friendly Damage Detection
4) Add a trigger function with the compatibility patch for Flux's Damage System
5) Add a trigger function with the compatibility patch for Weep's GDD

Unfortuntely still getting an error, this time it's the "ilusion" library, I just checked it and it's also by Flux:
[vJASS] - [System] Illusion

Error:
Line 3349: Missing requirement: DamageEvent (libraries cannot require scopes)

Probably also needs a compatibility patch, sorry for this...

Have the Illusion resource require DamageEngine instead of DamageEvent in that case.

 

[Ugabunda]

Have the Illusion resource require DamageEngine instead of DamageEvent in that case.

Ahhh I did the process again and I think I did a mistake before, because I'm no longer getting the "Missing requirement: DamageEvent" error. But, I have now this error...:

"source is not an static member of damage" --- referring to the line
"if IsUnitInGroup(Damage.source, thistype.g) then"

Does your compatibility patch in FLux's page include a patch for "DamageModify" - or is it just for DamageEvent?

In the Illusion Library Flux writes that Illusion needs both DamageModify and DamageEvent, so maybe it's related to this?

 

[Bribe]

Ahhh I did the process again and I think I did a mistake before, because I'm no longer getting the "Missing requirement: DamageEvent" error. But, I have now this error...:

"source is not an static member of damage" --- referring to the line
"if IsUnitInGroup(Damage.source, thistype.g) then"

Does your compatibility patch in FLux's page include a patch for "DamageModify" - or is it just for DamageEvent?

In the Illusion Library Flux writes that Illusion needs both DamageModify and DamageEvent, so maybe it's related to this?

Hmmm, I will have to test that tonight. I'm wondering if I can include both a static member and a dynamic member alike and see if that works.

Otherwise those lines would have to be Damage.index.source/target. You can use this script:

library Illusion /*

                         Illusion v1.34
                            by Flux, edited by Bribe to work with Damage Engine 5.6.2.0
       
            Allows easy creation of Illusion with any damage factor.
 
    */ requires DamageEngine /*
    https://www.hiveworkshop.com/threads/damage-engine-5-6-2-0.201016
    Required to manipulate damage given and damage taken by illusions.
 
 
    */ optional Table /*
    If not found, the system will create a hashtable. You cannot create more than 256 hashtable
    per map.

 
    ********************************************************************************
    *************************************** API ************************************
    ********************************************************************************
 
    Illusion.create(player, unitSource, x, y)
        - Create an Illusion based on <unitsource>, owned by <player>, positioned at (<x>, <y>)
   
    this.duration = <timedlife>
        - Add a timer to an illusion.
        - Cannot be overwritten once set.
   
    Illusion.get(unit)
        - Return the 'Illusion instance' based on <unit> parameter.
     
    this.unit
        - Refers to the actual illusion unit
   
    this.damageGiven
        - Determines damage dealt factor.
   
    this.damageTaken
        - Determines damage received factor.
 
 
    CREDITS:
        Bribe         - Table, DamageEngine
   
*/
    //===================================================================
    //========================= CONFIGURATION ===========================
    //===================================================================
    globals
        //Rawcode of Illusion Ability based on "Item Illusions"
        private constant integer ILLUSION_SPELL = 'A028'
   
        private constant integer DUMMY_ID = 'u005'
   
        private constant integer REFRESH_COUNT = 30
        //Dummy unit owner
        private constant player DUMMY_OWNER = Player(PLAYER_NEUTRAL_PASSIVE)
    endglobals
    //===================================================================
    //======================= END CONFIGURATION =========================
    //===================================================================
 
    native UnitAlive takes unit u returns boolean
 
    struct Illusion
   
        readonly unit unit
        public real damageTaken
        public real damageGiven
   
        static if LIBRARY_Table then
            private static Table tb
        else
            private static hashtable hash = InitHashtable()
        endif
   
        private static trigger deathTrg = CreateTrigger()
        private static group g = CreateGroup()
        private static timer t = CreateTimer()
        private static integer count = 0
        private static unit dummy
        private static unit illu
   
        static method get takes unit u returns thistype
            static if LIBRARY_Table then
                return thistype.tb[GetHandleId(u)]
            else
                return LoadInteger(thistype.hash, GetHandleId(u), 0)
            endif
        endmethod
   
        private static method reAdd takes nothing returns nothing
            call TriggerRegisterUnitEvent(thistype.deathTrg, GetEnumUnit(), EVENT_UNIT_DEATH)
        endmethod
   
        private static method onDeath takes nothing returns boolean
            call thistype(thistype.get(GetTriggerUnit())).destroy()
            return false
        endmethod
   
        method destroy takes nothing returns nothing
            if UnitAlive(this.unit) then
                call KillUnit(this.unit)
            endif
            static if LIBRARY_Table then
                call thistype.tb.remove(GetHandleId(this.unit))
            else
                call RemoveSavedInteger(thistype.hash, GetHandleId(this.unit), 0)
            endif
            call GroupRemoveUnit(thistype.g, this.unit)
            //Death trigger refresh
            set thistype.count = thistype.count + 1
            if thistype.count >= REFRESH_COUNT then
                call DestroyTrigger(thistype.deathTrg)
                set thistype.deathTrg = CreateTrigger()
                call TriggerAddCondition(thistype.deathTrg, Condition(function thistype.onDeath))
                call ForGroup(thistype.g, function thistype.reAdd)
                set thistype.count = 0
            endif
            set this.unit = null
            call this.deallocate()
        endmethod
   
   
        private static method onDamage takes nothing returns nothing
            //If source is illusion
            if IsUnitInGroup(Damage.index.source, thistype.g) then
                set Damage.index.amount = Damage.index.amount*thistype.get(Damage.index.source).damageGiven
            endif
            //If target is illusion
            if IsUnitInGroup(Damage.index.target, thistype.g) then
                set Damage.index.amount = Damage.index.amount*thistype.get(Damage.index.target).damageTaken
            endif
        endmethod
   
        private static method entered takes nothing returns boolean
            if GetSummoningUnit() == thistype.dummy then
                set thistype.illu = GetSummonedUnit()
            endif
            return false
        endmethod
   
        method operator duration= takes real time returns nothing
            call UnitApplyTimedLife(this.unit, 'BTLF', time)
        endmethod
   
        static method create takes player owner, unit source, real x, real y returns thistype
            local thistype this
            set thistype.illu = null
            //Create the Illusion Unit
            if source != null and UnitAlive(source) then
                call SetUnitX(thistype.dummy, GetUnitX(source))
                call SetUnitY(thistype.dummy, GetUnitY(source))
                call SetUnitOwner(thistype.dummy, GetOwningPlayer(source), false)
                if IssueTargetOrderById(thistype.dummy, 852274, source) then
                    if thistype.illu != null then
                        call SetUnitOwner(thistype.illu, owner, true)
                        if IsUnitType(source, UNIT_TYPE_STRUCTURE) then
                            call SetUnitPosition(thistype.illu, x, y)
                        else
                            call SetUnitX(thistype.illu, x)
                            call SetUnitY(thistype.illu, y)
                        endif
                    else
                        debug call DisplayTimedTextToPlayer(GetLocalPlayer(), 0, 0, 3600, "[Illusion] No illusion created")
                        call SetUnitOwner(thistype.dummy, DUMMY_OWNER, false)
                        return 0
                    endif
                else
                    debug call DisplayTimedTextToPlayer(GetLocalPlayer(), 0, 0, 3600, "[Illusion] Issued illusion create order failed")
                    call SetUnitOwner(thistype.dummy, DUMMY_OWNER, false)
                    return 0
                endif
                call SetUnitOwner(thistype.dummy, DUMMY_OWNER, false)
            else
                debug call DisplayTimedTextToPlayer(GetLocalPlayer(), 0, 0, 3600, "[Illusion] Source unit dead or non-existing")
                return 0
            endif
            //Initialize struct
            set this = thistype.allocate()
            set this.unit = thistype.illu
            set this.damageTaken = 1.0
            set this.damageGiven = 1.0
            call SetUnitAnimation(thistype.illu, "stand")
            call GroupAddUnit(thistype.g, this.unit)
            call TriggerRegisterUnitEvent(thistype.deathTrg, this.unit, EVENT_UNIT_DEATH)
            static if LIBRARY_Table then
                set thistype.tb[GetHandleId(this.unit)] = this
            else
                call SaveInteger(thistype.hash, GetHandleId(this.unit), 0, this)
            endif
            set thistype.illu = null
            return this
        endmethod
   
        private static method onInit takes nothing returns nothing
            local trigger t = CreateTrigger()
            set thistype.dummy = CreateUnit(DUMMY_OWNER, DUMMY_ID, 0, 0, 0)
            call TriggerRegisterAnyUnitEventBJ(t,EVENT_PLAYER_UNIT_SUMMON)
            call TriggerAddCondition(t, Condition(function thistype.entered))
            call TriggerAddCondition(thistype.deathTrg, Condition(function thistype.onDeath))
            call UnitAddAbility(thistype.dummy, ILLUSION_SPELL)
            static if LIBRARY_Table then
                set thistype.tb = Table.create()
            endif
            call RegisterDamageEvent(function thistype.onDamage, "Modifier", 1.00)
        endmethod
   
    endstruct
 
endlibrary

 

[Ugabunda]

Hmmm, I will have to test that tonight. I'm wondering if I can include both a static member and a dynamic member alike and see if that works.

Otherwise those lines would have to be Damage.index.source/target. You can use this script:

library Illusion /*

                         Illusion v1.34
                            by Flux, edited by Bribe to work with Damage Engine 5.6.2.0
       
            Allows easy creation of Illusion with any damage factor.
 
    */ requires DamageEngine /*
    https://www.hiveworkshop.com/threads/damage-engine-5-6-2-0.201016
    Required to manipulate damage given and damage taken by illusions.
 
 
    */ optional Table /*
    If not found, the system will create a hashtable. You cannot create more than 256 hashtable
    per map.

 
    ********************************************************************************
    *************************************** API ************************************
    ********************************************************************************
 
    Illusion.create(player, unitSource, x, y)
        - Create an Illusion based on <unitsource>, owned by <player>, positioned at (<x>, <y>)
   
    this.duration = <timedlife>
        - Add a timer to an illusion.
        - Cannot be overwritten once set.
   
    Illusion.get(unit)
        - Return the 'Illusion instance' based on <unit> parameter.
     
    this.unit
        - Refers to the actual illusion unit
   
    this.damageGiven
        - Determines damage dealt factor.
   
    this.damageTaken
        - Determines damage received factor.
 
 
    CREDITS:
        Bribe         - Table, DamageEngine
   
*/
    //===================================================================
    //========================= CONFIGURATION ===========================
    //===================================================================
    globals
        //Rawcode of Illusion Ability based on "Item Illusions"
        private constant integer ILLUSION_SPELL = 'A028'
   
        private constant integer DUMMY_ID = 'u005'
   
        private constant integer REFRESH_COUNT = 30
        //Dummy unit owner
        private constant player DUMMY_OWNER = Player(PLAYER_NEUTRAL_PASSIVE)
    endglobals
    //===================================================================
    //======================= END CONFIGURATION =========================
    //===================================================================
 
    native UnitAlive takes unit u returns boolean
 
    struct Illusion
   
        readonly unit unit
        public real damageTaken
        public real damageGiven
   
        static if LIBRARY_Table then
            private static Table tb
        else
            private static hashtable hash = InitHashtable()
        endif
   
        private static trigger deathTrg = CreateTrigger()
        private static group g = CreateGroup()
        private static timer t = CreateTimer()
        private static integer count = 0
        private static unit dummy
        private static unit illu
   
        static method get takes unit u returns thistype
            static if LIBRARY_Table then
                return thistype.tb[GetHandleId(u)]
            else
                return LoadInteger(thistype.hash, GetHandleId(u), 0)
            endif
        endmethod
   
        private static method reAdd takes nothing returns nothing
            call TriggerRegisterUnitEvent(thistype.deathTrg, GetEnumUnit(), EVENT_UNIT_DEATH)
        endmethod
   
        private static method onDeath takes nothing returns boolean
            call thistype(thistype.get(GetTriggerUnit())).destroy()
            return false
        endmethod
   
        method destroy takes nothing returns nothing
            if UnitAlive(this.unit) then
                call KillUnit(this.unit)
            endif
            static if LIBRARY_Table then
                call thistype.tb.remove(GetHandleId(this.unit))
            else
                call RemoveSavedInteger(thistype.hash, GetHandleId(this.unit), 0)
            endif
            call GroupRemoveUnit(thistype.g, this.unit)
            //Death trigger refresh
            set thistype.count = thistype.count + 1
            if thistype.count >= REFRESH_COUNT then
                call DestroyTrigger(thistype.deathTrg)
                set thistype.deathTrg = CreateTrigger()
                call TriggerAddCondition(thistype.deathTrg, Condition(function thistype.onDeath))
                call ForGroup(thistype.g, function thistype.reAdd)
                set thistype.count = 0
            endif
            set this.unit = null
            call this.deallocate()
        endmethod
   
   
        private static method onDamage takes nothing returns nothing
            //If source is illusion
            if IsUnitInGroup(Damage.index.source, thistype.g) then
                set Damage.index.amount = Damage.amount*thistype.get(Damage.index.source).damageGiven
            endif
            //If target is illusion
            if IsUnitInGroup(Damage.index.target, thistype.g) then
                set Damage.index.amount = Damage.amount*thistype.get(Damage.index.target).damageTaken
            endif
        endmethod
   
        private static method entered takes nothing returns boolean
            if GetSummoningUnit() == thistype.dummy then
                set thistype.illu = GetSummonedUnit()
            endif
            return false
        endmethod
   
        method operator duration= takes real time returns nothing
            call UnitApplyTimedLife(this.unit, 'BTLF', time)
        endmethod
   
        static method create takes player owner, unit source, real x, real y returns thistype
            local thistype this
            set thistype.illu = null
            //Create the Illusion Unit
            if source != null and UnitAlive(source) then
                call SetUnitX(thistype.dummy, GetUnitX(source))
                call SetUnitY(thistype.dummy, GetUnitY(source))
                call SetUnitOwner(thistype.dummy, GetOwningPlayer(source), false)
                if IssueTargetOrderById(thistype.dummy, 852274, source) then
                    if thistype.illu != null then
                        call SetUnitOwner(thistype.illu, owner, true)
                        if IsUnitType(source, UNIT_TYPE_STRUCTURE) then
                            call SetUnitPosition(thistype.illu, x, y)
                        else
                            call SetUnitX(thistype.illu, x)
                            call SetUnitY(thistype.illu, y)
                        endif
                    else
                        debug call DisplayTimedTextToPlayer(GetLocalPlayer(), 0, 0, 3600, "[Illusion] No illusion created")
                        call SetUnitOwner(thistype.dummy, DUMMY_OWNER, false)
                        return 0
                    endif
                else
                    debug call DisplayTimedTextToPlayer(GetLocalPlayer(), 0, 0, 3600, "[Illusion] Issued illusion create order failed")
                    call SetUnitOwner(thistype.dummy, DUMMY_OWNER, false)
                    return 0
                endif
                call SetUnitOwner(thistype.dummy, DUMMY_OWNER, false)
            else
                debug call DisplayTimedTextToPlayer(GetLocalPlayer(), 0, 0, 3600, "[Illusion] Source unit dead or non-existing")
                return 0
            endif
            //Initialize struct
            set this = thistype.allocate()
            set this.unit = thistype.illu
            set this.damageTaken = 1.0
            set this.damageGiven = 1.0
            call SetUnitAnimation(thistype.illu, "stand")
            call GroupAddUnit(thistype.g, this.unit)
            call TriggerRegisterUnitEvent(thistype.deathTrg, this.unit, EVENT_UNIT_DEATH)
            static if LIBRARY_Table then
                set thistype.tb[GetHandleId(this.unit)] = this
            else
                call SaveInteger(thistype.hash, GetHandleId(this.unit), 0, this)
            endif
            set thistype.illu = null
            return this
        endmethod
   
        private static method onInit takes nothing returns nothing
            local trigger t = CreateTrigger()
            set thistype.dummy = CreateUnit(DUMMY_OWNER, DUMMY_ID, 0, 0, 0)
            call TriggerRegisterAnyUnitEventBJ(t,EVENT_PLAYER_UNIT_SUMMON)
            call TriggerAddCondition(t, Condition(function thistype.entered))
            call TriggerAddCondition(thistype.deathTrg, Condition(function thistype.onDeath))
            call UnitAddAbility(thistype.dummy, ILLUSION_SPELL)
            static if LIBRARY_Table then
                set thistype.tb = Table.create()
            endif
            call RegisterDamageEvent(function thistype.onDamage, "Modifier", 1.00)
        endmethod
   
    endstruct
 
endlibrary

Ok thanks. In case it helps: By replacing the illusion library with the code above, I'm getting now the following error:

"amount is not an static member of Damage" --- for line
set Damage.index.amount = Damage.amount*thistype.get(Damage.index.source).damageGiven

 

[Bribe]

Ok thanks. In case it helps: By replacing the illusion library with the code above, I'm getting now the following error:

"amount is not an static member of Damage" --- for line
set Damage.index.amount = Damage.amount*thistype.get(Damage.index.source).damageGiven

Sorry! I have fixed that in my post now

EDIT - hot off the press: @Nestharus 's incredibly complex Damage system, shortened into a myriad of wrapper functions (yes, Damage Engine has gotten THAT much better over the years). Granted, I removed a few things from the API because I didn't understand how or why they worked, but it should cover the bulk of usage cases. The enable/disable and specific unit stuff has been deliberately pruned out as there is not really a way to efficiently compensate for that in Damage Engine (and like many things made by Nestharus, efficiency was their only purpose).

library DDS requires DamageEngine

//Incorporates much of Nestharus's DDS's API to the best of my understanding of how it works.

private struct S extends array
    static constant integer SPELL    = 0
    static constant integer PHYSICAL = 1
    static constant integer CODE     = 2
endstruct

struct DDS extends array
 
    readonly static S Archetype = 0
 
    static method operator archetype takes nothing returns integer
        if udg_IsDamageCode then
            return DDS.Archetype.CODE
        elseif udg_IsDamageSpell then
            return DDS.Archetype.SPELL
        endif
        return DDS.Archetype.PHYSICAL
    endmethod

    static method operator damageCode= takes integer i returns nothing
        set udg_NextDamageType = udg_DamageTypeCode
    endmethod
    static method operator damageCode takes nothing returns integer
        return GetUnitUserData(udg_DamageEventTarget)
    endmethod

    static method operator source takes nothing returns unit
        return udg_DamageEventSource
    endmethod
    static method operator sourceId takes nothing returns integer
        return GetUnitUserData(udg_DamageEventSource)
    endmethod
 
    static method operator target takes nothing returns unit
        return udg_DamageEventTarget
    endmethod
    static method operator targetId takes nothing returns integer
        return GetUnitUserData(udg_DamageEventTarget)
    endmethod
 
    static method operator damage takes nothing returns real
        return Damage.index.amount
    endmethod
    static method operator damage= takes real r returns nothing
        set Damage.index.amount = r
    endmethod
 
    static method operator damageOriginal takes nothing returns real
        return udg_DamageEventPrevAmt
    endmethod

    static method operator damageModifiedAmount takes nothing returns real
        return Damage.index.amount - udg_DamageEventPrevAmt
    endmethod

    static method operator sourcePlayer takes nothing returns player
        return GetOwningPlayer(Damage.index.source)
    endmethod
 
    static method operator targetPlayer takes nothing returns player
        return GetOwningPlayer(Damage.index.target)
    endmethod
 
endstruct

module DAMAGE_EVENT_INTERFACE
 
  static if not thistype.onDamageBefore.exists and not thistype.onDamageAfter.exists then
  else
    private static method onInit takes nothing returns nothing
      static if thistype.onDamageBefore.exists then
        call RegisterDamageEvent(function thistype.onDamageBefore, "Modifier", 4.0)
      endif
      static if thistype.onDamageAfter.exists then
        call RegisterDamageEvent(function thistype.onDamageAfter, "Modifier", 4.1)
      endif
    endmethod
  endif
 
endmodule

endlibrary

EDIT2: This is probably my last one for the day. It's MOST OF Rising_Dusk's IDDS:

library IntuitiveDamageSystem requires DamageEngine
 
globals
    constant integer       DAMAGE_TYPE_ATTACK  = 100
    constant integer       DAMAGE_TYPE_IGNORED = 101
    constant integer       DAMAGE_TYPE_SPELL   = 102
    constant integer       DAMAGE_TYPE_EXTRA   = 103
endglobals

    function IgnoreHigherPriority takes nothing returns nothing
        set udg_DamageEventOverride = true
    endfunction
 
    function SetDamage takes real dmg returns nothing
        set Damage.index.amount = dmg //Unlike with IDDS this WILL actually change the damage dealt
    endfunction
 
    function GetTriggerDamageSource takes nothing returns unit
        return udg_DamageEventSource
    endfunction
    function GetTriggerDamageTarget takes nothing returns unit
        return udg_DamageEventTarget
    endfunction
    function GetTriggerDamageBase takes nothing returns real
        return udg_DamageEventPrevAmt
    endfunction
    function GetTriggerDamage takes nothing returns real
        return Damage.index.amount
    endfunction
 
    function GetTriggerDamageType takes nothing returns integer
        return udg_DamageEventType
    endfunction

    //Any codes which use the below two functions of IDDS need to add the number "2" to the end of the function name for compatibility
    function TriggerRegisterDamageEvent2 takes trigger t, integer priority returns nothing
        call TriggerRegisterDamageEvent(t, "Modifier", 4.00 + priority)
    endfunction
 
    //The below function will actually use both DamageEngine's defined types as well as those of IDDS itself.
    function UnitDamageTargetEx2 takes unit s, unit t, real d, attacktype at, integer dt, boolean ca returns nothing
        if dt == DAMAGE_TYPE_ATTACK then
            set udg_NextDamageIsAttack = true
        endif
        set udg_NextDamageType = dt
        if ca then
            set b = UnitDamageTarget(s, t, d, true, false, at, DAMAGE_TYPE_NORMAL, null)
        elseif dt == DAMAGE_TYPE_IGNORED then
            set b = UnitDamageTarget(s, t, d, true, false, at, DAMAGE_TYPE_UNKNOWN, null)
        else
            set b = UnitDamageTarget(s, t, d, true, false, at, DAMAGE_TYPE_UNIVERSAL, null)
        endif
    endfunction
 
endlibrary

For reference, here's Flux's DamagePackage:

library_once DamageEvent requires DamageEngine
endlibrary
library_once DamageModify uses DamageEvent
endlibrary

globals
    constant integer DAMAGE_TYPE_PHYSICAL = 1
    constant integer DAMAGE_TYPE_MAGICAL = 2
endglobals

//! textmacro DAMAGE_EVENT_PLUGIN_01

static method operator type takes nothing returns integer
    if udg_IsDamageSpell then
        return DAMAGE_TYPE_MAGICAL
    endif
    return DAMAGE_TYPE_PHYSICAL
endmethod

static method registerTrigger takes trigger t returns nothing
    call Damage.setupEventRobust(t, "udg_DamageEvent", 1.00, false)
endmethod
static method register takes code c returns nothing
    local trigger t = CreateTrigger()
    call TriggerAddCondition(t, Filter(c))
    call registerTrigger(t)
    set t = null
endmethod

static method registerModifierTrigger takes trigger t returns nothing
    call Damage.setupEventRobust(t, "udg_DamageModifierEvent", 1.00, false)
endmethod
static method registerModifier takes code c returns nothing
    local trigger t = CreateTrigger()
    call TriggerAddCondition(t, Filter(c))
    call registerTrigger(t)
    set t = null
endmethod

//! endtextmacro

FINAL(?) EDIT: Jesus4Lyf's legendary "Damage" system:

library Damage requires DamageEngine
 
    public function RegisterEvent takes trigger whichTrigger returns nothing
        call RegisterDamageEventTrigger(whichTrigger, "Modifier", 4.00)
    endfunction
 
    public function RegisterZeroEvent takes trigger whichTrigger returns nothing
        call RegisterDamageEventTrigger(whichTrigger, "", 0.00)
    endfunction
 
    public function GetType takes nothing returns damagetype
        return Damage.index.damageType
    endfunction
 
    public function IsAttack takes nothing returns boolean
        return udg_IsDamageAttack
    endfunction
 
    public function Block takes real amount returns nothing
        set Damage.index.amount = Damage.index.amount - amount
    endfunction
 
    public function BlockAll takes nothing returns nothing
        set Damage.index.amount = 0.00
    endfunction
 
    //! textmacro Damage__DealTypeFunc takes NAME, TYPE
        public function $NAME$ takes unit source, unit target, real amount returns boolean
            return UnitDamageTargetEx(source, target, amount, false, false, null, $TYPE$, null)
        endfunction
        public function Is$NAME$ takes nothing returns boolean
            return Damage.index.damageType == $TYPE$
        endfunction
    //! endtextmacro
 
    //! runtextmacro Damage__DealTypeFunc("Pure","DAMAGE_TYPE_UNIVERSAL")
    //! runtextmacro Damage__DealTypeFunc("Spell","DAMAGE_TYPE_MAGIC")
 
    public function Physical takes unit source, unit target, real amount, attacktype whichType, boolean attack, boolean ranged returns boolean
        return UnitDamageTargetEx(source, target, amount, attack, ranged, whichType, DAMAGE_TYPE_NORMAL, null)
    endfunction
    public function IsPhysical takes nothing returns boolean
        return Damage.index.damageType == DAMAGE_TYPE_NORMAL
    endfunction
 
endlibrary

 

[Ugabunda]

It's working! Thank you!

This is so amazing! A unit of 9999 dmg is hitting my hero and getting 0 damage even though my hero only has 500 hp

Do I have to reset the "Set VariableSet DamageEventAmount = 0" once I edit it?

 

[Bribe]

Just to give a preview of what's coming next, I've been searching around for other Damage libraries to write compatibility scripts for and - while I've been mostly successfuly - there are a few features that don't work.

1) I will be adding a Damage.enabled "variable" which will actually disable both damage event triggers when set to True and re-enable them when set to False. This will not interrupt the ongoing damage but will ensure the subsequent damage is ignored.

2) I will be adding an ability to un-register triggers (for whoever thinks that's a good idea)

3) I will be adding some more syntax sugar so you don't have to use Damage.index.source/target/amount and can just use Damage.source/target/amount if you want.

And one final mention, I've noticed an interesting feature that's gaining a bit of popularity, and that is to have embedded conditions into the damage library and have branching events off of those. Now this would normally be incredibly difficult to pull off in GUI with so many different events already in the system (DamageModifierEvent, DamageEvent, etc.) so what will I do? Make this a vJass-specific feature...

JUST KIDDING!

I love GUI and would never abandon it! Thanks to the magic of how DamageEngine hooks the GUI events, I bring to you this:

EQUAL                 // Any damage type permitted (no change to your code needed, it will work as it always has)
NOT_EQUAL             // Same as including IsDamageCode   Equal to True
GREATER_THAN          // Same as including IsDamageSpell  Equal to True
LESS_THAN             // Same as including IsDamageAttack Equal to True
GREATER_THAN_OR_EQUAL // Same as including IsDamageRanged Equal to True
LESS_THAN_OR_EQUAL    // Same as including IsDamageMelee  Equal to True

This will provide syntax like:

• Spell Damage Detector
  • Events
    • Game - DamageModifierEvent becomes Greater than 1
  • Conditions
    • -------- No conditions needed if IsDamageSpell was your only condition --------
  • Actions

• Melee Damage Detector
  • Events
    • Game - DamageEvent becomes Less than or Equal to 1
  • Conditions
    • -------- No conditions needed if IsDamageMelee was your only condition --------
  • Actions

See you guys in the near future with Damage Engine 5.7.0.0 !

 

[iansdoor]

Ah Snap. Here we go again. Thank you for the GUI update!

 

[Av3n]

Just an update on my investigation on the suspected bug I'm reporting...

So, using a dummy caster to cast a spell within a call TriggerRegisterVariableEvent(t, "udg_DamageEvent", EQUAL, 1.00 ) block will prevent one of the Damage Engine triggers to not fire ~ which inadvertently prevents the damage (based on the recursion prevention block with the call BlzSetEventDamage(0.)?). If you use the call TimerStart(..., 0., false, ...) delay trick, the damage registers, but an extra Damage Engine trigger seems to be called even though the damage deals no damage.

I'll need to look into why this is happening on Damage Engine 5.6.2.0, as it was not a problem with Damage Engine 5.4.2.3.

(NB: I'm still looking into the recursion issue on my actual map if I were to change it to "udg_AfterDamageEvent". Current version of my MWE attached to this post.)

 

[Bribe]

Just an update on my investigation on the suspected bug I'm reporting...

So, using a dummy caster to cast a spell within a call TriggerRegisterVariableEvent(t, "udg_DamageEvent", EQUAL, 1.00 ) block will prevent one of the Damage Engine triggers to not fire ~ which inadvertently prevents the damage (based on the recursion prevention block with the call BlzSetEventDamage(0.)?). If you use the call TimerStart(..., 0., false, ...) delay trick, the damage registers, but an extra Damage Engine trigger seems to be called even though the damage deals no damage.

I'll need to look into why this is happening on Damage Engine 5.6.2.0, as it was not a problem with Damage Engine 5.4.2.3.

(NB: I'm still looking into the recursion issue on my actual map if I were to change it to "udg_AfterDamageEvent". Current version of my MWE attached to this post.)

You have enabled the wrong debug message in Damage Engine. You need to enable the ones that say "first damage event running for " and "second damage event running for "

Additionally, the debug message about levelsDeep will tell you if Damage Engine has a recursion problem or if it's something else.

I've had a look at your map and can find no issues with the code, but Blizzard frustratingly again is not allowing me to use the Test Map function...

EDIT: the second event is caused by the "slow" debuff. It's a zero damage event made by WC3 and uses DAMAGE_TYPE_UNKNOWN.

As far as the recursion is concerned, it must be due to the AfterDamageEvent having a flaw with its recursion de-stacking process. I'll bundle the fix with DamageEngine 5.7 so stay tuned!

 

[Av3n]

EDIT: the second event is caused by the "slow" debuff. It's a zero damage event made by WC3 and uses DAMAGE_TYPE_UNKNOWN.

As far as the recursion is concerned, it must be due to the AfterDamageEvent having a flaw with its recursion de-stacking process. I'll bundle the fix with DamageEngine 5.7 so stay tuned!

That probably explains why the 0 second timer trick works then.

No worries and thanks for looking into it! I'm looking forward to the next release then~

(I do need to get familiar on which set of debug messages to enable to make my bug reporting more precise in the future. So thanks for the tip!)

 

[Bribe]

That probably explains why the 0 second timer trick works then.

No worries and thanks for looking into it! I'm looking forward to the next release then~

(I do need to get familiar on which set of debug messages to enable to make my bug reporting more precise in the future. So thanks for the tip!)

I have tested this further and cannot find any lag issues when dealing the additional damage from an AfterDamageEvent either. I am not sure what you had been doing that caused the lag but it is not anything I can reproduce.

 

[ZeroGravity]

So I haven't edited map for a while and noticed that the damage engine is updated so I wonder do I need to change anything for my damage trigger?

• Terror Aura Mannoroth Damage
  • Events
    • Game - DamageModifierEvent becomes Equal to 1.00
  • Conditions
    • IsDamageSpell Equal to False
    • (Level of Terror Aura (Mannoroth) for DamageEventSource) Greater than or equal to 1
  • Actions
    • Set VariableSet NextDamageType = DamageTypePure
    • Set VariableSet Real1 = (Real((Strength of DamageEventSource (Include bonuses))))
    • Set VariableSet Point1 = (Position of DamageEventTarget)
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units within 250.00 of Point1.) and do (Actions)
      • Loop - Actions
        • Set VariableSet TempUnit = (Picked unit)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (TempUnit belongs to an enemy of (Owner of DamageEventSource).) Equal to True
            • (TempUnit is alive) Equal to True
            • (TempUnit is A structure) Equal to False
          • Then - Actions
            • Unit - Cause DamageEventSource to damage TempUnit, dealing (((Real((Base Damage of DamageEventSource for weapon index 0))) x 0.50) + (Real1 x (0.50 x (Real((Level of Terror Aura (Mannoroth) for DamageEventSource)))))) damage of attack type Magic and damage type Normal
          • Else - Actions
    • Custom script: call RemoveLocation(udg_Point1)