Damage Engine 5.A.0.0

[Bribe]

Is there any way to detect damage to Destructibles or Items?

You can only detect when a unit is issued an order against one of those things, and when one of those things dies.

 

[Madmaze]

Is there any chance that someone still has a version of this that works for 1.31 (pre-reforged)? There seems to be a link for people like myself in the "requirements" section, but it doesn't send to anywhere useful... or maybe I missed something?

 

[trantrungho71]

Is there any chance that someone still has a version of this that works for 1.31 (pre-reforged)? There seems to be a link for people like myself in the "requirements" section, but it doesn't send to anywhere useful... or maybe I missed something?

you can still use the 5.9 version tho, but with a little bit of edit of BlzGetEventIsAttack() by adding this at the top of the Damage Engine script

function BlzGetEventIsAttack() takes nothing returns boolean
    return BlzGetEventDamageType() == DAMAGE_TYPE_NORMAL
endfunction

Or you can use the 3.A or 3.8 version here (as if you like)

 

[Madmaze]

you can still use the 5.9 version tho, but with a little bit of edit of BlzGetEventIsAttack() by adding this at the top of the Damage Engine script

function BlzGetEventIsAttack() takes nothing returns boolean
    return BlzGetEventDamageType() == DAMAGE_TYPE_NORMAL
endfunction

Or you can use the 3.A or 3.8 version here (as if you like)

I downloaded the 5.9 map today, but trying to open it in the editor gives me this error... Editor is version 1.31b (6072), downloaded from around here actually.

 

[trantrungho71]

I downloaded the 5.9 map today, but trying to open it in the editor gives me this error... Editor is version 1.31b (6072), downloaded from around here actually.

The newest map is saved on reforged editor so any editor version below wont able to open it, you may need some one had access to reforge to export the trigger data or you can manually copy from preview triggers.

 

[trantrungho71]

I downloaded the 5.9 map today, but trying to open it in the editor gives me this error... Editor is version 1.31b (6072), downloaded from around here actually.

Here the maps trigger data i exported, dunno will it able to import to .31

 

[Drake53]

The newest map is saved on reforged editor so any editor version below wont able to open it, you may need some one had access to reforge to export the trigger data or you can manually copy from preview triggers.

View attachment 406505

You can also use my tool: Map Adapter

Here the maps trigger data i exported, dunno will it able to import to .31

The triggers seem to be compatible with 1.31, but in the war3map.j I can see the map uses 'BlzGetEventIsAttack', which is not compatible.
Fortunately there is a solution for this: Damage Engine 5.9.0.0

 

[Salva]

I use the reforged and now that the world editor has been updated 1.33.0 some resources like this are bugged, can I use an older editor without problems? And if so, how do I install it?

 

[Bribe]

I use the reforged and now that the world editor has been updated 1.33.0 some resources like this are bugged, can I use an older editor without problems? And if so, how do I install it?

Sorry, what's bugged? You have to enable JassHelper at the top menu of the trigger editor if you're having issues saving

 

[Salva]

Sorry, what's bugged? You have to enable JassHelper at the top menu of the trigger editor if you're having issues saving

Sorry bro ! I had it disabled since I updated a few weeks ago, too bad , I thought the update was the cause. Everything's fine .

 

[Spacebuns]

If you save a map as folder with JassHelper enabled, when you re-open it, the disabled JassHelper problem will not persist.

 

[sraltheking]

Hey,
Is it possible to set a minions movement speed to 0 without getting the number bug?
The first attack shows that the unit get's health in return, which is not the case. I assume it is linked to unit moving, but cannot connect the dots.

 

[komarovba]

• Hello, I am writing from a translator. I would like to intercept damage with the condition - if the target (the one who receives damage) the type of attack is common, but I can't figure out how to check for it. Please tell me and thank you in advance!
  
  
  

 

[Aldeia]

• Hello, I am writing from a translator. I would like to intercept damage with the condition - if the target (the one who receives damage) the type of attack is common, but I can't figure out how to check for it. Please tell me and thank you in advance!
  
  
  

I guess you meant Normal attack

 

[Bribe]

Hey,
Is it possible to set a minions movement speed to 0 without getting the number bug?
The first attack shows that the unit get's health in return, which is not the case. I assume it is linked to unit moving, but cannot connect the dots.

Are you referring to how the demo map triggers are set up? If so, you can remove the portion which checks if a unit is moving (as that was just a showcase, and the demo trigger was never intended to be copy&pasted to actual maps).

Hello, I am writing from a translator. I would like to intercept damage with the condition - if the target (the one who receives damage) the type of attack is common, but I can't figure out how to check for it. Please tell me and thank you in advance!

If I understand correctly, a "common" type of attack would mean "normal" (e.g. from a Footman, Knight, Grunt, Tauren) but not other types of attacks (e.g. Pierce, Hero, Siege, Chaos). To do this:

• Normal Attack Check
  • Events
    • Game - Value of PreDamageEvent becomes Equal to 0.00
  • Conditions
    • DamageEventAttackT Equal to ATTACK_TYPE_NORMAL
  • Actions
    • -------- Do stuff --------

(Sorry had this typed earlier today but had forgotten to submit it).

 

[komarovba]

Thank you all for the answers. I checked, and it doesn't work. I suspect that this check checks that the attacker's attack type is normal. And I need the target's attack type to be checked.

 

[Bribe]

Thank you all for the answers. I checked, and it doesn't work. I suspect that this check checks that the attacker's attack type is normal. And I need the target's attack type to be checked.





View attachment 407657

Well, you can check the armor type of the target:

DamageEventDefenseT Equal to DEFENSE_TYPE_NORMAL

But to check its attack type, you need to use one of the new functions that Blizzard added (which works in GUI):

(Unit: DamageEventTarget's Weapon Integer Field: Attack Attack Type ('ua1t') at Index:0) Equal to ATTACK_TYPE_NORMAL

This checks the first attack type of the unit, but wouldn't check the second attack type of the unit (because a unit sometimes has a different attack type for ground and air, e.g. Batrider/Siege Engine).

 

[komarovba]

Maybe I misunderstood, but here is the condition) After the attack, it changes the target's attack type to a normal one, it looks ridiculous.

 

[Bribe]

Maybe I misunderstood, but here is the condition) After the attack, it changes the target's attack type to a normal one, it looks ridiculous.

View attachment 407659

You will need to select the option "integer comparison" rather than "boolean comparison"

 

[komarovba]

There is no such function in integers(

 

[Bribe]

I had to search a bit to find it, unfortunately there are two separate lists in that drop-down, each with their own alphabetical sorting. So there are two groups of integer comparisons which start with "Unit", you just need to scroll to the other one which also starts with "Unit".

 

[sraltheking]

Are you referring to how the demo map triggers are set up? If so, you can remove the portion which checks if a unit is moving (as that was just a showcase, and the demo trigger was never intended to be copy&pasted to actual maps).

I can explain it in another way. I am making a spell, that makes a wall of units surrounding the caster. All of the units movement speed are set to 0 so they can't move. As I do that, the first hit will always say: +50
As if the units is getting a heal. Tho I tried to disable "Is unit moving" Trigger, and it still happens.

 

[Bribe]

I can explain it in another way. I am making a spell, that makes a wall of units surrounding the caster. All of the units movement speed are set to 0 so they can't move. As I do that, the first hit will always say: +50
As if the units is getting a heal. Tho I tried to disable "Is unit moving" Trigger, and it still happens.

If you give the units more than 0 movement speed, does the healing text go away? If so, you'd need to send me over a testable map to work with to try to help you to find the root cause.

 

[sraltheking]

If you give the units more than 0 movement speed, does the healing text go away? If so, you'd need to send me over a testable map to work with to try to help you to find the root cause.

Yes, if I set the speed above 0 the heal text disappear. So this is not a function in the base code? It is something I have done wrong?

 

[Bribe]

Yes, if I set the speed above 0 the heal text disappear. So this is not a function in the base code? It is something I have done wrong?

It sounds like there is a trigger somewhere in your map that is checking or changing the health of the unit differently, depending on if it has movement speed above 0 or not. Either by giving them +2 strength or by giving them an item that increases their health directly. But it doesn't make sense in the context of the systems that I've built. That's why it might be good if I take a look at your map to see if I can isolate it.

 

[sraltheking]

It sounds like there is a trigger somewhere in your map that is checking or changing the health of the unit differently, depending on if it has movement speed above 0 or not. Either by giving them +2 strength or by giving them an item that increases their health directly. But it doesn't make sense in the context of the systems that I've built. That's why it might be good if I take a look at your map to see if I can isolate it.

I just realised how stupid I am. Forgot that I added "Healing Engine" to display healing amounts. So the error is within Healing Engine, rather than Damage Engine.

 

[komarovba]

Thanks! It worked)

 

[Bribe]

I don't know if I did something different, but in version 3A.0.. that I recently used it, when I use a group that captures units in an area to deal damage, the second unit that is damaged its health goes up to +50000 health .

Spoiler: code

call GroupClear(G)
call GroupEnumUnitsInRange(G,GetUnitX(target),GetUnitY(target),300,Condition(function True))
call GroupRemoveUnit(G,target)
set dam = 20
loop
     set a = FirstOfGroup(G)
     exitwhen a == null
     call GroupRemoveUnit(G,a)
     call UnitDamageTarget(source,a,dam,false,false,ATTACK_TYPE_CHAOS,DAMAGE_TYPE_UNIVERSAL,null)
endloop

View attachment 407948

I deactivated all the damage codes, but it keeps happening, I don't know if it's because I can't use it in the same line of the event to do this.
Note 1: In the gui version, this strange thing does not happen...

I can't recall off-hand, but it could be that Damage Engine 3A might need some kind of ClearDamageEvent functionality to notify the system that it needs to be reset. I will review the code next week, and it's possible that this is just a bug that I never accounted for (and 3A has been completely untouched from version 1.0, surprisingly).

 

[AngelCraft]

I can't recall off-hand, but it could be that Damage Engine 3A might need some kind of ClearDamageEvent functionality to notify the system that it needs to be reset. I will review the code next week, and it's possible that this is just a bug that I never accounted for (and 3A has been completely untouched from version 1.0, surprisingly).

Ah, oks, I thought that designing a function similar to the "static method apply takes..." method for this version caused that error, but it was repeated in several events that it did not apply said function, I only needed it to save a damagetype variable in the library lol.

 

[ZeroGravity]

I tried to save my map but this happen,

any idea?

 

[Duckfarter]

I tried to save my map but this happen,

View attachment 408860

any idea?

It might be an error that occured when you imported the variables. Open up your variable editor from the trigger editor and make sure the variables with errors mentioned in jasshelper have the variable type real and initial value 0.

[Trigger] - Error with Creep Respawn

hey I get quite a few errors when saving after adding this trigger to my map there are 9 errors Line 392: Undefined type VarAsString_Real Line 13949, 13950, 13951, 13993, 13994, 13995, 13023, 14024: Cannot convert real to null heres the triggers that I added to my map Respawn Events...

www.hiveworkshop.com

 

[ZeroGravity]

It might be an error that occured when you imported the variables. Open up your variable editor from the trigger editor and make sure the variables with errors mentioned in jasshelper have the variable type real and initial value 0.

[Trigger] - Error with Creep Respawn

hey I get quite a few errors when saving after adding this trigger to my map there are 9 errors Line 392: Undefined type VarAsString_Real Line 13949, 13950, 13951, 13993, 13994, 13995, 13023, 14024: Cannot convert real to null heres the triggers that I added to my map Respawn Events...

www.hiveworkshop.com

Thank you, that works but now I encounter new problem which is,

and this one too,

 

[Duckfarter]

Undeclared variable would mean that the variable does not exist or cant be used in that stretch of code but since its global, the latter should not be it. It could be related to the same problem, that the variable has not initiated correctly or even might not exist. Try the same step as before and also make sure that it actually exists.

Take a look at the latest changelog for 5.9.0.0. Bribe stresses that "Installation or updating from a previous version will require re-copying the entire Damage Engine folder."

 

[ZeroGravity]

Undeclared variable would mean that the variable does not exist or cant be used in that stretch of code but since its global, the latter should not be it. It could be related to the same problem, that the variable has not initiated correctly or even might not exist. Try the same step as before and also make sure that it actually exists.

Take a look at the latest changelog for 5.9.0.0. Bribe stresses that "Installation or updating from a previous version will require re-copying the entire Damage Engine folder."

I see, that explains why when I copied it in new map, it works but not on my old map.

 

[Spacebuns]

If I have 2 triggers:
* Trigger 1: Event - DamageModifierEvent = 1.00 (runs for all damage)
above
* Trigger 2: Event - DamageModifierEvent < 1.00 (runs for attack damage)

I understand that the trigger above runs before the trigger under. An attack damage instance causes Trigger 1 to run, and the action block sets DamageEventOverride = true. Will that damage cause Trigger 2 to run after Trigger 1 finishes running?

 

[Bribe]

If I have 2 triggers:
* Trigger 1: Event - DamageModifierEvent = 1.00 (runs for all damage)
above
* Trigger 2: Event - DamageModifierEvent < 1.00 (runs for attack damage)

I understand that the trigger above runs before the trigger under. An attack damage instance causes Trigger 1 to run, and the action block sets DamageEventOverride = true. Will that damage cause Trigger 2 to run after Trigger 1 finishes running?

That's an interesting scenario you've outlined. EDIT: I just checked the code, and this would not work unless you modified the registerVerbose method to allow the same trigger to be added twice (right now, it would just add the extra conditional, which in this case is unnecessary). Therefore, out of the box, this would not work.

I'd personally just use an if/then/else block to handle the logic, rather than running two events on one trigger. This would leave nothing to the imagination of "what if" scenarios like what you've just given me.

Bear in mind that Lua Damage Event is getting a MAJOR overhaul sometime before the end of the year, which will make events behave differently than they do now with one trigger (as in, you can tell your trigger to "wait" until the next event).

 

[Spacebuns]

That's an interesting scenario you've outlined. EDIT: I just checked the code, and this would not work unless you modified the registerVerbose method to allow the same trigger to be added twice (right now, it would just add the extra conditional, which in this case is unnecessary). Therefore, out of the box, this would not work.

I'd personally just use an if/then/else block to handle the logic, rather than running two events on one trigger. This would leave nothing to the imagination of "what if" scenarios like what you've just given me.

Bear in mind that Lua Damage Event is getting a MAJOR overhaul sometime before the end of the year, which will make events behave differently than they do now with one trigger (as in, you can tell your trigger to "wait" until the next event).

So the "< 1.00" trigger will not execute if DamageEventOverride = true is executed on the "= 1.00" trigger that runs before "< 1.00". Well, it's the behavior I want anyway.
But these are two separate triggers and not two events on one trigger, so we may not be talking about the same thing?
Not really into Lua much because what I'm working on is still very JASS heavy

 

[AngelCraft]

and it's possible that this is just a bug that I never accounted

Doing certain things on a test map, Damage Engine 3.8, I got the +500000 health bug, this happened to me after detecting an attack damage and then in a different damage detection event adding a tornado slow aura to the attacker to increase his speed, a 0 damage is caused by the aura to the attacker, but it appears in messages that an AoE damage was done to the attacked unit, I suppose that the recursion will be the problem, I'll pass you the test map. Perhaps using the event call TriggerRegisterVariableEvent( t, "udg_DamageEvent", EQUAL, 0 ) to detect is the problem, and not setting it to a value of 1, but it could also be something else.

 

[Bribe]

Doing certain things on a test map, Damage Engine 3.8, I got the +500000 health bug, this happened to me after detecting an attack damage and then in a different damage detection event adding a tornado slow aura to the attacker to increase his speed, a 0 damage is caused by the aura to the attacker, but it appears in messages that an AoE damage was done to the attacked unit, I suppose that the recursion will be the problem, I'll pass you the test map. Perhaps using the event call TriggerRegisterVariableEvent( t, "udg_DamageEvent", EQUAL, 0 ) to detect is the problem, and not setting it to a value of 1, but it could also be something else.

Does the bug still occur on 3A? I don't advise using 3.8 anymore as its only advantage was that it worked without JassHelper.

 

[AngelCraft]

Does the bug still occur on 3A?

Oks, using version 3.A, the error doesn't happen. . Only area damage in this version is buggy.

 

[Bribe]

Oks, using version 3.A, the error doesn't happen. . Only area damage in this version is buggy.

Could you please let me know what about area damage appears to be buggy? I've modified your test map with 3A, but I'm not sure what I would need to do to replicate the bug behavior you are describing.

 

[AngelCraft]

Could you please let me know what about area damage appears to be buggy? I've modified your test map with 3A, but I'm not sure what I would need to do to replicate the bug behavior you are describing.

Edit 3: The +500000 health bug in the "Mod" event still occurs when dealing damage to other units within version 3.A.

//Bug life 3.A, +500000 on first unit: gg_unit_h002_0002
function Trig_On_Hit_Actions1 takes nothing returns nothing
    local unit u = udg_DamageEventSource
    local unit a = udg_DamageEventTarget
    local real dam = 20
    if udg_DamageEventAmount > 0 and udg_IsDamageSpell == false and udg_DamageEventType != 1 then
        set udg_NextDamageType = 1
        call UnitDamageTarget(u, gg_unit_h002_0002, dam,false,false,ATTACK_TYPE_CHAOS,DAMAGE_TYPE_UNIVERSAL,null)
        set udg_NextDamageType = 1
        call UnitDamageTarget(u, gg_unit_h005_0003, dam,false,false,ATTACK_TYPE_CHAOS,DAMAGE_TYPE_UNIVERSAL,null)
    endif
    set u = null
    set a = null
endfunction

function Init takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterDamageEngine(t,"Mod",1.00)
    call TriggerAddAction(t, function Trig_On_Hit_Actions1)
    set t = null
endfunction

If the attack is ATTACK_TYPE_NORMAL, it will be given as negative damage and taken as "udg_IsDamageSpell", the health error will not occur but the second unit "gg_unit_h005_0003" will not receive the damage put in this event. The same thing happens when doing a group damage (AoE) within this Event, the units will have error life or will not take damage, that's why it does not work to do code damage to a group of units.

In the version 3.8 issue the tornado slow aura bug remains causing additional damage to the attacked unit, this problem generates the bug of +500000 life to the attacked unit. This bug is generated in 3.8, if the source unit does damage to itself, within the event, damage 0 is the one that causes the most bugs.

//Bug life 3.8, This problem generates the bug of +500000 life to the attacked unit.
function Trig_On_Hit_Actions1 takes nothing returns nothing
    if GetUnitAbilityLevel(udg_DamageEventSource,'A009') > 0 and udg_DamageEventSource != udg_DamageEventTarget and udg_IsDamageSpell == false then
        if udg_DamageEventAmount > 0 then
            call UnitAddAbility(udg_DamageEventSource,'A000') //Bug life for Aure
            call UnitRemoveAbility(udg_DamageEventSource,'A000') //Bug life for Aure
            call UnitRemoveAbility(udg_DamageEventSource,'Basl') //Bug life for Aure
        endif
    endif
endfunction

function Init takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterVariableEvent( t, "udg_DamageModifierEvent", EQUAL, 1.00 )
    call TriggerAddAction(t, function Trig_On_Hit_Actions1)
    set t = null
endfunction

Note: Check if there were any more bugs but they are the only ones I found at the moment so I update the test maps only with what I specify. I've been trying a few things in my case to resolve this data, but in the end I ended up changing the recursion, and I don't want to touch that part since maybe there is another better way to solve this.

Note 2: If these bugs are maintained en 3.A, during the course of the game when several of these come together, the game will close, I don't know if it is due to recursion or null variables. Greetings...

 

[El Saif]

How to actually detect attack/damage type from the system? Since i wanna deal damages based on the damage type received within DamageEvent trigger.

 

[Bribe]

How to actually detect attack/damage type from the system? Since i wanna deal damages based on the damage type received within DamageEvent trigger.

DamageEventAttackT
DamageEventDamageT

 

[El Saif]

DamageEventAttackT
DamageEventDamageT

No i mean, within the DamageEvent i want to deal damage like 'Unit - cause unit to damage bla bla with Attack Type and DamageType'
I want to autodetects the AttackType and DamageType

 

[ThompZon]

No i mean, within the DamageEvent i want to deal damage like 'Unit - cause unit to damage bla bla with Attack Type and DamageType'
I want to autodetects the AttackType and DamageType

You mean something like this? (This it literally what Bribe said)
This example is: Cause the damage source to damage the target with the same attack and damage type dealing 500 damage.

• Unit - Cause DamageEventSource to damage DamageEventTarget, dealing 500.00 damage of attack type CONVERTED_ATTACK_TYPE[DamageEventAttackT] and damage type CONVERTED_DAMAGE_TYPE[DamageEventDamageT]

 

[El Saif]

You mean something like this? (This it literally what Bribe said)
This example is: Cause the damage source to damage the target with the same attack and damage type dealing 500 damage.

• Unit - Cause DamageEventSource to damage DamageEventTarget, dealing 500.00 damage of attack type CONVERTED_ATTACK_TYPE[DamageEventAttackT] and damage type CONVERTED_DAMAGE_TYPE[DamageEventDamageT]

Oh sorry that Converted vars is exist? I guess my Damage Engine is outdated then. Which version started using them? I'm still on classic w3 tho.

EDIT : Oh sorry again i get it now, thank you very much.

 

[ThompZon]

Oh sorry that Converted vars is exist? I guess my Damage Engine is outdated then. Which version started using them? I'm still on classic w3 tho.

I'm unsure what you mean by "classic". There are many versions before 1.32 and some introduced big changes.
The code say that these were introduced in 5.4.2. All 5.X versions require Warcraft 1.31 or later

 

[El Saif]

I'm unsure what you mean by "classic". There are many versions before 1.32 and some introduced big changes.
The code say that these were introduced in 5.4.2. All 5.X versions require Warcraft 1.31 or later

What i mean classic is that because i thought that was in Damage engine 5.8 and up. 5.8 and up is coded in reforged isn't it? and i can't really using them for now.
And to be honest i don't know which version i am using right now since it has been a few years and i can't really found the latest version which are not coded in refoged.

 

[Bribe]

What i mean classic is that because i thought that was in Damage engine 5.8 and up. 5.8 and up is coded in reforged isn't it? and i can't really using them for now.
And to be honest i don't know which version i am using right now since it has been a few years and i can't really found the latest version which are not coded in refoged.

As long as you have bought the (non-reforged) game, it's not some illegal copy of the game, and it is up-to-date, it should work. The Reforged thing is only about graphics/campaign, but it doesn't change the common.j/blizzard.j API.