Damage Engine 5.A.0.0

[Bribe]

It probably doesn't really matter as it's just an extra BlzSetUnitArmor call that's made but in the setArmor function where it modifies the armor the "if pierce != 0.00" is always true if there is no armor piercing, because in that case it sets pierce to -0.00, which apparently is different than 0.00.
View attachment 395576

lol, that’s a weird behavior. I’ll add it to the backlog of stuff.

 

[Darkfang]

One question, I think I'm using an old version, but I just want to verify before I make any change
I found a bug with Defend, defend does not deflect attacks nor does it activate it's iconic special effect, is this bug still present in the current version?

EDIT: Nevermind, don't mind me

 

[Spacebuns]

Where do you think Hardened Skin's reduction applies in the "How it works" flowchart?

 

[Bribe]

Where do you think Hardened Skin's reduction applies in the "How it works" flowchart?

I am pretty sure that it’s a “before-armor” thing like Mana Shield, but it is worth running some test data on it first.

 

[Spacebuns]

I have done some testing, and it does seem to enter calculation before armor type.

(DamageEventPrevAmt - Hardened Skin reduction)*Armor type*Armor value reduction = DamageEventAmount
(checked using DamageEventModifier 4.00, not detected by DamageEventModifier before 4.00)

So if you mean Hardened Skin is calculated before armor, you are correct.

 

[Bribe]

I have done some testing, and it does seem to enter calculation before armor type.

(DamageEventPrevAmt - Hardened Skin reduction)*Armor type*Armor value reduction = DamageEventAmount
(checked using DamageEventModifier 4.00, not detected by DamageEventModifier before 4.00)

So if you mean Hardened Skin is calculated before armor, you are correct.

The real question now is whether Mana Shield applies before or afterward. I would think before.

 

[googery]

I have a problem. My unit has 'missile splash' attack. When I use DamageModifierEvent event, the trigger will run for all units in the AOE, so it runs multiple times just in one attack. I just want it to only run once a attack. Then I tried AOEDamageEvent event and it run once each attack as expected but I cannot modify the damage. How can I modify the damage of an AOE attack?

 

[Bribe]

I have a problem. My unit has 'missile splash' attack. When I use DamageModifierEvent event, the trigger will run for all units in the AOE, so it runs multiple times just in one attack. I just want it to only run once a attack. Then I tried AOEDamageEvent event and it run once each attack as expected but I cannot modify the damage. How can I modify the damage of an AOE attack?

Just go back to your original trigger with a normal DamageModifierEvent and check if DamageEventAOE is equal to 1.

 

[googery]

Just go back to your original trigger with a normal DamageModifierEvent and check if DamageEventAOE is equal to 1.

I checked DamageEventAOE equal to 1 as you said and the trigger run once each attack, but it only modify the damage dealt to the main target of the attack, not the damage dealt to other units in AOE. To be more specific, my unit (has 'missile splash' attack) has an ability that every 3rd attack it will deal x2 damage of damage type Universal and restore 100hp. This is my trigger:

• Critical Shoot
  • Events
    • Game - DamageModifierEvent becomes Equal to 1.00
  • Conditions
    • (Unit-type of DamageEventSource) Equal to My Unit
    • IsDamageRanged Equal to True
    • (DamageEventTarget belongs to an enemy of (Owner of DamageEventSource)) Equal to True
    • DamageEventAOE Equal to 1
  • Actions
    • Set X = (X + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • X Equal to 3
      • Then - Actions
        • Set DamageEventAmount = (DamageEventAmount x 2.00)
        • Set DamageEventDamageT = DAMAGE_TYPE_UNIVERSAL
        • Unit - Set life of DamageEventSource to ((Life of DamageEventSource) + 100.00)
        • Set X = 0
      • Else - Actions

It works for the main target of the attack and the HP is restored correctly, but the other units in AOE still got the unmodified damage. I want the damage to be modified for all units in AOE.

 

[Spacebuns]

Is it possible to make a damage event ignore modification from abilities present on the target (Hardened Skin, Berserk, Spiked Carapace etc.)?

 

[Bribe]

Is it possible to make a damage event ignore modification from abilities present on the target (Hardened Skin, Berserk, Spiked Carapace etc.)?

Yep, just set the damage type to DamageTypePure from a DamageModifierEvent.

 

[Spacebuns]

Yep, just set the damage type to DamageTypePure from a DamageModifierEvent.

I'm aware of that, what I really mean to ask is if it's possible to make a damage event ONLY ignore modification from abilities on the target, but still calculate armor reduction.

 

[Bribe]

I'm aware of that, what I really mean to ask is if it's possible to make a damage event ONLY ignore modification from abilities on the target, but still calculate armor reduction.

Yes, but you’ll need to calculate the armor reduction yourself.

percentage = (armor * modifier) / ( 1 + armor * modifier ). Modifier is usually 0.06.

The above gets you the percentage of reduction based on armor quantity.

If you need armor types as well, the you can use this method:

[JASS] GetUnitArmorReduction

Just like to share this, with the new functions. Returns armor reduction of a unit against an attack type. function GetUnitArmorReduction takes unit u, attacktype aType returns real local real originalArmor = BlzGetUnitArmor(u) local real originalMaxLife = BlzGetUnitMaxHP(u) local...

www.hiveworkshop.com

 

[Bribe]

I checked DamageEventAOE equal to 1 as you said and the trigger run once each attack, but it only modify the damage dealt to the main target of the attack, not the damage dealt to other units in AOE. To be more specific, my unit (has 'missile splash' attack) has an ability that every 3rd attack it will deal x2 damage of damage type Universal and restore 100hp. This is my trigger:

• Critical Shoot
  • Events
    • Game - DamageModifierEvent becomes Equal to 1.00
  • Conditions
    • (Unit-type of DamageEventSource) Equal to My Unit
    • IsDamageRanged Equal to True
    • (DamageEventTarget belongs to an enemy of (Owner of DamageEventSource)) Equal to True
  • Actions
    • DamageEventAOE Equal to 1
• [/QUOTE]
• [QUOTE="googery, post: 3526080, member: 297688"]
• Set X = (X + 1)
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • X Equal to 3
    • Then - Actions
      • Set DamageEventAmount = (DamageEventAmount x 2.00)
      • Set DamageEventDamageT = DAMAGE_TYPE_UNIVERSAL
      • Unit - Set life of DamageEventSource to ((Life of DamageEventSource) + 100.00)
      • Set X = 0
    • Else - Actions

It works for the main target of the attack and the HP is restored correctly, but the other units in AOE still got the unmodified damage. I want the damage to be modified for all units in AOE.

I checked DamageEventAOE equal to 1 as you said and the trigger run once each attack, but it only modify the damage dealt to the main target of the attack, not the damage dealt to other units in AOE. To be more specific, my unit (has 'missile splash' attack) has an ability that every 3rd attack it will deal x2 damage of damage type Universal and restore 100hp. This is my trigger:

• Critical Shoot
  • Events
    • Game - DamageModifierEvent becomes Equal to 1.00
  • Conditions
    • (Unit-type of DamageEventSource) Equal to My Unit
    • IsDamageRanged Equal to True
    • (DamageEventTarget belongs to an enemy of (Owner of DamageEventSource)) Equal to True
    • DamageEventAOE Equal to 1
  • Actions
    • Set X = (X + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • X Equal to 3
      • Then - Actions
        • Set DamageEventAmount = (DamageEventAmount x 2.00)
        • Set DamageEventDamageT = DAMAGE_TYPE_UNIVERSAL
        • Unit - Set life of DamageEventSource to ((Life of DamageEventSource) + 100.00)
        • Set X = 0
      • Else - Actions

It works for the main target of the attack and the HP is restored correctly, but the other units in AOE still got the unmodified damage. I want the damage to be modified for all units in AOE.

This trigger can be modified with the following flow:

A) Move the condition “DamageEventAOE” to a new if/else block at the top of the Actions.

B) Move Set X = X + 1 into A’s “then” actions

C) Move Set X = 0 into a separate trigger with the event AOEDamageEvent and the condition “X Equal to or greater than 3”.

The flow will then work exactly as you wish it to, affecting all units hit by that splash instance.

 

[googery]

Thank you Bribe, it works fine now.

• Critical Shoot 1
  • Events
    • Game - DamageModifierEvent becomes Equal to 1.00
  • Conditions
    • (Unit-type of DamageEventSource) Equal to My Unit
    • IsDamageRanged Equal to True
    • (DamageEventTarget belongs to an enemy of (Owner of DamageEventSource)) Equal to True
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • DamageEventAOE Equal to 1
      • Then - Actions
        • Set X = (X + 1)
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • X Equal to 3
      • Then - Actions
        • Set DamageEventAmount = (DamageEventAmount x 2.00)
        • Set DamageEventDamageT = DAMAGE_TYPE_UNIVERSAL
      • Else - Actions

• Critical Shoot 2
  • Events
    • Game - AOEDamageEvent becomes Equal to 1.00
  • Conditions
    • (Unit-type of DamageEventSource) Equal to My Unit
    • IsDamageRanged Equal to True
    • (DamageEventTarget belongs to an enemy of (Owner of DamageEventSource)) Equal to True
    • X Greater than or equal to 3
  • Actions
    • Unit - Set life of DamageEventSource to ((Life of DamageEventSource) + 100.00)
    • Set X = 0

Edit: I think the EnhancedDamageTarget unit refer to the main target of the attack in AOEDamageEvent.

 

[googery]

There is a problem with the 2nd trigger in my comment above (the AOEDamageEvent trigger). It is: that trigger won't run when the attack only damage one unit. That means the event AOEDamageEvent won't run if there is only one unit damaged by the attack, even though the attack is splash. How do I fix this?

 

[Spacebuns]

Have you tried making a duplicate trigger but the condition AOEDamageEvent being 0?

 

[googery]

Have you tried making a duplicate trigger but the condition AOEDamageEvent being 0?

You mean condition DamageEventAOE? Well I just tested that condition:
Game - Display to (All players) the text: (String(DamageEventAOE))

• In DamageModifierEvent: If there are 3 units got damaged by the attack then the DamageEventAOE integer can be 1, 2 or 3 at the same time; if only 1 unit then DamageEventAOE will only be 1, so I think it cannot be 0.
• In AOEDamageEvent: DamageEventAOE is equal to the number of units damaged by the attack, except when there is only one unit => DamageEventAOE returns nothing.

 

[Bribe]

You mean condition DamageEventAOE? Well I just tested that condition:
Game - Display to (All players) the text: (String(DamageEventAOE))

• In DamageModifierEvent: If there are 3 units got damaged by the attack then the DamageEventAOE integer can be 1, 2 or 3 at the same time; if only 1 unit then DamageEventAOE will only be 1, so I think it cannot be 0.
• In AOEDamageEvent: DamageEventAOE is equal to the number of units damaged by the attack, except when there is only one unit => DamageEventAOE returns nothing.

DamageEngine can’t detect if damage is AOE unless the damage does hit multiple units.

Using AfterDamageEvent doesn’t work unless the damage only hits one unit, and would fail to affect all the units as you wanted it to.

Therefore, it seems like the only way to make this work for you is if I add an extra event modifier that runs the AOE damage event regardless of if the damage had hit multiple units. Something like “Less Than” instead of “Equal to”. This is worth doing, if it would help you. I will try to get it done this weekend if so.

Basically, you’d have that trigger turned off at all times, and just allow it to be turned on when X is 3, then the trigger turns itself back off once it runs.

 

[googery]

I think I found the way! I figured out how the integer DamageEventAOE works from my post above, so I tried to modify my triggers according to it.
In the first trigger, I replace the condition "X equal to 3" with "X equal to 3 or X equal to 0". In the second trigger, I replace "AOEDamageEvent" back to "DamageEvent". I tested and I think it works fine, for both case only one unit and more than one unit hit by the splash attack.

• Critical Shoot 1
  • Events
    • Game - DamageModifierEvent becomes Equal to 1.00
  • Conditions
    • (Unit-type of DamageEventSource) Equal to My Unit
    • IsDamageRanged Equal to True
    • (DamageEventTarget belongs to an enemy of (Owner of DamageEventSource)) Equal to True
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • DamageEventAOE Equal to 1
      • Then - Actions
        • Set X = (X + 1)
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Or - Any (Conditions) are true
          • Conditions
            • X Equal to 3
            • X Equal to 0
      • Then - Actions
        • Set DamageEventAmount = (DamageEventAmount x 2.00)
        • Set DamageEventDamageT = DAMAGE_TYPE_UNIVERSAL
      • Else - Actions

• Critical Shoot 2
  • Events
    • Game - DamageEvent becomes Equal to 1.00
  • Conditions
    • (Unit-type of DamageEventSource) Equal to My Unit
    • IsDamageRanged Equal to True
    • (DamageEventTarget belongs to an enemy of (Owner of DamageEventSource)) Equal to True
    • X Greater than or equal to 3
  • Actions
    • Unit - Set life of DamageEventSource to ((Life of DamageEventSource) + 100.00)
    • Set X = 0

I guess that the chronological order of these triggers in one attack should be:

1. Projectile hit the main target of the attack (the 1st unit)
2. The 1st unit is going to take damage => Run the first trigger actions. DamageEventAOE returns 1 => Add 1 to X => X now has a value of 1, 2 or 3. If X equal to 3, modify the damage deal to this unit.
3. The 1st unit takes damage. If X equal to 3, run the second trigger actions => Add HP to the attacker and Set X to 0.
   
   If there are more than one unit in AOE, it will continue as below:
   
4. The 2nd unit is going to take damage => Run the first trigger actions. DamageEventAOE returns 2. At this time, X is having a value of 1, 2 or 0. If X equal to 0, modify the damage deal to this unit.
5. The 2nd unit takes damage.
6. The 3rd unit... similar to the 2nd unit, but the DamageEventAOE returns 3...

I'm using DamageEngine 5.4.2.3, my patch is 1.31. I don't have Reforged so I think I can't use the update versions.

Edit: condition ''DamageEventAOE equal to 1'' not needed in second trigger

 

[darkravenbest]

Its possible to check from which exact spell damage came from? For example if unit was damage with finger of death of firebolt?

 

[BLOKKADE]

Its possible to check from which exact spell damage came from? For example if unit was damage with finger of death of firebolt?

You'd have to make some edits to DamageEngine to make it support that.

In my map what I do is whenever a hero casts a spell it actually uses a dummy unit to cast the real spell, this dummy unit has a variable linked to the spell its casting and then I can just use damage engine to detect the damage source to check what spell the damage is from.

You could also do it by making all spell damage coded and then just adding a damage source ability variable to damage engine and setting that right before you deal damage, like the udg_nextblablabla variable already in the library.

 

[darkravenbest]

You'd have to make some edits to DamageEngine to make it support that.

In my map what I do is whenever a hero casts a spell it actually uses a dummy unit to cast the real spell, this dummy unit has a variable linked to the spell its casting and then I can just use damage engine to detect the damage source to check what spell the damage is from.

You could also do it by making all spell damage coded and then just adding a damage source ability variable to damage engine and setting that right before you deal damage, like the udg_nextblablabla variable already in the library.

Well i actually use first one with dummy units, but i was curious if it possible to attach trigger to exact spell instead of attaching it to a unit, in cases where i dont want to use dummy cast for simple passives like envenomed weapon.

 

[darkravenbest]

How to reference DamageEventSource/DamageEventTarget in GethandleID functions for hashtable? You see, i cant reference unit from global variables which DamageEventSource/DamageEventTarget are.

 

[Bribe]

By making 3 events:

• <Event> Less than 1 = Only runs for damage from attacks
• <Event> Greater than 1 = Only runs for damage from abilities (I assume passive abilities like Thorns Aura, Spiked Carapace count toward this?)
• <Event> Not equal to 1 = Only runs for damage from triggers (UnitDamageTarget etc.)

This will practically cover all possibilities of damage in WC3, am I correct? It's much handier than running one <Event> Equal to 1 and have to filter for attack/ability/code damage with "ifs".
Is it correct to also assume that this works the same for real values !=1 (e.g. DamageModifierEvent less than 4.00 if I want to catch only attack damage after calculation has been applied)

Yes, that would cover every major branch. Those three events would never occur for the same damage instance.

Hello !

I'd like to report a really minor side effect of this library: because Damage Engine uses "CreateTrigger", "CreateGroup" and "CreateTimer" in a "globals" scope, you cannot hook those functions.

Indeed, on build you will have an build error saying "h__CreateTimer does not exist, do you mean CreateTrigger ?" (for example).
It is because, if you look at the war3map.j displayed in the error window, the "globals" definition appears first in the file, and only several lines below appears the hook definitions.

I think a simple "fix" would be to declare the variables with null value, and then initialize them with CreateTimer/Trigger/Group in the "onInit".

Sincerely,

Ricola3D

Are you using vJass or Lua? I'm just wondering why anyone would want to be hooking those functions. If it helps you, I can do it, but I am mostly curious as to why.

It probably doesn't really matter as it's just an extra BlzSetUnitArmor call that's made but in the setArmor function where it modifies the armor the "if pierce != 0.00" is always true if there is no armor piercing, because in that case it sets pierce to -0.00, which apparently is different than 0.00.
View attachment 395576

I have a version of 5.8 I'm testing that has now implemented this fix.

I think I found the way! I figured out how the integer DamageEventAOE works from my post above, so I tried to modify my triggers according to it.
In the first trigger, I replace the condition "X equal to 3" with "X equal to 3 or X equal to 0". In the second trigger, I replace "AOEDamageEvent" back to "DamageEvent". I tested and I think it works fine, for both case only one unit and more than one unit hit by the splash attack.

I guess that the chronological order of these triggers in one attack should be:

1. Projectile hit the main target of the attack (the 1st unit)
2. The 1st unit is going to take damage => Run the first trigger actions. DamageEventAOE returns 1 => Add 1 to X => X now has a value of 1, 2 or 3. If X equal to 3, modify the damage deal to this unit.
3. The 1st unit takes damage. If X equal to 3, run the second trigger actions => Add HP to the attacker and Set X to 0.
   
   If there are more than one unit in AOE, it will continue as below:
   
4. The 2nd unit is going to take damage => Run the first trigger actions. DamageEventAOE returns 2. At this time, X is having a value of 1, 2 or 0. If X equal to 0, modify the damage deal to this unit.
5. The 2nd unit takes damage.
6. The 3rd unit... similar to the 2nd unit, but the DamageEventAOE returns 3...

I'm using DamageEngine 5.4.2.3, my patch is 1.31. I don't have Reforged so I think I can't use the update versions.

Edit: condition ''DamageEventAOE equal to 1'' not needed in second trigger

1. You can use the latest version of Damage Engine with patch 1.31 with just the small edit of adding in your own custom BlzGetEventIsAttack, as shown in the "Requirements" section.

2. The actual, correct method is still for me to update Damage Engine. The next update (5.8) has a working method that makes "AOEDamageEvent equal to 0.00" react as if it doesn't matter whether it's AOE or not. This solves several problems by removing any dependency that users may have for a 0.00 second timer, which is actually the correct solution to the problem you presented.

Well i actually use first one with dummy units, but i was curious if it possible to attach trigger to exact spell instead of attaching it to a unit, in cases where i dont want to use dummy cast for simple passives like envenomed weapon.

Checking the damage type is the best option for you here. You can reference the following link to differentiate between many different types of spells per group. As long as your unit doesn't have more than one ability per damage type, then you can determine which spell was cast that dealt the damage: REPO in progress - mapping damage types to their abilities

How to reference DamageEventSource/DamageEventTarget in GethandleID functions for hashtable? You see, i cant reference unit from global variables which DamageEventSource/DamageEventTarget are.

You have to store every piece of information separately in that hashtable, or use arrays with indexing to store each of them separately. Damage Engine does not have a way to retain such information for longer than an instant. It is up to the user to determine what - if any - data needs to be stored for longer, and then use their own method of preference to do so.

 

[darkravenbest]

Checking the damage type is the best option for you here. You can reference the following link to differentiate between many different types of spells per group. As long as your unit doesn't have more than one ability per damage type, then you can determine which spell was cast that dealt the damage: REPO in progress - mapping damage types to their abilities

Well for spells which i use without dummy cast i figure out exact same decision, to replace exact damage type which spell uses, but i thought that there is intended way which i overlooked.

You have to store every piece of information separately in that hashtable, or use arrays with indexing to store each of them separately. Damage Engine does not have a way to retain such information for longer than an instant. It is up to the user to determine what - if any - data needs to be stored for longer, and then use their own method of preference to do so.

I know that damage engine can store information in global varible only for a bref moment, but there is no way to like:
"DamageEventModifier becomes 1.0

Save real as 1 of GetHandleID(DamageEventTarget)"
?

So i dont need Damage engine to actually store information, i only need a way to reference unit in a moment when its become a DamageEventTarget.

 

[Bribe]

I know that damage engine can store information in global varible only for a bref moment, but there is no way to like:
"DamageEventModifier becomes 1.0

Save real as 1 of GetHandleID(DamageEventTarget)"
?

So i dont need Damage engine to actually store information, i only need a way to reference unit in a moment when its become a DamageEventTarget.

That works just fine. How do your triggers currently look?

 

[darkravenbest]

That works just fine. How do your triggers currently look?

First of all i must point out that i use 1.31 pre reforged version so maybe there is can be differences.
In my map i try to implement custom resistances, which stored in hash-table, each unit has its own resistance stored in such way:

Save Real(resistance amount) as 1(number of resistance) of Key*(EnteringUnit) in last created hashtable

*Where key is GetHandleID, and it is getting ID of unit to which i apply resistance

As you can see its a simple operation and i have no troubles with it.

When i try to load resistance Value:

Event:
DamageModifierEvent becomes 1.0

Actions: (simple example)
DamageEventAmount = DamageEventAmount x Load 1 of Key(**) from last created hashtable

**And here should be DamageEventTarget, but i cant select it.

When i try to use GetHandleID function, only thing that i can reference is a units from other functions, like "Matching Unit" for example, as you can see in the variable field in example below i cant select any unit variable which DamageEventTarget is.

Maybe i overlooked something?

 

[Bribe]

First of all i must point out that i use 1.31 pre reforged version so maybe there is can be differences.
In my map i try to implement custom resistances, which stored in hash-table, each unit has its own resistance stored in such way:

Save Real(resistance amount) as 1(number of resistance) of Key*(EnteringUnit) in last created hashtable

*Where key is GetHandleID, and it is getting ID of unit to which i apply resistance

As you can see its a simple operation and i have no troubles with it.

When i try to load resistance Value:

Event:
DamageModifierEvent becomes 1.0

Actions: (simple example)
DamageEventAmount = DamageEventAmount x Load 1 of Key(**) from last created hashtable

**And here should be DamageEventTarget, but i cant select it.

When i try to use GetHandleID function, only thing that i can reference is a units from other functions, like "Matching Unit" for example, as you can see in the variable field in example below i cant select any unit variable which DamageEventTarget is.

View attachment 396947

Maybe i overlooked something?

Oh, right. I think Hashtables work a bit oddly in GUI. You may have to use custom script in order to properly get the handle ID:

set udg_YourInteger = GetHandleId(udg_DamageEventTarget)

Then reference the integer "YourInteger" rather than the Handle ID of the damage event target.

 

[darkravenbest]

Thank you! Yes usually what you can freely do in JASS, is not possible in GUI sometimes. I read about case when you need to get handle ID of unit from varibale and you need to use custom script in the end, but i thought that this case will be a little workaround, and there is more narrow way which i just cant see. I tried your advice and its working. Thank you.

 

[Bribe]

Thank you! Yes usually what you can freely do in JASS, is not possible in GUI sometimes. I read about case when you need to get handle ID of unit from varibale and you need to use custom script in the end, but i thought that this case will be a little workaround, and there is more narrow way which i just cant see. I tried your advice and its working. Thank you.

No problem. Another thing you could do, now that I think of it, is use "Custom value of unit". Since Damage Engine requires Unit Indexer, each unit already has an integer assigned to it which you can use in a GUI hashtable without having to use custom script.

 

[darkravenbest]

No problem. Another thing you could do, now that I think of it, is use "Custom value of unit". Since Damage Engine requires Unit Indexer, each unit already has an integer assigned to it which you can use in a GUI hashtable without having to use custom script.

I actually came with this idea as first solution, it worked well, but i wanted more straight forward way directly using unit ID without adding unit hadle id into its custom value in separate trigger.

 

[Bribe]

I actually came with this idea as first solution, it worked well, but i wanted more straight forward way directly using unit ID without adding unit hadle id into its custom value in separate trigger.

You never would need a unit’s handle ID for reference if you already have its Unit Indexer-assigned ID. It honestly sounds like you gave up too easily.

 

[darkravenbest]

You never would need a unit’s handle ID for reference if you already have its Unit Indexer-assigned ID. It honestly sounds like you gave up too easily.

Yes, maybe i already had good solution in my hands. Well its time to roll back.

 

[Gerional]

Ok, I´m really sorry for that
Playing Warcraft 1.26 and using DamageEvent 3.8 with 3.A.0.0 modification

But I can do anything for like a month
Can someone help me with trouble:


I want to make a trigger, that will cause Dying Unit damage Killing unit for some number.
If I do it by event Unit dies - nothing happens if unit killed by spell.

If I do it by checking the unit`s life before death (DamageEventAmount >= Life of DamageEventTarget) it bugged
Killing unit in this way by normal attacks works fine, but if I kill unit by spell causes unit survive and killing unit receive lot much damage that was noticed in "Cause Damage" action.


Any suggestions?
Thank you very much

 

[Bribe]

Ok, I´m really sorry for that
Playing Warcraft 1.26 and using DamageEvent 3.8 with 3.A.0.0 modification

But I can do anything for like a month
Can someone help me with trouble:


I want to make a trigger, that will cause Dying Unit damage Killing unit for some number.
If I do it by event Unit dies - nothing happens if unit killed by spell.

If I do it by checking the unit`s life before death (DamageEventAmount >= Life of DamageEventTarget) it bugged
Killing unit in this way by normal attacks works fine, but if I kill unit by spell causes unit survive and killing unit receive lot much damage that was noticed in "Cause Damage" action.


Any suggestions?
Thank you very much

Hi,

The equation there is not perfect, but would work in most cases. You'd instead want to do something like "((Life of DamageEventTarget) - DamageEventAmount) Less than 0.41" if you wanted something to cover pretty much every lethal damage event.

If I had to guess why your on-damage trigger is bugged, I'd have to assume it's because you may have forgotten to update the variables from things like (Killing unit) or (Dying unit) to the equivalent DamageEvent variables.

 

[FirstLegacy]

hi can anyone help me with this?.
I'm getting an error. I'm using the Lua Damage Engine based on 5.4.2.3 since i have 1.31.

i got "too many nested ifs (max is 50)"

Spoiler: error

under "damage engine" script.. i'm not familliar with

 

[Bribe]

hi can anyone help me with this?.
I'm getting an error. I'm using the Lua Damage Engine based on 5.4.2.3 since i have 1.31.

i got "too many nested ifs (max is 50)"

Spoiler: error

View attachment 397137

under "damage engine" script.. i'm not familliar with

Seems like the formatting got jacked up there. The equals signs need to be connected, not separated by a space

 

[FirstLegacy]

Seems like the formatting got jacked up there. The equals signs need to be connected, not separated by a space

I tried what you suggested. but I still got the error, I tried on a empty map, but still got the same error.

i'm using 1.31b, i did all the how to install and as well as in preferences but still got "too many nested ifs (max is 50)"
do i need some tools to copy the code???

do I also have to copy the demo folder? i only copied the damage engine folder as the description said..

 

[Bribe]

I tried what you suggested. but I still got the error, I tried on a empty map, but still got the same error.

i'm using 1.31b, i did all the how to install and as well as in preferences but still got "too many nested ifs (max is 50)"
do i need some tools to copy the code???

do I also have to copy the demo folder? i only copied the damage engine folder as the description said..

I honestly can't remember how it goes, but I think you need to copy the demo folder as well. The Lua version is kinda bork as I haven't messed around with Lua in years.

 

[FirstLegacy]

I honestly can't remember how it goes, but I think you need to copy the demo folder as well. The Lua version is kinda bork as I haven't messed around with Lua in years.

ah, thanks.
i think i found the problem, my script languange was set to JASS, since i have some spell and system uses JASS,
is it possible you have some old ver that required 1.31b only in JASS? since I can't access your latest map

 

[Bribe]

ah, thanks.
i think i found the problem, my script languange was set to JASS, since i have some spell and system uses JASS,
is it possible you have some old ver that required 1.31b only in JASS? since I can't accept your latest map

The latest map works perfectly fine with patch 1.31 as long as you add the below function (provided in my "How to install" section) to the top of the Damage Engine library:

 function BlzGetEventIsAttack takes nothing returns boolean
    return BlzGetEventDamageType() == DAMAGE_TYPE_NORMAL
 endfunction

 

[FirstLegacy]

The latest map works perfectly fine with patch 1.31 as long as you add the below function (provided in my "How to install" section) to the top of the Damage Engine library:

 function BlzGetEventIsAttack takes nothing returns boolean
    return BlzGetEventDamageType() == DAMAGE_TYPE_NORMAL
 endfunction

ah sorry, I meant "can't access the map", I tried opening your latest map, but it said level info data missing or invalid,

weird since im 100% sure my war3 is 1.31b patch. maybe I miss something?

 

[Gerional]

Hi,

The equation there is not perfect, but would work in most cases. You'd instead want to do something like "((Life of DamageEventTarget) - DamageEventAmount) Less than 0.41" if you wanted something to cover pretty much every lethal damage event.

If I had to guess why your on-damage trigger is bugged, I'd have to assume it's because you may have forgotten to update the variables from things like (Killing unit) or (Dying unit) to the equivalent DamageEvent variables.

I`ve tried but didn`t worked.
I did it on map attached to ur pastebin post, so no changes to system was made
Probly with that u can get what i mean:

function Trig_Set_Damage_____________________u_Actions takes nothing returns nothing
if GetUnitTypeId(udg_DamageEventTarget) == 'hpea' then
    if GetUnitState(udg_DamageEventTarget,UNIT_STATE_LIFE) - udg_DamageEventAmount <= 0.41 then
        call UnitDamageTargetBJ( udg_DamageEventTarget, udg_DamageEventSource, 500, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL)
    else
    endif
endif
endfunction

//===========================================================================
function InitTrig_Set_Damage_____________________u takes nothing returns nothing
    set gg_trg_Set_Damage_____________________u = CreateTrigger(  )
    call TriggerRegisterVariableEvent( gg_trg_Set_Damage_____________________u, "udg_DamageModifierEvent", EQUAL, 1.00 )
    call TriggerAddAction( gg_trg_Set_Damage_____________________u, function Trig_Set_Damage_____________________u_Actions )
endfunction

Spoiler: Result

Archimond had Divine armor and 3200 HP

 

[Kakerate]

Curious to see changelog updated. I wonder whats new!

 

[Bribe]

Curious to see changelog updated. I wonder whats new!

Not sure what happened to the formatting, but the whole thing is bonkers.

This is what's new with 5.8:

• Added a new functionality to the AOEDamageEvent, which allows it to fire even when only one unit is hit, if the AOEDamageEvent is registered as "Not Equal" instead of "Equal to". This is useful in a very specific scenario where an AfterDamageEvent may not be able to be relied upon to properly deallocate data from a running instance that needs to be able to function when multiple units are hit, but also needs to not fail when only one unit is hit.
• Added additional filters for GUI users to avoid using trigger conditions in even more scenarios:
  • DamageFilterSource/TargetI (has item)
  • DamageFilterSource/TargetA (has ability)
  • DamageFilterSource/TargetC (has a certain classification, like hero or Tauren)
  • DamageFilterFailChance - odds for the trigger to not be run (ideal for critical strike or evasion)
• Provided a way for GUI to un-register a Damage Event by setting "RemoveDamageEvent" to true from within their trigger's actions.
• Moved the CreateTimer/CreateTrigger/CreateGroup calls that had been included in the globals block down to the onInit block as per request of @Ricola3D
• Minor performance improvements thanks to @BLOKKADE

@Gerional which Damage Engine are you on again? DamageEngine 3A should be detecting that recursive flow and not allowing the unit to die. Also, how is the peasant even getting damaged by Archie?

 

[Gerional]

@Gerional which Damage Engine are you on again? DamageEngine 3A should be detecting that recursive flow and not allowing the unit to die. Also, how is the peasant even getting damaged by Archie?

That was 3.8.0.0 without 3.A.0.0.
I deleted part in which Archi heals, for showing main problem - enormous damage loop.

I just can`t get why does this happens?
I thought it would run once - in moment of getting damage by Pea.
Smth like

Pea got damage -> Damage taken > Life of Pea -> Cause Pea Damage DamageSource (Archi in this case) -> Coz Pea already dead and he can`t recieve damage, stop causing damage.

Where i`m wrong?

Sry for this stupid questions, but i`ve already tried every my theory to fix this, and stil can`t get over it

 

[Bribe]

That was 3.8.0.0 without 3.A.0.0.
I deleted part in which Archi heals, for showing main problem - enormous damage loop.

I just can`t get why does this happens?
I thought it would run once - in moment of getting damage by Pea.
Smth like

Pea got damage -> Damage taken > Life of Pea -> Cause Pea Damage DamageSource (Archi in this case) -> Coz Pea already dead and he can`t recieve damage, stop causing damage.

Where i`m wrong?

Sry for this stupid questions, but i`ve already tried every my theory to fix this, and stil can`t get over it

If you're using 3.8 rather than 3A, then you need to take into account the recursion that will trigger when this damage amount is reached. Only Damage Engine 5 and version 3A are considered foolproof when it comes to recursion.

 

[Gerional]

If you're using 3.8 rather than 3A, then you need to take into account the recursion that will trigger when this damage amount is reached. Only Damage Engine 5 and version 3A are considered foolproof when it comes to recursion.

Ok, there is still some questions about 3.A.0.0 in that case

If i`m using 3.A.0.0 i should use it INSTEAD 3.8.0.0 Damage Engine trigger or it should be in ADDITION to this trigger?

Coz if i`m trying to install 3.A.0.0 there is this kind of error so i cant get what shoul to do

Spoiler: error

 

[Bribe]

Ok, there is still some questions about 3.A.0.0 in that case

If i`m using 3.A.0.0 i should use it INSTEAD 3.8.0.0 Damage Engine trigger or it should be in ADDITION to this trigger?

Coz if i`m trying to install 3.A.0.0 there is this kind of error so i cant get what shoul to do

Spoiler: error

View attachment 397151

You would delete all the JASS from the 3.8 damage engine script and replace it with the vJass of the 3A script. I am pretty sure that the Config trigger does not need to be amended.