Damage Engine 5.A.0.0

[Bribe]

Yep you can make as many as you want as long as they use unique numbers. Just make sure if you want the damage type to explode the unit that the number is less than zero.

 

[The Wanderer]

Yep you can make as many as you want as long as they use unique numbers. Just make sure if you want the damage type to explode the unit that the number is less than zero.

Ok cool! Thanks for this awesome system Mr. Bribe!

 

[ssbbssc2]

i have some issues with multiplayer and assume that DE isnt working
does someone face dat bug as i am?
i cant see any damage msg and error msgs aswell

 

[chanckaka]

Hello, may I ask you a question?
if I have so much hero and spell that need this system, should I include all spell in single trigger (Set Damage)?
If yes, this trigger will have so much "if else", may be 100+, will the performance become slow? (Also it will be more difficult to manage spell)
If no, some spell may used to block or decrease damage, but it may overwrite by other trigger that placed below it?

Sorry for bothering you.

 

[Wietlol]

i have some issues with multiplayer and assume that DE isnt working
does someone face dat bug as i am?
i cant see any damage msg and error msgs aswell

Is it only in multiplayer?
(Also, did you disable the debug mode? In which case the debug messages should disappear alltogether.)

 

[ssbbssc2]

Is it only in multiplayer?
(Also, did you disable the debug mode? In which case the debug messages should disappear alltogether.)

looks like i fixed this by renewing all main triggers, including unit indexer and DE aswell
but this is very strange, cus i didnt touch them at all and they are updated
but now i randomly gets a recursion error... some weird shit is happening wuth my map :\

This was only in MP, SP was good

 

[13lack_Ro$e]

Hello.Is there anyway to detect damage before armor reduces it with this system?because I tried every event and variable but it always gives me the the damage amount after armor affected it (for example damage is 50% less than attacker damage) tnx.

 

[Wietlol]

Not as far as I know.
The best approach would be to not use the default damage engine and instead code it yourself, but that is not so easy to do.
Another way would be to deal some damage and compare the result with the damage value.
After that, you set the life back to what it was before the damage you dealt and then you have the factor of how much the damage was increased/decreased.
However, that would still not apply attack type/armor type, abilities that apply flat bonus damage or flat damage reduction (potentially with a limit), etc.

 

[Spellbound]

Use ArmorUtils. Then you do this set damage = GetFullDamage(udg_DamageEventPrevAmt, GetUnitArmor(udg_DamageEventTarget)) to get the full damage. You can then re-apply it as you see fit, but be sure to set udg_DamageEventAmount to 0 or else you'll be stacking damages.

 

[13lack_Ro$e]

thx

 

[The Wanderer]

Mr. Bribe? Is there a way to store crit rate and damage via variables for player controlled units and then modify them by using passive spells or items by using this system?

Like when a hero has 6 items that have 5% crit rate each and gets added up so it would be 30% and when a passive skill is learned the crit rate gets added up as well. Same goes for crit damage.

 

[Spellbound]

Have an array variable (real, eg YourCritRate) that will store the crit rate of a unit, then every time that unit picks up/drops a crit item or learns/unlearns a crit passive spell, just add the crit value to the existing rate. Then everytime you are dealt damage do:

• Crit Rate
  • Events
    • DamageModifierEvent Equal to 1.00
  • Conditions
  • Actions
    • Set ID = (Custom value of DamageEventSource)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Random real number between 0.00 and 100.00) Less than or equal to YourCritRate[ID]
      • Then - Actions
        • set udg_DamageEventAmount = udg_DamageEventAmount * .01 * YourCritRate
      • Else - Actions

Or here's JASS, if you prefer.

local integer id = GetUnitUserData(udg_DamageEventSource)
if GetRandomReal(0, 100.00) <= udg_YourCritRate[id] then
    set udg_DamageEventAmount = udg_DamageEventAmount * .01 * YourCritRate
endif

 

[The Wanderer]

Have an array variable (real, eg YourCritRate) that will store the crit rate of a unit, then every time that unit picks up/drops a crit item or learns/unlearns a crit passive spell, just add the crit value to the existing rate. Then everytime you are dealt damage do:

• Crit Rate
  • Events
    • DamageModifierEvent Equal to 1.00
  • Conditions
  • Actions
    • Set ID = (Custom value of DamageEventSource)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Random real number between 0.00 and 100.00) Less than or equal to YourCritRate[ID]
      • Then - Actions
        • set udg_DamageEventAmount = udg_DamageEventAmount * .01 * YourCritRate
      • Else - Actions

Or here's JASS, if you prefer.

local integer id = GetUnitUserData(udg_DamageEventSource)
if GetRandomReal(0, 100.00) <= udg_YourCritRate[id] then
    set udg_DamageEventAmount = udg_DamageEventAmount * .01 * YourCritRate
endif

Is this compatible in multiplayer maps? And why modify DamageEventAmount? Would that affect the damage dealt?

I'll work on this later its christmas eve and im busy preping. Thanks btw.

 

[Spellbound]

DamageEngine is MUI, so yep, it'll work in multiplayer. You can also directly modify DamageEventAmount to change the damage that gets applied.

Merry Christmas!

 

[The Wanderer]

DamageEngine is MUI, so yep, it'll work in multiplayer. You can also directly modify DamageEventAmount to change the damage that gets applied.

Merry Christmas!

likewise man! so the above triggers will work for crit chance and crit damage?

 

[Spellbound]

I haven't tested it, but it should.

 

[The Wanderer]

I haven't tested it, but it should.

ok man i will test it. a quick question, what variable is the "ID"?

 

[Spellbound]

ID is an integer. Use it to store the custom value of the unit. All units are assigned a unique number when they're created since to use Damage Engine, you need to be using Unit Indexer as well. That helps making array variables unique to them, thus the use of ID.

 

[The Wanderer]

oooh ok you made it so simple, i thought the triggers would be long and complex.

 

[Wietlol]

"set udg_DamageEventAmount = udg_DamageEventAmount * .01 * YourCritRate"
You use the same variable twice.
You should have 2 different variables:
Real : 0 - 100 : critical strike chance.
Real : 0 - inf : critical strike damage. (preferably where a critical strike damage of 1 wouldnt chance anything and 2 would double it.)

 

[Spellbound]

Doh, silly me, ofc. Must have been distracted.

@The Wanderer:
This set udg_DamageEventAmount = udg_DamageEventAmount * .01 * YourCritRate should be this instead set udg_DamageEventAmount = udg_DamageEventAmount * .01 * YourCritAmount. If you want to have damage increased by, say 50% per crit, set the YourCritAmount to 1.5 and just do udg_DamageEventAmount * YourCritAmount instead. Easy peasy.

 

[The Wanderer]

Doh, silly me, ofc. Must have been distracted.

@The Wanderer:
This set udg_DamageEventAmount = udg_DamageEventAmount * .01 * YourCritRate should be this instead set udg_DamageEventAmount = udg_DamageEventAmount * .01 * YourCritAmount. If you want to have damage increased by, say 50% per crit, set the YourCritAmount to 1.5 and just do udg_DamageEventAmount * YourCritAmount instead. Easy peasy.

i cant see the whole line.

 

[Spellbound]

The line is the same, I just swtiched YourCritRate to YourCritAmount. They're different variables. The CritRate checks for the chance that you will crit, and the CritAmount defines but how much the damamge will be multiplied. For a 50% increase, it's 1 + 0.5 = 1.5. For 100% increase it's 1 + 1 = 2, etc.

 

[The Wanderer]

ok so i got a little time to test the triggers out and ended up dealing zero crit damages. was quite drunk but will test things again.

 

[Spellbound]

Post your full trigger if you still have trouble getting it to work.

 

[The Wanderer]

Post your full trigger if you still have trouble getting it to work.

Ok so i tried it again using the given triggers and got it working but i think theres something wrong.

I set the CritRate to 0.25 assuming its 25%

set the CritDamage to 1.50 (assuming again it adds 50% to base damage when crit activates)

My concerns are:

When the hero is at level 1, it takes 10 to 15 or more before crit activates but when it reaches level 2, it only takes 1-3 to crit and almost everytime. (CritRate is still at 0.25)

Second is i think the crit damage is way too high. The hero has 26-34 base damage and when it crits the damage gets to 200-300+ (way too high for a 50% increase in damage. CritDamage is still at 1.50)

I replicated the triggers exactly like shown here.

 

[Spellbound]

I need you to post the entire thing, not just go from the snippet I gave you. There could be other things interfering with the code.

How to easily post triggers

 

[The Wanderer]

I did exactly what you showed me

• Test
  • Events
    • Game - DamageModifierEvent becomes Equal to 1.00
  • Conditions
  • Actions
    • Set Hero_ID = (Custom value of DamageEventSource)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Random real number between 0.00 and 100.00) Less than or equal to Test_Crit_Rate[Hero_ID]
        • (DamageEventSource is A Hero) Equal to True
      • Then - Actions
        • Set DamageEventType = DamageTypeCriticalStrike
        • Set DamageEventAmount = (DamageEventAmount x Test_Crit_Damage[Hero_ID])
      • Else - Actions

and this is i did to set the crit rate and damage

• Test 2
  • Events
    • Game - DamageModifierEvent becomes Equal to 1.00
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (DamageEventSource has an item of type |cffff8c00SOUL SWORD|r|n) Equal to True
      • Then - Actions
        • Set Test_Crit_Rate[Hero_ID] = (Test_Crit_Rate[Hero_ID] + 0.25)
        • Set Test_Crit_Damage[Hero_ID] = (Test_Crit_Damage[Hero_ID] + 0.25)
      • Else - Actions

 

[The Wanderer]

Ok so i tried another approach on increasing crit rate and damage by acquiring items and here's the trigger

• Test 2
  • Events
    • Unit - A unit Acquires an item
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Item-type of (Item being manipulated)) Equal to |cffff8c00SOUL SWORD|r|n
      • Then - Actions
        • Set CritRate[Hero_ID] = (CritRate[Hero_ID] + 25)
        • Set Test_Crit_Damage[Hero_ID] = (Test_Crit_Damage[Hero_ID] + 2.20)
        • Game - Display to (All players) for 10.00 seconds the text: (String(CritRate[Hero_ID]))
      • Else - Actions

But the problem is when you drop/pick the item the crit rate and damage will increase continuously.

 

[Spellbound]

First of all, avoid double-posting and use the Edit link in green at the bottom of your post.

Secondly, referring to your first method of damage increase, doing the following:

• Set Test_Crit_Rate[Hero_ID] = (Test_Crit_Rate[Hero_ID] + 0.25)
• Set Test_Crit_Damage[Hero_ID] = (Test_Crit_Damage[Hero_ID] + 0.25)

...will keep increasing the crit rate and damage forever, so you need to reset them. However, it's not the best way to do it, imo. Do you have any stacking crit items?

For the second method you used, you need to have a trigger that removes the +25 and +2.20 from your hero whenever they drop the crit item. Aka: Unit - A unit Loses an item

 

[The Wanderer]

First of all, avoid double-posting and use the Edit link in green at the bottom of your post.

Secondly, referring to your first method of damage increase, doing the following:

• Set Test_Crit_Rate[Hero_ID] = (Test_Crit_Rate[Hero_ID] + 0.25)
• Set Test_Crit_Damage[Hero_ID] = (Test_Crit_Damage[Hero_ID] + 0.25)

...will keep increasing the crit rate and damage forever, so you need to reset them. However, it's not the best way to do it, imo. Do you have any stacking crit items?

For the second method you used, you need to have a trigger that removes the +25 and +2.20 from your hero whenever they drop the crit item. Aka: Unit - A unit Loses an item

Yeah the first method has:

• Events
  • Game - DamageModifierEvent becomes Equal to 1.00

So i guess everytime the crit activates it raises both.

The second one has a little issue though it doesnt add the first time the item is picked and i further tested it with a trigger that subtracts the numbers when item is lost, the crit rate and damage is reduced to 0 even if the item is not dropped. Attacked a unit and then debugged, the number is 0.

Uploaded a map to test triggers.

 

[Spellbound]

There wasn't any item-drop trigger, but I assume you tested the map with one? The main issue, however, was that you weren't telling the game what the value of Hero_ID was supposed to be.

• Item Pickup
  • Events
    • Unit - A unit Acquires an item
  • Conditions
  • Actions
    • Set Hero_ID = (Custom value of (Hero manipulating item))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Item-type of (Item being manipulated)) Equal to |cffff8c00SOUL SWORD|r|n
      • Then - Actions
        • Set CritRate[Hero_ID] = (CritRate[Hero_ID] + 25)
        • Set Test_Crit_Damage[Hero_ID] = (Test_Crit_Damage[Hero_ID] + 2.20)
      • Else - Actions

• Item Drop
  • Events
    • Unit - A unit Loses an item
  • Conditions
  • Actions
    • Set Hero_ID = (Custom value of (Hero manipulating item))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Item-type of (Item being manipulated)) Equal to |cffff8c00SOUL SWORD|r|n
      • Then - Actions
        • Set CritRate[Hero_ID] = (CritRate[Hero_ID] - 25)
        • Set Test_Crit_Damage[Hero_ID] = (Test_Crit_Damage[Hero_ID] - 2.20)
      • Else - Actions

• Debug
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • Set Hero_ID = (Custom value of Crusader 0000 <gen>)
    • Game - Display to (All players) for 5.00 seconds the text: (CritRate + :) + (String(CritRate[Hero_ID]))))

These triggers worked for me.

 

[The Wanderer]

There wasn't any item-drop trigger, but I assume you tested the map with one? The main issue, however, was that you weren't telling the game what the value of Hero_ID was supposed to be.

• Item Pickup
  • Events
    • Unit - A unit Acquires an item
  • Conditions
  • Actions
    • Set Hero_ID = (Custom value of (Hero manipulating item))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Item-type of (Item being manipulated)) Equal to |cffff8c00SOUL SWORD|r|n
      • Then - Actions
        • Set CritRate[Hero_ID] = (CritRate[Hero_ID] + 25)
        • Set Test_Crit_Damage[Hero_ID] = (Test_Crit_Damage[Hero_ID] + 2.20)
      • Else - Actions

• Item Drop
  • Events
    • Unit - A unit Loses an item
  • Conditions
  • Actions
    • Set Hero_ID = (Custom value of (Hero manipulating item))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Item-type of (Item being manipulated)) Equal to |cffff8c00SOUL SWORD|r|n
      • Then - Actions
        • Set CritRate[Hero_ID] = (CritRate[Hero_ID] - 25)
        • Set Test_Crit_Damage[Hero_ID] = (Test_Crit_Damage[Hero_ID] - 2.20)
      • Else - Actions

• Debug
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • Set Hero_ID = (Custom value of Crusader 0000 <gen>)
    • Game - Display to (All players) for 5.00 seconds the text: (CritRate + :) + (String(CritRate[Hero_ID]))))

These triggers worked for me.

ohhh! So you have set the Hero_ID to the crusader? What i did was set it to DamageEventSource like on your first example. And why did you set the hero id on the periodic trigger? is that for debugging purpose only?
yes i tested it unit loses an item as well.

 

[Spellbound]

The trigger won't know the value of Hero_ID unless to tell it what it is. Setting it to the custom value of the crusader ensured that the correct array was being read. It's just good practice to do that even if you're just testing for one unit.

 

[The Wanderer]

The trigger won't know the value of Hero_ID unless to tell it what it is. Setting it to the custom value of the crusader ensured that the correct array was being read. It's just good practice to do that even if you're just testing for one unit.

ok thanks man! will test this out as soon as i can.

 

[The Wanderer]

Have an array variable (real, eg YourCritRate) that will store the crit rate of a unit, then every time that unit picks up/drops a crit item or learns/unlearns a crit passive spell, just add the crit value to the existing rate. Then everytime you are dealt damage do:

• Crit Rate
  • Events
    • DamageModifierEvent Equal to 1.00
  • Conditions
  • Actions
    • Set ID = (Custom value of DamageEventSource)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Random real number between 0.00 and 100.00) Less than or equal to YourCritRate[ID]
      • Then - Actions
        • set udg_DamageEventAmount = udg_DamageEventAmount * .01 * YourCritRate
      • Else - Actions

On the ID part should i set it as is or to the custom value of the unit? Because it is where the actuall crit rate and crit damage activates.

 

[Spellbound]

You need to set it to the custom value (CV) of the hero (remember, Damage Engine uses Unit Indexer, so by default all your units are going to be a assigned a unique number as their custom value). Whenever you need to find out what the CritRate is, identify what your unit is going to be referred to as. If the trigger's event is Starts the Effect of an Ability, then your unit is the (Triggering Unit). If it's an item that was picked up, it going to be (Hero manipulating item). For DamageEngine, per Bribes instruction in the system's readme, the unit is the one inflicting the damage, therefore you need to find the CV of the (DamageEventSource).

 

[The Wanderer]

You need to set it to the custom value (CV) of the hero (remember, Damage Engine uses Unit Indexer, so by default all your units are going to be a assigned a unique number as their custom value). Whenever you need to find out what the CritRate is, identify what your unit is going to be referred to as. If the trigger's event is Starts the Effect of an Ability, then your unit is the (Triggering Unit). If it's an item that was picked up, it going to be (Hero manipulating item). For DamageEngine, per Bribes instruction in the system's readme, the unit is the one inflicting the damage, therefore you need to find the CV of the (DamageEventSource).

Oh ok. So for every active spell i make i should set the ID to triggering unit?

btw i tested it further and it worked perfectly thanks to you! Havent tried it on different players but will sure do.

 

[The Wanderer]

Hey i think we could update and put many features in Mr. Bribe's damage engine. I come up with ideas and you do the triggers.

 

[Spellbound]

Triggers take time to make and especially debug. I don't really have the time to be adding new stuff to it, unfortunately.

 

[SpasMaster]

Hello, I got a tiny issue. I am using the system for custom critical strikes (besides other things), but I encountered a small problem:

Units with crit properly do the critical damage, however the floating text does not change as it should. For some reason the DamageEventType = DamageTypeCriticalStrike does not work, I believe.

Hidden

[trigger=""]
Damage Critical Strike
Events
Game - DamageModifierEvent becomes Equal to 1.00
Conditions
DamageEventAmount Greater than or equal to 1.00
IsDamageSpell Equal to False
Actions
-------- CRITICAL STRIKE --------
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(DamageEventSource is A Hero) Equal to True
(Random real number between 0.00 and 100.00) Less than or equal to CriticalStrike_Chance[(Player number of (Owner of DamageEventSource))]
Then - Actions
Set DamageEventType = DamageTypeCriticalStrike
Set DamageEventAmount = ((DamageEventAmount x CriticalStrike_Rating[(Player number of (Owner of DamageEventSource))]) + Animosity_Bonus)
Else - Actions
[/trigger]

In the above trigger, the damage is properly manipulated. The chance works well, the Critical Strike_Rating properly increases the damage dealt. Everything is fine. Except that the floating message in the next trigger does not happen, like the 'Set DamageEventType = DamageTypeCriticalStrike' did not happen in the first trigger.

Crit should happen in Orange with exclamation mark.
Spell should happen in Purple.
Attacks should happen in Red.

Even when Crit happens (cause I see the value is doubled) text is still red.

Hidden

[trigger=""]
Damage Floating Text
Events
Game - DamageEvent becomes Equal to 1.00
Conditions
DamageEventAmount Greater than or equal to 1.00
Actions
Set GenericPlayerGroup = (All players matching ((Matching player) Not equal to (Owner of DamageEventSource)))
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
DamageEventType Equal to DamageTypeCriticalStrike
Then - Actions
Set DamageTypeColor_Used = |c00ff6600
Floating Text - Create floating text that reads (DamageTypeColor_Used + ((String((Integer(DamageEventAmount)))) + !)) above DamageEventTarget with Z offset 0.00, using font size 9.50, color (100.00%, 100.00%, 100.00%), and 0.00% transparency
Floating Text - Hide (Last created floating text) for GenericPlayerGroup
Floating Text - Set the velocity of (Last created floating text) to 100.00 towards 90.00 degrees
Floating Text - Change (Last created floating text): Disable permanence
Floating Text - Change the lifespan of (Last created floating text) to 2.75 seconds
Floating Text - Change the fading age of (Last created floating text) to 0.65 seconds
Else - Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
IsDamageSpell Equal to True
Then - Actions
Set DamageTypeColor_Used = |c00cc66ff
Floating Text - Create floating text that reads (DamageTypeColor_Used + (String((Integer(DamageEventAmount))))) above DamageEventTarget with Z offset 0.00, using font size TextSize_dmg, color (100.00%, 100.00%, 100.00%), and 0.00% transparency
Floating Text - Hide (Last created floating text) for GenericPlayerGroup
Floating Text - Set the velocity of (Last created floating text) to 100.00 towards (Random real number between 45.00 and 135.00) degrees
Floating Text - Change (Last created floating text): Disable permanence
Floating Text - Change the lifespan of (Last created floating text) to 2.00 seconds
Floating Text - Change the fading age of (Last created floating text) to 0.65 seconds
Else - Actions
Set DamageTypeColor_Used = |c00FF0303
Floating Text - Create floating text that reads (DamageTypeColor_Used + (String((Integer(DamageEventAmount))))) above DamageEventTarget with Z offset 0.00, using font size TextSize_dmg, color (100.00%, 100.00%, 100.00%), and 0.00% transparency
Floating Text - Hide (Last created floating text) for GenericPlayerGroup
Floating Text - Set the velocity of (Last created floating text) to 100.00 towards (Random real number between 45.00 and 135.00) degrees
Floating Text - Change (Last created floating text): Disable permanence
Floating Text - Change the lifespan of (Last created floating text) to 2.00 seconds
Floating Text - Change the fading age of (Last created floating text) to 0.65 seconds
Custom script: call DestroyForce(udg_GenericPlayerGroup)
[/trigger]

Any ideas?

 

[Wietlol]

Maybe a different trigger is overriding the variable.

Try to display the value of DamageTypeCriticalStrike in both of the triggers.

(Btw, +1 for actually making poper use of the events.)

 

[SpasMaster]

Maybe a different trigger is overriding the variable.

Thanks, that was indeed the issue. @IcemanBo helped me identify it in PM.
I am getting used to the system, I recently imported it.

Few minutes ago I struggled with the following issue:
-I have an item that causes triggered splash spell damage when the hero crits. (Splash Damage is dealt by the DamageDealerTower_Splash dummy unit).

Hidden

[trigger=""]
Damage Attack Splash
Events
Game - DamageEvent becomes Equal to 1.00
Conditions
DamageEventAmount Greater than or equal to 1.00
IsDamageSpell Equal to False
Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
DamageEventType Equal to DamageTypeCriticalStrike
(DamageEventSource has an item of type |c007c2abbThe Twins|r) Equal to True
Then - Actions
Set Generic_Point = (Position of DamageEventTarget)
Set Generic_Group = (Units within 150.00 of Generic_Point matching (((Owner of (Matching unit)) Not equal to (Owner of DamageEventSource)) and ((((Matching unit) belongs to an ally of (Owner of DamageEventSource)) Not equal to True) and ((((Matching unit) is A structure) Not equ
Unit Group - Pick every unit in Generic_Group and do (Actions)
Loop - Actions
Unit - Cause DamageDealerTower_Splash[(Player number of (Owner of DamageEventSource))] to damage (Picked unit), dealing (0.35 x DamageEventAmount) damage of attack type Spells and damage type Magic
Special Effect - Create a special effect attached to the origin of DamageEventTarget using Abilities\Spells\Human\SpellSteal\SpellStealTarget.mdl
Special Effect - Destroy (Last created special effect)
Custom script: call RemoveLocation(udg_Generic_Point)
Custom script: call DestroyGroup(udg_Generic_Group)
Else - Actions
[/trigger]

-When the effect procs, the splash damage floating text appeared, but the crit text did not. When there were no units to splash on, the crit text showed properly.
-I figured I have to use <Game - AfterDamageEvent becomes Equal to 1.00> when I want the splash to happen.
-That fixed it, now I see both floating texts and everything is fine. I am not certain why exactly <Game - DamageEvent becomes Equal to 1.00> hid the Critical Strike text when splash happened tho and why I needed to use the <Game - AfterDamageEvent becomes Equal to 1.00> event, but hey.. at least I fixed the issue

 

[Wietlol]

This is the case where I kind of hate GUI: Object Oriented Programming (OOP).
Or to be more precise, Non-OOP.

In your trigger, you have an event that fires when a unit attacks, then you set it to be a critical strike.
Then, you deal splash damage and run other damage instances.
When they are all done, you continue with your original attack, but you lost the data of that attack being a critical strike.

In OOP, you have different object and you give each of them their own variables, then you can give each of them their own boolean of wether they are critical strikes or whatever without overwriting any of the other instances.

 

[Shaeam]

How is the best way to detect if damage is cleaved? I'm using this for an ability that gives the Hero cleave damage for X amount of attacks, or a duration. When I detect an attack the cleave damage sets the variable for the trigger +X however many units were hit, instead of +1 which is a huge problem as you can well imagine.

Is it possible for me to filter cleave somehow or do I need to find a clever work around?

 

[13lack_Ro$e]

Hi , I used this system together with Bribe's knock back 2d system for a unit's ability , worked just fine until I added another ability to that unit that is a pulverize ability , after casting first one and a few (like 10 or so) pulverizes it starts to send me an error message :

"Warning : Recursion error when dealing damage! Make sure when you deal damage from within a DamageEvent trigger , do it like this :
Trigger - Turnoff this trigger
Unit - Cause ...
Trigger - Turnon this trigger"

well none of these two spells damage by triggers , the damage event is used as a detection for knockback time , I tried to add a turnoff/turnon this trigger to knock back trigger but still same error comes.

Tried to ignore the error but noticed that after the message show , the main target that is attacked gets healed when pulverize occurs.

Does this system has bugs with pulverize based spells? Or does it need to be configured?

 

[KeepitMovinBaby]

Ah, finally i found this. This really deserves a Director's Cut. 6/5

 

[SpasMaster]

I am running into the recursion error as well. I have multiple damage detecting triggers that have the "damage unit" action within them and all use the <Turn Off> and <Turn On> method. It appears however, that this action still runs at least once, thus running all other damage detection triggers.

Apparently the system has a set limit where the Recursion Error is displayed. What are the best ways to avoid it?

 

[Vengyr]

Need help detecting the specific ability which does damage. While some are instant and can be done as you do in the example, how to track non-instant is beyond my understanding. Maybe if those are triggered and issued by a specific dummy, but maybe there's another way?

 

[Spellbound]

Disclaimer: not 100% sure this will work, but I did that before with poison arrow and it worked.

If you want to track non-instant ability damage, the spell in question needs to apply a buff that is immediately removed. For example, use Acid Bomb and then when if udg_DamageEventType == 0 and udg_IsDamageSpell and GetUnitAbilityLevel(udg_DamageEventTarget, 'buff id') > 0 then will detect that specific spell. You will have to immediately remove the buff, don't forget. In GUI, it looks like so:

• Acid Bomb Test
  • Events
    • Game - DamageModifierEvent becomes Equal to 1.00
  • Conditions
    • DamageEventType Equal to 0
    • IsDamageSpell Equal to True
    • (DamageEventTarget has buff Acid Bomb) Equal to True
  • Actions
    • Unit - Remove Acid Bomb buff from DamageEventTarget
    • ... then add the rest of this spell's feature...

Otherwise, a custom missile system (if you're using projectiles) would give you control to when the missile hits.

Bribe also has a system specific for making MUI spells: GUI Spell System. The only issue is that there is a learning curve on this system.