Damage Engine 5.A.0.0

[Almia]

Wow, I didn't even know that this supports Damage Detection and this received a DC.

Great job indeed, you always amaze me Bribe

 

[Hydrolisk]

How does the damage event recursion detection work? When it occurs, it seems that the system breaks. When I skim the code it looks like there is a limit (16) of recursions allowed to occur before it breaks and issues the damage recursion warning.

To avoid the recursion warning, I have tried to Disable/Enable the triggering triggers, avoiding damaging units that I know would cause a recursion, and changing "if i < 16 then" to "if i < 32 then" (code line 95, v3.9), and only the last solution worked (but I am afraid of side effects).

 

[Bribe]

There really shouldn't be any damage that is fired more times than necessary. The recursion warning once popped up more often than it was supposed to due to a (now resolved) glitch. You said you are on v3.9? Damage Engine is only 3.6. Would you like to share the map with me via PM and I see what's up?

 

[Hydrolisk]

My bad, it is indeed, I made a mistake. Sure, will do.

 

[Almia]

Hmm, need opinions.


Should I pick this over DamageEvent (lfh)?

 

[Bribe]

DamageEvent by Nestharus is a great resource that I was fortunate enough to be able to contribute a small amount to. It is very powerful. Damage Engine is an epic resource for GUI users since it has cross-compatibility with Weep's GDD and LFH's PDD. Ultimately, the choice is yours, since it is a choice and not a strict A > B scenario.

Edit: upon re-read of your post I see you wrote LFH next to it, so you're referring to PDD. I sometimes recommend PDD if the user doesn't need certain behavior, but DamageEngine has great extras like separating damage modification from just the damage event, as well aa giving access to the AfterDamageEvent and handling recursion in a bug-free way.

 

[Almia]

oh great

I think I should pick this over LFH, tho I think it would be better if you have some sort of "Plugin" for it in vJASS

 

[Bribe]

This simplifies a lot of the ugliness in getting a vJass version: http://www.hiveworkshop.com/forums/submissions-414/snippet-realevent-270158/

I've worked on a vJass DamageEngine before, but recieved essentially 0 feedback:

http://www.hiveworkshop.com/forums/...mageengine-plugin-damage-engine-3-2-a-269711/

http://www.hiveworkshop.com/forums/lab-715/vjass-alternative-damageengine-270064/

 

[Almia]

thanks

 

[Spacebuns]

Which variable do I use to refer to the damage before armor reductions? For example, Meat Wagon has 100 damage, after armor reduction from a Medium armor unit 50 damage is dealt, I want to get the 100 damage.

 

[Bribe]

That's impossible (very difficult to implement and too full of bugs to be reliable) unless you only modify your damage through triggers. Blizzard did not give us the ability to access a unit's attack value via triggers.

 

[Almia]

i think that's possible, by applying the inverse function of armor effectiveness given the result damage, i think that would output the original value(tho what would be hard is that it would apply the attack type table values)

 

[Bribe]

>> Armor value

That's what I'm referring to as being too unreliable. I disregard it as impossible unless Blizzard gives us a GetUnitArmorValue native. You just have to read the criticism of existing armor libraries to discover the method can fail in countless unpredictable ways.

 

[Spacebuns]

Oh, so I assume that other damage detection systems are limited at referring to attack value after reduction (e.g. the one used in Dota, for damage negation spells)?

 

[Bribe]

Yes, all in-game damage modification is processed beforehand. It would be amazing if there was a "pre-damage-event" where it gives you the ability to:

- View the original damage amount
- View the attack & damage type
- MODIFY that damage amount and attack/damage types so WC3's processing handles them differently

Since the game engine lacks the ability to do those things, triggering special damage modification is the best way to go.

 

[Almia]

damage negation do you mean blocking the damage? just heal the unit to the received damage to completely negate it.

 

[Bribe]

damage negation do you mean blocking the damage? just heal the unit to the received damage to completely negate it.

That only works when the damage is less than the unit's max life and the unit's current life + the blocked damage is less than the unit's full health. Hence why I use the Cheat Death Ability.

What I was referring to was in-game-engine damage modification, so that a unit can keep its normal anti-magic shell, mana shield, critical strike, etc. complemented by the user's scripted damage processing. Say you want to nullify all damage of the next attack via triggers - but the unit has a mana shield. The game engine will still take mana from the unit even if the user sets the damage to 0. That's why I recommend using the custom abilities featured in the demo map and to trigger any damage that you want fully-modifyable.

 

[Woodenplank]

The only thing that bothers me about this is that Bribe has already helped me so much, that I cannot give this more reputation "before spreading some about".

Deeply grateful for this system, and all the great opportunity it opens up.

 

[Thombien]

When I try to do an Floating text that indicate DamageEventAmount, i see it with 3 decimal how can we set it with no decimal ?

 

[Bribe]

You have to convert the real to integer and display it as an integer. A lot of people just copy the text right out of the demo map.

 

[blancfaye7]

It is said that I need to comment before rating. Here goes.

I've been using this system and I like it. Works on all my triggers. A few bugs here and there are caused by me, so I shouldn't doubt the system in the first place (how arrogant of me).

5/5!

 

[Bribe]

thanks - glad you like it!

 

[Thombien]

How could i remove the Gold: 0 Under my unit ?

 

[Thombien]

When I put my mouse on a unit, I can see his name but I got Gold : 0 Under is name, how can i remove the variable Gold : 0 ?

 

[Bribe]

That's not caused by this system. Check all the fields towards the bottom of that unit in Object Editor to see if one of them says "Gold: 0".

 

[Thombien]

It mark on every unit. When i disable the gui , it remove the gold and the name

 

[Thombien]

It show gold like gold mine but on every unit ( custom and original unit)

 

[Remixer]

How do I detect if certain unit type deals dmg? If I want to have a passive ability thats triggered ;s? Only lets me select individual units.

 

[Spacebuns]

You use "Unit type of (DamageEventSource) equals to ..." condition.

 

[Remixer]

Exactly what I was looking for. I knew it was somewhere but just could not think of the way (hidden in front of my eyes).

 

[Wietlol]

You should use "Ability level of MyPassiveAbility for DamageEventSource is greater than 0"
Which checks if the unit has the ability or not.
Sounds more logical right?

 

[vuakudo]

Hey umm, i don't know if this was mentioned before but in my map, after playing for a while the DDS broke (the triggers didn't work anymore) and all the spell damage became negative/healed the target. I don't know what caused it so can anyone help me please? I use GUI Unit Event and the latest DDS

 

[Wietlol]

Sounds like the cleanup isnt working.
I thought I knew how the cleanup is used in this system, but cant recognize it any more.

How long does it take to make this happen?
At least an estimation, 60 seconds, 3 minutes, 10 minutes, 60 minutes?

 

[vuakudo]

Last time i tried was about 10 minutes

 

[Bribe]

It sounds like you are using an old version of Damage Engine. Can you PM me the map so I can check?

 

[Slifer62]

Hey Bribe!

First things first : just thank you for all you incredible systems, I've managed to reproduce my favorite champions in League of Legends in W3 (and even making them MUI!) only thanks to your systems!

Second thing : you say that Life Drain is bugging and doesn't give hp to the caster with this system.
but... it does give the hp, even with the fix turned off.

At first I just copied and pasted your triggers in my test map, and then I noticed that the life drain was healing the double of the damage dealt. I then turned off the fix, and now it just works perfectly.

I tested it with Sylvanas / the Dark Ranger and I even gave the Blood Mage a Life Drain (by modifying his original ability that only drains Mana I think), both work well without the fix.

I don't know if this bug was fixed a long time ago and you just forgot to state it for everyone, or if you fixed it by doing something else and think it still is bugging, or if it should bug and that my map is special (lol I wouldn't know why since I'm not a coder at all and didn't touch the code), but anyway I just wanted to tell you that it's not bugging.

Thanks again for your systems, using them alltogether (Spell System with Loop + Knockback System = creating a blackhole-like spell in like 3 minutes, it would have taken me a whole week of work otherwise, and your Damage Modifier 4 and Shield is simply brilliant, I wouldn't have been able to recreate Orianna if it wasn't thanks to you) is just like an epic combo haha just thanks and good job!♥

(sorry for any spelling mistakes or grammar mistakes, English isn't my first language)

EDIT : and if somebody already told you that then sorry but I didn't read all of the 25 pages

 

[Wietlol]

My guess... is that you didnt properly configure the system.
The Spell Damage Reduction ability in particular.

 

[Slifer62]

But... even if I didn't configure it properly... everything works fine. Spell damages are detected, and the same goes for every damage detection (I'm using custom damage types like the ones created by Bribe). Everything does work perfectly.

And anyway I just checked, I have the very same settings (DmgEvBracers = disabled, Detect Spell Damage just has 2 dmg reduction just like in the test map).

Why is the Life Drain not supposed to work? I might have done something that fixed it in my other triggers, even though I HIGHLY doubt it since I've no trigger that is supposed to intervene during Life Drain.

Screenshots of my settings :

Spoiler

Spoiler

 

[Wietlol]

The life drain dmg is spell dmg, which gets inverted because of the spell dmg reduction ability.
And because the dmg is inverted, the healing is either negative (damaging yourself) or none.
Because the damage you actually see is the triggered damage, this doesnt apply to the life drains.

 

[Slifer62]

Ah, I thought so. Didn't understand fully how the system was coded, but now I get it. Thanks a lot!

I've tried using Drain more times just to experiment, changing the values etc, and it still works without the fix.

Weird.

 

[LittleBigApple]

I tried the system in my map which only contains a hero with an ability set including Rejuvenation.
When I copied the triggers and the required abilities from the Demo Map into my map, the hero had lost only his Rejuvenation spell (in game) and died instantly when he took only 30 dmg (he had 400hp).
Does anybody know the solution to this? The Demo map worked perfectly when I tried it!

 

[Wietlol]

Read "How to install".
You have to let the system know which ability is which.
Check the configuration trigger and you should be fine.

 

[LittleBigApple]

I am so stupid. Thank you very much.

 

[ssbbssc2]

Hey Bribe
What should i do to make this work?

• Set Damage
  • Events
    • Game - DamageModifierEvent becomes Equal to 1.00
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (DamageEventTarget has an item of type Blood Key) Equal to True
      • Then - Actions
        • Set items_counter = 0
        • For each (Integer A) from 1 to 6, do (Actions)
          • Loop - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Item-type of (Item carried by DamageEventTarget in slot (Integer A))) Equal to Blood Key
              • Then - Actions
                • Set items_counter = (items_counter + 1)
              • Else - Actions
        • Set DamageEventAmount = (DamageEventAmount - ((DamageEventAmount / 10.00) x (Real(items_counter))))
        • Set DamageEventType = DamageTypeReduced
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • IsDamageSpell Equal to False
            • (Unit-type of DamageEventSource) Equal to Archimonde
          • Then - Actions
            • Set DamageEventAmount = (0.00 - DamageEventAmount)
            • Set DamageEventType = DamageTypeHeal
          • Else - Actions

I modified Blood Key, so its now should reduce damage for 10% for each item of that type the hero have
And it works all fine
But Archimonde instead of healing now deals his regular attack damage (which was reduced by items)
So, i suppose blood key overrides Archimondes damage settings, and i would like to know, how can i make them both to work?

 

[Spellbound]

From the way you set up the triggers, the game will always check for blood keys on a hero first. If it finds blood keys on a hero, it will execute the damage-reduction-per-blood-key and ignore the Archimonde part. The Archimonde part is only going to happen if your target doesn't have any blood keys.

You have to decide which is the most important part. If you want the healing attacks to be prioritised, then your triggers should check for IsDamgeSpell Equal to False and (Unit-type of DamageEventSource) Equal to Archimonde. Then, under Else it should check for (DamageEventTarget has an item of type Blood Key) Equal to True

If you want Archimonde's healing attacks to be affected by blood keys, then you can just copy-paste the blood key part into the Archimonde Then - Actions

 

[ssbbssc2]

so i need to do this for every damage modificator i wanna add to my map?
i mean, for every stacking types, like +10% damage aura for spells and bonus damage from INT (for example)

 

[Spellbound]

I think so, yeah. What you can do instead is to have one trigger that handles all the damage processing through Damage Engine. That's what I did in my techtree contest 11 map. So, you would have 1 trigger that fires when DamageModifierEvent becomes Equal to 1.00 and then from there on you do start creating specific conditions. For instance:

I don't have access to the editor right now so I'll just write it in JASS. I hope it's readable

local boolean AllowDamageReduction = false

if GetUnitTypeId(udg_DamageEventSource) == 'archimonde unit id' and udg_IsSpellDamage then
    //Do Stuff
    set AllowDamageReduction = true //this local variable will tell another trigger below that the damage values can be further modified. if you use a global, be sure to set it to false at the end of the trigger.
elseif...
    //Do Stuff
endif

if AllowDamageReduction then
    if (DamageEventTarget has an item of type Blood Key) Equal to True then //idk the JASS syntax for items lol
        //Do Stuff
    endif
    if //add more damage modifiers here
        //Do Stuff
    endif
endif

The idea behind the above trigger is to make all damage modification go through a single function so that you are better able to control it. This way you can do all sorts of damage modification and control the order in which they happen yourself. It also reduces the number of times the DamageModifierEvent becomes Equal to 1.00 is called to 1 instead of one per every trigger that contains this as an event.

Below, I'll just repeat the same code as above, but include an example of how you can use this system to have a custom shield spell that nullifies a set amount of damage.

Example

local integer UnitID = GetUnitUserData(udg_DamageEventTarget) //this stores the custom value of the target

... things happen...

if AllowDamageReduction then
    if (DamageEventTarget has an item of type Blood Key) Equal to True then //idk the JASS syntax for items lol
        //Do Stuff
    endif
    if ShieldAmount[UnitID] > 0. then //I set this after the Blood Key so that the damage is first reduced by the Blood Keys, then applied to the shields.
        if udg_DamageEventAmount > ShieldAmount[UnitID] then
            set ShieldAmount[UnitID] = 0.
            set udg_DamageEventAmount = udg_DamageEventAmount - ShieldAmount[UnitID]
        else
            set udg_DamageEventAmount = 0.
            set ShieldAmount[UnitID] = ShieldAmount[UnitID] - udg_DamageEventAmount
        endif
    endif
endif

PS: you should set items_counter back to 0 after Set DamageEventType = DamageTypeReduced. Or use a local variable instead.

 

[The Wanderer]

Is it possible to make an item that gives critical strike to abilities by using this system? example a unit has item and when it cast a spell the spell has a chance to do multipled damage.

 

[Bribe]

Sure. You could use the Critical Strike featured in the demo map as an example of what it would generally look line. In your case, you would want to check if "Unit has an item of type Spell Booster" and also, to make sure it's not physicial damage, check "IsDamageSpell Equal to True".

 

[The Wanderer]

Sure. You could use the Critical Strike featured in the demo map as an example of what it would generally look line. In your case, you would want to check if "Unit has an item of type Spell Booster" and also, to make sure it's not physicial damage, check "IsDamageSpell Equal to True".

Thanks Mr. Bribe! I already got it working. I have another question about the damage types like explosive and reduced, could i create a new one? was planning to make elemental damage types. Just want to know if i can do that with your system.