Curse of Terror v1.9

[Moderator]

17th Oct 2015
Bribe: A neat spell which works properly. Like a custom mana flare which penalizes spell casting. This would have been a good contender for the Deception Contest!

Old by Maker

Curse of Terror v1.4 | Reviewed by Maker | 05.01.15 [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" Concept[/COLOR]] An area of effect spell which causes affected units to take damage when they cast spells. Triggers[/COLOR]] The spell is leakless and MUI The effect trigger should be turned off when there are no units with the buff The effect trigger only needs one condition, unit has buff Use only one dummy unit per cast I don't think you should do this Unit Group - Remove all units from CT_AffectedUnits[CT_Index] Using single 1 second timer is problematic. The spell can last 7-7.999... seconds. Objects[/COLOR]] No unnecessary objects Good tooltip The dummy should be configured to be able to cast spells instantly The death type of the dummy should be Can't raise, does not decay Effects[/COLOR]] The effects are well chosen. Rating[/COLOR]] CONCEPT TRIGGERS OBJECTS EFFECTS RATING STATUS APPROVED Links[/COLOR]] One dummy per cast [COLOR="gray"

[/TD]

 

[gorillabull]

looks good

 

[deathismyfriend]

Every 1.00 seconds for loop is horrible. You should use 0.03 seconds.

With the 1 second loop you can have a delay of .99 seconds. That is easily noticeable.

 

[Veritas 117]

I like this idea. It could be a good ability for a boss to have.

 

[Blightsower]

@gorillabull -> thank you

@deathismyfriend, i think you missed the idea about the 1.00 second delay.
the cast trigger stores the units in the selected area.
the timer trigger removes the unit that can be damaged when they cast spell.
the last trigger damages the casting units.
i dont see why this should be 0.03 seconds.

@Veritas 117 - > thank you

 

[kakuzu]

Nice spell, good work, and i like the name !

 

[Blightsower]

@kakuzu -> thank you

 

[Tal'Rarity]

Cool spell however you overcomplicate in a lot of area's... Mind if I post a fixed version for you?

 

[Blightsower]

@Dat-C3 -> please show me the way. You're talking about the unit group deindexing? or about detecting who to damage and where the damage came from?
i know this can be coded like this add units to unitgroup[1] for units affected by level 1 spell, unitgroup[2] for units affected by level 2 spell and so on.. i did it like this for games that needs hero attributes based damage.

 

[Tal'Rarity]

Yours was almost perfect, just a few things missing and/or needing editing.

I also changed your timer event to shut up death over there. It is better honestly because Game time is a bad value to rely on it because it is actually similar to Global Integer A & B. He is wrong though, if you use a triggered timer then you don't really need 0.03 depending on the spell and in your case the best value is 1.00. Though what happens when someone purges or dispels your buff? Is that intended to save casters from your spell?

I know it isn't as important for GUI'ers, but I think we should start learning how to null our unit variables, after using a temp unit variable just set it to no unit. Same for the other unit variables, it is worth it in order to obtain a "perfect" as possible spell/system.

By the way to catch auto-heal and other auto-cast spells I suggest another trigger on top of the ones so far, sure you'll end up making your spell into more of a system but at least you'll be able to catch bugged spells/abilities. I actually already made one into your test-map for you to start you off with.
I left examples of displaying if you caught an ability cast or order cast inside the map. Since orders can't be custom-made there is a limit which also makes it easier to catch the spells but also sad that they can't be stacked easily.

People will likely complain that the heal order isn't in a variable, I wouldn't worry too much about it since there's only one instance/use of it per run. If there is any bugs I do apologize, I usually don't stack events in complicated spells.

Oh, and don't increase variable arrays in the variable manager/editor, it is bad to do so because it adds load time onto the map and wc3 auto-increases them with every new index/integer add EXCEPT for a few such as unit group which I showed you already how to fix within your triggers. You require JASS/custom script in order to do so, but it is only three lines... So it shouldn't be a big deal, one to set it, one to destroy it, one to null it.

Edit: Yeah I know, I dislike the extra variables but they're also good to make it easier to configure/edit your spell. So I didn't bother with that and left it alone even though you can use equations to reduce however don't worry about it, that part is just fine. Posting triggers as well shortly for you so all you have to do is click quote my reply then copy [trigger=] to the end part. I am sure you know that though.

Triggers for you to copy to main post

[trigger=init]
Events
Time - Elapsed game time is 0.00 seconds
Conditions
Actions
Set CT_Ability = Curse of Terror
Set CT_AoE[1] = 300.00
Set CT_AoE[2] = 300.00
Set CT_AoE[3] = 300.00
Set CT_AreaSFX = Abilities\Spells\Items\AItb\AItbTarget.mdl
Set CT_Attach = overhead
Set CT_Buff = Curse of Terror (Buff)
Set CT_Damage[1] = 60.00
Set CT_Damage[2] = 120.00
Set CT_Damage[3] = 180.00
Set CT_DamageType = Unknown
Set CT_DummyAbility = Curse of Terror (Dummy)
Set CT_Duration[1] = 5
Set CT_Duration[2] = 7
Set CT_Duration[3] = 10
Set CT_UnitSFX = Abilities\Spells\Items\AIil\AIilTarget.mdl
Set CT_DummyType = Dummy
[/trigger]
[trigger=cast]
Curse of Terror Cast
Events
Unit - A unit Starts the effect of an ability
Conditions
(Ability being cast) Equal to CT_Ability
Actions
Set CT_Index = (CT_Index + 1)
Set CT_Caster[CT_Index] = (Triggering unit)
Set CT_Player[CT_Index] = (Triggering player)
Set CT_Level[CT_Index] = (Level of CT_Ability for CT_Caster[CT_Index])
Set CT_Point = (Target point of ability being cast)
Special Effect - Create a special effect at CT_Point using CT_AreaSFX
Special Effect - Destroy (Last created special effect)
Set CT_TimeLeft[CT_Index] = CT_Duration[CT_Level[CT_Index]]
Custom script: set udg_CT_AffectedUnits[udg_CT_Index] = CreateGroup()
Set CT_AffectedUnits[CT_Index] = (Units within CT_AoE[CT_Level[CT_Index]] of CT_Point matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is Mechanical) Equal to False) and ((((Matching unit) is Magic Immune) Equal to False) and ((((Matching unit) is alive) Equ
Unit Group - Add all units of CT_AffectedUnits[CT_Index] to CT_DamageGroup
Custom script: call RemoveLocation(udg_CT_Point)
Unit Group - Pick every unit in CT_AffectedUnits[CT_Index] and do (Actions)
Loop - Actions
Set CT_Target = (Picked unit)
Set CT_Point = (Position of CT_Target)
Unit - Create 1 CT_DummyType for CT_Player[CT_Index] at CT_Point facing Default building facing degrees
Set CT_Dummy = (Last created unit)
Unit - Add a 2.00 second Generic expiration timer to CT_Dummy
Unit - Add CT_DummyAbility to CT_Dummy
Unit - Set level of CT_DummyAbility for CT_Dummy to CT_Level[CT_Index]
Unit - Order CT_Dummy to Neutral Alchemist - Acid Bomb CT_Target
Custom script: call RemoveLocation(udg_CT_Point)
Set CT_Dummy = No unit
Set CT_Target = No unit
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
CT_Index Equal to 1
Then - Actions
Countdown Timer - Start CT_Timer as a Repeating timer that will expire in 1.00 seconds
Else - Actions
[/trigger]
[trigger=run]
Curse of Terror Duration
Events
Time - CT_Timer expires
Conditions
Actions
For each (Integer CT_LoopInteger) from 1 to CT_Index, do (Actions)
Loop - Actions
Set CT_TimeLeft[CT_LoopInteger] = (CT_TimeLeft[CT_LoopInteger] - 1)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
CT_TimeLeft[CT_LoopInteger] Equal to 0
Then - Actions
Unit Group - Remove all units of CT_AffectedUnits[CT_LoopInteger] from CT_DamageGroup
Unit Group - Remove all units from CT_AffectedUnits[CT_LoopInteger]
Custom script: call DestroyGroup(udg_CT_AffectedUnits[udg_CT_LoopInteger])
Set CT_AffectedUnits[CT_LoopInteger] = CT_AffectedUnits[CT_Index]
Custom script: set udg_CT_AffectedUnits[udg_CT_Index] = null
Set CT_Caster[CT_LoopInteger] = CT_Caster[CT_Index]
Set CT_Damage[CT_LoopInteger] = CT_Damage[CT_Index]
Set CT_Level[CT_LoopInteger] = CT_Level[CT_Index]
Set CT_Player[CT_LoopInteger] = CT_Player[CT_Index]
Set CT_TimeLeft[CT_LoopInteger] = CT_TimeLeft[CT_Index]
Set CT_LoopInteger = (CT_LoopInteger - 1)
Set CT_Index = (CT_Index - 1)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
CT_Index Equal to 0
Then - Actions
Countdown Timer - Pause CT_Timer
Else - Actions
Else - Actions
[/trigger]
[trigger=Cast/Order Catching]
Curse of Terror Effect
Events
Unit - A unit Starts the effect of an ability
Unit - A unit Is issued an order targeting an object
Conditions
((Triggering unit) is in CT_DamageGroup) Equal to True
((Triggering unit) has buff CT_Buff) Equal to True
Actions
For each (Integer CT_LoopInteger) from 1 to CT_Index, do (Actions)
Loop - Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Target unit of ability being cast) Equal to No unit
(Issued order) Equal to (Order(heal))
Then - Actions
Unit Group - Pick every unit in CT_AffectedUnits[CT_LoopInteger] and do (Actions)
Loop - Actions
Set CT_Target = (Picked unit)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Triggering unit) Equal to CT_Target
Then - Actions
Special Effect - Create a special effect attached to the CT_Attach of CT_Target using CT_UnitSFX
Special Effect - Destroy (Last created special effect)
Unit - Cause CT_Caster[CT_LoopInteger] to damage CT_Target, dealing CT_Damage[CT_Level[CT_LoopInteger]] damage of attack type CT_AttackType and damage type CT_DamageType
Else - Actions
Set CT_Target = No unit
Else - Actions
Unit Group - Pick every unit in CT_AffectedUnits[CT_LoopInteger] and do (Actions)
Loop - Actions
Set CT_Target = (Picked unit)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Triggering unit) Equal to CT_Target
Then - Actions
Special Effect - Create a special effect attached to the CT_Attach of CT_Target using CT_UnitSFX
Special Effect - Destroy (Last created special effect)
Unit - Cause CT_Caster[CT_LoopInteger] to damage CT_Target, dealing CT_Damage[CT_Level[CT_LoopInteger]] damage of attack type CT_AttackType and damage type CT_DamageType
Else - Actions
Set CT_Target = No unit
[/trigger]

 

[Blightsower]

@Dat-C3 -> in you example which event will be triggered? there are 2 events.

 

[Tal'Rarity]

@Dat-C3 -> in you example which event will be triggered? there are 2 events.

Both depending on the type of cast, they won't double-cast because of the condition I put there. Since like you said you can't catch auto-cast heals which is the bug that is fixed by using it's order to catch it and since its an order then target unit of ability being cast will return null/no unit.

 

[Blightsower]

Thank you for fixing the bug. The spell will be updated shortly

EDIT: sad news, the bug still exists. However ill add this line

dont look

• Set CT_Target = No unit

EDIT2: i missed something. i works now.

 

[BPower]

Solid spell idea. You could use just one Dummy Caster unit, instead of one per spell instance.
To achieve this you have to create an unit on map initialization and set it to a unit variable (this is your dummy caster).
Now during each spell cast, change the owner of the dummy caster unit to the spell triggering player.
--> eventually set the unit position to the desired target coordiantes ( required in case of spells like hoofstomp for instance)
--> order the dummy ability ( and optionally: reset the owner to neutral passive).

 

[Tal'Rarity]

Solid spell idea. You could use just one Dummy Caster unit, instead of one per spell instance.
To achieve this you have to create an unit on map initialization and set it to a unit variable (this is you dummy caster).
Now during each spell cast, change the owner of the dummy caster unit to the spell triggering player.
--> eventually set the unit position to the desired target coordiantes ( required in case of spells like hoofstomp for instance)
--> order the dummy ability ( and reset the owner to neutral passive).

That's a bit advanced which is why I didn't say anything.

However agreed, but I think that should of wait for a bit until he finished the other parts and then tell him and let him search through hive's spells to find examples and/or figure it out in object editor.

http://www.hiveworkshop.com/forums/...24594/?prev=search=dummy%20caster&d=list&r=20

 

[Blightsower]

@BPower-> that's how to prevent the creation of dummy units per spell instance right?

EDIT: i've tried creating a dummy caster. the result was only one unit gets the debuff. perhaps, the process happens too fast that the dummy caster is moved before it can cast.

this is correct right? on map init i added these lines ->

• Set CT_Point = (Random point in (Playable map area))
• Unit - Create 1 CT_DummyType for Neutral Passive at CT_Point facing Default building facing degrees
• Set CT_Dummy = (Last created unit)
• Unit - Add CT_DummyAbility to CT_Dummy
• Custom script: call RemoveLocation(udg_CT_Point)

and on the cast trigger i added these lines ->

• Unit Group - Pick every unit in CT_AffectedUnits[CT_Index] and do (Actions)
  • Loop - Actions
    • Set CT_Target = (Picked unit)
    • Set CT_Point = (Position of CT_Target)
    • Unit - Move CT_Dummy instantly to CT_Point
    • Unit - Change ownership of CT_Dummy to CT_Player[CT_Index] and Change color
    • Unit - Set level of CT_DummyAbility for CT_Dummy to CT_Level[CT_Index]
    • Unit - Order CT_Dummy to Neutral Alchemist - Acid Bomb CT_Target
    • Custom script: call RemoveLocation(udg_CT_Point)

Spell has been updated with slightly new triggers

Edit: Reverted the spell to the first version. Waiting for approval.

 

[GywGod133]

Maybe if I suggest

Time - Every 1.00 seconds of game time

You can change this into

Time - Every 0.03 seconds of game time

 

[Blightsower]

no. 1.00 seconds is the right time here. what the 1.00 second here is counting down the duration of the spell. im not trying to catch the spell cast with the timer.

 

[lAzazeLl]

Está buenisimo el poder, 5

 

[Blightsower]

Hello, I would like to request for a re-evaluation. I've made significant changes to this spell and now requesting for approval (if approvable).

Edit: forgot to mention that the spell does not stack anymore. Just like blizzard spells only the last instance of the spell is applied.

 

[BPower]

For now set back to pending.

 

[Blightsower]

Thank you for setting it to pending BPower. Thank you FireTiger

Edit: Waiting for approval.

 

[Blightsower]

*bumps* waiting for approval

 

[IcemanBo]

• Remove following operation from spell init:
  

  Sichtbarkeit - Create an initially Aktiviert visibility modifier for Neutral passiv emitting Sichtbarkeit across (Playable map area)

• The dummy unit should only be moved once to target location, not potentialy more often.
• Store "(TriggeringUnit)" into a variable in your effect trigger.
• Why do you need the "DamageGroup"? Can't you simply check for the buff?
• Maybe it would make sense to only apply new damage if new damage is higher than the current one.
  But this would not refresh the duration, and finding a compromise would be not worth it,
  so it is up to you which way you go.

In your import instructions:

3) copy the dumm ability

->

3) copy the dummy ability

And I recommend you to change the name of the trigger sheet "Importing Instructions" to "ReadMe",
because it's not only import instructions, but there is also a very important note about the spell duration.

 

[Blightsower]

thanks for the review. ill be making the updates next week.

Edit: wow that was a thorough review. you even read the importing instructions. btw i i think ill go with the newest applied buff being applied to the unit and not allow the effect to stack. also the unit group is for checking if the unit is already in the loop. you're suggesting that i shouldnt check the unit group and just check if the unit has the buff before applying the buff yes?

 

[IcemanBo]

For me, yes. I thought the buff check can replace the unit group check.
It does not change much, but if group is not needed, it is just useless overhead.

 

[Blightsower]

thanks for the response. ill update you once the changes are made.

 

[Blightsower]

*bumps*

Spell has been updated now waiting for approval

 

[Blightsower]

*bumps*

 

[Blightsower]

Thank you for the approval sir. Hehe too bad this was here before the contest has begun. Thanks again

 

[Maximum_Evil]

looks likes a pretty simple spell, but its a very nice idea!

 

[Blightsower]

Thanks