Cosmic Vortex

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

Bribe:

Plenty of leaks for everyone. This is a goldmine of leaks:

• For each (Integer A_IndexDummy1[1]) from 1 to 12 do (Actions)
  • Loop - Actions
    • Set A_Angle[A_IndexDummy1[1]] = (30.00 x (Real(A_IndexDummy1[1])))
    • Unit - Create 1 DummyVortex for (Owner of (Triggering unit)) at ((Position of (Triggering unit)) offset by A_Distance1[A_Index[1]] towards A_Angle[A_IndexDummy1[1]] degrees) facing Default building facing degrees
    • Set A_Dummy1[((A_IndexDummy1[1] x 12) - A_Index[1])] = (Last created unit)
• For each (Integer A_IndexDummy2[1]) from 1 to 12 do (Actions)
  • Loop - Actions
    • Unit - Create 1 DummyVortex for (Owner of (Triggering unit)) at ((Position of (Triggering unit)) offset by A_Distance2[A_Index[1]] towards A_Angle[A_IndexDummy2[1]] degrees) facing Default building facing degrees
    • Set A_Dummy2[((A_IndexDummy2[1] x 12) - A_Index[1])] = (Last created unit)
• For each (Integer A_IndexCircle[1]) from 1 to 12 do (Actions)
  • Loop - Actions
    • Unit - Create 1 DummyCircle for (Owner of (Triggering unit)) at ((Position of (Triggering unit)) offset by A_DistanceCircle[A_Index[1]] towards A_Angle[A_IndexCircle[1]] degrees) facing Default building facing degrees
    • Set A_DummyCircle[((A_IndexCircle[1] x 12) - A_Index[1])] = (Last created unit)

A_Index[1] should be a normal variable. It will be a lot more readable and run a lot faster in-game.

Same with A_Index[2] in the next trigger.

Another treasure trove of location leaks here:

• For each (Integer A_IndexDummy1[2]) from 1 to 12 do (Actions)
  • Loop - Actions
    • Set A_Angle[A_IndexDummy1[2]] = (A_Angle[A_IndexDummy1[2]] + A_AngularVelocity[A_Index[2]])
    • Unit - Move A_Dummy1[((A_IndexDummy1[2] x 12) - A_Index[2])] instantly to ((Position of A_Caster[A_Index[2]]) offset by A_Distance1[A_Index[2]] towards A_Angle[A_IndexDummy1[2]] degrees)
• For each (Integer A_IndexDummy2[2]) from 1 to 12 do (Actions)
  • Loop - Actions
    • Unit - Move A_Dummy2[((A_IndexDummy2[2] x 12) - A_Index[2])] instantly to ((Position of A_Caster[A_Index[2]]) offset by A_Distance2[A_Index[2]] towards A_Angle[A_IndexDummy2[2]] degrees)
• For each (Integer A_IndexCircle[2]) from 1 to 12 do (Actions)
  • Loop - Actions
    • Unit - Move A_DummyCircle[((A_IndexCircle[2] x 12) - A_Index[2])] instantly to ((Position of A_Caster[A_Index[2]]) offset by A_DistanceCircle[A_Index[2]] towards A_Angle[A_IndexCircle[2]] degrees)
    • Destructable - Pick every destructible within A_DistanceCircle[A_Index[2]] of (Position of A_Caster[A_Index[2]]) and do (Actions)
      • Loop - Actions
        • Destructable - Kill (Picked destructible)

Needs a good amount of work. You can ask for help making your triggers leakless here: http://www.hiveworkshop.com/forums/triggers-scripts-269/

 

[EloTheMan]

I think I just massacred an entire Eco-system

EDIT:

Creates a vortex which moves without stopping, causing damage with regard to strength, agility and intelligence of the hero. Summarizing the effect of this skill, you could say that the unit enters the circle of the vortex is destroyed.

Level: 1/2/3/4.

Damage: STR+AGI+INT x 1/2/3/4.
Every: 0.5 seconds.
Duration: 4/8/12/16 seconds.
Max distance: 350/500/650/800 units.

Mana Cost: 100/150/200/250.
Cooldown: 20 seconds.

Sry about the colors being wrong.

 

[Archangel678]

Comments

Merge the loops, use .03, not .05....

Position of (Unit) leaks... use a variable and destroy the variable...

"Vista building" = ?

I'd set [A_Index [2]] to a variable to make it look neater...

Set (Triggering Unit) to a variable...

There has to be a way to merge the If/Then/Else actions, as the 'Else' action seems to be the same.

Remove the 850 KB of stuff.

Remarkably similar to Maker's Omega Wave...

 

[Marcos DAB]

Useful, but I have doubts about its originality.

 

[HStyleV]

Useful, but I have doubts about its originality.

It's reaally me man. :s,

 

[HStyleV]

I think I just massacred an entire Eco-system

EDIT:

Sry about the colors being wrong.

I don't know that spell. this is originally from me.

I believe you are very demanding

 

[Archangel678]

HStyleV, you could combine those posts, and should, as you double posted...

Remove the imported objects/models...

 

[Klingo]

import alert, well, remove all those useless import

 

[Adiktuz]

Imports unless EXTREMELY NEEDED is unwelcome on spell resources...

you didn't even wrote on the desc, who made that model...

and use IN-game screenshot....

I think Marcos isn't saying that this isn't your spell, what he's saying from what I understand is that the idea wasn't original...

A_INDEX[] array should be replaced by three different variables, as the presence of that array where you only use the indexes 0,1,2, greatly reduces performance...

 

[x3GlikE]

Remove custom icon and use in game screen shot for this to get approved.

 

[EloTheMan]

It's reaally me man. :s,

He meant the spell's originality (the fact that some one else might have done something similar)

I don't know that spell. this is originally from me.

I believe you are very demanding

I simply Copy+Paste it form your in-game description so that people could read it here on the Hive, this is your spell right?

 

[Maker]

Comments

In my opinion you should get rid of all imports, they're not needed.
The tooltip has too many colours to my liking.
The disbtn icon has wrong path.
You leak locations:

• Unit - Create 1 DummyVortex for (Owner of (Triggering unit)) at ((Position of (Triggering unit)) offset by A_Distance1[A_Index[1]] towards...

^That alone leaks two locations, the position of unit and the offset point.
The loop time should be 0.03 IMO, 0.05 makes it not look smooth due to low update rate.
Do this check only after you actually reduce the integer:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • A_Index[0] Equal to 0
  • Then - Actions
    • Set A_Index[1] = 0
    • Trigger - Turn off (This trigger)
  • Else - Actions

Leaks:

• Unit - Move A_Dummy1[((A_IndexDummy1[2] x 12) - A_Index[2])] instantly to ((Position of A_Caster[A_Index[2]]) offset by...

Unit group leak, location leak:

• Unit Group - Pick every unit in (Units within A_DistanceCircle[A_Index[2]] of (Position of A_Caster[A_Index[2]])) and do (Actions)

This

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • And - All (Conditions) are true
      • Conditions
        • ((Picked unit) is A structure) Equal to False
        • ((Picked unit) is alive) Equal to True
        • ((Picked unit) belongs to an enemy of (Owner of A_Caster[A_Index[2]])) Equal to True

works the same as

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • ((Picked unit) is A structure) Equal to False
    • ((Picked unit) is alive) Equal to True
    • ((Picked unit) belongs to an enemy of (Owner of A_Caster[A_Index[2]])) Equal to True

^Get rid of the extra and, it adds unneeded code.
Leaks:

• Floating Text - Create floating text that reads (- + ((String((Integer(A_Damage[A_Index[2]])))) + !)) at (Position of (Picked unit)) with...

• Unit - Cause A_Caster[A_Index[2]] to damage (Picked unit), dealing A_Damage[A_Index[2]] damage of attack type Spells and damage type Normal

The spell is kind of effect heavy, maybe too much.
32 dummies for one ability is kind of much.
The spell is not fully MUI, try casting it with three paladins almost at the same time. Good testing methiod is to slow down the game speed, select all paladins and cast the ability on them, use alt to change to next unit. You might be overwriting the dummy units, overlapping indexes.

With that said I still like the spell, it's ok but maybe there's too much going on. Fix the leaks and it not being MUI.

 

[Magtheridon96]

• ((Position of (Triggering unit))

^This leaks

Store every location in a variable to destroy later


You're repeating many function calls.
Try storing data in variables so you could improve efficiency

For example:

• Set u = (Triggering Unit)
• Set p = (Triggering Player)

This way, you don't have to call functions more than once ^^
This really boosts performance (GUI needs all the help it can get )

 

[IllidanStormrange]

Not Approved

 

[baassee]

Useful, but I have doubts about its originality.

And not about it leaks like hell?

 

[Rogue_11]

good job anyway