Complete Noob at triggering; why does this not work?

[Blang]

• Events
• Time-Every 5.00 seconds of game time
• Conditions
• Actions
• For Each (Integer A) from 1 to 12, do (Actions)
• Loop-Actions
• Set Temp_Group = (Units in (Playable map area) matching (((Unit-type of (Matching unit)) Equal to Farm) and (((Owner of (Matching unit)) Equal to (Player((Integer A)))) and (((Matching unit) is alive) Equal to True)))
• Player - Add ((Number of units in Temp_Group) x 50) to (Player((Integer A))) Current gold
• Custom Script: call DestroyGroup( udg_Temp_Group )

That is the trigger I tried to use (sorry if I didn't format it correctly), I'm trying to get a periodic income system to work.

 

[shadowvzs]

• Events
• Time-Every 5.00 seconds of game time
• Conditions
• Actions
• For Each (Integer A) from 1 to 12, do (Actions)
• Loop-Actions
• Set Temp_Group = (Units in (Playable map area) matching (((Unit-type of (Matching unit)) Equal to Farm) and (((Owner of (Matching unit)) Equal to (Player((Integer A)))) and (((Matching unit) is alive) Equal to True)))
• Player - Add ((Number of units in Temp_Group) x 50) to (Player((Integer A))) Current gold
• Custom Script: call DestroyGroup( udg_Temp_Group )

That is the trigger I tried to use (sorry if I didn't format it correctly), I'm trying to get a periodic income system to work.

u destroy the group inside the pick loop? sorry coz i can get it if u use

 tagg, try use [trigger] tag.
also dont destroy the group :P

 

[Arhowk]

right click in the top of your trigger where it shows a little sheet of paper and your triggers name and hit copy as text than post it in trigger tags

 

[Meticulous]

u destroy the group inside the pick loop? sorry coz i can get it if u use

 tagg, try use [trigger] tag.
also dont destroy the group :P[/QUOTE]

If he didn't destroy the group within the loop it would leak.

I can't see what's wrong with it personally.

 

[Hashjie]

• Income
  • Events
    • Time - Every 5.00 seconds of game time
  • Conditions
  • Actions
    • For Each (Integer A) from 1 to 12, do (Actions)
      • Loop - Actions
        • Set Temp_Group = (Units in (Playable map area) matching (((Unit-type of (Matching unit)) Equal to Farm) and (((Owner of (Matching unit)) Equal to (Player((Integer A)))) and (((Matching unit) is alive) Equal to True)))
        • Player - Add ((Number of units in Temp_Group) x 50) to (Player((Integer A))) Current gold
        • Custom script: call DestroyGroup( udg_Temp_Group )

That is the trigger I tried to use (sorry if I didn't format it correctly), I'm trying to get a periodic income system to work.

Could you tell us exactly what is not working?
Because as far as I know, this should work.
Is it not adding the income?
Are you sure there are any farms inside the map? (Check the unit type of the farms inside your map)
Are you sure the farms are not owned by the neutral player?

Hint: You can copy a trigger by right clicking the name inside the trigger's functions and then click on copy as text. Which you can then paste within trigger tags.
Or you can manually use spacebars in order to put them on the correct place. 3 spacebars inbetween. So: name = 0 spacebars Events = 3 spacebars actual events within Events = 6 spacebars etc...
Just make sure that the names are exactly the same as in the trigger editor so that they won't all show up as question marks.

If it doesn't add income then that means that 0x50 = 0 so there is something wrong with the enumeration of the group.

 

[shadowvzs]

If he didn't destroy the group within the loop it would leak.

I can't see what's wrong with it personally.

its sure if it is leak what u dont use anymore a group and u store another group to variable?

since i know this aint leak because point is lost when u use group enum again (UG - unit group)

        call GroupEnumUnitsInRange(udg_UG, nx, ny, 250, null)
        loop
            set pu = FirstOfGroup(udg_UG)
            exitwhen (pu==null)
             //do action
            call GroupRemoveUnit(udg_UG, pu)
        endloop

 

[Meticulous]

Sorry, I misread. I meant inside of the "From 1 to 12" loop.

If the group is being destroyed inside of the unit group loop then yeah that would break the trigger completely, it would only be able to add 1 instance of income per player.

 

[helekiller]

• (((Owner of (Matching unit)) Equal to (Player((Integer A)))) and (((Matching unit) is alive) Equal to True)))

try using picked unit instead of matching unit at these 2

 

[Maker]

try using picked unit instead of matching unit at these 2

Matching unit should be used in unit filters. Matching unit is correct in this case.

I suggest you check the unit type and that you actually have some of them placed on the map.

Also, filter out dead units.