[vJASS] "code" Variable Type

[Tyman2007]

I've been wondering how to use the variable type "code" in creating a function that can execute a function given to it.

For instance;

globals
    code Func
endglobals

function SetFunction takes code codeFunc returns nothing
    set Func = codeFunc //I want to use the function later, So I store it in a global.
endfunction

function RunFunction takes nothing returns nothing
    //Not sure what to put here.
endfunction

Then in another trigger

function This takes nothing returns nothing
    //...
endfunction

function That takes nothing returns nothing
    call SetFunction(function This)
endfunction

I know I can store it in a trigger and just execute the trigger, but I was wondering if that was truly the best way. Anyone's thoughts? I can't seem to find anything relating to this.

 

[Adiktuz]

maybe try

// DOES THIS EVEN EXIST???
call ExecuteFunction(Func)

though, why save it anyways?

 

[Tyman2007]

Mainly because I have a cinematic system which uses triggers to store the cinematic data, then runs through the data. The functions needing to be stored so they can be used later on because they are not called immediately.

It's mainly so I can use this system without repeating the same actions each trigger (timers, etc. when I can call it from the system itself.)

Anyway, thanks, I will try it out

UPDATE: No dice I think I may have to just store it in a private trigger.

 

[Adiktuz]

functions stay there for the whole duration of the map normally, so you don't really need to save them...

 

[Tyman2007]

It's mainly so I don't have to change the code in my system to run a function from another library.

For instance, here's an example on what I'm doing;

Trigger 1:
The game starts
Add transmission from U1 saying S1 to Trigger2
Add transmission from U2 saying S2 to Trigger2
Add transmission from U1 saying S3 to Trigger2
Add a function to run when the cinematic is over to Trigger2

So trigger 1 sends data to trigger 2 to store for the cinematic.

Trigger 2:
Run all transmissions
Run stored function

Trigger 2 then runs all the data it has stored. I can make as many triggers similar to trigger 1 as I would like without changing trigger 2 at all and still have everything run as planned. The only way to know what function that it needs to run in the end is to store it for later use in its own trigger.

The main reason is just so I can have a skippable cinematic It might be a system I release later on, I'm fairly confident in how it's functioning thus far.

 

[PurgeandFire]

You can always do:

call ForForce(bj_FORCE_PLAYER[0], <code>)

But you can't use waits in the callback. Otherwise, just use triggers.

 

[BPower]

I never used it, but this should also work.

globals
    private trigger MyTrigger
    private triggercondition triggercond//array?
endglobals

   private function AddFunctionExample takes code func returns nothing
        local boolean expression = Condition(func)
        set triggercond          = TriggerAddCondition(MyTrigger, expression)
        call TriggerEvaluate(MyTrigger)
        call TriggerRemoveCondition(MyTrigger, triggercond)
        set triggercond          = null
        set expression           = null
    endfunction

I suggest you just make a second trigger and evaluate it when the cinematic in question is over or just call that function.
Wouldn't that work for you:

function xy takes nothing returns nothing
    //......
    //cinematic is over
    call FunctionYouWantedToAdd()
endfunction

If possible don't make easy things complicated.

 

[PurplePoot]

The only reason that code variables exist is for ForGroup/ForForce/boolexprs, etc. The rest of the time, just use ExecuteFunc.

 

[BPower]

I'm not sure if ExecuteFunc is properly recognized by a map optimizer, as ExecuteFunc takes a string.
You also don't recieve a JassHelper error if that function does not exists.
For instance call ExecuteFunc("aidiufsdifs") does compile perfectly.

 

[PurplePoot]

It certainly needs to be used responsibly, but it's the correct solution to the problem here. Code variables are even worse than ExecuteFunc could ever hope to be.

 

[PurgeandFire]

@BPower: It works fine with the optimizer. That was just a rumor spread around a while back.

Thankfully, ExecuteFunc() isn't as bad as it used to be. It was previously avoided because it would crash when you input a nonexistent function name, but that was fixed some time ago. Now the only real disadvantage is speed, which is negligible if you're not doing it periodically.

 

[Troll-Brain]

I even prefer function interface than ExecuteFunc, since we are talking about vJass.
Not pop an error on save if you misstype is definetely a con, now if you play with strings you can do "cool" stuff with ExecuteFunc, but frankly i've never needed it.
I mean if code is not enough i went for function interface.