a script to show damage

[a ghost]

globals
trigger  gg_trg_b =null
trigger  gg_trg_a = null
endglobals
function Trig_a_Func001A takes nothing returns nothing
 call TriggerRegisterUnitEvent( gg_trg_b, GetEnumUnit(),EVENT_UNIT_DAMAGED )
endfunction

function Trig_a_Actions takes nothing returns nothing
    call ForGroupBJ( GetUnitsInRectAll(GetPlayableMapRect()), function Trig_a_Func001A )
endfunction
function InitTrig_a takes nothing returns nothing
    set gg_trg_a = CreateTrigger(  )              //map initialization
    call TriggerAddAction( gg_trg_a, function Trig_a_Actions )
endfunction

function Trig_b_Actions takes nothing returns nothing
    call DisplayTimedTextToForce( GetPlayersAll(), 10.00, ( GetUnitName(GetEventDamageSource()) + ( "Damage is" + R2S(GetEventDamage()) ) ) )
endfunction
function InitTrig_b takes nothing returns nothing
    set gg_trg_b = CreateTrigger(  )
    call TriggerAddAction( gg_trg_b, function Trig_b_Actions )
endfunction

function Trig_c_Actions takes nothing returns nothing
    call TriggerRegisterUnitEvent( gg_trg_b, GetEnteringUnit(), EVENT_UNIT_DAMAGED )
endfunction
function InitTrig_c takes nothing returns nothing
    local trigger  gg_trg_c =null
    set gg_trg_c = CreateTrigger(  )
    call TriggerRegisterEnterRectSimple( gg_trg_c, GetPlayableMapRect() )   //register    event for the   EnteringUnit
    call TriggerAddAction( gg_trg_c, function Trig_c_Actions )
    set  gg_trg_c =null
endfunction

maybe GetPlayableMapRect() can be in place of GetEntireMapRect()
,i wonder when a unit enters PlayableMapRect,it will be registered in the
trigger gg_trg_c ,if i have several thousand units, will it make a lag??

 

[PurgeandFire]

If you have several thousands of units, yeah you might see some lag. However, it should be pretty negligible; after all, that is the main technique for damage detection. In a big map though, it might become a problem.

The code leaks though, and is a GUI-JASS conversion, so it is a bit inefficient. ;\

 

[Adiktuz]

wrap the code in JASS tags for better readability... ^_^

have you posted this because you want to share it or you have some problems with it?

anyway, if you just want to share it, I must say that it is unneeded coz we already have a very good working GUI one...

 

[a ghost]

i just want someone could find problems and correct it.maybe this time can be
better.

globals
trigger  gg_trg_b =null
trigger  gg_trg_a = null
endglobals
function Trig_a_Func001A takes nothing returns nothing
 call TriggerRegisterUnitEvent( gg_trg_b, GetEnumUnit(),EVENT_UNIT_DAMAGED )
endfunction

function Trig_a_Actions takes nothing returns nothing
    local group g = CreateGroup()
    call GroupEnumUnitsInRect(g,bj_mapInitialPlayableArea, null)
    call ForGroup( g, function Trig_a_Func001A )
    set g=null
endfunction
function InitTrig_a takes nothing returns nothing
    set gg_trg_a = CreateTrigger(  )              //map initialization
    call TriggerAddAction( gg_trg_a, function Trig_a_Actions )
endfunction

function Trig_b_Actions takes nothing returns nothing
    call DisplayTimedTextToPlayer( GetLocalPlayer(), 0.00,0.00,10.00, ( GetUnitName(GetEventDamageSource()) + ( "Damage is" + R2S(GetEventDamage()) ) ) )
endfunction
function InitTrig_b takes nothing returns nothing
    set gg_trg_b = CreateTrigger(  )
    call TriggerAddAction( gg_trg_b, function Trig_b_Actions )
endfunction

function Trig_c_Actions takes nothing returns nothing
    call TriggerRegisterUnitEvent( gg_trg_b, GetEnteringUnit(), EVENT_UNIT_DAMAGED )
endfunction
function InitTrig_c takes nothing returns nothing
    local trigger  gg_trg_c =null
    local region rectRegion = CreateRegion()
    set gg_trg_c = CreateTrigger(  )
    call RegionAddRect(rectRegion,bj_mapInitialPlayableArea )
    call TriggerRegisterEnterRegion(gg_trg_c, rectRegion, null)    //register    event for the   EnteringUnit
    call TriggerAddAction( gg_trg_c, function Trig_c_Actions )
    set  gg_trg_c =null
    set  rectRegion =null
endfunction

 

[Adiktuz]

you can combine this set gg_trg_b = CreateTrigger( ) with the creation of the global

globals
   trigger gg_trg_b = CreateTrigger(  )
endglobals

also remove InitTrig_a and b... just merge it with the InitTrig_c

function InitTrig_c takes nothing returns nothing
    local trigger  gg_trg_c = CreateTrigger(  )
    local region rectRegion = CreateRegion()
    call RegionAddRect(rectRegion,bj_mapInitialPlayableArea )
    call TriggerRegisterEnterRegion(gg_trg_c,rectRegion, null)    
    call TriggerAddAction( gg_trg_c, function Trig_c_Actions )
    call TriggerAddAction( gg_trg_a, function Trig_a_Actions )
    call TriggerAddAction( gg_trg_b, function Trig_b_Actions )
    set  gg_trg_c =null
    set  rectRegion =null
endfunction

 

[a ghost]

it is said that triggeraction will leak .is that right?
for example

native TriggerAddAction     takes trigger whichTrigger, code actionFunc returns triggeraction

we could clear it through TriggerRemoveAction

 

[Adiktuz]

as long as you need the action it is not considered a leak...

anyway, anything that is still needed is not a leak, a leak is something that stays in your memory which is not needed anymore...

 

[a ghost]

trigger gg_trg_c is to be set null,so i think Trig_c_Actions should be deleted
before that trigger gg_trg_c be set null

 

[Adiktuz]

trigger gg_trg_c is to be set null,so i think Trig_c_Actions should be deleted
before that trigger gg_trg_c be set null

NO!!! your trigger will not run if you delete the action... plus you didn't destroy the real gg_trg_c, you just nulled the variable pertaining to it...

you need to learn the difference between a variable and an object...