[Trigger] Checkpoint system

[Dimitri]

Im making an escape map, where I need to everyone that isnt alive to ressurect at one place, I have this trigger:

• For each (Integer A) from 1 to 10, do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Units[(Integer A)] is dead) Equal to True
      • Then - Actions
        • Unit - Create 1 Wisp for (Owner of Units[(Integer A)]) at (Center of Region 010 <gen>) facing 0.00 degrees
        • Set Units[(Integer A)] = (Last created unit)
        • Item - Remove (Item carried by Units[(Integer A)] of type Jornal - segundo nivel)
        • Hero - Create Jornal - terceiro nivel and give it to Units[(Integer A)]
        • Camera - Pan camera for (Owner of Units[(Integer A)]) to (Center of Region 010 <gen>) over 1.00 seconds
      • Else - Actions

also, the variables:

• Set Units[1] = Wisp 0012 <gen>
• Set Units[2] = Wisp 0017 <gen>
• Set Units[3] = Wisp 0015 <gen>
• Set Units[4] = Wisp 0019 <gen>
• Set Units[5] = Wisp 0018 <gen>
• Set Units[6] = Wisp 0013 <gen>
• Set Units[7] = Wisp 0016 <gen>
• Set Units[8] = Wisp 0014 <gen>
• Set Units[9] = Wisp 0021 <gen>
• Set Units[10] = Wisp 0020 <gen>

The wisps arent reviving! dunno why! please, help me
thanks in advance

 

[PurgeandFire]

What are the events/conditions of the first trigger?

 

[Dimitri]

• Events
  • Unit - A unit enters Region 009 <gen>
• Conditions
  • (Unit-type of (Triggering unit)) Equal to Wisp
• Actions
  • Game - Display to (All players) the text: Parte 2 concluida!
  • Set wispsgroup = (Units of type Wisp)
  • Unit Group - Pick every unit in wispsgroup and do (Actions)
    • Loop - Actions
      • Item - Remove (Item carried by (Picked unit) of type Jornal - segundo nivel)
      • Camera - Pan camera for (Owner of (Picked unit)) to (Center of Region 010 <gen>) over 1.00 seconds
      • Unit - Move (Picked unit) instantly to (Center of Region 010 <gen>)
      • Hero - Create Jornal - terceiro nivel and give it to (Picked unit)
  • For each (Integer A) from 1 to 10, do (Actions)
    • Loop - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Units[(Integer A)] is dead) Equal to True
        • Then - Actions
          • Unit - Create 1 Wisp for (Owner of Units[(Integer A)]) at (Center of Region 010 <gen>) facing 0.00 degrees
          • Set Units[(Integer A)] = (Last created unit)
          • Item - Remove (Item carried by Units[(Integer A)] of type Jornal - segundo nivel)
          • Hero - Create Jornal - terceiro nivel and give it to Units[(Integer A)]
          • Camera - Pan camera for (Owner of Units[(Integer A)]) to (Center of Region 010 <gen>) over 1.00 seconds
        • Else - Actions
  • Unit - Create 1 new challenge for Neutral Hostile at (Center of Region 010 <gen>) facing 0.00 degrees
  • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
  • Unit - Order (Last created unit) to Orc Tauren Chieftain - War Stomp
  • Special Effect - Create a special effect at (Center of Region 010 <gen>) using Abilities\Spells\Human\ThunderClap\ThunderClapCaster.mdl
  • Special Effect - Destroy (Last created special effect)
  • Custom script: call DestroyGroup (udg_wispsgroup)
  • Floating Text - Destroy (Last created floating text)

 

[Dr Super Good]

Units that die are normally automatically removed after a while if not resurrected. You are referencing a removed unit in your resurrection procedure so it does not make sense.

 

[Dimitri]

How should I do it then?!

 

[mckill2009]

here's the idea...

- create a point variable...
- set variable like this at the initialization >>> set YOUR_POINT_VARIABLE = YOUR_LOCATION/REGION
- when your unit dies revive it to that point, simple eh?...

if you want to move your point, just use the MoveLocation native...

 

[Dr Super Good]

When a wisp dies you set a boolean for the player to false (representing wisp is dead). If this boolean is false for a player, you make them a wisp when someone reaches the checkpoint and set the boolean to true.

 

[Dimitri]

the point is, I have the variable Units[1-10], how do I set it to be exactly the same when I create new wisps for someone? I mean, if red dies, and someon reaches the checkpoint, I will create new wisp for him, but the wisp wont be = Units[1]

 

[darkzxx]

why not juz make the unit a hero and then use the hero revive action o.0

 

[Dr Super Good]

the point is, I have the variable Units[1-10], how do I set it to be exactly the same when I create new wisps for someone? I mean, if red dies, and someon reaches the checkpoint, I will create new wisp for him, but the wisp wont be = Units[1]

You update the variable by setting it to a new value?

 

[Dimitri]

well, heres what I did and didnt worked also!

• Events
  • Unit - A unit Dies
• Conditions
  • (Unit-type of (Triggering unit)) Equal to Wisp
• Actions
  • If ((Owner of (Triggering unit)) Equal to Player 1 (Red)) then do (Set wispdead[1] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 2 (Blue)) then do (Set wispdead[2] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 3 (Teal)) then do (Set wispdead[3] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 4 (Purple)) then do (Set wispdead[4] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 5 (Yellow)) then do (Set wispdead[5] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 6 (Orange)) then do (Set wispdead[6] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 7 (Green)) then do (Set wispdead[7] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 8 (Pink)) then do (Set wispdead[8] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 9 (Gray)) then do (Set wispdead[9] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 10 (Light Blue)) then do (Set wispdead[10] = True) else do (Do nothing)

• For each (Integer A) from 1 to 10, do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • wispdead[(Integer A)] Equal to True
      • Then - Actions
        • Unit - Create 1 Wisp for (Owner of Units[(Integer A)]) at (Center of Region 010 <gen>) facing 0.00 degrees
        • Set Units[(Integer A)] = (Last created unit)
        • Set wispdead[(Integer A)] = False
        • Item - Remove (Item carried by Units[(Integer A)] of type Jornal - segundo nivel)
        • Hero - Create Jornal - terceiro nivel and give it to Units[(Integer A)]
        • Camera - Pan camera for (Owner of Units[(Integer A)]) to (Center of Region 010 <gen>) over 1.00 seconds
      • Else - Actions

 

[darkzxx]

like i said its easier to make it if you make the units a hero and make it respawn

 

[Vladadamm]

Look your trigger :

• Events
  • Unit - A unit Dies
• Conditions
  • (Unit-type of (Triggering unit)) Equal to Wisp
• Actions
  • If ((Owner of (Triggering unit)) Equal to Player 1 (Red)) then do (Set wispdead[1] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 2 (Blue)) then do (Set wispdead[2] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 3 (Teal)) then do (Set wispdead[3] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 4 (Purple)) then do (Set wispdead[4] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 5 (Yellow)) then do (Set wispdead[5] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 6 (Orange)) then do (Set wispdead[6] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 7 (Green)) then do (Set wispdead[7] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 8 (Pink)) then do (Set wispdead[8] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 9 (Gray)) then do (Set wispdead[9] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 10 (Light Blue)) then do (Set wispdead[10] = True) else do (Do nothing)

You should use directly Player Numbers :

• Set wispdead[Player number of (Triggering Player)] = True

And why you want create a new wisp ? Why you don't revive the old one ?

I know that escapes are generally less indeed coded than mazes/slides, but it's not a reason.

Just when a player finish a level, you kill all others players, and you revive all of them in the region (excepted the one who finished).

And avoid leaks, it's already hard to play (ice) escapes without lags if you don't have any very good bot.

 

[Dr Super Good]

Dimitri, that still leaks locations. I advise reading up about memory leaks in JASS.

 

[mckill2009]

you leak group as well >>> Set wispsgroup = (Units of type Wisp), better to add the triggering unit to the group then remove it after it gets the journal...
maybe another trigger is modifying this >>> (Units[(Integer A)] is dead) Equal to True
as for the location leak, see my post in #6 to solve it...

 

[Dimitri]

I know the leaks guys, but first, I need to make this trigger work, otherwise wont make sense clearing leaks, and my escape isnt a simple one, it has lots of mixes, if anyone is interested in helping me. I guess I will try to make the wisps a Hero. Maybe this way the trigger will work.

 

[Kadabra]

your problem is this line!

• Unit - Create 1 Wisp for (Owner of Units[(Integer A)]) at (Center of Region 010 <gen>) facing 0.00 degrees

Because the "Units" variable is no longer detectable as DrSG stated above.
Instead use Player Integer A it should fix your problem

Edit: Hey guys first make it work then fix the way it work right? stop the leak thing majig

 

[Dr Super Good]

Something that leaks is classed as bad as something that is not working or is broken in Computing Science. It is as much of a fault as a system giving you 2 units when you were meant to get only 1.

 

[Dimitri]

?????

 

[Noobsmoke]

well, heres what I did and didnt worked also!

• Events
  • Unit - A unit Dies
• Conditions
  • (Unit-type of (Triggering unit)) Equal to Wisp
• Actions
  • If ((Owner of (Triggering unit)) Equal to Player 1 (Red)) then do (Set wispdead[1] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 2 (Blue)) then do (Set wispdead[2] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 3 (Teal)) then do (Set wispdead[3] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 4 (Purple)) then do (Set wispdead[4] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 5 (Yellow)) then do (Set wispdead[5] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 6 (Orange)) then do (Set wispdead[6] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 7 (Green)) then do (Set wispdead[7] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 8 (Pink)) then do (Set wispdead[8] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 9 (Gray)) then do (Set wispdead[9] = True) else do (Do nothing)
  • If ((Owner of (Triggering unit)) Equal to Player 10 (Light Blue)) then do (Set wispdead[10] = True) else do (Do nothing)

• For each (Integer A) from 1 to 10, do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • wispdead[(Integer A)] Equal to True
      • Then - Actions
        • Unit - Create 1 Wisp for (Owner of Units[(Integer A)]) at (Center of Region 010 <gen>) facing 0.00 degrees
        • Set Units[(Integer A)] = (Last created unit)
        • Set wispdead[(Integer A)] = False
        • Item - Remove (Item carried by Units[(Integer A)] of type Jornal - segundo nivel)
        • Hero - Create Jornal - terceiro nivel and give it to Units[(Integer A)]
        • Camera - Pan camera for (Owner of Units[(Integer A)]) to (Center of Region 010 <gen>) over 1.00 seconds
      • Else - Actions

Do NOT use "Do nothing"