Chaotic Sphere v1.2

[Moderator]

17:32, 30th Nov 2009
TriggerHappy:

Coding is good. Effect is decent. Approved.

 

[ap0calypse]

My first spell (submission), great... >.>

Any comments are appreciated (negative help me improve the spell, positive help me boost my ego... win-win situation).

If I need to add another guide, or add comments in the triggers (to make it more readable), or anything else you can think of, please say so.
I hope I didn't look over anything important

Edit:
YES, it's GUI and YES, it's with hashtables, it's not as good as JASS, but you need to learn to live with the fact that most people use GUI... (and that I don't like using JASS for some stupid reasons).

 

[Cihparg]

Reviewing O_O

Current Job: Nothing!...

Triggering: - Leaks: No - Eye-Candy: Nice! - Documentation: Where is it...? - User Friendly: Hashtables.... BLARGH! Not.. (Maybe for some people..) - Usability: Lots! Could go anywhere.

In-Game: - Eye-Candy: What would look better than green and black O_O - Testmap: Well... It is, but the terrain is dull. - User Friendly: Very... VERY! User Friendly.

{5/5}

 

[The_Witcher]

Review:

nice idea and i haven't seen something totally similar here
5/5

well cause i use mainly vJass i can't see every small mistake in GUI, but your coding seems to be leakless and efficient.
but your calculation of the missile movement seems to need improvement cause they hit the ground a little in front of the unit and not at the units feet...
4/5

One word: Perfect
5/5

A very good spell with nice eyecandy, perfect documentation and a nice short code.
Just one suggestion: replace the 10000HP footman with the normal version so testers can see the force of this spell at once

Overall: (5+4+5)/3 = 4.6 ==> 5
Vote for Approval: Yes
+rep: Yes

PM me when you want me to look over your ressource again

 

[Thanathos]

Edit:
YES, it's GUI and YES, it's with hashtables, it's not as good as JASS, but you need to learn to live with the fact that most people use GUI... (and that I don't like using JASS for some stupid reasons).

I don´t see whats so bad about GUI, if you can use it right it´s perfectly fine. Anyway i checked the spell and it is very good for your fist spell submission. Coding seems fine for me, i couldn´t spot any leaks so far and it is MUI. I like the idea that you stored that data from the hashtable in globals, this improves efficiency, because using variables is much faster then call functions. You should really add some comments to your code (some seperating lines so that the code is easier to read). The spell concept is decent and the visuals are nice too. The documentation is in one word awesome. You should fix the missile inaccuracy the wither mentioned, furthermore the small missiles which spawn after the explosion will move to the position of the target unit when the spell was casted, so if the target unit goes away the small missiles head to the wrong place.

~TNT

 

[D4RK_G4ND4LF]

Agree with the post above (the missiles flying back are inaccurate)

the spell hits magic immune units, structures, flying units, etc. (you can not select such a target directly but the shockwave dmg does hit them)

I prefer

set bj_wantDestroyGroup = true

over

call DestroyGroup( udg_Group )

cause it is faster, requires less variables and cooler
(source: http://www.thehelper.net/forums/showthread.php?t=123207 )

I didn't get the use of this:

• Set SphereInt = 0

and deleting this line didn't cause any errors so I think it's useless

some text explaining how the triggers work would be nice, too (although I think it's a waste of time 'cause everybody who'd bother to read them is able to understand the spell anyway)

nice work
make more

 

[Cihparg]

D4RK_G4ND4LF, set bj_wantDestroyGroup = true doesn't work allways.
As for me it bugged once so it caused the spell to work only for player 1.
So thats your "set bj_wantDestroyGroup = true"

 

[ap0calypse]

Okay, I've mixed up a lot of quotes in this post...
It's a bit chaotic, but I hope everyone can find his post in this ><

- Leaks: Yes (Where do you clear MissileGroup1 & MissileGroup2? I cannot find the clear for the leak, I'll make it for now as yes. Just tell me where you clear it, or am I wrong and it is not even needed to be cleared?)

They do not need to be cleared, as they're static groups (together with "SphereDamage", which is also a unit group )
So I never create an additional group - if I do use additional groups, I have used the "SphereGroup" variable).

- Documentation: Where is it...?

Inside the trigger editor?
Okay, I didn't say how the spell works, perhaps I'll add that in as well ^^
(as well as comments in the triggers, wihch has also been said by

but your calculation of the missile movement seems to need improvement cause they hit the ground a little in front of the unit and not at the units feet...

Really? D: awkward... I thought it was all perfectly calculated xD
I'll look into this (my first thought is a loc[1] / loc[2] mixup, which can easily be fixed).

Just one suggestion: replace the 10000HP footman with the normal version so testers can see the force of this spell at once

Ohh, yeah... I thought I'd place a 10k HP footman, so the users can see exactly how much damage it does (easy calculating), but I've made a command (and quest) for that.
Stupid me

I prefer
set bj_wantDestroyGroup = true
over
call DestroyGroup( udg_Group )
cause it is faster, requires less variables and cooler

Yeah, but the MissileGroup1, MissileGroup2 and SphereDamage (all unit groups) may not be removed

- Testmap: Well... It is, but the terrain is dull.

I know
Before uploading I thought "I should actually create a better terrain".
Then I laughed and thought "Ya, right" and hit the upload-button.
I'll do my best to add it, though ^^
(be happy it isn't the standard, ugly, lordaeron summer )

I didn't get the use of this:
Set SphereInt = 0
and deleting this line didn't cause any errors so I think it's useless

Oi, that was a function I had to use when testing the map :O (I added a few things and I needed that to clear my stupid tests )
~Removed

- User Friendly: Hashtables.... BLARGH! Not.. (Maybe for some people...

I don't know, I find it very easy to use/change them, but perhaps that is because I like working with them?

the spell hits magic immune units, structures, flying units, etc. (you can not select such a target directly but the shockwave dmg does hit them)

I don't see a problem with structures, but I will make flying/immune units exceptions (didn't even think about that).

so if the target unit goes away the small missiles head to the wrong place.

When that happens, the target unit won't receive any damage (from the small missiles), I don't see the problem in that case
Creating homing missiles wasn't exactly my point (they won't make the spheric shape in that case )


Update will follow in several minutes (if I'm not too lazy).

• Magic Immune / Flying Units will be excluded
• I hope to fix the small missiles' accuracy
• More information about the triggering itself
• Adding standard warcraft-units, so you can see how strong the spell actually is.
• A terrain... perhaps?

Actually, the basic idea was to create an arcane spell, but when I checked a few special effects (that's why the useless line still exists in my code, so I could change the effect in-game -.-), I saw this effect and thought "wow, cool", so I just changed the entire concept...


Thanks to everyone for posting!

 

[hell gate]

• Hashtable - Save SphereValue[1] as 0 of (Key (Triggering unit)) in SphereTable
• Hashtable - Save SphereValue[2] as 1 of (Key (Triggering unit)) in SphereTable
• Hashtable - Save SphereValue[3] as 2 of (Key (Triggering unit)) in SphereTable
• Hashtable - Save SphereValue[4] as 3 of (Key (Triggering unit)) in SphereTable
• Hashtable - Save SphereValue[5] as 4 of (Key (Triggering unit)) in SphereTable

does this not destroy the MUInes?
because if you cast it again the variables will be overwritten.

 

[ap0calypse]

• Hashtable - Save SphereValue[1] as 0 of (Key (Triggering unit)) in SphereTable
• Hashtable - Save SphereValue[2] as 1 of (Key (Triggering unit)) in SphereTable
• Hashtable - Save SphereValue[3] as 2 of (Key (Triggering unit)) in SphereTable
• Hashtable - Save SphereValue[4] as 3 of (Key (Triggering unit)) in SphereTable
• Hashtable - Save SphereValue[5] as 4 of (Key (Triggering unit)) in SphereTable

does this not destroy the MUInes?
because if you cast it again the variables will be overwritten.

Nope, that's exactly the main advantage of hashtables ^^
I save the variable ONLY for the picked unit (which is the casting unit in your example).
When another unit casts the spell, the variables will be saved for that unit, the other ones will not be overwritten.
(well, it doesn't exactly work like that, but it's easy to explain it like this ).

 

[X-OMG-X]

I know
Before uploading I thought "I should actually create a better terrain".
Then I laughed and thought "Ya, right" and hit the upload-button.
I'll do my best to add it, though ^^
(be happy it isn't the standard, ugly, lordaeron summer )

If you suck that much in terraining, you can always use a terrain template
Then you can import the spell to the terrain map and its done. Ofc give credits, but anyways

 

[hell gate]

but the triggering unit is the caster and if the the unit cast it again this variables will overwritten (as i know) because Key(Triggering unit) is the same

 

[ap0calypse]

but the triggering unit is the caster and if the the unit cast it again this variables will overwritten (as i know) because Key(Triggering unit) is the same

But the caster can't cast it while the spell is already being casted... sounds logical (coodlown etc...).
Besides, only the shockwave (part 1 of the spell) is based on that unit, the second part (the small missiles) is based on itself (and it has the casting unit stored in a variable).
Since the shockwave only lasts 1sec - 0.30sec (depends on the cast range), the hero can cast this spell every second, if all goes well every 0.30seconds... not enough for you? xD

Edit:
Here, the caster is casting it twice (believe me, I couldn't cast if faster after eachother xD)
It didn't bug at all.

Screeny

 

[Kingz]

I am interested in the arcs you used, what is the formula you used or the way you implemented it?
EDIT:
If you can, merge the 2 triggers(periodic ones).
EDIT2:
Not MUI:
-changed the speed of the misile to 5 to see if it can be bugged.
-spammed the spell
-result, the attached pics
NOTE:
I wasn't fast enough to snapshot 2 pics of first 4 casts, so i did that in the 2nd time i tested.

EDIT3:
@baasee reply
Indexing ftw, you will never reach such a high amount of instances, and some indexing is of high quality.
EDIT4:
If you can't spam it mindlessly it ain't MUI by my book

 

[baassee]

but the triggering unit is the caster and if the the unit cast it again this variables will overwritten (as i know) because Key(Triggering unit) is the same

it doesnt bug because it saves each different info for each unit it saves into the hashtable if it is the same, it just creates another instance isntead of overwriting with limitless of instances (ofc they are ALOT slower than indexing but got the great advantage of limitless instances)

 

[ap0calypse]

I am interested in the arcs you used, what is the formula you used or the way you implemented it?

XY-arc:

For the XY-arc I've used the "basic angle" (the normal angle would depend on the position of the caster compared to the position of the targetted unit), but since I've used the cosinus, it would bug (I have to divide 12 with the cosinus, cos(90º) = 0, so in that case I had to divide something with zero).


First I will show an image which might clear up a few things ^^

A triangle... a right-angled triangle, this is the basis.

On the drawing:
A = Angle that the missile has to make every loop
c = Offset the missile needs to be moved every loop
b = Offset the missile moves towards the caster (= 12.00, this never changes... I want it to move smoothly towards the target)

The arc formula is:

Set Sloc[2] = (Sloc[1] offset by (12.00 / (Cos(SReal[5]))) towards SReal[1] degrees)​

That doesn't say much I guess?

I'll try to explain this

The initial angle of the missile is defined by another formula (actually 3, since it's different for positive/negative angles and 0º), but I won't show that... all you need to know is that it's a pre-defined angle.
Then I have divided that angle by 12.00 (the same as b), this new number will become the amount of degrees the original angle will change every loop.

In the arc-formula, I move the missile
(if you don't know why, it comes from the formula "Cos(A) = b/c"
Since I already know b (which is 12.00) and A (which changes every loop, but I decide the amount it changes, so I also know A).
the formula becomes: "c = b/Cos(A)"

OR: c = 12.00/Cos(A)
Let's say A = 60º
c = 12/Cos(60º) = 12/0.5 => c = 24

Which means I need to move the missile with an offset of 24 towards 60º.
This value will get smaller and smaller, until it reaches c = 12 and will then increase again (the angle will become negative).

Z-arc:

(height)

This is a lot easier, since all missiles have the same Z-angle (65º I believe)

We'll need the drawing again...
This time, I want to calculate 'a' (which is the height, obviously).
Since the formula is "tan(A) = a/b"

We know A, it's a pre-defined angle (and it decreases by 6º every loop).
We also know b
We need to know a, so this becomes: "a = tan(A) x b".

if A = 30º: a = tan(30º) x 12.00 => a = 6.93

The value will decrease as the angle becomes negative, thus the missile descends.



ehhh, I'm not the best teacher... this is really simple once you know how to do it, though ><

Not MUI:

Lol, MUI means "Multi-Unit Instanceable", or: multiple units can use this spell at the same time, so every unit on the map can cast it once at the same moment.
You are creating something new, probably something like "MCI" (Multi-Cast Instanceable): it doesn't matter who casts it and when, it will always work - this cannot be done with hashtables (or perhaps it can, but a long way around).

And I think I have proven that it is half-MCI and completely MUI (the small missiles will not bug with the shockwave while existing at the same time, casted by the same unit, but when there are multiple shockwaves, it will bug indeed).]
Funny, since it's absolutely pointless to have multiple shockwaves runnig at the same time.

If you can't spam it mindlessly it ain't MUI by my book

Lol xD
it is MUI, though...

Yeah, indexing ftw, but I like hashtables because they're really easy to use and I'm just way too lazy xD

If you can, merge the 2 triggers(periodic ones).

Perhaps I can, but then the overall stress increases according to me.
The shockwave-trigger will turn off when it's done and then the small missiles turn on.
If you pour it all into 1 trigger, it loops the entire, huge thing until the entire spell is done.

 

[baassee]

@kingz

I never said that indexing was bad or did I? ^^

 

[Kingz]

Damn i hate trigonometry

Anyway, gj on getting this aproved.

@apocalypse

Well what if a guy wants to use this in a map that has an item/ability that resets cooldowns? Then it would bug, yes?

Anyway you make a fine point, i won't debate any further, nice spell, nice effects, though the missiles return trajectory is a bit strange.

 

[ap0calypse]

Well what if a guy wants to use this in a map that has an item/ability that resets cooldowns? Then it would bug, yes?

Well, yeah... if they decrease the speed of the shockwave, or if they change the casting cooldown (how do I say this? Err... the there's a time delay between casting the spell and being able to cast it again, it's not really casting time, but it's just the animation), it will bug.

With the current settings (which look the best in my opinion), you would have to be a pro at buttonmashing to make it bug, but it would still be possible (small chance, though).
But I don't think anyone (if someone would use the spell in the first place) change the speed this drastically that it could easily be bugged ^^

You're still correct, though... it can be bugged (on the conditions mentioned above).

Thanks for your comments

 

[aaron]

ap0 lol make the spell fully MUI, i am disappointed in you ( told you to not use hash )

 

[ap0calypse]

Hash is an easy way to make something MUI, like it or not... perhaps most people just don't accept that and stick to the older indexing because they don't like change?
Whatever the reason, I haven't experienced any problems with hashtables so far, I can easily use multiple hashtable systems running at the same moment without any lag/delay/bugs and the systems that I create with it are always completely MUI.
It's also not very hard to make some MCI, as I just noticed (As I name it... Multi-Cast Instanceable).

And it IS fully MUI...

MUI-ness

If that isn't MUI, then neither are the standard blizzard spells :/

 

[Thanathos]

Of course your spell supports more than one casts at the same time, but it only works properly if there is only one instance running on one caster. Well try this: Set the interval in your Move 1 and 2 triggers to a rather high high value, some thing like one second. Now launch the spell with the same caster on the same target unit twice. Of course the will be 2 of there main missiles, the first one will work properly, but after the second one explodes it won´t create the small green missiles.
I don´t really know what´s causing this effect but i guess it has something to do with the unit groups. A group won´t contain the same unit twice, so when the first instance expires then the caster or whatever you used in that group is removed from it, so the second instance which also uses the unit from the first instance lost it´s reference what could result in a malfunction. However this is only a surmise of mine and there is no guarantee that i´m right.

~TNT

 

[ap0calypse]

Of course your spell supports more than one casts at the same time, but it only works properly if there is only one instance running on one caster. Well try this: Set the interval in your Move 1 and 2 triggers to a rather high high value, some thing like one second. Now launch the spell with the same caster on the same target unit twice. Of course the will be 2 of there main missiles, the first one will work properly, but after the second one explodes it won´t create the small green missiles.

I know this, Kingz already mentioned it and I think my answer is good enough:
With the current values, it's highly unlikely that the spell will bug - even when you spam it, because the large missile and the small missiles move independantly (and thus you can have small and large missiles of the same caster which both perfectly work).
When you fiddle with the numbers (e.g.: make the movement speed slower, or increase the interval), the spell will just look like crap, so I don't see the point in that as well.
On top of that: most maps have something called "cooldown" (okay, there are modes without cooldown, but then the above statement would still be in effect).

I don´t really know what´s causing this effect but i guess it has something to do with the unit groups. A group won´t contain the same unit twice, so when the first instance expires then the caster or whatever you used in that group is removed from it, so the second instance which also uses the unit from the first instance lost it´s reference what could result in a malfunction. However this is only a surmise of mine and there is no guarantee that i´m right.

Well, I just overwrite all values when the spell is cast twice (I save all values for the casting unit, when the spell is cast twice, the first values will be overwritten by the second one, causing it to explode whenever the first one exploed), that's the cause of the malfunction :/
I can do it differently: I can create the shockwave and save all values for the shockwave instead of the caster and that would fix it, but I just don't see the point in doing this.

 

[Aesthetics]

Off-Topic

So ap0calpyse... you don't know how to use vJass, and if I submitted my maps in 100% pure concentrated vJass, you wouldn't be able to criticize my triggers?

 

[XombeR]

Not the best ive seen but guess it works

 

[ap0calypse]

Off-Topic

So ap0calpyse... you don't know how to use vJass, and if I submitted my maps in 100% pure concentrated vJass, you wouldn't be able to criticize my triggers?

Indeed, I don't know vJass
But knowing vJass is very efficient, I'll just believe your triggers are good xD (and if they aren't, my basic JASS knowledge will see that I think).

Not the best ive seen but guess it works

Can you explain? Perhaps i can adjust a few things

 

[YourNameHere]

EDIT:
If you can, merge the 2 triggers(periodic ones).

Thus making it even more slower? GUI is slow anyway, so merging 2 big GUI triggers into 1 makes it ultraslow.

 

[Kingz]

Having several periodic triggers is less efficent that 1 as far as i know.

Also i forgot that the spell has 2 stages so it would only complicate the spell, i just didn't think nobody even payed attention to what i said

 

[ChaosKnight]

Can someone tell me how to import Spells? Btw ver good job 5/5!

 

[Crazed_seal2]

I shall test this.
Mah review

[+] MUI: Allows more then one unit to cast it.
[+] Effects: It looks cool, the missles do an excellent arc.
[+] Configuration: You added a guide to configure your spell's value
[+] Leaks: Removed all leaks Good Job. (I hate lag)
[+] Name suits it: It is definitly Chaotic, or unholy.
Overall Opinion: The effects are wonderful and are not spamming like a million and one lightning bolts at the same time, Configuration is easy as you added a guide into the demo map. Leaks are pesky and can cause lag, thats why you clean them, and you have cleaned your leaks. MUI is important, otherwise the spell will end up bugging and something bad will happen.
5/5 -> +REP

Great Job!

 

[YourNameHere]

Having several periodic triggers is less efficent that 1 as far as i know.

I don't know who told you that, but it is definately not true. Although it depends on the size of those triggers, it's more likely that different triggers execute faster when they're seperated from eachother.That does make sense because all those BJ's you're using are slow as hell.

 

[kimberker]

Help!!!

Hey, i think i edit it wrong way but i dont know how to edit it in the correct way.. when i try my skill the wave come out and my food keep going up very fast and theres no effect buy only dmg...

 

[ap0calypse]

Hey, i think i edit it wrong way but i dont know how to edit it in the correct way.. when i try my skill the wave come out and my food keep going up very fast and theres no effect buy only dmg...

Okay, I am guessing you didn't read the manual thoroughly.
The reason why there are no effects and the food count goes up is because you didn't use the correct units.
Once you have copied all units and triggers, you need to edit these things:

Go to the trigger "Sphere I Spell Init" and change the condition to "(Ability being cast) Equal to Chaotic Sphere" (if this wasn't already correct).
Still is in the same trigger, there is a unit - create unit-action, set the unit to "Sphere Missile 1". (again: if this wasn't already correct)

Halfway through the trigger "Sphere I Move 1", there is also a create unit-action.
This time, set the unit to "Sphere Missile 2".


So the reason why it didn't work correctly, is because it picked another unit.
This unit will be spawned, this the food cost goes higher and the effects are based off the unit's model, so since the unit has another model, the effects won't show.

-------------------------------------------------

Can someone tell me how to import Spells? Btw ver good job 5/5!

Thank you ^^
Well, if you open the map ( = spell) in the world editor and go to the trigger editor (F4), you can see a green category with a few green triggers.
Those are comments, everything you need to know should be in there.
This is what's included:

• General Information - (explains the spell)
• How To Import? (1) - (how to import all data correctly)
• How To Import? (2) - (how to set up all data correctly)
• Possible Problems - (if you encounter a problem after imporing, consult this)
• Change Values - (How to change the damage, range, amount of missiles, ...).

 

[Fanny.Shaver]

Looks allright.

 

[FrostScythe]

Nice Spell
Voting:5/5

 

[Maximum_Evil]

Awesome spell, actually hoped it would be a point target. But still awesome!

 

[GaAg0]

Nice Magic 5/5

 

[CoLd Bon3]

The spell is epic, i like it. The effect is really eye-catching. However, it might be better if you make it be a point-target spell, instead of a unit-target spell. Or perhaps "Unit or point" target type spell.

 

[toanlove371]

Good job ^^b

 

[Xerxes]

What is MCI?

 

[ap0calypse]

Multi-Cast Instanceable (information is given in the description). Also called "SUMI".
It's what most people call "[abbr="Multiple Units Instanceable]MUI[/abbr]", which seems incorrect to me because it only says that different units have to be able to cast it once at the same time (not multiple times).