Change Terrain (Not Working Well)

[Tom_Almighty1]

Hey guys, I want to change the terrain into different ones through triggers.

• Harvest Moon (3D).w3x
• function RT2 takes real X, real Y, integer T returns nothing
  • call SetTerrainType(X, Y, T, -1, 1, 1)
  • endfunction
  • function RT1 takes real MinX, real MaxX, real Y, integer OldTerrain, integer Terrain returns nothing
    • loop
      • exitwhen MinX > MaxX
        • if GetTerrainType(MinX, Y) == OldTerrain then
          • call RT2 (MinX, Y, Terrain)
        • endif
      • set MinX = MinX + 128
    • endloop
  • endfunction
  • function ReplaceTerrainTypeEx takes integer OldTerrain, integer NewTerrain, rect WhichRect returns nothing
    • local real MinX = GetRectMinX(WhichRect)
    • local real MaxX = GetRectMaxX(WhichRect)
    • local real MinY = GetRectMinY(WhichRect)
    • local real MaxY = GetRectMaxY(WhichRect)
    • loop
      • exitwhen MinY > MaxY
        • call RT1 (MinX, MaxX, MinY, OldTerrain, NewTerrain)
      • set MinY = MinY + 128
    • endloop
  • endfunction
  • function ReplaceGlobalTerrain takes integer OldTerrain, integer NewTerrain returns nothing
    • call ReplaceTerrainTypeEx(OldTerrain, NewTerrain, GetWorldBounds())
  • endfunction
  • function ReplaceGlobalTerrainReversed takes integer NewTerrain, integer OldTerrain returns nothing
    • call ReplaceTerrainTypeEx(OldTerrain, NewTerrain, GetWorldBounds())
  • endfunction

Then I use this which activates when I press ESC.

• SET when Player press ESC
• call ReplaceGlobalTerrain ('Agrs', 'Lgrs')
• call ReplaceGlobalTerrain ('Adrg', 'Ldrg')

The 1st is (Ashenvale Grass to Lordaeron Grass)
The 2nd is (Ashenvale Grassy Dirt to Lordaeron Grassy Dirt)

But it only changes the 1st and the 2nd does not happen.
And it does not change in the ENTIRE MAP. my map size is (192 x 192) can someone help me?? xO

 

[water_Knight]

I swear it could be done so much more simple, I guess i will reinstall wc3 and have a look at it, Thats if someone doesn't beat me to it.

 

[Tom_Almighty1]

Thanks, I just copied that from another map. But it works fine in the map where i copied these, but in my map it doesnt work well xO

 

[SA Dashie]

function ReplaceTerrainTypeId takes integer OldTerrain, integer NewTerrain, rect WhichRect returns nothing
    local real MinX = GetRectMinX(WhichRect)
    local real MaxX = GetRectMaxX(WhichRect)
    local real MinY = GetRectMinY(WhichRect)
    local real MaxY = GetRectMaxY(WhichRect)
    loop
        loop
            if GetTerrainType(MinX, MinY) == OldTerrainId then
                call SetTerrainType(MinX, MinY, NewTerrain, -1, 1, 1)
            endif
            
            exitwhen MinX >= MaxX
            set MinX = MinX + 128
        endloop
        
        exitwhen MinY >= MaxY
        set MinY = MinY + 128
    endloop
endfunction

This function replaces a specific Terrain Type with another within a rect.

If you call it properly it should work(haven't tested).


It's also more recommended to make the coordinates of the region yourself.

Code

function ReplaceTerrainTypeId takes integer OldTerrain, integer NewTerrain, real MinX, real MaxX, real MinY, real MaxY returns nothing
    loop
        loop
            if GetTerrainType(MinX, MinY) == OldTerrainId then
                call SetTerrainType(MinX, MinY, NewTerrain, -1, 1, 1)
            endif
            
            exitwhen MinX >= MaxX
            set MinX = MinX + 128
        endloop
        
        exitwhen MinY >= MaxY
        set MinY = MinY + 128
    endloop
endfunction

Oh yes and remember to paste your jass code here with the jass tags [code=jass][/code].