Bury Corpse V.1.1

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

19:53, 30th Jun 2013
Magtheridon96:

Spell Submission Rules

Comments

• You have 2 location leaks in the Drop Corpse trigger.
• (Selling unit) can be replaced with (Triggering unit).
• It would be better to make the constants like the item types and the unit types in this system configurable via a trigger that runs on map initialization so users only have to refer to one trigger to configure this system properly.
• The condition of the Drop Corpse function could be cleaned up so that you're only checking if the type of the item being manipulated is equal to a constant item type.
• In the Bury Corpse function, you could store (Buying unit) into a variable at the top BEFORE the wait, and then set that variable again directly AFTER the wait so you can use that variable to represent the buying unit throughout the whole trigger.
• You have an unused variable in the map.

 

[Kingz]

Saddly it doesn't follow the rules:
* Contains leaks
* Isn't MUI

Read the rules regarding these issues and consult with some tutorials.
Should be mentioned:

Waits break MUI for almost all systems, this however can be fixed in this case through simple use of local variables.

You should use variables to preset the item type and replaced units.

The unit array isn't needed at all, a unit variable however should suffice.
Seeing as this is your first submission in the spell section, i strongly advise you to read some tutorials.

 

[sonofjay]

Bro, don't use waits, its 99% will make your spell/system MUI,

 

[Tank-Commander]

Rather too simple to be approved unfortunately, fixing the wait to make it MUI wouldn't be enough unfortunately.

 

[Sin'dorei300]

Updated!

 

[Chaosy]

1. more varaiables plz
2. replace the wait with a timer or a loop with a counter.
3. fix leaks

quite simple but since I know you havent triggered alot I wont blame you

 

[Daffa]

• You know, the ITE is unnecessary, move the condition to the main condition part of the trigger and move the actions to main actions part of the trigger then delete the ITE [ITE = If/Then/Else]
• Also, waits are dangerous, if I buy the item in 2 second wait still running, the selling and buying unit will be overrides.
• Also, store the buying unit in a variable.
• Leaks :
  
  • Unit - Create 1 Corpse for Neutral Passive at /(Position of (Hero manipulating item))/ facing /(Random point in (Playable map area))/
  I marked the leaks with / mark before and after the function.