Buff problem

[daniel91]

i have this:

• Unit - A unit starts an effect of an ability
• Conditions - Ability being cast equal to Inner fire
• Actions - hero - modify strength of (target unit being ability being cast: add 10
• if - triggering unit has buff inner fire equal to true
• Then - Hero modify strength of (taget unit of ability being cast):substract 10

I dont know how to do it when it finish to give back original strength. Like my hero get 10 strength, i add that buf which means my hero will have 20, and when inner fire is done that 10 strength to dissapear. Help please!

 

[FUJI]

attach the map I can help you with this ^^.

EDIT:

It is not a buff problem XD.

 

[daniel91]

....

 

[FUJI]

Wait after 5 minutes

 

[Rheiko]

LOL
you should check when your buff's duration has ended then substract hero's strength
that's all

 

[Maker]

Add the target into a unit group. Pick all units in the group once per second. If the unit does no have a buff, remove it from the group and subtract strength. Turn the trigger off if the group is empty.

 

[FUJI]

here

 

[Rheiko]

this is what does maker mean

Cast Trigger

• Inner Fire Cast
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Inner Fire
  • Actions
    • Set TempUnit = (Target unit of ability being cast)
    • Hero - Modify Strength of TempUnit: Add 10
    • Unit Group - Add TempUnit to TempGroup
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (TempGroup is empty) Equal to False
      • Then - Actions
        • Trigger - Turn on Inner Fire Check <gen>
      • Else - Actions

Loop Trigger

• Inner Fire Check
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in TempGroup and do (Actions)
      • Loop - Actions
        • Set TempUnit = (Picked unit)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (TempUnit has buff Inner Fire) Equal to False
          • Then - Actions
            • Unit Group - Remove TempUnit from TempGroup
            • Hero - Modify Strength of TempUnit: Subtract 10
          • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (TempGroup is empty) Equal to True
      • Then - Actions
        • Trigger - Turn off (This trigger)
      • Else - Actions
    • Set TempUnit = No Unit

 

[Maker]

Yes but every 0.03 seconds is way too often for this. Once per second should be enough.

 

[Rheiko]

okay, fixed

 

[Vinz]

@Rheiko
a.) You could have used Mag's wait indexing style
b.) You don't add 10 STR to the target at cast
c.) Null TempUnit, leaks some bytes every time

 

[Rheiko]

a.) You could have used Mag's wait indexing style

using wait is not recommended

b.) You don't add 10 STR to the target at cast

will do (forgot to add 'em)

c.) Null TempUnit, leaks some bytes every time

to make sure, i have to ask professionals.
_{Awaiting Answer}

 

[FUJI]

Wrathion: c.) Null TempUnit, leaks some bytes every time

Hmm??

 

[pOke]

I think Wrathion is not refering to waits but to an indexed counter as a pseudo wait. I'm not sure if it's much better, it just avoids the use of a unit group which some might view as beneficial, and a better practice.

As to nulling globals I have heard mixed responses, I doubt it would hurt but seems unlikely to add or subtract much.

 

[FUJI]

I think Wrathion is not refering to waits but to an indexed counter as a pseudo wait. I'm not sure if it's much better, it just avoids the use of a unit group which some might view as beneficial, and a better practice.

As to nulling globals I have heard mixed responses, I doubt it would hurt but seems unlikely to add or subtract much.

It is like Reading Index and Listener Index with wait Right??? It is from the tutorial of Mag.

 

[Maker]

to make sure, i have to ask professionals.
_{Awaiting Answer}

Yes it does leak but only really really little. So little you don't have to worry about it, but you can null it to prevent it.

 

[Rheiko]

thanks, maker

fixed: add 10 strength
Maker, where should i null it? i'm a bit confused

 

[Maker]

After using it the last time in the trigger. You can null it at the end of the trigger.

 

[Rheiko]

like that?

 

[Maker]

Yeah.

 

[daniel91]

Thanks a lot, man! I love you! @jakeZinc...That`s perfect

 

[FUJI]

^Gladly.

 

[Vinz]

@Rheiko
You should null it inside the unit group pick after the actions.

 

[Maker]

@Rheiko
You should null it inside the unit group pick after the actions.

No..